Re: [tcpdump-workers] NSEC magic number in savefile.c

2009-05-21 Thread Pierre KARAMPOURNIS
Hi, I agree that the modification I want to do is modifying the behaviour of libpcap in a way that the compatibility can't be assured. What I planned to do was creating a new compilation macro which will be defined if the user wants it (e.g. ./configure --enable-nsec-timestamp) that will modify t

Re: [tcpdump-workers] [PATCH 2/2] print-olsr: Add basic IPv6 support.

2009-05-21 Thread Guy Harris
On May 16, 2009, at 3:05 PM, Florian Forster wrote: From: Florian Forster Unfortunately OLSR uses the same IDs for IPv4 and IPv6 packets, even though the size of "messages" differ. The version of the internet protocol is therefore handed to the "olsr_print" function. The code isn't very n

Re: [tcpdump-workers] [PATCH 1/2] util.c: Add the `mask62plen' utility function.

2009-05-21 Thread Guy Harris
On May 16, 2009, at 3:05 PM, Florian Forster wrote: From: Florian Forster The function does the same as `mask2plen' but for IPv6. Checked into the main branch and pushed. (Again, --whitespace=fix needed.) - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe

Re: [tcpdump-workers] [PATCH] print-olsr: Don't trust the package payload.

2009-05-21 Thread Guy Harris
On May 16, 2009, at 4:01 AM, Florian Forster wrote: From: Florian Forster Especially not to do pointer arithmetic. This is a real problem even without malicious people around if you use OLSR via IPv6, because the message IDs didn't change but addresses are now longer than four bytes. Check

Re: [tcpdump-workers] NSEC magic number in savefile.c

2009-05-21 Thread Guy Harris
On May 14, 2009, at 11:58 AM, Pierre KARAMPOURNIS wrote: Furthermore, if we try to use tools using libpcap to read nsec-pcap files, it won't work What should "work" mean? It can't mean "supply time stamps with nanosecond precision", as that would break source and binary compatibility. T