Re: [tcpdump-workers] Printing of TCP flags seems incorrect

2008-07-03 Thread grarpamp
> once a connection is established, there should not be any packets > with no flags set ... not sure when you'd ever see a TCP segment > with no flags set "Packets Found on an Internet" :) The net's full of physical packets that make no logical sense to the viewer. Still have to print them correct

Re: [tcpdump-workers] Printing of TCP flags seems incorrect

2008-07-03 Thread Guy Harris
grarpamp wrote: Hi. Patch inline. I conformed the naming to the RFC's I assume by "naming" you are referring not only to the bits used to print the flags in tcpdump but also the flag values used in libpcap for filters. Perhaps a name using the "psh" abbreviation used by RFC 793 for the "pu

Re: [tcpdump-workers] Printing of TCP flags seems incorrect

2008-07-03 Thread Guy Harris
grarpamp wrote: Hi. I think I've found this 'none' printf you speak of. More precisely it's a "none" argument passed to bittok2str_nosep() plus the else { /* bummer - lets print the "unknown" message as advised in the fmt string if we got one */ if (fmt == NUL