I've addressed all the comments from below and updated the webrev.
http://cr.opensolaris.org/~sagun/libpcap/
While testing the changes I found out that my changes didn't work on a Solaris
system that had libdlpi.h version
that existed before the public libdlpi.h was integrated. Some changes had
hello,
on Thu 1/31/2008 10:37 AM Alexander 'Leo' Bergolth wrote:
> I just gave your new linux mmap patch a try
thanks for the review :-)
> *) There is a typo in the macro RING_GET_FRAME(h) (handle instead of h).
> The attached patch fixes that.
Your patch looks good to me. I hope that Guy Harri
Hi!
I just gave your new linux mmap patch a try, that was committed to svn
a few weeks ago.
The code works fine, except for two issues:
*) There is a typo in the macro RING_GET_FRAME(h) (handle instead of h).
The attached patch fixes that.
*) If pcap_loop is called with cnt=0 (ngrep erroneously