Re: [tcpdump-workers] Libpcap reentrancy and PF_RING patch

2008-01-10 Thread Guy Harris
On Jan 6, 2008, at 12:54 PM, Guy Harris wrote: Would it work better if, for PF_RING sockets, there were a separate pcap_read_pf_ring, and handle->read_op were set to pcap_read_pf_ring if a PF_RING socket were being used? That'd avoid some per-packet checks in the read_op routine, and migh

Re: [tcpdump-workers] supporting extend 'open live capture' parametes

2008-01-10 Thread Guy Harris
Andy Howell wrote: How about having a generic list of options? Something like: typedef enum { END_OF_OPTS, PARAM_1, PARAM_2, } pcap_opts; typedef union { void *p; unsigned int u; } pcap_opt_value; That assumes that an option will either be an "unsigned int" or a pointer

Re: [tcpdump-workers] supporting extend 'open live capture' parametes

2008-01-10 Thread Andy Howell
Abeni Paolo wrote: hello, I assume that the my initial suggestion is going to be dismissed, right ?!? on Thu 1/10/2008 10:47 AM Guy Harris wrote: There'd also be an API to ask which parameters a particular adapter supports (and possibly which values it supports for those parameters, e.g. if

Re: [tcpdump-workers] supporting extend 'open live capture' parametes

2008-01-10 Thread Guy Harris
Abeni Paolo wrote: I assume that the my initial suggestion is going to be dismissed, right ?!? The extensible live-capture-open would be better (for one thing, a global variable would have problems with multiple threads), but it might be nice to get *something* into 1.0, so if we can't get t

Re: [tcpdump-workers] tcpdump problem with DAG card

2008-01-10 Thread Carter Bullard
Hey Stephen, Thanks, I'll take a look tonight, and make the changes. Carter Carter Bullard QoSient LLC 150 E. 57th Street Suite 12D New York, New York 10022 +1 212 588-9133 Phone +1 212 588-9134 Fax -Original Message- From: Stephen Donnelly <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008

Re: [tcpdump-workers] supporting extend 'open live capture' parametes [was: setting the initial ring size]

2008-01-10 Thread Abeni Paolo
hello, I assume that the my initial suggestion is going to be dismissed, right ?!? on Thu 1/10/2008 10:47 AM Guy Harris wrote: > There'd also be an API to ask which parameters a particular adapter > supports (and possibly which values it supports for those parameters, > e.g. if one of the para

Re: [tcpdump-workers] setting the initial ring size

2008-01-10 Thread Guy Harris
Abeni Paolo wrote: I have some concerns about more the "open a live capture" call[s]: in the future it could be useful to set more parameters, so in the long run there could be a proliferation of such call. A possible solution would be to make the "open a live capture" call extensible, adding a

Re: [tcpdump-workers] setting the initial ring size

2008-01-10 Thread Abeni Paolo
hello, on Thu 1/10/2008 3:20 AM Guy Harris wrote: > "Set receive buffer size at open time" could be implemented on most if > not all platforms - including platforms using BPF; it would require a > new "open a live capture" call, but that might be useful for other > purposes (e.g., to reques