Re: [tcpdump-workers] [PACTH] enable memory mapped access to ethernet

2007-12-14 Thread Guy Harris
Abeni Paolo wrote: Yes, they can be used. The USB capture use a character device which implement the poll interface. My main concern is with mmapped access. Presumably, with mmapped access, there are still system calls that move a "these packets have been read" pointer and that block until

Re: [tcpdump-workers] [PACTH] enable memory mapped access to ethernet

2007-12-14 Thread Abeni Paolo
hello, on 14/12/2007 9.24 Guy Harris wrote: > If, in pcap_open_live(), live_open_mmap() succeeds, > handle->selectable_fd doesn't get set. Oops... I missed this point... I'm going to fix this in the next version of the patch, but first I will wait a bit more for other comments/issues. The mappe

Re: [tcpdump-workers] [PACTH] enable memory mapped access to ethernet

2007-12-14 Thread Guy Harris
Paolo Abeni wrote: Any comments on this matter or on the patch are very welcome ! If, in pcap_open_live(), live_open_mmap() succeeds, handle->selectable_fd doesn't get set. This will break, among other programs, the current version of Wireshark, and the upcoming version of Wireshark. (A s