Re: [tcpdump-workers] print-tcp.c: remove commas from output, to be consistent

2007-01-17 Thread Hannes Gredler
well the correct thing would then be: 1. embrace .SFP into Flags [.SPF], 2. add commas to sep. the rest of the field /hannes On Wed, Jan 17, 2007 at 07:25:07PM -0800, Kevin Steves wrote: | On Wed, Jan 17, 2007 at 11:42:48PM +0100, Hannes Gredler wrote: | : can you re-explain your concern ? | : w

Re: [tcpdump-workers] print-tcp.c: remove commas from output, to be consistent

2007-01-17 Thread Kevin Steves
On Wed, Jan 17, 2007 at 11:42:48PM +0100, Hannes Gredler wrote: : can you re-explain your concern ? : we use the comma here as a means of seperating : fields suitable to human-processors. 3 main issues: 0) not consistent with rest of tcp output (no commas used) 1) distracts from output (e.g., see

Re: [tcpdump-workers] print-tcp.c: remove commas from output, to

2007-01-17 Thread Stephen Donnelly
On Wed, 2007-01-17 at 11:56 -0800, Rick Jones wrote: > Kevin Steves wrote: > > commas aren't used in tcp fields so remove these that are > > before and after cksum. > > i'm not necessarily trying to stop the patch, but while it may not be > consistent with other output, maintaining "consistency"

Re: [tcpdump-workers] print-tcp.c: remove commas from output, to

2007-01-17 Thread Hannes Gredler
can you re-explain your concern ? we use the comma here as a means of seperating fields suitable to human-processors. /hannes Kevin Steves wrote: commas aren't used in tcp fields so remove these that are before and after cksum. Index: print-tcp.c ===

Re: [tcpdump-workers] print-ip.c: why print ttl with %3u ?

2007-01-17 Thread Hannes Gredler
if we don't get flamed for it [aka "this breaks my script"] i have no objections. /hannes Guy Harris wrote: Hannes Gredler wrote: ahh now i get you ... the ttl %3u change was introduced _before_ we decided to print the ID-field ... and this made multiline outputs more readable ... checked in

Re: [tcpdump-workers] print-tcp.c: remove commas from output, to

2007-01-17 Thread Rick Jones
Kevin Steves wrote: commas aren't used in tcp fields so remove these that are before and after cksum. i'm not necessarily trying to stop the patch, but while it may not be consistent with other output, maintaining "consistency" with previous versions has the nice property of being less likely

Re: [tcpdump-workers] how to make the sniffer quicker?

2007-01-17 Thread Mike Kershaw
On Wed, Jan 17, 2007 at 11:44:26AM -0600, David Young wrote: > > My problem is: the sniffer is too slow. > > How fast is your computer? Do you use a Prism radio? A host has to read > packets from the Prism II/2.5 radios using programmed I/O, which is slow. > > > When I'm flooding the receiver w

[tcpdump-workers] print-tcp.c: remove commas from output, to be consistent

2007-01-17 Thread Kevin Steves
commas aren't used in tcp fields so remove these that are before and after cksum. Index: print-tcp.c === RCS file: /tcpdump/master/tcpdump/print-tcp.c,v retrieving revision 1.126 diff -u -r1.126 print-tcp.c --- print-tcp.c 2 Nov 2006

Re: [tcpdump-workers] [PATCH] cleanup usb_platform_finddevs()

2007-01-17 Thread Guy Harris
Abeni Paolo wrote: the attached patch cleanup the usb_platform_finddevs(), removing the dependency from debugfs. There are also some other minor cleanup in the pcap-usb-linux.c file (unused variables removed and indentation fix). Checked in. I plan to post the aligment fix for usb header in

Re: [tcpdump-workers] how to make the sniffer quicker?

2007-01-17 Thread David Young
On Wed, Jan 17, 2007 at 10:39:55AM -, David Lopez wrote: > Hi > > > > I'm developing a position system for my PhD. > > This system is based on Round Trip Time measurements. > > I'm getting the timestamp of the packets using Tethereal and the Mactime > in the Prism Monitor Header > > My p

Re: [tcpdump-workers] print-ip.c: why print ttl with %3u ?

2007-01-17 Thread Guy Harris
Hannes Gredler wrote: ahh now i get you ... the ttl %3u change was introduced _before_ we decided to print the ID-field ... and this made multiline outputs more readable ... checked in your fix into head. Should it also go into the x.9 branch? - This is the tcpdump-workers list. Visit https://

Re: [tcpdump-workers] print-ip.c: why print ttl with %3u ?

2007-01-17 Thread Hannes Gredler
ahh now i get you ... the ttl %3u change was introduced _before_ we decided to print the ID-field ... and this made multiline outputs more readable ... checked in your fix into head. On Wed, Jan 17, 2007 at 09:32:47AM -0800, Kevin Steves wrote: | not sure what you mean here. | | how would it app

Re: [tcpdump-workers] print-ip.c: why print ttl with %3u ?

2007-01-17 Thread Kevin Steves
not sure what you mean here. how would it apply to the following? 09:31:09.559173 IP (tos 0x10, ttl 64, id 49030, offset 0, flags [none], proto UDP (17), length 76) 10.66.203.33.22235 > 209.44.12.114.123: [udp sum ok] NTPv4, length 48 On Wed, Jan 17, 2007 at 03:04:43PM +0100, Hannes Gredler w

Re: [tcpdump-workers] how to make the sniffer quicker?

2007-01-17 Thread Asier Martinez
Hi David, the problem is not in the sniffer is in the 802.11 medium itself, when you use -f you lost a lot of packets ( in Ethernet is similar ) before they arrive to the network, they lost in the card buffer because the 802.11 ACK - RTS/CTS mechanism is too slow. Regards, 2007/1/17, David Lo

Re: [tcpdump-workers] print-ip.c: why print ttl with %3u ?

2007-01-17 Thread Hannes Gredler
but it removes all trailing columns (ip addresses) and makes things more unreadable ... On Sun, Jan 14, 2007 at 02:20:41PM -0800, Kevin Steves wrote: | this seems nicer without extra spaces. | | Index: print-ip.c | === | RCS file: /

Re: [tcpdump-workers] print-ip.c: no colons here to be consistent

2007-01-17 Thread Hannes Gredler
checked into head and 3.9 branch. - /hannes Kevin Steves wrote: > the other fields don't print 'field: value' so don't here either. > > Index: print-ip.c > === > RCS file: /tcpdump/master/tcpdump/print-ip.c,v > retrieving revision 1.

[tcpdump-workers] how to make the sniffer quicker?

2007-01-17 Thread David Lopez
Hi I'm developing a position system for my PhD. This system is based on Round Trip Time measurements. I'm getting the timestamp of the packets using Tethereal and the Mactime in the Prism Monitor Header My problem is: the sniffer is too slow. When I'm flooding the receiver with pings, us