Re: [tcpdump-workers] Bug in print_unknown_data() + fuzz testing

2005-06-15 Thread Guy Harris
On Jun 15, 2005, at 6:10 PM, Guy Harris wrote: OK, got it. I've checked in a fix for the underlying problem, and audited the calls to "print_unknown_data()" and checked in other fixes. BTW, whenever you're dealing with TLVs and, especially, TLVs whose data is made up of subTLVs, doing l

Re: [tcpdump-workers] Bug in print_unknown_data() + fuzz testing

2005-06-15 Thread Guy Harris
On Jun 15, 2005, at 10:55 AM, Gerald Combs wrote: It's attached to this message It doesn't appear to have gotten attached. and is also available at http://www.ethereal.com/~gerald/lcp-crash.pcap . OK, got it. I've checked in a fix for the underlying problem, and audited the calls to "p

Re: [tcpdump-workers] Bug in print_unknown_data() + fuzz testing

2005-06-15 Thread Gerald Combs
Guy Harris wrote: > Gerald Combs wrote: >> - A capture file that triggers the bug in the current daily build. > > > That wasn't attached. Do you either have the capture, or a stack trace? > I'm curious whether the problem is that it's being handed a negative > length, or being handed a pointe

Re: [tcpdump-workers] Bug in print_unknown_data() + fuzz testing

2005-06-15 Thread Guy Harris
Gerald Combs wrote: We recently added fuzz testing to Ethereal's automated build system. I tried out the script we're using on tcpdump and it turned up a bug in util.c. Yes, I've fixed some bugs that it turned up with my capture menagerie. (Yes, I need to run the fuzz testing with those captu