Re: [tcpdump-workers] Buffer size question

On Oct 15, 2004, at 6:19 AM, Hannes Gredler wrote: shouldn't we have upper/lower boundary checks for such a buffer ? i.e. minbuffer 1.5K maxbuffer 128K I think the BPF kernel code in most of the BSDs already impose upper and lower bounds; are you suggesting that libpcap impose its own bounds

Re: [tcpdump-workers] Buffer size question

> shouldn't we have upper/lower boundary checks for > such a buffer ? > > i.e. minbuffer 1.5K > maxbuffer 128K So would you propose just returning an error from pcap_open_live if the obtained buffer size is less than minbuffer? Something like if PCAP_MAXBUFFER environment var is set and >

Re: [tcpdump-workers] Buffer size question

On Fri, 15 Oct 2004, Hannes Gredler wrote: > shouldn't we have upper/lower boundary checks for > such a buffer ? > > i.e. minbuffer 1.5K > maxbuffer 128K And if this is done, shouldn't we be doing some input validation? The user might not even give a numeric value, much less positive one.

Re: [tcpdump-workers] Buffer size question

shouldn't we have upper/lower boundary checks for such a buffer ? i.e. minbuffer 1.5K maxbuffer 128K /hannes On Thu, Oct 14, 2004 at 02:29:14PM -0400, Ed Maste wrote: | > I'll download one of the nightly tars and try out the | > environment variable idea. | | Here's my simple patch to all