Re: [systemd-devel] systemd coverity

2012-08-23 Thread Zbigniew Jędrzejewski-Szmek
On 08/23/2012 03:11 PM, Daniel P. Berrange wrote: > On Thu, Aug 23, 2012 at 03:04:23PM +0200, Zbigniew Jędrzejewski-Szmek wrote: >> On 08/23/2012 02:36 PM, Lennart Poettering wrote: >>> maybe we should add macros like: >>> >>> #define _cleanup_free_ __attribute__((cleanup(freep))) >>>

Re: [systemd-devel] systemd coverity

2012-08-23 Thread Daniel P. Berrange
On Thu, Aug 23, 2012 at 03:04:23PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On 08/23/2012 02:36 PM, Lennart Poettering wrote: > > maybe we should add macros like: > > > > #define _cleanup_free_ __attribute__((cleanup(freep))) > > #define _cleanup_fclose_ __attribute__((cleanup(f

Re: [systemd-devel] systemd coverity

2012-08-23 Thread Zbigniew Jędrzejewski-Szmek
On 08/23/2012 02:36 PM, Lennart Poettering wrote: > maybe we should add macros like: > > #define _cleanup_free_ __attribute__((cleanup(freep))) > #define _cleanup_fclose_ __attribute__((cleanup(fclosep))) > > What do you think? I personally think that this would be a welcome chang

Re: [systemd-devel] systemd coverity

2012-08-23 Thread Zbigniew Jędrzejewski-Szmek
On 08/23/2012 02:26 PM, Lennart Poettering wrote: > On Thu, 23.08.12 13:57, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > >> On 08/23/2012 12:36 PM, Lukáš Nykrýn wrote: >>> Hello, >>> Two more patches from diff scan 188-189. >> Applied both. > > I think you forgot to push? Aaaargh. Pus

Re: [systemd-devel] systemd coverity

2012-08-23 Thread Lennart Poettering
On Thu, 23.08.12 09:25, Lukáš Nykrýn ([email protected]) wrote: > > diff --git a/src/readahead/readahead-analyze.c > b/src/readahead/readahead-analyze.c > index 11b2b2d..9a929c0 100644 > --- a/src/readahead/readahead-analyze.c > +++ b/src/readahead/readahead-analyze.c > @@ -144,6 +144,7 @@ int

Re: [systemd-devel] systemd coverity

2012-08-23 Thread Lennart Poettering
On Thu, 23.08.12 13:57, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > On 08/23/2012 12:36 PM, Lukáš Nykrýn wrote: > > Hello, > > Two more patches from diff scan 188-189. > Applied both. I think you forgot to push? Lennart -- Lennart Poettering - Red Hat, Inc. ___

Re: [systemd-devel] systemd coverity

2012-08-23 Thread Zbigniew Jędrzejewski-Szmek
On 08/23/2012 12:36 PM, Lukáš Nykrýn wrote: > Hello, > Two more patches from diff scan 188-189. Applied both. Zbyszek ___ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] systemd coverity

2012-08-23 Thread Zbigniew Jędrzejewski-Szmek
On 08/23/2012 09:25 AM, Lukáš Nykrýn wrote: > Hello, > Coverity found some new small issues between releases 185-188. See attached > patches. Applied all, with small change in 'login: check return of parse_pid and parse_uid'. Zbyszek ___ systemd-devel m

Re: [systemd-devel] systemd coverity

2012-08-23 Thread Lukáš Nykrýn
Lukáš Nykrýn píše v Čt 23. 08. 2012 v 09:25 +0200: > Hello, > Coverity found some new small issues between releases 185-188. See attached > patches. > > Regards > Lukas > Hello, Two more patches from diff scan 188-189. Regards Lukas >From fb11041ccb2149381ebf9ddc7457b4e83dcdef41 Mon Sep 17 00:

[systemd-devel] systemd coverity

2012-08-23 Thread Lukáš Nykrýn
Hello, Coverity found some new small issues between releases 185-188. See attached patches. Regards Lukas >From b258ab8b5fec97e924ba5d3784be9b72d7966118 Mon Sep 17 00:00:00 2001 From: Lukas Nykryn Date: Mon, 20 Aug 2012 14:33:21 +0200 Subject: [PATCH 1/4] load-fragment: initialize bool invert b