Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-26 Thread Chris Murphy
OK so I'm seeing with systemd.log_level debug at shutdown that there is a swapoff [ 406.997210] fmac.local systemd[1]: dev-zram0.swap: About to execute: /sbin/swapoff /dev/zram0 [ 406.997844] fmac.local systemd[1]: dev-zram0.swap: Forked /sbin/swapoff as 1966 [ 406.998308] fmac.local systemd[1]

Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-25 Thread Chris Murphy
On Tue, Jun 25, 2019 at 3:30 AM Zbigniew Jędrzejewski-Szmek wrote: > > On Tue, Jun 25, 2019 at 10:55:27AM +0200, Lennart Poettering wrote: > > On Mo, 24.06.19 13:16, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > > > So for tmpfs mounts that don't turn off DefaultDependencies=

Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jun 25, 2019 at 10:55:27AM +0200, Lennart Poettering wrote: > On Mo, 24.06.19 13:16, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > So for tmpfs mounts that don't turn off DefaultDependencies= we > > > implicit add in an After=swap.target ordering dep. The thinking was > >

Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-25 Thread Lennart Poettering
On Mo, 24.06.19 21:01, Chris Murphy (li...@colorremedies.com) wrote: > On Mon, Jun 24, 2019 at 6:11 AM Lennart Poettering > wrote: > > That said, I don't really grok zram, and not sure why there's any need > > to detach it at all. I mean, if at shutdown we lose compressed RAM > > or lose uncompre

Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-25 Thread Lennart Poettering
On Mo, 24.06.19 13:16, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > So for tmpfs mounts that don't turn off DefaultDependencies= we > > implicit add in an After=swap.target ordering dep. The thinking was > > that there's no point in swapping in all data of a tmpfs because we > > want

Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-24 Thread Chris Murphy
On Mon, Jun 24, 2019 at 6:11 AM Lennart Poettering wrote: > That said, I don't really grok zram, and not sure why there's any need > to detach it at all. I mean, if at shutdown we lose compressed RAM > or lose uncompressed RAM shouldn't really matter. Hence from my > perspective there's no need fo

Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jun 24, 2019 at 02:11:03PM +0200, Lennart Poettering wrote: > On Sa, 22.06.19 10:42, Chris Murphy (li...@colorremedies.com) wrote: > > > Hi, > > > > I've got a commit to add 'Conflicts=umount.target' to this zram > > service based on a bug comment I cited in the comment. But I'm not > > ce

Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-24 Thread Lennart Poettering
On Sa, 22.06.19 10:42, Chris Murphy (li...@colorremedies.com) wrote: > Hi, > > I've got a commit to add 'Conflicts=umount.target' to this zram > service based on a bug comment I cited in the comment. But I'm not > certain I understand if it's a good idea or necessary. > > https://src.fedoraproject

Re: [systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-22 Thread Reindl Harald
Am 22.06.19 um 18:42 schrieb Chris Murphy: > I've got a commit to add 'Conflicts=umount.target' to this zram > service based on a bug comment I cited in the comment. But I'm not > certain I understand if it's a good idea or necessary. > > https://src.fedoraproject.org/fork/chrismurphy/rpms/zram/

[systemd-devel] swap on zram service unit, using Conflicts=umount

2019-06-22 Thread Chris Murphy
Hi, I've got a commit to add 'Conflicts=umount.target' to this zram service based on a bug comment I cited in the comment. But I'm not certain I understand if it's a good idea or necessary. https://src.fedoraproject.org/fork/chrismurphy/rpms/zram/c/63900c455e8a53827aed697b9f602709b7897eb2?branch=