Re: [systemd-devel] Promoting a pull request

2016-11-22 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Nov 22, 2016 at 12:02:41PM +0100, Jouke Witteveen wrote: > On Tue, Nov 22, 2016 at 11:55 AM, Martin Pitt wrote: > > Jouke Witteveen [2016-11-22 11:44 +0100]: > >> I see no way of (trying to) removing the reviewed/needs-rework label > >> in the PR interface. > > > > I click on the cog next

Re: [systemd-devel] Promoting a pull request

2016-11-22 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Nov 22, 2016 at 01:07:51PM +0100, Lennart Poettering wrote: > On Tue, 22.11.16 11:44, Jouke Witteveen ([email protected]) wrote: > > > The contribution guidelines [1] state: > > > > > After you have pushed a new version, try to remove the > > > reviewed/needs-rework label. Also add a

Re: [systemd-devel] Promoting a pull request

2016-11-22 Thread Lennart Poettering
On Tue, 22.11.16 11:44, Jouke Witteveen ([email protected]) wrote: > The contribution guidelines [1] state: > > > After you have pushed a new version, try to remove the > > reviewed/needs-rework label. Also add a comment about the new version > > (no notification is sent just for the commits,

Re: [systemd-devel] Promoting a pull request

2016-11-22 Thread Jouke Witteveen
On Tue, Nov 22, 2016 at 11:55 AM, Martin Pitt wrote: > Jouke Witteveen [2016-11-22 11:44 +0100]: >> I see no way of (trying to) removing the reviewed/needs-rework label >> in the PR interface. > > I click on the cog next to "Labels" on the right, there I can "untick" > labels. I've done so for #42

Re: [systemd-devel] Promoting a pull request

2016-11-22 Thread Martin Pitt
Hello Jouke, Jouke Witteveen [2016-11-22 11:44 +0100]: > I see no way of (trying to) removing the reviewed/needs-rework label > in the PR interface. I click on the cog next to "Labels" on the right, there I can "untick" labels. I've done so for #4259. So maybe it's just UI obfuscation, but perha

[systemd-devel] Promoting a pull request

2016-11-22 Thread Jouke Witteveen
The contribution guidelines [1] state: > After you have pushed a new version, try to remove the > reviewed/needs-rework label. Also add a comment about the new version > (no notification is sent just for the commits, so it's easy to miss the > update without an explicit comment). I see no way of