Re: [systemd-devel] [PATCH] Fix hostnamectl exit code

2014-11-28 Thread David Herrmann
Hi On Fri, Nov 28, 2014 at 3:54 PM, Martin Pitt wrote: > Hey David, > > David Herrmann [2014-11-28 15:49 +0100]: >> Why not fix all those other occurrences with one fix by changing >> hostnamectl_main() the last line from: >> return r < 0 ? EXIT_FAILURE : r; >> to >> return r < 0 ? EXIT_F

Re: [systemd-devel] [PATCH] Fix hostnamectl exit code

2014-11-28 Thread Martin Pitt
Hey David, David Herrmann [2014-11-28 15:49 +0100]: > Why not fix all those other occurrences with one fix by changing > hostnamectl_main() the last line from: > return r < 0 ? EXIT_FAILURE : r; > to > return r < 0 ? EXIT_FAILURE : 0; > > Usually, >=0 means success, <0 failure, in systemd

Re: [systemd-devel] [PATCH] Fix hostnamectl exit code

2014-11-28 Thread David Herrmann
Hi On Fri, Nov 28, 2014 at 3:43 PM, Martin Pitt wrote: > Hello all, > > while packaging 217 my integration tests for hostnamed yelled at me > that hostnamectl fails. Indeed it exits with 1 now even though it > succeeds. > > Trivial patch attached. OK to push? Why not fix all those other occurren

[systemd-devel] [PATCH] Fix hostnamectl exit code

2014-11-28 Thread Martin Pitt
Hello all, while packaging 217 my integration tests for hostnamed yelled at me that hostnamectl fails. Indeed it exits with 1 now even though it succeeds. Trivial patch attached. OK to push? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubunt