Re: [systemd-devel] [PATCH] mounting /dev/pts noexec causes trouble for grantpts(3)

2010-10-12 Thread Mike Kelly
On Tue, Oct 12, 2010 at 08:11:58PM +0200, Lennart Poettering wrote: > On Tue, 12.10.10 13:57, Mike Kelly ([email protected]) wrote: > > > grantpt(3) failed: Exec format error > > Hmm, can you elaborate on this? Why does executability help here? Well, this code is failing

[systemd-devel] [PATCH] mounting /dev/pts noexec causes trouble for grantpts(3)

2010-10-12 Thread Mike Kelly
grantpt(3) failed: Exec format error --- src/mount-setup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mount-setup.c b/src/mount-setup.c index d2f05bc..3ca2cca 100644 --- a/src/mount-setup.c +++ b/src/mount-setup.c @@ -47,7 +47,7 @@ static const MountPoint mount_t

[systemd-devel] [PATCH] unit-name: fix unit name escaping

2010-10-01 Thread Mike Kelly
we want to do a bitwise shift, not a greater-than comparision --- src/unit-name.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/unit-name.c b/src/unit-name.c index 2e2948a..868d13e 100644 --- a/src/unit-name.c +++ b/src/unit-name.c @@ -211,7 +211,7 @@ static char* d