Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Mike Gilbert
On Fri, May 29, 2015 at 8:05 PM, Daniel Mack wrote: > Make sure the variable set via --with-rootprefix= does not contain a > trailing slash, so man pages can use entities like "&rootprefix;/lib" > without ending up having double slashes. > --- > configure.ac | 3 ++- > 1 file changed, 2 insertion

[systemd-devel] [PATCH] build-sys: Normalize paths of configure options

2015-05-29 Thread Filipe Brandenburger
From: Michael Biebl Strip trailing slashes from options such as --with-rootprefix, so that building with rootprefix="/" results in paths like "/lib" instead of "//lib". Also handle paths such as "/usr/" gracefully. Use m4/ax_normalize_path.m4 from the autoconf-archive project, which is now incl

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Filipe Brandenburger
Hi, On Fri, May 29, 2015 at 6:04 PM, Michael Biebl wrote: > I we assume, autconf-archive is installed, the resulting patch would > look like the attached diff. > For convenience sake, we could also ship a copy of > /usr/share/aclocal/ax_normalize_path.m4 in our m4/ directory. Yep... indeed autoc

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:53 GMT+02:00 Michael Biebl : > 2015-05-30 2:50 GMT+02:00 Michael Biebl : >> 2015-05-30 2:24 GMT+02:00 Daniel Mack : >>> >>> Fine for me, just go ahead if you have an implementation in mind :) >> >> I was lazy and just copied >> ftp://ftp.tu-clausthal.de/pub/mirror/gnu/www/software/ac-a

Re: [systemd-devel] [PATCH 2/2] man: replace hard-coded /usr/lib

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:50 GMT+02:00 Michael Biebl : > 2015-05-30 2:24 GMT+02:00 Daniel Mack : >> >> Fine for me, just go ahead if you have an implementation in mind :) > > I was lazy and just copied > ftp://ftp.tu-clausthal.de/pub/mirror/gnu/www/software/ac-archive/normpath.html Oh, I just noticed there is

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:24 GMT+02:00 Daniel Mack : > > Fine for me, just go ahead if you have an implementation in mind :) I was lazy and just copied ftp://ftp.tu-clausthal.de/pub/mirror/gnu/www/software/ac-archive/normpath.html The resulting diff would look something like diff --git a/configure.ac b/config

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:30 GMT+02:00 Filipe Brandenburger : > On Fri, May 29, 2015 at 5:21 PM, Michael Biebl wrote: >> autoconf already strips trailing slashes for all default directory >> variables [1]. > > How does it handle --prefix=/ though? Does it turn it into an empty string? Hm, no, apparently it do

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Filipe Brandenburger
On Fri, May 29, 2015 at 5:21 PM, Michael Biebl wrote: > autoconf already strips trailing slashes for all default directory > variables [1]. How does it handle --prefix=/ though? Does it turn it into an empty string? > I think we should do the same for *all* our custom --with-$foo-dir > variables

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Daniel Mack
On 05/30/2015 02:21 AM, Michael Biebl wrote: > 2015-05-30 2:05 GMT+02:00 Daniel Mack : >> Make sure the variable set via --with-rootprefix= does not contain a >> trailing slash, so man pages can use entities like "&rootprefix;/lib" >> without ending up having double slashes. >> --- >> configure.ac

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:05 GMT+02:00 Daniel Mack : > Make sure the variable set via --with-rootprefix= does not contain a > trailing slash, so man pages can use entities like "&rootprefix;/lib" > without ending up having double slashes. > --- > configure.ac | 3 ++- > 1 file changed, 2 insertions(+), 1 delet

[systemd-devel] [PATCH 2/2] man: replace hard-coded /usr/lib

2015-05-29 Thread Daniel Mack
Replace some /usr/lib occurences in man/ with &rootprefix;/lib. --- man/hwdb.xml| 4 ++-- man/systemd.link.xml| 4 ++-- man/systemd.netdev.xml | 4 ++-- man/systemd.network.xml | 4 ++-- man/udev.xml| 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --g

[systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Daniel Mack
Make sure the variable set via --with-rootprefix= does not contain a trailing slash, so man pages can use entities like "&rootprefix;/lib" without ending up having double slashes. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac ind

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-29 Thread Daniel Mack
On 05/29/2015 07:37 PM, Filipe Brandenburger wrote: > I haven't tested it, but I do have a few comments. > > First, why not use "rootlibdir" instead of "rootprefixlibdir"? Because $(rootlibdir) resolves to /usr/lib64 on my system. [...] > On Fri, May 29, 2015 at 2:05 AM, Daniel Mack wrote: >>

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Daniel Mack
On 05/29/2015 06:53 PM, Lennart Poettering wrote: > On Fri, 29.05.15 09:45, Filipe Brandenburger (filbran...@google.com) wrote: >>> Atm, man/custom-entities.ent is only cleaned up on "make distclean". >>> I think we should move that from DISTCLEANFILES to CLEANFILES. >> >> Yes I think that's a goo

Re: [systemd-devel] [PATCH 5/5] Add cgroup.populated inotify watches.

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-deve

Re: [systemd-devel] [PATCH v2 5/5] core/cgroup: Add cgroup.populated inotify watches, when available.

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-deve

[systemd-devel] [PATCH v2 0/5] resent

2015-05-29 Thread Dimitri John Ledkov
... sigh looks like I had duplicate patches generated in my tree. this is a clean resent. Dimitri John Ledkov (5): cgroup-util: fix is_valid check to pass for unified cgroup hierchy. configure.ac: add option for experimental unified cgroup handling. core/mount-setup: Mount unified hierchy, i

[systemd-devel] [PATCH v2 2/5] configure.ac: add option for experimental unified cgroup handling.

2015-05-29 Thread Dimitri John Ledkov
--- configure.ac | 11 +++ 1 file changed, 11 insertions(+) diff --git a/configure.ac b/configure.ac index 92654a6..232d419 100644 --- a/configure.ac +++ b/configure.ac @@ -1325,6 +1325,16 @@ AC_ARG_ENABLE(ldconfig, AM_CONDITIONAL(ENABLE_LDCONFIG, [test x$enable_ldconfig = xyes]) # -

[systemd-devel] [PATCH v2 1/5] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Dimitri John Ledkov
It appears in /proc/self/cgroup as `0::/' --- src/shared/cgroup-util.c| 4 src/test/test-cgroup-util.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c index 9988e5c..2bca32a 100644 --- a/src/shared/cgroup-util.c ++

[systemd-devel] [PATCH v2 3/5] core/mount-setup: Mount unified hierchy, instead of name=systemd, when compiled to do so.

2015-05-29 Thread Dimitri John Ledkov
--- src/core/mount-setup.c | 5 + src/shared/def.h | 4 2 files changed, 9 insertions(+) diff --git a/src/core/mount-setup.c b/src/core/mount-setup.c index c35248e..3112e00 100644 --- a/src/core/mount-setup.c +++ b/src/core/mount-setup.c @@ -94,10 +94,15 @@ static const MountPoint

[systemd-devel] [PATCH v2 5/5] core/cgroup: Add cgroup.populated inotify watches, when available.

2015-05-29 Thread Dimitri John Ledkov
--- src/core/cgroup.c| 81 ++-- src/core/manager.c | 7 - src/core/manager.h | 3 ++ src/core/service.c | 2 +- src/shared/cgroup-util.c | 28 + src/shared/cgroup-util.h | 6 ++-- src/test/test-cgroup.c

[systemd-devel] [PATCH v2 4/5] unified-cgroup: fix cg_pid_get_path() and cg_get_path().

2015-05-29 Thread Dimitri John Ledkov
--- src/shared/cgroup-util.c| 8 src/test/test-cgroup-util.c | 18 ++ 2 files changed, 26 insertions(+) diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c index 2bca32a..eae9f5d 100644 --- a/src/shared/cgroup-util.c +++ b/src/shared/cgroup-util.c @@ -74

[systemd-devel] [PATCH 3/5] Mount unified hierchy, instead of name=systemd.

2015-05-29 Thread Dimitri John Ledkov
--- src/core/mount-setup.c | 5 + src/shared/def.h | 4 2 files changed, 9 insertions(+) diff --git a/src/core/mount-setup.c b/src/core/mount-setup.c index ba96741..1cf7099 100644 --- a/src/core/mount-setup.c +++ b/src/core/mount-setup.c @@ -94,10 +94,15 @@ static const MountPoint

[systemd-devel] [PATCH 4/5] unified-cgroup: fix cg_pid_get_path() and cg_get_path().

2015-05-29 Thread Dimitri John Ledkov
--- src/shared/cgroup-util.c| 8 src/test/test-cgroup-util.c | 18 ++ 2 files changed, 26 insertions(+) diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c index 2bca32a..eae9f5d 100644 --- a/src/shared/cgroup-util.c +++ b/src/shared/cgroup-util.c @@ -74

[systemd-devel] [PATCH 1/5] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Dimitri John Ledkov
It appears in /proc/self/cgroup as `0::/' --- src/shared/cgroup-util.c| 4 src/test/test-cgroup-util.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c index 9988e5c..2bca32a 100644 --- a/src/shared/cgroup-util.c ++

[systemd-devel] [PATCH 3/5] core/mount-setup: Mount unified hierchy, instead of name=systemd, when compiled to do so.

2015-05-29 Thread Dimitri John Ledkov
--- src/core/mount-setup.c | 5 + src/shared/def.h | 4 2 files changed, 9 insertions(+) diff --git a/src/core/mount-setup.c b/src/core/mount-setup.c index c35248e..3112e00 100644 --- a/src/core/mount-setup.c +++ b/src/core/mount-setup.c @@ -94,10 +94,15 @@ static const MountPoint

[systemd-devel] [PATCH 5/5] Add cgroup.populated inotify watches.

2015-05-29 Thread Dimitri John Ledkov
--- src/core/cgroup.c| 81 ++-- src/core/manager.c | 7 - src/core/manager.h | 3 ++ src/core/service.c | 2 +- src/shared/cgroup-util.c | 28 + src/shared/cgroup-util.h | 6 ++-- src/test/test-cgroup.c

[systemd-devel] [PATCH 5/5] core/cgroup: Add cgroup.populated inotify watches, when available.

2015-05-29 Thread Dimitri John Ledkov
--- src/core/cgroup.c| 81 ++-- src/core/manager.c | 7 - src/core/manager.h | 3 ++ src/core/service.c | 2 +- src/shared/cgroup-util.c | 28 + src/shared/cgroup-util.h | 6 ++-- src/test/test-cgroup.c

[systemd-devel] [PATCH 2/5] configure.ac: add option for experimental unified cgroup handling.

2015-05-29 Thread Dimitri John Ledkov
--- configure.ac | 11 +++ 1 file changed, 11 insertions(+) diff --git a/configure.ac b/configure.ac index 92654a6..232d419 100644 --- a/configure.ac +++ b/configure.ac @@ -1325,6 +1325,16 @@ AC_ARG_ENABLE(ldconfig, AM_CONDITIONAL(ENABLE_LDCONFIG, [test x$enable_ldconfig = xyes]) # -

[systemd-devel] [PATCH 0/5] experimental basic unified cgroups work

2015-05-29 Thread Dimitri John Ledkov
This is initial basic experimental integration of unified cgroups work. I've started this by adding compile time option to switch the behaviour a little bit. At the moment this does the following for the /sys/fs/cgroup/systemd mountpoint: - instead of mounting name=systemd legacy cgroup - it mou

Re: [systemd-devel] systemd-logind and selinux enforcing: Assertion failed

2015-05-29 Thread George Karakougioumtzis
Its an fc21 with all the updates as of today. systemd version is 216.24 here. I think i should quit on enforcing as i have too many problems apart these two. I saw the bug report which was related to the one you had fixed (on redhat bugzilla)but mine was kind of different. Upgrading to rawhide is

Re: [systemd-devel] fsck, /home, btrfs, multiple partitions/drives, boot failure [Ubuntu 15.04]

2015-05-29 Thread Roger Binns
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/28/2015 08:40 PM, Andrei Borzenkov wrote: > Try booting with udev.log-priority=debug > rd.udev.log-priority=debug, this may give some hint what happens. Wow did that produce a lot of output! > No. You can set "nofail" in which case boot will pr

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-29 Thread Filipe Brandenburger
Hi Daniel, I haven't tested it, but I do have a few comments. First, why not use "rootlibdir" instead of "rootprefixlibdir"? There's already similar "rootbindir" and "rootlibexecdir" defined there, so I think we could stick to the same convention. From a few lines down in Makefile.am: # And t

Re: [systemd-devel] [PATCH V3] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 11:05, Daniel Mack (dan...@zonque.org) wrote: > On 05/29/2015 05:18 AM, Michael Biebl wrote: > > 2015-05-28 19:47 GMT+02:00 Filipe Brandenburger : > >> We're actually still missing a small part of it (A sentence like > >> "Files in /etc have the highest priority, files in /run tak

Re: [systemd-devel] [PATCH V3] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 18:24, har...@redhat.com (har...@redhat.com) wrote: > +static int disk_major_minor(const char *path, char **ret) { > +struct stat st; > + > +assert(path); > + > +if (stat(path, &st) < 0) > +return -errno; > + > +if (!S_ISBLK(st.st_mo

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 09:45, Filipe Brandenburger (filbran...@google.com) wrote: > Hi, > > I was thinking about this one recently... > > I really think the "correct" solution is for man/custom-entities.ent > to be generated by configure from a man/custom-entities.ent.in > template instead. I haven't

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Filipe Brandenburger
Hi, I was thinking about this one recently... I really think the "correct" solution is for man/custom-entities.ent to be generated by configure from a man/custom-entities.ent.in template instead. I haven't really checked if that's viable though, if configure knows about every variable it will nee

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Michael Biebl
2015-05-29 15:56 GMT+02:00 Lennart Poettering : > > I think it's ok to expect people to run "make clean" after touching > the makefile to get the man pages fixed. Atm, man/custom-entities.ent is only cleaned up on "make distclean". I think we should move that from DISTCLEANFILES to CLEANFILES. -

[systemd-devel] [PATCH V3] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread harald
From: Harald Hoyer If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device path. If possible "/dev/block/:" is used, otherwise the original argv[3] is used. This enables password agents like petera [1] to provide a password accordin

Re: [systemd-devel] [PATCH v2 2/2] path-util: Change path_is_mount_point() symlink arg from bool to flags

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 17:50 +0200]: > Looks good too. Please push! Pushed. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing li

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Aaron_Wright
> > I compiled systemd without dbus support (--disable-dbus), and there is no > > dbus daemon or dbus lib on the system. Is that a requirement to get the > > functionality I want? I didn't see much need for dbus as the system works > > quite well without it. Well, except for this of course. >

Re: [systemd-devel] [PATCH V2] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

[systemd-devel] [PATCH V2] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread harald
From: Harald Hoyer If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device path. If possible "/dev/block/:" is used, otherwise the original argv[3] is used. This enables password agents like petera [1] to provide a password accordin

Re: [systemd-devel] [PATCH v2 2/2] path-util: Change path_is_mount_point() symlink arg from bool to flags

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:25, Martin Pitt (martin.p...@ubuntu.com) wrote: > Hello, > > and this is the second part which updates the signature of > path_is_mount_point() to replace "bool allow_symlink" to an > openat()-like flags. > > This patch does not change visible behaviour, it's just a stylistic

[systemd-devel] [HEADSUP] nspawn/networkd: moving from iptables to nftables

2015-05-29 Thread Lennart Poettering
Heya, just a small heads-up: Currently there are two firewall APIs used on Linux: iptables and nftables. iptables is the older one, nftables the new replacement. systemd-nspawn and systemd-networkd currently interface with iptables via the libiptc library: nspawn to implement the --port= switch f

Re: [systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 17:31 +0200]: > I think this: > > flags = flags & ~AT_SYMLINK_FOLLOW; > > should better be written like this: > > flags &= ~AT_SYMLINK_FOLLOW; > > this matches the other if branch better then... Of course, little brainfart.. > Looks good otherwis

Re: [systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:22, Martin Pitt (martin.p...@ubuntu.com) wrote: > Hello, > > Lennart Poettering [2015-05-28 19:44 +0200]: > > I really think this should work as close as the usual *at() calls > > work. i.e. take a dir fd as first argument, and a filename > > *within*that*directory* to check.

[systemd-devel] [PATCH v2 2/2] path-util: Change path_is_mount_point() symlink arg from bool to flags

2015-05-29 Thread Martin Pitt
Hello, and this is the second part which updates the signature of path_is_mount_point() to replace "bool allow_symlink" to an openat()-like flags. This patch does not change visible behaviour, it's just a stylistic issue. Martin -- Martin Pitt| http://www.piware.de Ubunt

[systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
Hello, Lennart Poettering [2015-05-28 19:44 +0200]: > I really think this should work as close as the usual *at() calls > work. i.e. take a dir fd as first argument, and a filename > *within*that*directory* to check. Maybe even give it the _at() suffix: > > int fd_is_mount_point_at(int fd, const

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:11, Harald Hoyer (har...@redhat.com) wrote: > Am 29.05.2015 um 17:04 schrieb Lennart Poettering: > > On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: > > > >> > >> +static char* disk_maj_min(const char *path) { > > > > I'd really not abbreivate things he

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:09, Martin Pitt (martin.p...@ubuntu.com) wrote: > Lennart Poettering [2015-05-29 17:02 +0200]: > > I'd really just introduce a new kernel cmdline option: > > systemd.debug-unified-cgroup=1 or so. A simple boolean that gets you > > either one or the other behaviour. Maybe make t

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Harald Hoyer
Am 29.05.2015 um 17:04 schrieb Lennart Poettering: > On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: > >> >> +static char* disk_maj_min(const char *path) { > > I'd really not abbreivate things here... call it "major" and > "minor". there's no point in saving two "or"s... >

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 17:02 +0200]: > I'd really just introduce a new kernel cmdline option: > systemd.debug-unified-cgroup=1 or so. A simple boolean that gets you > either one or the other behaviour. Maybe make the default for this > setting configurable with a configure script switch. An

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:01, Martin Pitt (martin.p...@ubuntu.com) wrote: > Harald Hoyer [2015-05-29 16:50 +0200]: > > I was more thinking about symlinks pointing to the same device. > > Naïvely I'd think that resolving symlinks would still be more readable > than major/minor numbers; why would that be

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: > > +static char* disk_maj_min(const char *path) { I'd really not abbreivate things here... call it "major" and "minor". there's no point in saving two "or"s... > +struct stat st, st2; > +char *i = NULL; > +

Re: [systemd-devel] [PATCH] zsh-completion: a more style/tag aware _systemctl

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 15:52, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: > > And yeah, getting proper notifications especially for the container > > case is the most important thing for me too. > > Right. I have it as compile option at the moment, and i'm booting > fresh VMs with it. I do

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Martin Pitt
Harald Hoyer [2015-05-29 16:50 +0200]: > I was more thinking about symlinks pointing to the same device. Naïvely I'd think that resolving symlinks would still be more readable than major/minor numbers; why would that be worse? Thanks, Martin -- Martin Pitt| http://www.pi

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 15:45, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: > On 29 May 2015 at 11:17, wrote: > > From: Harald Hoyer > > > > If cryptsetup is called with a source device as argv[3], then craft the > > ID for the password agent with a unique device path. > > > > I'm not sure

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Dimitri John Ledkov
On 29 May 2015 at 14:41, Lennart Poettering wrote: > On Fri, 29.05.15 12:42, Dimitri John Ledkov (dimitri.j.led...@intel.com) > wrote: > >> On 29 May 2015 at 11:25, Lennart Poettering wrote: >> > On Fri, 29.05.15 00:24, Dimitri John Ledkov (dimitri.j.led...@intel.com) >> > wrote: >> > >> >> On

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Harald Hoyer
Am 29.05.2015 um 16:38 schrieb Lennart Poettering: > On Fri, 29.05.15 16:30, Harald Hoyer (har...@redhat.com) wrote: > >> Am 29.05.2015 um 16:26 schrieb Lennart Poettering: >>> On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: >>> From: Harald Hoyer If cryptsetup

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Harald Hoyer
Am 29.05.2015 um 16:45 schrieb Dimitri John Ledkov: > On 29 May 2015 at 11:17, wrote: >> From: Harald Hoyer >> >> If cryptsetup is called with a source device as argv[3], then craft the >> ID for the password agent with a unique device path. >> > > I'm not sure why this is needed... if the devi

Re: [systemd-devel] [PATCH] build-sys: pass originally configured --enable-split-usr to distcheck

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 16:28 +0200]: > Looks good. Please push. Pushed. > Any chance you can connect this thing to #systemd on IRC? Would really > love to be notified about failures, but ideall without email-spam... Yes, I'd like that too. I haven't looked at how to create IRC bots, but

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Dimitri John Ledkov
On 29 May 2015 at 11:17, wrote: > From: Harald Hoyer > > If cryptsetup is called with a source device as argv[3], then craft the > ID for the password agent with a unique device path. > I'm not sure why this is needed... if the device path is not good enough, there is also luks UUID header. In

[systemd-devel] [PATCH] zsh-completion: a more style/tag aware _systemctl

2015-05-29 Thread Eric Cook
using _wanted instead of calling compadd directly. this allows the user to customize possible matches. An example being, grouping units by type: autoload -Uz compinit; compinit zstyle ':completion:*' menu select zstyle ':completion:*' group-name '' zstyle ':completion:*' format 'Completing %d' zs

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 16:30, Harald Hoyer (har...@redhat.com) wrote: > Am 29.05.2015 um 16:26 schrieb Lennart Poettering: > > On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: > > > >> From: Harald Hoyer > >> > >> If cryptsetup is called with a source device as argv[3], then craft

Re: [systemd-devel] I am adding RegisterMachine to docker.

2015-05-29 Thread Lennart Poettering
On Thu, 28.05.15 16:05, Daniel J Walsh (dwa...@redhat.com) wrote: > When container stops machinectl still shows it registered? Do I need to > Unregister the machine? I though systemd would notice the pid died and > remove the machine. Most likely it's not machined/machinectl that is confused he

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Harald Hoyer
Am 29.05.2015 um 16:26 schrieb Lennart Poettering: > On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: > >> From: Harald Hoyer >> >> If cryptsetup is called with a source device as argv[3], then craft the >> ID for the password agent with a unique device path. >> >> If possible

Re: [systemd-devel] [PATCH] build-sys: pass originally configured --enable-split-usr to distcheck

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 07:49, Martin Pitt (martin.p...@ubuntu.com) wrote: > Hello all, > > this is a little patch which fixes "make distcheck" on split-/usr > systems. That together with the previous "Stop depending on current > configure options for EXTRA_DIST" now makes check, distcheck, etc. > compl

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > If cryptsetup is called with a source device as argv[3], then craft the > ID for the password agent with a unique device path. > > If possible "/dev/block/:" is used, otherwise the original > argv[3] i

Re: [systemd-devel] [PATCH] install: follow symlinks when enabling unit files from /usr/

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel maili

[systemd-devel] [PATCH] install: follow symlinks when enabling unit files from /usr/

2015-05-29 Thread Michal Sekletar
Right now it is difficult for distros to ship convenience/compat alias for some service, e.g. mariadb aliased to mysql or nfs-server to nfs. If service which comes with alias is not enabled by default then user must refer to its new unit file name when trying to enable the service. Contrary, using

Re: [systemd-devel] systemctl disable not working as expected

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 11:19, Belal, Awais (awais_be...@mentor.com) wrote: > Hi, > > I am working on an x86_64 platform with a yocto based environment. I > was trying to disable pulseaudio which is included in the system by > default so I did a 'systemctl disable pulseaudio' but when I reboot > it seem

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 12:26, Daniel Mack (dan...@zonque.org) wrote: > On 05/29/2015 12:07 PM, Lennart Poettering wrote: > > On Fri, 29.05.15 03:03, Daniel Mack (zon...@kemper.freedesktop.org) wrote: > > > >> Makefile.am |2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> New commi

Re: [systemd-devel] systemd-logind and selinux enforcing: Assertion failed

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 14:04, George Karakougioumtzis (mad-proffes...@hotmail.com) wrote: > As i was trying to enforce selinux on a fedora 21 i got this which seems > more related to systemd-mailing list rather than the selinux one. > > systemd-logind[355]: Assertion 's->user->slice' failed at > ../s

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 13:56, Mantas Mikulėnas (graw...@gmail.com) wrote: > > systemd will always use D-Bus (the protocol) for IPC, that's not > > optional, and you cannot turn it off neither during build-time nor > > during runtime. systemd does not use libdbus to implement this > > however, but instea

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 12:42, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: > On 29 May 2015 at 11:25, Lennart Poettering wrote: > > On Fri, 29.05.15 00:24, Dimitri John Ledkov (dimitri.j.led...@intel.com) > > wrote: > > > >> On 28 May 2015 at 18:08, Lennart Poettering wrote: > >> > On Thu,

Re: [systemd-devel] [PATCH v3 3/3] udev: input_id - use ABS_MT_SLOT{-1} to exclude non touch screen devices

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-d

[systemd-devel] [PATCH v3 2/3] udev: input_id - use direct property and mt axis for touch screen detection

2015-05-29 Thread Andreas Pokorny
A lot of touch screens use INPUT_PROP_DIRECT to indicate that touch input maps directly to the underlying screen, while the BTN_TOUCH bit might not be set. --- src/udev/udev-builtin-input_id.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/udev/udev-builtin-input_id

[systemd-devel] [PATCH v3 3/3] udev: input_id - use ABS_MT_SLOT{-1} to exclude non touch screen devices

2015-05-29 Thread Andreas Pokorny
Require touch screens to have a ABS_MT_SLOT axis while exclude devices that overlap with the MT range of axes. --- src/udev/udev-builtin-input_id.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/udev/udev-builtin-input_id.c b/src/udev/udev-builtin-input_id.c index 0f9f02

[systemd-devel] [PATCH v3 1/3] udev: input_id - refactor device detection

2015-05-29 Thread Andreas Pokorny
This change switches to bools and separates bit flag evaluation from decision making and application of udev properties, while hopefully keeping the same semantics. Apart from using BTN_LEFT instead of BTN_MOUSE for mouse detection. --- src/udev/udev-builtin-input_id.c | 134 +-

[systemd-devel] [PATCH v3 0/3] udev: input_id - extended device detection for touch screens

2015-05-29 Thread Andreas Pokorny
Hi, This is the revised version, split up into a series of changes. The first separates evdev property evaluation from decision taking and udev property application. The second adds INPUT_PROP_DIRECT and MT axis to detect touch screens. The final one adds a check for overlapping axis ranges.

Re: [systemd-devel] systemctl disable not working as expected

2015-05-29 Thread Mantas Mikulėnas
On Fri, May 29, 2015 at 3:04 PM, Belal, Awais wrote: > Hi Martin, > > Thanks for the very quick reply :) > So, are you saying that there is no guaranteed way in which PA can be > enabled/disabled in a systemd based system? pulseaudio is *very rarely* run as a system service in the first place.

Re: [systemd-devel] systemctl disable not working as expected

2015-05-29 Thread Belal, Awais
Hi Martin, Thanks for the very quick reply :) So, are you saying that there is no guaranteed way in which PA can be enabled/disabled in a systemd based system? That too, if I want to keep the binary in so if a user needs he can enable/disable PA as per need. How can I disable PA in such a scen

Re: [systemd-devel] [PATCH] build-sys: fix typo

2015-05-29 Thread Martin Pitt
Hey Karel, Karel Zak [2015-05-29 13:42 +0200]: > There is nothing like systemd_verify_* in Makefile.am. The bug has > been invisible because automake uses the default CFLAGS when component > CFLAGS are undefined. Applied, looks/works fine. Thanks! Martin -- Martin Pitt|

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Dimitri John Ledkov
On 29 May 2015 at 11:25, Lennart Poettering wrote: > On Fri, 29.05.15 00:24, Dimitri John Ledkov (dimitri.j.led...@intel.com) > wrote: > >> On 28 May 2015 at 18:08, Lennart Poettering wrote: >> > On Thu, 28.05.15 16:42, Dimitri John Ledkov (dimitri.j.led...@intel.com) >> > wrote: >> > >> >> It

[systemd-devel] [PATCH] build-sys: fix typo

2015-05-29 Thread Karel Zak
There is nothing like systemd_verify_* in Makefile.am. The bug has been invisible because automake uses the default CFLAGS when component CFLAGS are undefined. --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index d6010c5..ed5135d 10064

Re: [systemd-devel] systemctl disable not working as expected

2015-05-29 Thread Martin Pitt
Hello Belal, Belal, Awais [2015-05-29 11:19 +]: > I am working on an x86_64 platform with a yocto based environment. I > was trying to disable pulseaudio which is included in the system by > default so I did a 'systemctl disable pulseaudio' but when I reboot > it seems pulseaudio is still run

[systemd-devel] systemctl disable not working as expected

2015-05-29 Thread Belal, Awais
Hi, I am working on an x86_64 platform with a yocto based environment. I was trying to disable pulseaudio which is included in the system by default so I did a 'systemctl disable pulseaudio' but when I reboot it seems pulseaudio is still run for a very short period of time and this is messing u

[systemd-devel] systemd-logind and selinux enforcing: Assertion failed

2015-05-29 Thread George Karakougioumtzis
As i was trying to enforce selinux on a fedora 21 i got this which seems more related to systemd-mailing list rather than the selinux one. systemd-logind[355]: Assertion 's->user->slice' failed at ../src/login/logind-session.c:496, function session_start_scope(). Aborting. As a result loginctl

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Mantas Mikulėnas
On Fri, May 29, 2015 at 1:02 PM, Lennart Poettering wrote: > On Thu, 28.05.15 17:21, aaron_wri...@selinc.com (aaron_wri...@selinc.com) > wrote: > > > Brandon Philips wrote on 05/28/2015 05:10:33 PM: > > > Access to the system dbus is controlled by dbus policies. You will > > > need to write a po

Re: [systemd-devel] [PATCH v2] udev: input_id: fix detection of various touchscreens

2015-05-29 Thread Andreas Pokorny
Hi, On Fri, May 29, 2015 at 2:07 AM, Peter Hutterer wrote: > On Thu, May 28, 2015 at 02:47:35PM +0200, Andreas Pokorny wrote: > > There are touch screens that do not provide 'BTN_TOUCH' and hence no > > 'EV_KEY'. Previously those would not get any properties assigned and > > note: I consider th

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Daniel Mack
On 05/29/2015 12:07 PM, Lennart Poettering wrote: > On Fri, 29.05.15 03:03, Daniel Mack (zon...@kemper.freedesktop.org) wrote: > >> Makefile.am |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> New commits: >> commit 6096d9ccc3f0b963010a47febce7e44c8632c23b >> Author: Daniel Mack

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 00:24, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: > On 28 May 2015 at 18:08, Lennart Poettering wrote: > > On Thu, 28.05.15 16:42, Dimitri John Ledkov (dimitri.j.led...@intel.com) > > wrote: > > > >> It appears in /proc/self/cgroup as `0::/' > > > > What precisely d

Re: [systemd-devel] [PATCH] build-sys: Stop depending on current configure options for EXTRA_DIST

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 12:20 +0200]: > From all I can see this looks fine. Please push. Pushed. -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-deve

Re: [systemd-devel] [PATCH] build-sys: Stop depending on current configure options for EXTRA_DIST

2015-05-29 Thread Lennart Poettering
On Thu, 28.05.15 12:16, Martin Pitt (martin.p...@ubuntu.com) wrote: > Hello all, > > for the quest of doing daily builds/distcheck/etc. on Debian/Ubuntu I > started running distcheck on current trunk. It failed with > > GEN units/kmod-static-nodes.service > make[3]: *** No rule to make ta

[systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread harald
From: Harald Hoyer If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device path. If possible "/dev/block/:" is used, otherwise the original argv[3] is used. This enables password agents like petera [1] to provide a password accordin

  1   2   >