[systemd-devel] [PATCH 1/2] selinux: make sure selinux is using on mac_selinux_fix()

2014-10-23 Thread WaLyong Cho
--- src/shared/selinux-util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shared/selinux-util.c b/src/shared/selinux-util.c index 1eddd17..bb27328 100644 --- a/src/shared/selinux-util.c +++ b/src/shared/selinux-util.c @@ -128,6 +128,9 @@ int mac_selinux_fix(const char *path, bool ig

[systemd-devel] [PATCH 2/2] udev: do NOT re-label smack

2014-10-23 Thread WaLyong Cho
From: WaLyong Cho If selinux is disabled and smack is only enabled, smack label is relable-ed by label_fix. To avoid, make only be labeled for selinux. --- src/udev/udev-node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udev/udev-node.c b/src/udev/udev-node.c index 4

Re: [systemd-devel] [PATCH 3/3] udev: do NOT re-label smack

2014-10-23 Thread WaLyong Cho
On 10/23/2014 06:13 AM, Lennart Poettering wrote: > On Thu, 16.10.14 16:59, WaLyong Cho (walyong@samsung.com) wrote: > >> If selinux is disabled and smack is only enabled, smack label is >> relable-ed by label_fix. To avoid, make only be labeled for selinux. >> --- >> src/udev/udev-node.c | 4

Re: [systemd-devel] [PATCH 2/2] mac: rename apis with mac_{selinux/smack}_ prefix

2014-10-23 Thread WaLyong Cho
On 10/24/2014 07:56 AM, Lennart Poettering wrote: > On Thu, 23.10.14 17:23, WaLyong Cho (walyong@gmail.com) wrote: > > Heya! > > I merged both patches now! Thanks! > > After merging I reworked quite a bit more code to make the selinux > and smack bits work more similar to each. I cannot test

[systemd-devel] [properly] man/pam_systemd.xml: remove heinous use of exclusionary gendered pronoun

2014-10-23 Thread Johnathan Zefran
Sorry about the formatting, I forgot to turn off html. Here's what I was trying to say: --- The use of a gendered pronoun like 'his' constitutes a rather baffling piece of sexism and misogyny on Lennart's part, considering he overwrote a valid gender-neutral pronoun

[systemd-devel] [systemd-commits] man/pam_systemd.xml

2014-10-23 Thread Johnathan Zefran
The use of a gendered pronoun like 'his' constitutes a rather baffling piece of sexism and misogyny on Lennart's part, considering he overwrote a valid gender-neutral pronoun. I am disappointed by this, so I would like to propose the use of the gender-neutral 'zir' pronoun. Tech has a big problem w

Re: [systemd-devel] [systemd-commits] man/pam_systemd.xml

2014-10-23 Thread Chris Bell
On Thu, Oct 23, 2014 at 8:53 PM, Lennart Poettering wrote: > Well, the sentence is complicated enough as it is. On Thu, Oct 23, 2014 at 8:55 PM, Alex Gaynor wrote: > Switching to "her/his" would be a definitely improvement. What if we reworded it to avoid the use of them, his, or her altogether

Re: [systemd-devel] [systemd-commits] 2 commits - man/pam_systemd.xml src/shared

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 04:15:59PM -0700, Lennart Poettering wrote: > man: in pam_systemd, it must be "his" (or "her"), not their Why? "Their" is gramatically correct, and sidesteps specyfing the gender. http://english.stackexchange.com/questions/192/is-it-correct-to-use-their-instead-of-his-

Re: [systemd-devel] [systemd-commits] man/pam_systemd.xml

2014-10-23 Thread Alex Gaynor
Lennart Poettering poettering.net> writes: > > Well, the sentence is complicated enough as it is. By sticking to a > singular form it appears clearer to me what is meant here. > > I am fine with changing this to "her/his" if "his" alone is really is > too bad, but "their" appears a lot more con

Re: [systemd-devel] [systemd-commits] man/pam_systemd.xml

2014-10-23 Thread Lennart Poettering
On Fri, 24.10.14 00:26, Alex Gaynor (alex.gay...@gmail.com) wrote: > Lennart Poettering poettering.net> writes: > > > > > hmm, why "their"? THat's wrong. It's the user's instance, hence must > > be singular. Or is this about his vs. her? If so I find "their" quite > > confusing, and if so, at l

Re: [systemd-devel] [systemd-commits] man/pam_systemd.xml

2014-10-23 Thread Alex Gaynor
Lennart Poettering poettering.net> writes: > > hmm, why "their"? THat's wrong. It's the user's instance, hence must > be singular. Or is this about his vs. her? If so I find "their" quite > confusing, and if so, at least "his/her" would be better. > Hi Lennart, In English it's perfectly valid

Re: [systemd-devel] Regression in v209: SIGKILL sent immediately after SIGTERM

2014-10-23 Thread Lennart Poettering
On Fri, 12.09.14 11:57, Stef Walter (st...@redhat.com) wrote: > This commit breaks cockpit orderly shutdown: > > > commit 743970d2ea6d08aa7c7bff8220f6b7702f2b1db7 > > Author: Lennart Poettering > > Date: Fri Feb 7 16:12:09 2014 +0100 > > > > core: one step back again, for nspawn we actuall

Re: [systemd-devel] Race condition on systemd-run --scope

2014-10-23 Thread Lennart Poettering
On Mon, 29.09.14 15:34, Umut Tezduyar Lindskog (u...@tezduyar.com) wrote: > Hi, > > I have stumbled on a race condition on systemd-run --scope command. > Due to race condition, unit might show up as active/running even > though there is no process in the cgroup. Umut! At the hackfest in Düsseld

Re: [systemd-devel] [PATCH] shutdown: pass own argv to /run/initramfs/shutdown

2014-10-23 Thread Lennart Poettering
On Tue, 30.09.14 17:02, Marius Tessmann (mus@gmail.com) wrote: > On 09/30/2014 05:03 AM, Zbigniew Jędrzejewski-Szmek wrote: > >On Fri, Aug 29, 2014 at 05:51:45PM +0200, Marius Tessmann wrote: > >>Since commit b1e90ec515408aec2702522f6f68c4920b56375b systemd passes > >>its log settings to syste

Re: [systemd-devel] [PATCH, v3 3/3] find_symlinks: adds a cache of enabled unit symbolic link state

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 09:24, David Timothy Strauss (da...@davidstrauss.net) wrote: > On Thu, Oct 23, 2014 at 5:15 AM, Lennart Poettering > wrote: > > With your patch you generate a system-wide cache for that, but when do > > you flush it precisely? What's the logic there? > > It updates on daemon-rel

Re: [systemd-devel] [systemd-commits] man/pam_systemd.xml

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 10:19, Daniel Mack (zon...@kemper.freedesktop.org) wrote: > On logout, this module ensures the following: > > > -If this is enabled, all > -processes of the session are terminated. If > -

Re: [systemd-devel] [PATCH v4] socket: introduce SELinuxContextFromNet option

2014-10-23 Thread Lennart Poettering
On Wed, 03.09.14 19:39, Lennart Poettering (lenn...@poettering.net) wrote: Michal, I reworked some parts of your patch a bit in current git, as retrieving a label is something that cannot be made a NOP on non-selinux-enabled systems. It either must fail with an error, or return something useful,

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Ronny Chevalier
2014-10-23 21:24 GMT+02:00 Łukasz Stelmach : > --- > src/timesync/timesync-wait.c | 43 +++ > 1 file changed, 43 insertions(+) > create mode 100644 src/timesync/timesync-wait.c > > I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much here. You can > watch

Re: [systemd-devel] [PATCH 2/2] mac: rename apis with mac_{selinux/smack}_ prefix

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 17:23, WaLyong Cho (walyong@gmail.com) wrote: Heya! I merged both patches now! Thanks! After merging I reworked quite a bit more code to make the selinux and smack bits work more similar to each. I cannot test this though, as I don't run SMACK. I really hope I didn't break a

Re: [systemd-devel] Journal, rotation and loglevels

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 17:19, D.S. Ljungmark (spi...@aanstoot.se) wrote: > > > On 23/10/14 16:50, Lennart Poettering wrote: > > On Thu, 23.10.14 15:27, D.S. Ljungmark (spi...@aanstoot.se) wrote: > > > >> Hi, > >> we have a few services that are spamming a fair bit on DEBUG level of > >> log output.

Re: [systemd-devel] Stop Job for User Manager

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 11:38, Chris Bell (cwb...@mail.usf.edu) wrote: > It looks like Fedora recently implemented changes in the user@.service > unit file to address this issue. They use: > > ExecStop=/bin/kill -TERM ${MAINPID} > KillSignal=SIGCONT Not sure I grok this? Colin? > as opposed to KillMod

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 21:24, Łukasz Stelmach (stl...@poczta.fm) wrote: > +int main(int argc, char *argv[]) { > +struct timex tbuf; > +int r; > + > +memset(&tbuf, 0, sizeof(tbuf)); Please initialize this with "= {}" while declaring, instead of using memset() here. > +r

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Tom Gundersen
On Thu, Oct 23, 2014 at 9:24 PM, Łukasz Stelmach wrote: > --- > src/timesync/timesync-wait.c | 43 +++ > 1 file changed, 43 insertions(+) > create mode 100644 src/timesync/timesync-wait.c > > I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much here. You

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 09:24:06PM +0200, Łukasz Stelmach wrote: > --- > src/timesync/timesync-wait.c | 43 +++ > 1 file changed, 43 insertions(+) > create mode 100644 src/timesync/timesync-wait.c > > I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much h

[systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Łukasz Stelmach
--- src/timesync/timesync-wait.c | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 src/timesync/timesync-wait.c I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much here. You can watch for time changes but it is not the moment adjtimex() start

Re: [systemd-devel] So how am I supposed to put together my Linux system?

2014-10-23 Thread Tobias Hunger
On Thu, Oct 23, 2014 at 12:51 AM, Lennart Poettering wrote: > Correct. I can see that for some uses this might appear as overkill, > but in general I would not make much of a distinction between the > kernel and the basic userspace here, they really belong together. > >> I am following Arch and

Re: [systemd-devel] [Featur Request] Allow list of names in file.network

2014-10-23 Thread Tom Gundersen
On Thu, Oct 2, 2014 at 12:40 PM, Lennart Poettering wrote: > On Thu, 25.09.14 19:39, Damien Robert (damien.olivier.robert+gm...@gmail.com) > wrote: > >> This is a minor feature request for systemd-networkd: >> my files in /etc/systemd/network/ all share the same pattern: >> >> [Match] >> Name=en*

Re: [systemd-devel] assert() when restarting systemd-networkd

2014-10-23 Thread Tom Gundersen
On Tue, Aug 12, 2014 at 11:19 AM, Michael Olbrich wrote: > On Wed, Jul 30, 2014 at 06:09:44PM +0200, Tom Gundersen wrote: >> On Sun, Jul 20, 2014 at 3:12 PM, Michael Olbrich >> wrote: >> > with the current git master (v215-293-g4e6029435111) restarting >> > systemd-networkd triggers an assert() h

Re: [systemd-devel] [networkd] intermittent failure to get DHCP lease on a bond interface

2014-10-23 Thread Tom Gundersen
On Tue, Aug 5, 2014 at 5:24 PM, Leonid Isaev wrote: > Hi, > > Ever since updating to kernel 3.16, systemd-networkd very often fails > to get a DHCPv4 lease on a bond interface. This happens irregularly which > makes > me suspect some kind of a race. The bond enslaves eth and wlan cards. H

[systemd-devel] [PATCH v2] journalctl: Unify boot id lookup into common function get_boots

2014-10-23 Thread Jan Janssen
--- Changes in v2: - Properly initialize count to zero src/journal/journalctl.c | 134 +-- 1 file changed, 59 insertions(+), 75 deletions(-) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index dfde0a9..7ce5ff6 100644 --- a/src/journ

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-23 Thread Reindl Harald
Am 23.10.2014 um 19:14 schrieb Tomasz Torcz: On Thu, Oct 23, 2014 at 05:00:04PM +, dennis.mur...@wipro.com wrote: One thing I would like to point out, on the project website there is NO mailing list for advocacy. The comment "this is for technical email only use a different ML" is for all

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-23 Thread Tomasz Torcz
On Thu, Oct 23, 2014 at 05:00:04PM +, dennis.mur...@wipro.com wrote: > One thing I would like to point out, on the project website there is NO > mailing list for advocacy. The comment "this is for technical email only use > a > different ML" is for all purposes just a brush off. If the proj

Re: [systemd-devel] [215] bridge with static network does not work

2014-10-23 Thread Tom Gundersen
Hi Gerardo, Sorry to dig up this old thread. Are you incidentally able to reproduce this with current systemd/kernel? I am not able to on this end. FWIW, what I do is create bridge0 with networkd and set up a DHCP server on it, and start two containers with --network-bridge=bridge0. These contain

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-23 Thread dennis.murata
One thing I would like to point out, on the project website there is NO mailing list for advocacy. The comment "this is for technical email only use a different ML" is for all purposes just a brush off. If the project would create an advocacy mailing list it would go a long way toward segrega

Re: [systemd-devel] [PATCH, v3 3/3] find_symlinks: adds a cache of enabled unit symbolic link state

2014-10-23 Thread David Timothy Strauss
On Thu, Oct 23, 2014 at 5:15 AM, Lennart Poettering wrote: > With your patch you generate a system-wide cache for that, but when do > you flush it precisely? What's the logic there? It updates on daemon-reload or daemon-reexec, consistent with how we load modified unit files. "systemctl enable/di

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Damien Robert
From Zbigniew Jędrzejewski-Szmek, Thu 23 Oct 2014 at 17:26:57 (+0200) : > > order it after basic.target (which things are by default anyway)... > > My proposal now, (which is the same Damien's as I understood him): > > > > 1. pam_systemd should sync on default.target > > 2. by default default.targ

Re: [systemd-devel] Stop Job for User Manager

2014-10-23 Thread Colin Guthrie
Chris Bell wrote on 23/10/14 16:38: > It looks like Fedora recently implemented changes in the user@.service > unit file to address this issue. They use: > > ExecStop=/bin/kill -TERM ${MAINPID} > KillSignal=SIGCONT > > as opposed to KillMode=mixed. FWIW, I think KillMode=mixed is the preferred o

Re: [systemd-devel] Unicode support in console after boot

2014-10-23 Thread Ray Strode
Hi, On Tue, Oct 21, 2014 at 1:39 PM, Ivan Shapovalov wrote: >> > > Please try editing >> > > /usr/lib/systemd/system/systemd-vconsole-setup.service and >> > > remove RemainAfterExit=yes, then regenerate your initramfs image by >> > > running >> > > dracut command. Add back RemainAfterExit=yes t

Re: [systemd-devel] Stop Job for User Manager

2014-10-23 Thread Reindl Harald
Am 23.10.2014 um 17:38 schrieb Chris Bell: It looks like Fedora recently implemented changes in the user@.service unit file to address this issue. They use: ExecStop=/bin/kill -TERM ${MAINPID} KillSignal=SIGCONT fine, but it don't help really i have exactly that setting on F20 and some machin

Re: [systemd-devel] Stop Job for User Manager

2014-10-23 Thread Chris Bell
It looks like Fedora recently implemented changes in the user@.service unit file to address this issue. They use: ExecStop=/bin/kill -TERM ${MAINPID} KillSignal=SIGCONT as opposed to KillMode=mixed. I think this is why I haven't been able to reproduce this on my Fedora 20 box recently. The discus

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 04:59:45PM +0200, Lennart Poettering wrote: > On Thu, 23.10.14 17:52, Mantas Mikulėnas (graw...@gmail.com) wrote: > > > On Oct 23, 2014 5:48 PM, "Lennart Poettering" > > wrote: > > > > > > On Thu, 23.10.14 16:06, Damien Robert (damien.olivier.rob...@gmail.com) > > wrote: >

Re: [systemd-devel] Journal, rotation and loglevels

2014-10-23 Thread D.S. Ljungmark
On 23/10/14 16:50, Lennart Poettering wrote: > On Thu, 23.10.14 15:27, D.S. Ljungmark (spi...@aanstoot.se) wrote: > >> Hi, >> we have a few services that are spamming a fair bit on DEBUG level of >> log output. In syslog, we'd separate the DEBUG logs from the main log, >> and set the rotation

Re: [systemd-devel] Systemd-networkd -- Cannot acquire DHCP lease on bridge interface

2014-10-23 Thread Marcel Holtmann
Hi Lennart, >> Trying unicast, waiting some time and then trying broadcast, if a DHCP >> offer >> is not sent within that time limit, seems like a fair thing to do. My 2 >> cents. > > Yeah, it seems this is what we should do. I guess it makes sense to > make RequestBr

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 17:52, Mantas Mikulėnas (graw...@gmail.com) wrote: > On Oct 23, 2014 5:48 PM, "Lennart Poettering" > wrote: > > > > On Thu, 23.10.14 16:06, Damien Robert (damien.olivier.rob...@gmail.com) > wrote: > > > > > >From Lennart Poettering, Thu 23 Oct 2014 at 14:01:22 (+0200) : > > > > O

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Mantas Mikulėnas
On Oct 23, 2014 5:48 PM, "Lennart Poettering" wrote: > > On Thu, 23.10.14 16:06, Damien Robert (damien.olivier.rob...@gmail.com) wrote: > > > >From Lennart Poettering, Thu 23 Oct 2014 at 14:01:22 (+0200) : > > > Oh indeed, there is not sysinit.target. It sounded so wron in a user > > > context...

Re: [systemd-devel] Journal, rotation and loglevels

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 15:27, D.S. Ljungmark (spi...@aanstoot.se) wrote: > Hi, > we have a few services that are spamming a fair bit on DEBUG level of > log output. In syslog, we'd separate the DEBUG logs from the main log, > and set the rotation of DEBUG+ to be ~24 hours, while keeping INFO and > abo

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 16:06, Damien Robert (damien.olivier.rob...@gmail.com) wrote: > >From Lennart Poettering, Thu 23 Oct 2014 at 14:01:22 (+0200) : > > Oh indeed, there is not sysinit.target. It sounded so wron in a user > > context... I figure if people want to stick something in there they > > can

Re: [systemd-devel] [PATCH 2/2] localectl: verify layout, model, variant and options

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 16:22, Jan Synacek (jsyna...@redhat.com) wrote: > > Hmm, why is this a bitfield? Do I get this patch right and you are > > trying to match the passed arguments to all > > models/layouts/variants/options all the time? This means if a layout > > happens to have the same name as a mo

Re: [systemd-devel] [PATCH] core: improve error message when machine id is missing

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 16:24, Jan Synacek (jsyna...@redhat.com) wrote: > Jan Synacek writes: > > > --- > > src/core/machine-id-setup.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/src/core/machine-id-setup.c b/src/core/machine-id-setup.c > > index efb074f..eba35

Re: [systemd-devel] [PATCH] swap: rework discard

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 14:58, Jan Synacek (jsyna...@redhat.com) wrote: > -static int property_get_discard( > +static int property_get_options( > sd_bus *bus, > const char *path, > const char *interface, > @@ -72,9 +72,9 @@ static int property_get_discar

Re: [systemd-devel] [PATCH] core: improve error message when machine id is missing

2014-10-23 Thread Jan Synacek
Jan Synacek writes: > --- > src/core/machine-id-setup.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/core/machine-id-setup.c b/src/core/machine-id-setup.c > index efb074f..eba35be 100644 > --- a/src/core/machine-id-setup.c > +++ b/src/core/machine-id-setup.c

Re: [systemd-devel] [PATCH 2/2] localectl: verify layout, model, variant and options

2014-10-23 Thread Jan Synacek
Lennart Poettering writes: > On Mon, 20.10.14 12:43, Jan Synacek (jsyna...@redhat.com) wrote: > >> When setting any of those using set-x11-keymap, check that their values >> are available on the system. >> --- >> src/locale/localectl.c | 208 >> +

Re: [systemd-devel] Systemd-networkd -- Cannot acquire DHCP lease on bridge interface

2014-10-23 Thread Marcel Holtmann
Hi Tom, Trying unicast, waiting some time and then trying broadcast, if a DHCP offer is not sent within that time limit, seems like a fair thing to do. My 2 cents. >>> >>> Yeah, it seems this is what we should do. I guess it makes sense to >>> make RequestBroadcast=yes|no|aut

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Damien Robert
>From Lennart Poettering, Thu 23 Oct 2014 at 14:01:22 (+0200) : > Oh indeed, there is not sysinit.target. It sounded so wron in a user > context... I figure if people want to stick something in there they > can just as well use basic.target here... > > > But I was arguing that basic.target has a w

[systemd-devel] Journal, rotation and loglevels

2014-10-23 Thread D.S. Ljungmark
Hi, we have a few services that are spamming a fair bit on DEBUG level of log output. In syslog, we'd separate the DEBUG logs from the main log, and set the rotation of DEBUG+ to be ~24 hours, while keeping INFO and above for ~4 weeks. How can we do something similar with Journald? Keeping all

[systemd-devel] [PATCH] swap: rework discard

2014-10-23 Thread Jan Synacek
Instead of a dedicated Discard option, use more general Options. When the swapon command learns "-o", it will be possible to pass the value of Options as is. The code now assumes that the only possible value to Options is related to discard. http://lists.freedesktop.org/archives/systemd-devel/2014

Re: [systemd-devel] Fwd: [PATCH v3] tests: added tests for unit_file_get_{state, list}

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 02:22:01PM +0200, Lennart Poettering wrote: > On Fri, 17.10.14 14:02, Martin Pitt (martin.p...@ubuntu.com) wrote: > > > > diff --git a/Makefile.am b/Makefile.am > > > index e52db17..7d4f2f5 100644 > > > --- a/Makefile.am > > > +++ b/Makefile.am > > > @@ -1358,7 +1358,8 @@ t

Re: [systemd-devel] Fwd: [PATCH v3] tests: added tests for unit_file_get_{state, list}

2014-10-23 Thread Lennart Poettering
On Fri, 17.10.14 14:02, Martin Pitt (martin.p...@ubuntu.com) wrote: > > diff --git a/Makefile.am b/Makefile.am > > index e52db17..7d4f2f5 100644 > > --- a/Makefile.am > > +++ b/Makefile.am > > @@ -1358,7 +1358,8 @@ tests += \ > > test-ratelimit \ > > test-condition-util \ > >

Re: [systemd-devel] transforming Iptables bash script to systemd service file -help

2014-10-23 Thread Dave Reisner
On Wed, Oct 22, 2014 at 12:37:36PM +0100, Simon McVittie wrote: > On 21/10/14 20:30, Lennart Poettering wrote: > > But in cases like the iptables tool (which > > is written in a style that kinda requires the usage of shell scripts > > to invoke it, since it is more a programming language and is sel

Re: [systemd-devel] Systemd-networkd -- Cannot acquire DHCP lease on bridge interface

2014-10-23 Thread Tom Gundersen
On Thu, Oct 23, 2014 at 1:55 PM, Lennart Poettering wrote: > On Thu, 23.10.14 13:24, Tom Gundersen (t...@jklm.no) wrote: > >> > Trying unicast, waiting some time and then trying broadcast, if a DHCP >> > offer >> > is not sent within that time limit, seems like a fair thing to do. My 2 >> > cents

Re: [systemd-devel] Systemd-networkd -- Cannot acquire DHCP lease on bridge interface

2014-10-23 Thread Camilo Aguilar
Yes, also one would like to avoid broadcasting as much as possible. On Thursday, October 23, 2014, Lennart Poettering wrote: > On Thu, 23.10.14 13:24, Tom Gundersen (t...@jklm.no ) wrote: > > > > Trying unicast, waiting some time and then trying broadcast, if a DHCP > offer > > > is not sent wit

Re: [systemd-devel] [PATCH, v3 3/3] find_symlinks: adds a cache of enabled unit symbolic link state

2014-10-23 Thread Lennart Poettering
On Tue, 21.10.14 15:21, Ken Sedgwick (ksedg...@bonsai.com) wrote: > The current find_symlinks_fd code traverses the config directories > duplicatively. This is a performance problem if 1000s of units are > being controlled. This patch adds a hashmap cache of symbolic link > state which is filled i

Re: [systemd-devel] systemd build dependency on dbus

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 12:44, Simon McVittie (simon.mcvit...@collabora.co.uk) wrote: > On 23/10/14 12:21, Lennart Poettering wrote: > > The behaviour should really be to: > > > > 1. take the paths from configure switches > > 2. if they are not specified, try to get them from pkg-config > > 3. if the re

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 13:47, Damien Robert (damien.olivier.rob...@gmail.com) wrote: > >From Lennart Poettering, Thu 23 Oct 2014 at 11:49:27 (+0200) : > > On Thu, 23.10.14 08:09, Damien Robert > > (damien.olivier.robert+gm...@gmail.com) wrote: > > > But isn't using default.target more flexible than bas

Re: [systemd-devel] [Tracker] How to use cgroups for Tracker?

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 13:31, Philip Van Hoof (phi...@codeminded.be) wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 23/10/2014 13:01, Lennart Poettering wrote: > > On Thu, 23.10.14 11:40, Martyn Russell (mar...@lanedo.com) wrote: > > [cut] > > >> I know it's a hard problem to solve,

Re: [systemd-devel] Systemd-networkd -- Cannot acquire DHCP lease on bridge interface

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 13:24, Tom Gundersen (t...@jklm.no) wrote: > > Trying unicast, waiting some time and then trying broadcast, if a DHCP offer > > is not sent within that time limit, seems like a fair thing to do. My 2 > > cents. > > Yeah, it seems this is what we should do. I guess it makes sense

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Damien Robert
>From Lennart Poettering, Thu 23 Oct 2014 at 11:49:27 (+0200) : > On Thu, 23.10.14 08:09, Damien Robert (damien.olivier.robert+gm...@gmail.com) > wrote: > > But isn't using default.target more flexible than basic.target? When > > basic.target is activated I expect at least socket.target, timers.ta

Re: [systemd-devel] systemd build dependency on dbus

2014-10-23 Thread Simon McVittie
On 23/10/14 12:21, Lennart Poettering wrote: > The behaviour should really be to: > > 1. take the paths from configure switches > 2. if they are not specified, try to get them from pkg-config > 3. if the relevant pkg-config files are not installed, generate an error and > refuse build Actually..

Re: [systemd-devel] [Tracker] How to use cgroups for Tracker?

2014-10-23 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 23/10/2014 13:01, Lennart Poettering wrote: > On Thu, 23.10.14 11:40, Martyn Russell (mar...@lanedo.com) wrote: [cut] >> I know it's a hard problem to solve, but if it's not solved with >> the proposed solutions, the kernel developers shouldn't re

Re: [systemd-devel] Systemd-networkd -- Cannot acquire DHCP lease on bridge interface

2014-10-23 Thread Tom Gundersen
On Thu, Oct 23, 2014 at 11:04 AM, Camilo Aguilar wrote: > > > On Wednesday, October 22, 2014, Lennart Poettering > wrote: >> >> On Wed, 22.10.14 20:49, Tom Gundersen (t...@jklm.no) wrote: >> >> > On Wed, Oct 22, 2014 at 6:23 PM, Lennart Poettering >> > wrote: >> > > On Wed, 22.10.14 18:16, Tom G

Re: [systemd-devel] systemd build dependency on dbus

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 07:06, Filipe Brandenburger (filbran...@google.com) wrote: > Hi Lennart, > > On Wed, Oct 22, 2014 at 2:07 PM, Lennart Poettering > wrote: > > On Mon, 25.08.14 21:58, Filipe Brandenburger (filbran...@google.com) wrote: > >> Indeed it would be good to clarify that libdbus is not r

Re: [systemd-devel] [PATCH, v3 2/3] tests: unit_file_get_list performance with many units

2014-10-23 Thread Lennart Poettering
On Tue, 21.10.14 15:21, Ken Sedgwick (ksedg...@bonsai.com) wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "manager.h" > +#include "macro.h" > +#include "util.h" > + > +static const int NUNITS = 3000; Tss, this is not C++. ;-) Jus

Re: [systemd-devel] [Tracker] How to use cgroups for Tracker?

2014-10-23 Thread Martyn Russell
On 23/10/14 12:01, Lennart Poettering wrote: On Thu, 23.10.14 11:40, Martyn Russell (mar...@lanedo.com) wrote: I don't really understand why it was developed as a half complete solution if I am honest. It's not as if there are no examples to follow out there (FSEvents) and it's not as if we didn

Re: [systemd-devel] [PATCH, v3 1/3] tests: added tests for unit_file_get_{state, list}

2014-10-23 Thread Lennart Poettering
On Tue, 21.10.14 15:21, Ken Sedgwick (ksedg...@bonsai.com) wrote: > This test constructs different unit file states and checks the output > of unit_file_get_state and unit_file_get_list for each. > > This test characterizes the current output of the master branch in > preparation for a patch whic

Re: [systemd-devel] [PATCH, REVIEW] Added unit enabled-context cache to improve performance w/ many units.

2014-10-23 Thread Lennart Poettering
On Tue, 07.10.14 23:08, Ken Sedgwick (ksedg...@bonsai.com) wrote: > Resubmitting using git format-patch, git imap-send ... no code > changes. Patch is line-broken! If nothing else works, simply attach the git-formatted patch. It's really hard following the patch with all those broken lines! Len

Re: [systemd-devel] [Tracker] How to use cgroups for Tracker?

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 11:40, Martyn Russell (mar...@lanedo.com) wrote: > >>Anyway, please remember that being privileged isn't the only reason > >>why Tracker can't use fanotify. It's API being fd-based, it works on > >>existing open files only; e.g. it won't notify file deletes or move > >>events, amo

Re: [systemd-devel] [Tracker] How to use cgroups for Tracker?

2014-10-23 Thread Martyn Russell
On 23/10/14 10:34, Lennart Poettering wrote: On Thu, 23.10.14 08:15, Aleksander Morgado (aleksan...@aleksander.es) wrote: That's a good one indeed; coalescing events in that way in the kernel looks quite a sane approach. Still, one single process in userspace doing all the control of what chang

Re: [systemd-devel] [RFC] tmpfiles.d with mac_label

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 11:03, Maciej Wereski (m.were...@partner.samsung.com) wrote: > 3.10.2014 at 10:34 WaLyong Cho wrote: > > >As we know we can make a direcory or link or file or some others by > >using tmpfiles.d. But we can not apply mac_label on there when after > >that is genreated. > > Last y

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 08:09, Damien Robert (damien.olivier.robert+gm...@gmail.com) wrote: > Zbigniew Jędrzejewski-Szmek wrote in message > <20141019135812.gu29...@in.waw.pl>: > >> > PAM creates sessions by calling into systemd's pam-module, which then > >> > uses CreateSession() (internal api!). This

Re: [systemd-devel] transforming Iptables bash script to systemd service file -help

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 09:17, Alexandre Detiste (alexandre.deti...@gmail.com) wrote: > >2014-10-22 13:37 GMT+02:00 Simon McVittie : > > all it would need is for systemd to support StandardInput=/a/file/path > > That feature would be nice. > I have a direct use for this. > Doing '/bin/echo -e line1\\nli

Re: [systemd-devel] [PATCH 3/3] run: introduce timer support option

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 15:25, WaLyong Cho (walyong@gmail.com) wrote: > On 10/23/2014 12:56 AM, Lennart Poettering wrote: > >On Tue, 07.10.14 14:20, WaLyong Cho (walyong@samsung.com) wrote: > > > >>If systemd-run is called with timer option, then systemd-run call > >>NewTransientUnit with service

Re: [systemd-devel] Failure to umount /var at shutdown

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 11:27, Daniele Nicolodi (dani...@grinta.net) wrote: > Hello, > > I have a Debian sid system where there is a problem with the unmonting > of the /var filesystem that causes a delay in the shutdown process: > > > ott 21 10:08:46 nautilus virtualbox[28559]: Stopping VirtualBox ker

Re: [systemd-devel] [Tracker] How to use cgroups for Tracker?

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 08:15, Aleksander Morgado (aleksan...@aleksander.es) wrote: > That's a good one indeed; coalescing events in that way in the kernel > looks quite a sane approach. Still, one single process in userspace > doing all the control of what changed when (like FSEvents does) may > actuall

[systemd-devel] Failure to umount /var at shutdown

2014-10-23 Thread Daniele Nicolodi
Hello, I have a Debian sid system where there is a problem with the unmonting of the /var filesystem that causes a delay in the shutdown process: > ott 21 10:08:46 nautilus virtualbox[28559]: Stopping VirtualBox kernel > modules. > ott 21 10:08:46 nautilus systemd[2086]: Received SIGRTMIN+24 fro

Re: [systemd-devel] Systemd-networkd -- Cannot acquire DHCP lease on bridge interface

2014-10-23 Thread Camilo Aguilar
On Wednesday, October 22, 2014, Lennart Poettering wrote: > On Wed, 22.10.14 20:49, Tom Gundersen (t...@jklm.no ) wrote: > > > On Wed, Oct 22, 2014 at 6:23 PM, Lennart Poettering > > > wrote: > > > On Wed, 22.10.14 18:16, Tom Gundersen (t...@jklm.no ) > wrote: > > > > > >> Hi guys, > > >> > > >>

Re: [systemd-devel] [RFC] tmpfiles.d with mac_label

2014-10-23 Thread Maciej Wereski
3.10.2014 at 10:34 WaLyong Cho wrote: As we know we can make a direcory or link or file or some others by using tmpfiles.d. But we can not apply mac_label on there when after that is genreated. Last year I've proposed patch, that was adding xattr option to tmpfiles (which can be used for SMAC

Re: [systemd-devel] [RFC] tmpfiles.d with mac_label

2014-10-23 Thread WaLyong Cho
On 10/23/2014 05:34 PM, WaLyong Cho wrote: > As we know we can make a direcory or link or file or some others by > using tmpfiles.d. But we can not apply mac_label on there when after > that is genreated. > > How about add mac_label field on tmpfiles.d? Actually, now we can not > assign a mac_labe

[systemd-devel] [RFC] tmpfiles.d with mac_label

2014-10-23 Thread WaLyong Cho
As we know we can make a direcory or link or file or some others by using tmpfiles.d. But we can not apply mac_label on there when after that is genreated. How about add mac_label field on tmpfiles.d? Actually, now we can not assign a mac_label to newly generated directory. So we make a script whi

[systemd-devel] [PATCH 2/2] mac: rename apis with mac_{selinux/smack}_ prefix

2014-10-23 Thread WaLyong Cho
From: WaLyong Cho --- src/core/execute.c| 2 +- src/core/main.c | 4 ++-- src/core/namespace.c | 4 ++-- src/core/selinux-setup.c | 4 ++-- src/core/socket.c | 26 +- src/hostname/hostnamed.c | 2 +- src/locale

[systemd-devel] [PATCH 1/2] label: rearrange mandatory access control(MAC) apis

2014-10-23 Thread WaLyong Cho
From: WaLyong Cho move label apis to selinux-util.ch or smack-util.ch appropriately. --- src/shared/label.c| 554 -- src/shared/label.h| 31 +-- src/shared/mkdir-label.c | 26 +++ src/shared/mkdir.h| 2 +- src/shared/selinu

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Damien Robert
Zbigniew Jędrzejewski-Szmek wrote in message <20141019135812.gu29...@in.waw.pl>: >> > PAM creates sessions by calling into systemd's pam-module, which then >> > uses CreateSession() (internal api!). This call does not return until >> > the job of user@.service is done. `systemd --user` notifies RE

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Damien Robert
From Mantas Mikulėnas, Thu 23 Oct 2014 at 07:06:18 (+0300) : > Wasn't this already fixed in polkit.git recently? Yes indeed: commit a68f5dfd7662767b7b9822090b70bc5bd145c50c sessionmonitor-systemd: prepare for D-Bus "user bus" model In the D-Bus "user bus" model, all sessions of a user share the

Re: [systemd-devel] [Tracker] How to use cgroups for Tracker?

2014-10-23 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 23/10/2014 8:15, Aleksander Morgado wrote: > On Thu, Oct 23, 2014 at 1:24 AM, Philip Van Hoof > wrote: [cut] >>> This is fixable, by enforcing a size limit on the queue. As >>> the limit is hit the algorithm should coalesce queued events >>> base

Re: [systemd-devel] [PATCH 3/3] udev: do NOT re-label smack

2014-10-23 Thread WaLyong Cho
On 10/23/2014 06:13 AM, Lennart Poettering wrote: > On Thu, 16.10.14 16:59, WaLyong Cho (walyong@samsung.com) wrote: > >> If selinux is disabled and smack is only enabled, smack label is >> relable-ed by label_fix. To avoid, make only be labeled for selinux. >> --- >> src/udev/udev-node.c | 4

Re: [systemd-devel] transforming Iptables bash script to systemd service file -help

2014-10-23 Thread Jóhann B. Guðmundsson
On 10/23/2014 07:17 AM, Alexandre Detiste wrote: 2014-10-22 13:37 GMT+02:00 Simon McVittie: >all it would need is for systemd to support StandardInput=/a/file/path That feature would be nice. I have a direct use for this. Doing '/bin/echo -e line1\\nline2\\nline3 | command' is ugly. Not reall

Re: [systemd-devel] [PATCH 2/3] mac: rename apis with mac_{selinux/smack}_ prefix

2014-10-23 Thread WaLyong Cho
On 10/23/2014 06:12 AM, Lennart Poettering wrote: > On Thu, 16.10.14 16:59, WaLyong Cho (walyong@samsung.com) wrote: > >> -if (smack_label_ip_in_fd(fd, s->smack_ip_in) < 0) >> -log_error_unit(UNIT(s)->id, "smack_label_ip_in_fd: >> %m"); >> +

Re: [systemd-devel] transforming Iptables bash script to systemd service file -help

2014-10-23 Thread Alexandre Detiste
>2014-10-22 13:37 GMT+02:00 Simon McVittie : > all it would need is for systemd to support StandardInput=/a/file/path That feature would be nice. I have a direct use for this. Doing '/bin/echo -e line1\\nline2\\nline3 | command' is ugly. https://github.com/systemd-cron/systemd-cron/blob/master/sr

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Ivan Shapovalov
On Thursday 23 October 2014 at 07:06:18, Mantas Mikulėnas wrote: > On Oct 23, 2014 1:54 AM, "Lennart Poettering" > wrote: > > > > On Wed, 22.10.14 12:44, Damien Robert ( > damien.olivier.robert+gm...@gmail.com) wrote: > > > > [...] > > > > policykit really should get fixed there. it should