> Gesendet: Mittwoch, 08. Oktober 2014 um 01:40 Uhr
> Von: "Zbigniew Jędrzejewski-Szmek"
> An: "Jan Janssen"
> Cc: systemd-devel@lists.freedesktop.org
> Betreff: Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique
> skipping values
>
> On Mon, Oct 06, 2014 at 06:57:38PM +0200,
Resubmitting using git format-patch, git imap-send ... no code changes.
---
.gitignore | 1 +
Makefile.am| 44 +++-
src/core/dbus-manager.c| 4 +-
src/core/manager.c
---
man/systemctl.xml | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/man/systemctl.xml b/man/systemctl.xml
index b28a3b7..d2fa3b3 100644
--- a/man/systemctl.xml
+++ b/man/systemctl.xml
@@ -924,6 +924,9 @@ kobject-uevent 1 systemd-udevd-kernel.socket
systemd-udevd.servi
Combined initial submission and subsequent fixes into a single patch.
Ken Sedgwick (1):
Added test for unit file state returned by unit_file_get_state and
unit_file_get_list. Made test-enabled units more basic, removing
superfluous fields. Cleaned up test path assignment code.
---
.gitignore | 1 +
Makefile.am| 44 ++-
src/test/test-enabled.c| 141 +
.../etc/systemd/system/masked.service | 1 +
.../etc/systemd/system/maske
---
man/os-release.xml | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/man/os-release.xml b/man/os-release.xml
index 4e02f80..b298304 100644
--- a/man/os-release.xml
+++ b/man/os-release.xml
@@ -90,11 +90,15 @@
files at the same
ti
Does anyone have any feedback on this thread? If it's not possible for a
container to create its own /dev/net/tun device (or use the host system's),
I'll just move on to finding a less preferable solution.
> On Oct 3, 2014, at 10:46 AM, James Lott wrote:
>
> Hello, list!
>
> In some work I
On Mon, Oct 06, 2014 at 06:57:38PM +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Mon, Oct 06, 2014 at 06:36:34PM +0200, Jan Janssen wrote:
> > *bump*
> Sorry, I'll look into this.
Doesn't work. Both without or with your other patch
sd_journal_enumerate_unique I get bogus results on my test case.
On Tue, Oct 07, 2014 at 05:46:48PM +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Tue, Oct 07, 2014 at 02:09:37PM +0200, Lukas Nykryn wrote:
> > ---
> > Changes in v4
> > - renamed install_dependency -> dependency
> > - removed the enum with dependencies and used the general one instead
> This part
On Tue, Oct 07, 2014 at 01:35:41PM +0200, Jan Synacek wrote:
> ---
> src/shared/install.c | 13 +
> 1 file changed, 13 insertions(+)
Applied.
Making the error messages better is another step that needs to be done.
Zbyszek
___
systemd-devel
On Tue, 2014-10-07 at 14:15 -0400, Rob Owens wrote:
> My question really isn't "why are the Debian dependencies the way they are".
> I understand that. I was trying to highlight the strange situation of a
> desktop application requiring a particular init system. I *think* this is a
> result o
I think the test additions need to be rebased into a single commit
onto master rather than the initial patch plus the fixes as a second
commit.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinf
The attached patch adds an EnabledContext cache so systems with 1000s of
units do not suffer
O(N^2) performance when determining unit state. The test-enabled unit test
(added to master under other patch)
is used to confirm that the returned states are the same as the current
master.
Please review
> From: Simon Peeters
>
> 2014-10-07 19:12 GMT+02:00 Jon Stanley :
> > [Service]
> > ExecStartPre=/something/that/sets/var
> > ExecStart=/some/file $var
>
> ExecStart=/bin/sh -c ". /something/that/sets/var; /some/file $var"
Yeah, I think some thing like this would work:
ExecStartPre=/bin/sh -c
---
src/test/test-enabled.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/test/test-enabled.c b/src/test/test-enabled.c
index 607f68c..104348e 100644
--- a/src/test/test-enabled.c
+++ b/src/test/test-enabled.c
@@ -75,9 +75,6 @@
*/
-const char *subdir = "/test-ena
---
test/test-enabled-root/etc/systemd/system/some.target | 6 +-
test/test-enabled-root/run/systemd/system/other.target | 3 +--
test/test-enabled-root/usr/lib/systemd/system/another.service | 7 ++-
test/test-enabled-root/usr/lib/systemd/system/disabled.serv
---
.gitignore | 1 +
Makefile.am| 44 ++-
src/test/test-enabled.c| 143 +
.../etc/systemd/system/masked.service | 1 +
.../etc/systemd/system/maske
Ken Sedgwick (3):
Added test for unit file state returned by unit_file_get_state and
unit_file_get_list.
Made test-enabled units more basic, removing superfluous fields.
Cleaned up test path assignment code.
___
systemd-devel mailing list
systemd-de
- Original Message -
> From: "Zbigniew Jędrzejewski-Szmek"
> On Mon, Oct 06, 2014 at 02:56:22PM -0400, Rob Owens wrote:
> > On Debian, I came across an unusual dependency. Installing a cd burner
> > (brasero) required me to change my init system to systemd. Sounds kind of
> > ridiculous
2014-10-07 19:12 GMT+02:00 Jon Stanley :
> Since EnvironmentFile in a service isn't sourced by any shell, shell
> expressions in it will obviously not work the way that they did in a
> SysV style script.
>
> Nor does it seems that the environment gets preserved between
> ExecStartPre (where one cou
Since EnvironmentFile in a service isn't sourced by any shell, shell
expressions in it will obviously not work the way that they did in a
SysV style script.
Nor does it seems that the environment gets preserved between
ExecStartPre (where one could run a script that sets environment
variables to b
Hi:
I am debugging a problem where the symlinks in /dev/disk/by-path
disappeared for iSCSI target devices.
It looks like it's from systemd/udev commit
e98bbfd2074e2b1079b7059341eac25741baf319
udev: path_id - suppress ID_PATH for devices with an unknown parent device type
I believe the worry wa
On Tue, Oct 07, 2014 at 08:23:32AM +0200, Jan Synacek wrote:
> While I'm at it, what about disable? Should it behave in the same way,
> i.e. return error when the unit is masked? My guess is that yes, but I'm
> not sure.
I don't see a reason why disabling should be disallowed. I think we even
allow
On Tue, Oct 07, 2014 at 02:09:37PM +0200, Lukas Nykryn wrote:
> ---
> Changes in v4
> - renamed install_dependency -> dependency
> - removed the enum with dependencies and used the general one instead
This part should really be a separate commit. It moves a lot of code
around and makes it harder to
On Mon, Oct 06, 2014 at 05:52:40PM +0200, Lennart Poettering wrote:
> On Sat, 04.10.14 21:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
>
> > Hi,
> >
> > Environment="X='Y' Z"
> > ExecStart=/bin/echo $X ${X}
> >
> > results in echo[31266]: Y Z 'Y' Z
> >
> > i.e., $X not only splits
On Thu, Oct 02, 2014 at 12:04:02PM +0200, Lennart Poettering wrote:
> On Thu, 02.10.14 09:57, Michal Sekletar (msekl...@redhat.com) wrote:
>
> > #define FINALIZE_ATTEMPTS 50
> >
> > @@ -207,7 +208,11 @@ int main(int argc, char *argv[]) {
> >
> > in_container = detect_container(NULL)
On Thu, Oct 02, 2014 at 11:43:22AM +0200, Lennart Poettering wrote:
> On Thu, 02.10.14 09:57, Michal Sekletar (msekl...@redhat.com) wrote:
>
> > In cases when we are running as system manager, but we don't have the
> > capability to mount filesystems don't call mount_setup(). However we
> > assume
---
Changes in v4
- renamed install_dependency -> dependency
- removed the enum with dependencies and used the general one instead
- add an error meesage in the case that --root is used and it fails
- changes in manpage
TODO | 1 -
man/systemctl.xml
Even though the 'emergency' and 'single' aliases come from sysvinit, the
lack of 'rescue' is still quite confusing (caught me by surprise for the
9th time yet) and inconsistent with `systemctl rescue` as well.
---
src/core/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/core/main.c
---
src/shared/install.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/shared/install.c b/src/shared/install.c
index fa064c2..945bb27 100644
--- a/src/shared/install.c
+++ b/src/shared/install.c
@@ -1516,6 +1516,19 @@ int unit_file_enable(
return r;
I'm not sure about the error type and message the user gets, though. It seems
that the only way to do this currently is to return an approximate errno, which
gets translated on the client side and the real message is then found in the
error log.
Changes in v2:
- move the funcionality to a common
On 25/09/14 22:12, Gustavo Sverzut Barbieri wrote:
> move each user/group creation to a file that represents its own split
> package, so it's possible to ship them in separate.
Even if you split out bits of systemd functionality like networkd,
timesyncd, kdbus into separate binary packages, what h
32 matches
Mail list logo
