Re: [systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-27 Thread Jan Janssen
Ivan Shapovalov gmail.com> writes: > > On Wednesday 27 August 2014 at 03:16:10, Zbigniew Jędrzejewski-Szmek wrote: > > On Tue, Aug 26, 2014 at 10:21:59PM +0200, Lennart Poettering wrote: > > > On Wed, 27.08.14 00:17, Ivan Shapovalov (intelfx100 gmail.com) wrote: > > > > This patchset allows

Re: [systemd-devel] Suppressing automounting

2014-08-27 Thread Andrei Borzenkov
В Thu, 28 Aug 2014 00:31:49 +0300 Mantas Mikulėnas пишет: > On Aug 27, 2014 10:03 PM, "Dale R. Worley" wrote: > > > > > From: Thomas Suckow > > > > > > >> From: Lennart Poettering > > > > > > > >> Note that a concept of "mount at boot if it is there, otherwise > don't" > > > >> cannot work. >

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 05:07:10PM -0700, Luis R. Rodriguez wrote: > > Hey, if you have patches already, I'll be glad to look at them :) > > OK well I'll spin what I have then, but I'm reviewing Wu's solution > from February as well. I take it we'd want the async_schedule() > approach rather that

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-27 Thread Luis R. Rodriguez
On Wed, Aug 27, 2014 at 4:44 PM, Greg Kroah-Hartman wrote: > On Wed, Aug 27, 2014 at 03:51:58PM -0700, Luis R. Rodriguez wrote: >> On Mon, Aug 11, 2014 at 10:19 AM, Luis R. Rodriguez wrote: >> > On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering >> > wrote: >> >> On Mon, 11.08.14 18:39, Luis R

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 03:51:58PM -0700, Luis R. Rodriguez wrote: > On Mon, Aug 11, 2014 at 10:19 AM, Luis R. Rodriguez wrote: > > On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering > > wrote: > >> On Mon, 11.08.14 18:39, Luis R. Rodriguez ([email protected]) wrote: > >> > >>> > This looks reall

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-27 Thread Luis R. Rodriguez
On Mon, Aug 11, 2014 at 10:19 AM, Luis R. Rodriguez wrote: > On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering > wrote: >> On Mon, 11.08.14 18:39, Luis R. Rodriguez ([email protected]) wrote: >> >>> > This looks really wrong. We shouldn't permit worker processes to be >>> > blocked indefinitely

Re: [systemd-devel] Suppressing automounting

2014-08-27 Thread Mantas Mikulėnas
On Aug 27, 2014 10:03 PM, "Dale R. Worley" wrote: > > > From: Thomas Suckow > > > > >> From: Lennart Poettering > > > > > >> Note that a concept of "mount at boot if it is there, otherwise don't" > > >> cannot work. > > > > > > It worked until a week or two ago. I want it back. > > > > > > I'm

Re: [systemd-devel] [PATCH 0/2] units: add and use ConditionInitrd= instead of checking for /etc/initrd-release.

2014-08-27 Thread Thomas Bächler
Am 27.08.2014 um 20:25 schrieb Ivan Shapovalov: > On Wednesday 27 August 2014 at 20:19:45, Lennart Poettering wrote: >> On Wed, 27.08.14 20:26, Ivan Shapovalov ([email protected]) wrote: >> >>> This is as proposed by Thomas in review of my hibernate-resume patchset. >>> >>> The objective ben

Re: [systemd-devel] [PATCH] tty-ask-password-agent: reset a signal handler for SIGTERM to the default

2014-08-27 Thread Lennart Poettering
On Wed, 27.08.14 09:47, HATAYAMA, Daisuke ([email protected]) wrote: > >Sounds like the right option here... I have now added a slightly > >different patch (1dedb74a2e1d840b531b76b01a76979f3b57456b) that does > >this. > > > > Thanks! But this could still hang in very rare case becuase the

Re: [systemd-devel] [PATCH 1/2] sd-journal: properly convert object->size on big endian

2014-08-27 Thread Lennart Poettering
On Wed, 27.08.14 00:39, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > mmap code crashes when attempting to map an object of zero size. > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758392 > https://bugs.freedesktop.org/show_bug.cgi?id=82894 > --- > Oops, both my analysis and fi

Re: [systemd-devel] Suppressing automounting

2014-08-27 Thread Dale R. Worley
> From: Thomas Suckow > > >> From: Lennart Poettering > > > >> Note that a concept of "mount at boot if it is there, otherwise don't" > >> cannot work. > > > > It worked until a week or two ago. I want it back. > > > > I'm sure you're right that in the abstract, it cannot be made to > > work.

Re: [systemd-devel] [PATCHv6 2/3] hibernate-resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-27 Thread Lennart Poettering
On Wed, 27.08.14 10:59, Andrei Borzenkov ([email protected]) wrote: > On Wed, Aug 27, 2014 at 10:18 AM, Thomas Bächler wrote: > >> +[Unit] > >> +Description=Resume from hibernation using device %f > >> +Documentation=man:[email protected](8) > >> +DefaultDependencies=no > >> +Bi

Re: [systemd-devel] [PATCHv6 2/3] hibernate-resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-27 Thread Lennart Poettering
On Wed, 27.08.14 08:18, Thomas Bächler ([email protected]) wrote: > > +[Unit] > > +Description=Resume from hibernation using device %f > > +Documentation=man:[email protected](8) > > +DefaultDependencies=no > > +BindsTo=%i.device > > What's the purpose of BindsTo= as opposed to

Re: [systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-27 Thread Lennart Poettering
On Wed, 27.08.14 13:17, Ivan Shapovalov ([email protected]) wrote: > On Wednesday 27 August 2014 at 03:16:10, Zbigniew Jędrzejewski-Szmek wrote: > > On Tue, Aug 26, 2014 at 10:21:59PM +0200, Lennart Poettering wrote: > > > On Wed, 27.08.14 00:17, Ivan Shapovalov ([email protected]) wrote:

Re: [systemd-devel] [RFC] [PATCH 0/3] resume: implement support for resuming from hibernation

2014-08-27 Thread Lennart Poettering
On Wed, 27.08.14 10:19, Umut Tezduyar Lindskog ([email protected]) wrote: > > Hi Ivan, > > Great job! > > I was wondering if a ./configure switch makes sense to disable it. > Embedded devices won't be using it. Sure! I'd be happy to merge a patch that makes this compile-time optional. Lennart

Re: [systemd-devel] [PATCH 2/2 v3] socket: introduce SELinuxContextFromNet option

2014-08-27 Thread Lennart Poettering
On Wed, 27.08.14 04:45, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > +} > > + > > +bcon = context_new(mycon); > > +if (!bcon) > > +goto out; > This will return 0. Should return log_oom() or ENOMEM instead? Please use ENOMEM here, don't use log

Re: [systemd-devel] [PATCH 0/2] units: add and use ConditionInitrd= instead of checking for /etc/initrd-release.

2014-08-27 Thread Ivan Shapovalov
On Wednesday 27 August 2014 at 20:19:45, Lennart Poettering wrote: > On Wed, 27.08.14 20:26, Ivan Shapovalov ([email protected]) wrote: > > > This is as proposed by Thomas in review of my hibernate-resume patchset. > > > > The objective benefit of this change is that in_initrd() function

Re: [systemd-devel] [PATCH 0/2] units: add and use ConditionInitrd= instead of checking for /etc/initrd-release.

2014-08-27 Thread Lennart Poettering
On Wed, 27.08.14 20:26, Ivan Shapovalov ([email protected]) wrote: > This is as proposed by Thomas in review of my hibernate-resume patchset. > > The objective benefit of this change is that in_initrd() function is used > for checking, which not only checks for /etc/initrd-release, but also ve

[systemd-devel] [PATCH] units: remove unnecessary ordering dependencies in [email protected]

2014-08-27 Thread Ivan Shapovalov
They were left from an early review iteration, when hibernate-resume functionality was intended to work also outside of initramfs. Now this is not the case, and these dependencies became redundant as systemd-fsck-root.service can never be part of initramfs, and systemd-remount-fs.service makes litt

[systemd-devel] [PATCH 2/2] units: use ConditionInitrd=true instead of ConditionPathExists=/etc/initrd-release

2014-08-27 Thread Ivan Shapovalov
--- units/initrd-cleanup.service.in| 2 +- units/initrd-fs.target | 2 +- units/initrd-parse-etc.service.in | 2 +- units/initrd-root-fs.target| 2 +- units/initrd-switch-root.service.in| 2 +- units/initrd-switch-root.target

[systemd-devel] [PATCH 0/2] units: add and use ConditionInitrd= instead of checking for /etc/initrd-release.

2014-08-27 Thread Ivan Shapovalov
This is as proposed by Thomas in review of my hibernate-resume patchset. The objective benefit of this change is that in_initrd() function is used for checking, which not only checks for /etc/initrd-release, but also verifies that the rootfs is on a virtual device. Ivan Shapovalov (2): units: a

[systemd-devel] [PATCH 1/2] units: add ConditionInitrd=

2014-08-27 Thread Ivan Shapovalov
--- man/systemd.unit.xml | 13 + src/core/condition.c | 17 + src/core/load-fragment-gperf.gperf.m4 | 1 + src/shared/condition-util.c | 1 + src/shared/condition-util.h | 1 + 5 files changed, 33 insertions(+) d

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-27 Thread Marcel Holtmann
Hi Miroslav, >> ConnMan is a single daemon solution doing NTP, DHCP and DNS all in >> one place. Any sort of callouts are costing time. And that is time >> that has a visible user impact. There is nothing that justifies to >> have a bit more nanosecond accuracy of synchronized time than making >>

Re: [systemd-devel] [PATCH] bootchart: only show printable processes

2014-08-27 Thread WaLyong Cho
On 08/27/2014 03:49 AM, Lennart Poettering wrote: > On Tue, 26.08.14 18:11, Mantas Mikulėnas ([email protected]) wrote: > >> On Tue, Aug 26, 2014 at 5:07 PM, WaLyong Cho wrote: >>> >>> This case really shouldn't be happen. (But actually sometime that was >>> happen.) Eeven if happened we maybe wa

[systemd-devel] [PATCH 2/8] timesyncd: fix calculation of transmit time

2014-08-27 Thread Miroslav Lichvar
The kernel timestamp (recv_time) is made earlier than current time (now_ts), use the timestamp captured before sending packet directly. --- src/timesync/timesyncd-manager.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesy

[systemd-devel] [PATCH 3/8] timesyncd: get kernel timestamp in nanoseconds

2014-08-27 Thread Miroslav Lichvar
--- src/timesync/timesyncd-manager.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c index 3339606..2b0580c 100644 --- a/src/timesync/timesyncd-manager.c +++ b/src/timesync/timesyncd-manager.c @@

[systemd-devel] [PATCH 0/8] timesyncd bugfixing and improvements

2014-08-27 Thread Miroslav Lichvar
When I was looking at the timesyncd code I noticed few issues that I thought could be easily fixed and you might be interested in. The last two patches is an attempt to fix the problem with frequent polling. I'm not sure if this is robust enough, I feel like a minor change in the code could break

[systemd-devel] [PATCH 8/8] timesyncd: wait before reconnecting to first server

2014-08-27 Thread Miroslav Lichvar
When all servers are exhausted, wait for one poll interval before trying to connect again to the first server in the list. Also, keep increasing the polling interval to make sure a client not getting any valid replies will not send requests to any server more frequently than is allowed by the maxim

[systemd-devel] [PATCH 4/8] timesyncd: check root distance

2014-08-27 Thread Miroslav Lichvar
NTPv4 servers don't reply with unsynchronized status when they lost synchronization, they only keep increasing the root dispersion and it's up to the client to decide at which point they no longer consider it synchronized. Ignore replies with root distance over 5 seconds. --- src/timesync/timesyn

[systemd-devel] [PATCH 5/8] timesyncd: use longer PLL time constant

2014-08-27 Thread Miroslav Lichvar
The shortest time constant that is stable with the kernel PLL (compiled with SHIFT_PLL=2) is about log2 of update interval - 3. Set the constant to poll - 2 to make room for one missed update. --- src/timesync/timesyncd-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[systemd-devel] [PATCH 6/8] timesyncd: allow two missed replies before reselecting server

2014-08-27 Thread Miroslav Lichvar
After receiving a reply from the server, allow two missed replies before switching to another server to avoid unnecessary clock hopping when packets are getting lost in the network. --- src/timesync/timesyncd-manager.c | 27 ++- src/timesync/timesyncd-manager.h | 1 + 2 fi

[systemd-devel] [PATCH 1/8] timesyncd: check if stratum is valid

2014-08-27 Thread Miroslav Lichvar
--- src/timesync/timesyncd-manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c index d80c72f..60f39c6 100644 --- a/src/timesync/timesyncd-manager.c +++ b/src/timesync/timesyncd-manager.c @@ -574,7 +574,

[systemd-devel] [PATCH 7/8] timesyncd: don't reset polling interval when reselecting server

2014-08-27 Thread Miroslav Lichvar
--- src/timesync/timesyncd-manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c index 9f12149..d1f77a8 100644 --- a/src/timesync/timesyncd-manager.c +++ b/src/timesync/timesyncd-manager.c @@ -735,7 +735,

[systemd-devel] Thoughts about /etc/crypttab keyscript options

2014-08-27 Thread Paul Harvey
I've just been pointed to this discussion from #debian-systemd, where I dropped in to suggest that Debian packaging of systemd should probably abort installation if incompatible config like this is detected (I ended up with a non-booting test server, no harm done). I thought I'd help elaborate

Re: [systemd-devel] [PATCH 1/2] sd-journal: properly convert object->size on big endian

2014-08-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Aug 27, 2014 at 06:58:17PM +1200, Chris Tillman wrote: > Ummm, luser here, how would I know if it was BE mode? That would stand for > big-endian? I reckon so, as I wouldn't know how to change it. /proc/cpuinfo > didn't mention it. Yeah, big-endian. With PowerPC it is more complicated since

[systemd-devel] [PATCH] systemd-tmpfiles: Fix IGNORE_DIRECTORY_PATH age handling

2014-08-27 Thread Richard Weinberger
If one has a config like: d /tmp 1777 root root - X /tmp/important_mount All files below /tmp/important_mount will be deleted as the /tmp/important_mount item will spuriously inherit a max age of 0 from /tmp. /tmp has a max age of 0 but age_set is (of course) false. Fix this by checking ->age_set

Re: [systemd-devel] Socket based activation/deactivation

2014-08-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Aug 27, 2014 at 11:18:11AM +0200, Umut Tezduyar Lindskog wrote: > On Wed, Aug 27, 2014 at 3:24 AM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Tue, Aug 26, 2014 at 08:49:29PM -0400, Gary Mort wrote: > >> Socket based activation for systemd is a really cool feature for my > >> dev system. >

Re: [systemd-devel] Is it possible to override dependencies (without resorting to editing files in /lib)

2014-08-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Aug 27, 2014 at 07:51:17AM +0100, Alastair Scobie wrote: > Apologies if this isn't the appropriate mailing list to raise this question. > > Is there any way to override dependencies without resorting to > editing files in /lib? > > For example, with a stock EL7.0 machine, getty.target is

Re: [systemd-devel] [BUG] time-sync.target reached prematurely

2014-08-27 Thread Miroslav Lichvar
On Tue, Aug 26, 2014 at 10:28:54PM +0200, Lennart Poettering wrote: > On Tue, 26.08.14 22:11, Lukasz Stelmach ([email protected]) wrote: > > > Greetings. > > > > According to systemd.special(7) "all services where correct time is > > essential should be ordered after" time-sync.target. Implicitly

Re: [systemd-devel] systemd-networkd DHCP renew

2014-08-27 Thread Tom Gundersen
On Wed, Aug 27, 2014 at 10:17 AM, Mads wrote: > Is there a way to force a DHCPv4 release/renew with systemd-networkd? We don't currently allow dynamic interaction with networkd, but you can force renew the release by either restarting networkd or unplugging/replugging the cable (or switching your

Re: [systemd-devel] [PATCH] systemctl: fix broken list-unit-files with --root

2014-08-27 Thread Lukáš Nykrýn
Lennart Poettering píše v Út 26. 08. 2014 v 20:26 +0200: > On Tue, 26.08.14 13:36, Lukas Nykryn ([email protected]) wrote: > > Looks good! Please commit! > > > --- > > src/shared/install.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/src/shared/install.c

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-27 Thread Miroslav Lichvar
On Tue, Aug 26, 2014 at 09:08:47AM -0700, Marcel Holtmann wrote: > ConnMan is a single daemon solution doing NTP, DHCP and DNS all in > one place. Any sort of callouts are costing time. And that is time > that has a visible user impact. There is nothing that justifies to > have a bit more nanosecon

Re: [systemd-devel] Socket based activation/deactivation

2014-08-27 Thread Umut Tezduyar Lindskog
On Wed, Aug 27, 2014 at 3:24 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Aug 26, 2014 at 08:49:29PM -0400, Gary Mort wrote: >> Socket based activation for systemd is a really cool feature for my >> dev system. >> >> Prior to using socket based activation, on my dev system I would >> have 2 ch

Re: [systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-27 Thread Ivan Shapovalov
On Wednesday 27 August 2014 at 03:16:10, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Aug 26, 2014 at 10:21:59PM +0200, Lennart Poettering wrote: > > On Wed, 27.08.14 00:17, Ivan Shapovalov ([email protected]) wrote: > > > This patchset allows systemd to parse resume= kernel command line >

Re: [systemd-devel] Preventing automatic seat assignments

2014-08-27 Thread Tanu Kaskinen
On Tue, 2014-08-26 at 14:00 +0200, Lennart Poettering wrote: > On Tue, 26.08.14 12:17, Tanu Kaskinen ([email protected]) wrote: > > > Hi, > > > > If I want to designate some sound card to be shared between seats, > > then I suppose that sound card shouldn't be assigned to any seats. >

[systemd-devel] [Feature request] Retentiontime per unit configuration

2014-08-27 Thread Kris Erik Schwerdt
Hallo During a task of migration of multiple servers to a systemd-based distribution I was wondering if there would be a way of setting the retentiontime of journald per unit. In some cases e.g. there are limits for special program e.g. webserver where it is not allowed to keep the logs as long a

[systemd-devel] systemd-networkd DHCP renew

2014-08-27 Thread Mads
Hi! Is there a way to force a DHCPv4 release/renew with systemd-networkd? - Mads ___ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 2/2] udev: do NOT re-label smack

2014-08-27 Thread WaLyong Cho
On 08/27/2014 04:54 AM, Lennart Poettering wrote: > On Tue, 26.08.14 21:52, Lennart Poettering ([email protected]) wrote: > >> >> On Thu, 21.08.14 12:58, WaLyong Cho ([email protected]) wrote: >> >>> If selinux is disabled and smack is only enabled, smack label is >>> relable-ed by labe

Re: [systemd-devel] [RFC] [PATCH 0/3] resume: implement support for resuming from hibernation

2014-08-27 Thread Umut Tezduyar Lindskog
Hi Ivan, Great job! I was wondering if a ./configure switch makes sense to disable it. Embedded devices won't be using it. Thanks On Sat, Aug 23, 2014 at 2:47 PM, Ivan Shapovalov wrote: > This patchset allows systemd to parse resume= kernel command line parameter > and initiate resume from the

Re: [systemd-devel] [BUG] time-sync.target reached prematurely

2014-08-27 Thread Lukasz Stelmach
On 26.08.2014 22:28, Lennart Poettering wrote: > On Tue, 26.08.14 22:11, Lukasz Stelmach ([email protected]) wrote: > >> Greetings. >> >> According to systemd.special(7) "all services where correct time is >> essential should be ordered after" time-sync.target. Implicitly this >> means that if syst

Re: [systemd-devel] [PATCHv6 2/3] hibernate-resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-27 Thread Thomas Bächler
Am 27.08.2014 um 09:22 schrieb Ivan Shapovalov: >>> +[Unit] >>> +Description=Resume from hibernation using device %f >>> +Documentation=man:[email protected](8) >>> +DefaultDependencies=no >>> +BindsTo=%i.device >> >> What's the purpose of BindsTo= as opposed to Requires= here. They

[systemd-devel] Is it possible to override dependencies (without resorting to editing files in /lib)

2014-08-27 Thread Alastair Scobie
Apologies if this isn't the appropriate mailing list to raise this question. Is there any way to override dependencies without resorting to editing files in /lib? For example, with a stock EL7.0 machine, getty.target is "wanted" by multi-user.target through configuration in /lib/systemd. I'd

Re: [systemd-devel] [PATCHv6 2/3] hibernate-resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-27 Thread Ivan Shapovalov
On Wednesday 27 August 2014 at 08:18:38, Thomas Bächler wrote: > Am 26.08.2014 um 22:17 schrieb Ivan Shapovalov: > > This can be used to initiate a resume from hibernation by path to a swap > > device containing the hibernation image. > > > > The respective templated unit is also added. It is in