Re: [systemd-devel] [PATCH] systemd-networkd man repair

2014-04-25 Thread poma
On 25.04.2014 19:44, Tom Gundersen wrote: > Hi poma, > > The patch looks correct, thanks. However, Lennart requested that I > drop the whole config file (and hence the man page), so the patch I'm > working on now makes this one redundant. Sorry about that. > > Cheers, > > Tom > Slip the jab! :

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-25 Thread Umut Tezduyar Lindskog
On Sat, Apr 26, 2014 at 12:36 AM, Tom Gundersen wrote: > On Sun, Apr 13, 2014 at 12:52 PM, Umut Tezduyar Lindskog > wrote: >> Log error no for such client_stop(client, DHCP_EVENT_STOP) >> --- >> src/libsystemd-network/sd-dhcp-client.c |5 - >> 1 file changed, 4 insertions(+), 1 deletion(

Re: [systemd-devel] [PATCH 2/2] core: let selinux_setup() load policy more than once

2014-04-25 Thread Tom Gundersen
On Sat, Apr 26, 2014 at 12:26 AM, Will Woods wrote: > When you switch-root into a new root that has SELinux policy, you're > supposed to to run selinux_init_load_policy() to set up SELinux and load > policy. Normally this gets handled by selinux_setup(). > > But if SELinux was already initialized,

Re: [systemd-devel] [PATCH 1/2] core: reindent {selinux, ima, smack}-setup.c

2014-04-25 Thread Tom Gundersen
Applied. Thanks! Tom On Sat, Apr 26, 2014 at 12:26 AM, Will Woods wrote: > 7-space indentation is just too weird to leave alone. > Make it 8 spaces, as per CODING_STYLE. No other changes. > --- > src/core/ima-setup.c | 110 +- > src/core/selinux-setup.c | 152

Re: [systemd-devel] [PATCH] unit: add waiting jobs to run queue in unit_coldplug

2014-04-25 Thread Brandon Philips
On Wed, Apr 23, 2014 at 2:36 PM, Lennart Poettering wrote: > This looks correct, but could you move this into job_coldplug()? I rewrote the patch to be in job_coldplug() and tested. Patch attached. 0001-job-add-waiting-jobs-to-run-queue-in-unit_coldplug.patch Description: Binary data __

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-25 Thread Tom Gundersen
On Sun, Apr 13, 2014 at 12:52 PM, Umut Tezduyar Lindskog wrote: > Log error no for such client_stop(client, DHCP_EVENT_STOP) > --- > src/libsystemd-network/sd-dhcp-client.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/libsystemd-network/sd-dhcp-client.c > b

[systemd-devel] [PATCH 1/2] core: reindent {selinux, ima, smack}-setup.c

2014-04-25 Thread Will Woods
7-space indentation is just too weird to leave alone. Make it 8 spaces, as per CODING_STYLE. No other changes. --- src/core/ima-setup.c | 110 +- src/core/selinux-setup.c | 152 +++ 2 files changed, 131 insertions(+),

[systemd-devel] [PATCH 2/2] core: let selinux_setup() load policy more than once

2014-04-25 Thread Will Woods
When you switch-root into a new root that has SELinux policy, you're supposed to to run selinux_init_load_policy() to set up SELinux and load policy. Normally this gets handled by selinux_setup(). But if SELinux was already initialized, selinux_setup() skips loading policy and returns 0. So if you

[systemd-devel] [PATCH] core: let selinux_setup() load policy more than once

2014-04-25 Thread Will Woods
Hey all, Currently, systemd refuses to load SELinux policy more than once. Normal systems don't care, because they either: a) have initramfs without policy, then load policy after switch-root, or b) load policy in initramfs, and never switch-root out. But if you *do* switch-root more than once -

Re: [systemd-devel] [PATCH 3/3] nspawn: allow to bind mount journal on top of a non empty container journal dentry

2014-04-25 Thread Tom Gundersen
On Fri, Apr 11, 2014 at 2:45 AM, Djalal Harouni wrote: > Currently if nspawn was called with --link-journal=host or > --link-journal=auto and the right /var/log/journal/machine-id/ exists > then the bind mount the subdirectory into the container might fail due > to the ~/mycontainer/var/log/journa

Re: [systemd-devel] [PATCH 2/3] nspawn: make nspawn able to cleanly terminate on container errors

2014-04-25 Thread Tom Gundersen
On Fri, Apr 11, 2014 at 2:45 AM, Djalal Harouni wrote: > nspawn and the container child use eventfd to wait and notify each other > that they are ready so the container setup can be completed. > > However in its current form the wait/notify event ignore errors that > may especially affect the chil

Re: [systemd-devel] [PATCH 1/3] nspawn: move container wait logic into wait_for_container() function

2014-04-25 Thread Tom Gundersen
On Fri, Apr 11, 2014 at 2:45 AM, Djalal Harouni wrote: > Move the container wait logic into its own wait_for_container() function > and add two status codes: CONTAINER_TERMINATED or CONTAINER_REBOOTED > > These status codes are used to terminate nspawn or loop again in case of > CONTAINER_REBOOTED

Re: [systemd-devel] [PATCH] systemd-networkd man repair

2014-04-25 Thread Tom Gundersen
Hi poma, The patch looks correct, thanks. However, Lennart requested that I drop the whole config file (and hence the man page), so the patch I'm working on now makes this one redundant. Sorry about that. Cheers, Tom On Fri, Apr 25, 2014 at 5:42 AM, poma wrote: > Corrections to the manuals rel

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-25 Thread Tom Gundersen
On Fri, Apr 11, 2014 at 6:29 PM, Susant Sahani wrote: > On 04/08/2014 12:54 PM, "Jóhann B. Guðmundsson" wrote: > > > On 04/08/2014 03:22 AM, Susant Sahani wrote: > > file: ipip.netdev > -- > [NetDev] > Name=ipip-tun > Kind=ipip > > [Tunnel] > Local=192.168.8.102 > Remote=10

Re: [systemd-devel] [PATCH 1/2] networkd: ipip tunell add address support

2014-04-25 Thread Tom Gundersen
On Mon, Apr 14, 2014 at 12:41 PM, Susant Sahani wrote: > On 04/14/2014 04:04 PM, "Jóhann B. Guðmundsson" wrote: >> >> >> On 04/14/2014 10:31 AM, Susant Sahani wrote: >>> >>> It's a name not tunnel type. Tunnel type configured in .netdev . you can >>> put anything here . Should match the

Re: [systemd-devel] Cache passphrase for cryptsetup?

2014-04-25 Thread David Härdeman
On Sun, Apr 20, 2014 at 09:55:11PM +0300, Mantas Mikulėnas wrote: >On 2014-04-20 21:45, Matthew Monaco wrote: >> And of course, the third option would be to submit a patch. The >> src/cryptsetup >> stuff is pretty straightforward. > >Wasn't one submitted just a month ago? Yes, patches 1/3 and 2/3