Re: [systemd-devel] [PATCH] handle: unref handle->ep and free handle->meta on error path

2014-03-23 Thread Kay Sievers
On Mon, Mar 24, 2014 at 12:20 AM, Djalal Harouni wrote: > Signed-off-by: Djalal Harouni > --- > handle.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Applied. Thanks, Kay ___ systemd-devel mailing list [email protected]

Re: [systemd-devel] [PATCH 1/2] endpoint: free the policy_db on error path

2014-03-23 Thread Kay Sievers
On Sun, Mar 23, 2014 at 11:06 PM, Djalal Harouni wrote: > Signed-off-by: Djalal Harouni > --- > endpoint.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Applied. Thanks, Kay ___ systemd-devel mailing list [email protected]

Re: [systemd-devel] [PATCH 2/2] test-kdbus: rename check bus and domain functions

2014-03-23 Thread Kay Sievers
On Sun, Mar 23, 2014 at 11:06 PM, Djalal Harouni wrote: > Signed-off-by: Djalal Harouni > --- > test/test-kdbus.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.

Re: [systemd-devel] journal handling of process title changes

2014-03-23 Thread Patrick Donnelly
[adding message to list, sorry Lennart...] On Sun, Mar 23, 2014 at 9:25 PM, Lennart Poettering wrote: > On Sun, 23.03.14 00:32, Patrick Donnelly ([email protected]) wrote: > >> It seems the journal is reading from /proc/pid/cmdline (argv[0]) for >> each entry. So when reading using journalctl,

Re: [systemd-devel] journal handling of process title changes

2014-03-23 Thread Lennart Poettering
On Sun, 23.03.14 00:32, Patrick Donnelly ([email protected]) wrote: > It seems the journal is reading from /proc/pid/cmdline (argv[0]) for > each entry. So when reading using journalctl, we don't see process > title changes properly. See the below example: We are reading both /proc/$PID/comm a

Re: [systemd-devel] stopping a systemd-nspwan container

2014-03-23 Thread Lennart Poettering
On Sat, 22.03.14 16:35, Kevin Wilson ([email protected]) wrote: > Hello, > > I had created a container according to systemd-nspwan man page and > ran it by: > systemd-nspawn -D/srv/mycontainer > > I killed it by pkill systemd-nspaw (and not by poweroff from within the > container). > > Now, ru

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Lennart Poettering
On Sun, 23.03.14 11:06, Dave Reisner ([email protected]) wrote: > Also adds a few tests for the absolute cases of parse_timestamp. > > Suggested by: Mantas Mikulėnas > --- > src/shared/time-util.c | 10 ++ > src/test/test-time.c | 21 + > 2 files changed, 31 i

[systemd-devel] [PATCH] handle: unref handle->ep and free handle->meta on error path

2014-03-23 Thread Djalal Harouni
Signed-off-by: Djalal Harouni --- handle.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/handle.c b/handle.c index 921faca..3af6119 100644 --- a/handle.c +++ b/handle.c @@ -130,7 +130,7 @@ static int kdbus_handle_open(struct inode *inode, struct file *file)

Re: [systemd-devel] [RFC][PATCH] sd-bus: split ref-counting of queues from ref-counting of the rest of the sd-bus object

2014-03-23 Thread Tom Gundersen
On Sun, Mar 23, 2014 at 11:50 PM, David Herrmann wrote: > On Sun, Mar 23, 2014 at 4:49 PM, Tom Gundersen wrote: >> Introduce a new ref-count, n_ref_queues, which only protects the {r,w}queue >> of >> a bus, and introduce bus_{un,}ref(), which are only available internally, and >> which do not pr

Re: [systemd-devel] [RFC][PATCH] sd-bus: split ref-counting of queues from ref-counting of the rest of the sd-bus object

2014-03-23 Thread David Herrmann
Hi On Sun, Mar 23, 2014 at 4:49 PM, Tom Gundersen wrote: > Introduce a new ref-count, n_ref_queues, which only protects the {r,w}queue of > a bus, and introduce bus_{un,}ref(), which are only available internally, and > which do not protect these queues. > > Make sure that sd_bus_message object d

[systemd-devel] [PATCH 2/2] test-kdbus: rename check bus and domain functions

2014-03-23 Thread Djalal Harouni
Signed-off-by: Djalal Harouni --- test/test-kdbus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test-kdbus.c b/test/test-kdbus.c index 0427419..6f9b3e9 100644 --- a/test/test-kdbus.c +++ b/test/test-kdbus.c @@ -259,7 +259,7 @@ static int send_message(const str

[systemd-devel] [PATCH 1/2] endpoint: free the policy_db on error path

2014-03-23 Thread Djalal Harouni
Signed-off-by: Djalal Harouni --- endpoint.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/endpoint.c b/endpoint.c index 465ae31..5afabf9 100644 --- a/endpoint.c +++ b/endpoint.c @@ -236,7 +236,7 @@ int kdbus_ep_new(struct kdbus_bus *bus, const char *name, if (bu

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 10:04:00PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Mar 23, 2014 at 02:27:04PM -0400, Dave Reisner wrote: > > On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: > > > ]] Dave Reisner > > > > > > > On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 02:27:04PM -0400, Dave Reisner wrote: > On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: > > ]] Dave Reisner > > > > > On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek > > > wrote: > > > > On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: > ]] Dave Reisner > > > On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > > On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: > > > > Also adds a few tests for the absolute cases of parse_t

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Tollef Fog Heen
]] Dave Reisner > On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: > > > Also adds a few tests for the absolute cases of parse_timestamp. > > Yeah, that looks useful. > > > > You don't test negative val

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Susant Sahani
On 03/23/2014 10:00 PM, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 08:44:09PM +0530, Susant Sahani wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Susant Sahani
On 03/23/2014 09:34 PM, Tom Gundersen wrote: On Sun, Mar 23, 2014 at 4:14 PM, Susant Sahani wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs super user privileges to

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: > > Also adds a few tests for the absolute cases of parse_timestamp. > Yeah, that looks useful. > > You don't test negative values. Maybe you could an exampl

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 08:44:09PM +0530, Susant Sahani wrote: > Added support for tunneling netlink attrributes (ipip, gre, sit). > These works with kernel module ipip, gre and sit . > The test cases are > commented out because they requirs super user privileges to run and > respective kernel mo

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: > Also adds a few tests for the absolute cases of parse_timestamp. Yeah, that looks useful. You don't test negative values. Maybe you could an example with a negative value to the documentation and tests? Zbyszek > Suggested by: Mant

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Tom Gundersen
On Sun, Mar 23, 2014 at 4:14 PM, Susant Sahani wrote: > Added support for tunneling netlink attrributes (ipip, gre, sit). > These works with kernel module ipip, gre and sit . The test cases are > commented out because they requirs super user privileges to run and > respective kernel modules as wel

[systemd-devel] [RFC][PATCH] sd-bus: split ref-counting of queues from ref-counting of the rest of the sd-bus object

2014-03-23 Thread Tom Gundersen
Introduce a new ref-count, n_ref_queues, which only protects the {r,w}queue of a bus, and introduce bus_{un,}ref(), which are only available internally, and which do not protect these queues. Make sure that sd_bus_message object do not call sd_bus_ref(), but only the internal bus_ref(). This is ok

[systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Susant Sahani
Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs super user privileges to run and respective kernel modules as well. --- src/libsystemd/sd-rtnl/rtnl-message.c | 37

[systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
Also adds a few tests for the absolute cases of parse_timestamp. Suggested by: Mantas Mikulėnas --- src/shared/time-util.c | 10 ++ src/test/test-time.c | 21 + 2 files changed, 31 insertions(+) diff --git a/src/shared/time-util.c b/src/shared/time-util.c index faa