Re: [systemd-devel] Question about a udev rule

2013-12-08 Thread Hannes Reinecke
On 12/08/2013 07:14 PM, Robert Milasan wrote: > I've got this small rule which seems to not work at all: > > ACTION!="add|change", GOTO="end_root_symlink" > SUBSYSTEM!="block", GOTO="end_root_symlink" > ENV{DEVTYPE}!="partition", GOTO="end_root_symlink" > > IMPORT{program}="/usr/bin/udevadm info

Re: [systemd-devel] [PATCH 4/4] core: lazy distribute for Distribute pools

2013-12-08 Thread Shawn Landden
On Sun, Dec 8, 2013 at 7:50 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Nov 18, 2013 at 12:36:52AM +0100, Zbigniew Jędrzejewski-Szmek wrote: >> On Sun, Nov 17, 2013 at 02:57:56PM -0800, Shawn Landden wrote: >> > On Sun, Nov 17, 2013 at 2:28 PM, Zbigniew Jędrzejewski-Szmek >> > wrote: >> > >

Re: [systemd-devel] Question regarding the NotifyAccess parameter

2013-12-08 Thread salil GK
Hello did any body get a chance to look into this. I am a kind of stuck on this. I can work around using ExecStartPre script where I can kill the previous instances. But if systemd is capable to do it by itself, that would be the neat solution. Thanks ~S On 5 December 2013 13:19, salil GK

Re: [systemd-devel] systemd unit review requested

2013-12-08 Thread Peter Hutterer
On Thu, Dec 05, 2013 at 01:24:10PM +, "Jóhann B. Guðmundsson" wrote: [...] > So we need an udev wacom-serial-driver rule that might look like > this for the wacom serial devices > > ACTION=="remove", GOTO="drivers_end" > ENV{MODALIAS}=="?*", RUN{builtin}="kmod load $env{MODALIAS}" > SUBSYSTEM=

Re: [systemd-devel] [PATCH 4/4] core: lazy distribute for Distribute pools

2013-12-08 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 18, 2013 at 12:36:52AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Nov 17, 2013 at 02:57:56PM -0800, Shawn Landden wrote: > > On Sun, Nov 17, 2013 at 2:28 PM, Zbigniew Jędrzejewski-Szmek > > wrote: > > > On Sun, Nov 17, 2013 at 08:46:46PM +0100, Lennart Poettering wrote: > > >>

Re: [systemd-devel] systemd unit review requested

2013-12-08 Thread Peter Hutterer
On Fri, Dec 06, 2013 at 04:10:02PM +0100, Kay Sievers wrote: > On Fri, Dec 6, 2013 at 7:20 AM, Peter Hutterer > wrote: > > >> >It also depends on the wacom_w8001 and how it reacts when it's loaded > >> >and no hardware is present. > >> > > >> >Peter, couldn't this module be autoloaded? > > > > t

Re: [systemd-devel] systemd-nspawn and pam_securetty

2013-12-08 Thread Colin Guthrie
'Twas brillig, and Lennart Poettering at 08/12/13 23:46 did gyre and gimble: >> > 3. And finally, if we should not add "console", could nspawn do >> > something clever with a temporary file + bind mount to temporarily allow >> > console logins in the /etc/securetty without actually modifying it. >

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-08 Thread Lennart Poettering
On Sat, 07.12.13 19:03, Colin Guthrie ([email protected]) wrote: > > 'Twas brillig, and Shawn Landden at 07/12/13 18:57 did gyre and gimble: > > On Sat, Dec 7, 2013 at 10:33 AM, Colin Guthrie wrote: > >> Hi, > >> > >> When playing with systemd-nspawn, is there a way to override the kernel > >

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-08 Thread Lennart Poettering
On Sat, 07.12.13 18:33, Colin Guthrie ([email protected]) wrote: > Hi, > > When playing with systemd-nspawn, is there a way to override the kernel > command line seen inside the container. I mean it's probably not correct > that the host systems /proc/cmdline leaks into the container. Most of

Re: [systemd-devel] systemd-nspawn and pam_securetty

2013-12-08 Thread Lennart Poettering
On Sat, 07.12.13 18:25, Colin Guthrie ([email protected]) wrote: > Hi, > > So playing around a bit it seems our default pam config for pam.d/login > uses a pam_securetty to only allow root logins via "secure" seats. > > The file /etc/securetty are tty0-6 and vc/1-6 > > When "booting" with ns

Re: [systemd-devel] [PATCH] systemd: always start jobs for units in SYSTEMD_WANTS=

2013-12-08 Thread Lennart Poettering
On Sat, 07.12.13 00:35, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > Before they would only be started when the unit transitioned from > inactive to active state. Now, they will be started also on other > udev events. > > https://bugzilla.redhat.com/show_bug.cgi?id=1026860: > > we ha

Re: [systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread David Timothy Strauss
On Sun, Dec 8, 2013 at 12:23 PM, Dan McGee wrote: > It is the "free(s->buffer);" bit that snuck in there from the other patches > I sent this morning. I can rebase this one before those so it applies to the > current tree, my mistake. Aha! Applied. Thanks.

[systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread Dan McGee
Just as 'identifier' is strdup-ed and freed, we need to do the same for unit_id. --- src/journal/journald-stream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c index 9ca26e2..091f59d 100644 --- a/src/journal/journald-stream.c +++

Re: [systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread Dan McGee
On Sun, Dec 8, 2013 at 1:56 PM, David Timothy Strauss < [email protected]> wrote: > This fails to apply for me. Just to check yours methods and mine, I > tried applying your "Ensure unit is journaled for short-lived or > oneshot processes" patch and succeeded. Comparing the two, it looks > li

Re: [systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread David Timothy Strauss
This fails to apply for me. Just to check yours methods and mine, I tried applying your "Ensure unit is journaled for short-lived or oneshot processes" patch and succeeded. Comparing the two, it looks like the text above the first triple-hyphen got dropped. _

Re: [systemd-devel] [PATCH] Ensure unit is journaled for short-lived or oneshot processes

2013-12-08 Thread David Timothy Strauss
How reliable is the unit_id data this falls back to? If it's going into an underscore-prefixed field in the journal, we need confidence that it's not forgeable. ___ systemd-devel mailing list [email protected] http://lists.freedesktop.or

[systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread Dan McGee
--- src/journal/journald-stream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c index 890c0bf..eb9ea36 100644 --- a/src/journal/journald-stream.c +++ b/src/journal/journald-stream.c @@ -360,6 +360,7 @@ void stdout_stream_free(Stdo

[systemd-devel] [PATCH] Ensure unit is journaled for short-lived or oneshot processes

2013-12-08 Thread Dan McGee
In the time it takes to process incoming log messages, the process we are logging details for may exit. This means the cgroup data is no longer available from '/proc'. Unfortunately, the way the code was structured before, we never log _SYSTEMD_UNIT if we don't have this cgroup information. Add an

Re: [systemd-devel] Question about a udev rule

2013-12-08 Thread Robert Milasan
On Sun, 8 Dec 2013 19:30:45 +0100 "Martin Pitt" wrote: > Robert Milasan [2013-12-08 19:14 +0100]: > > IMPORT{program}="/usr/bin/udevadm info --export > > --export-prefix=ROOT_ --device-id-of-file=/" ENV{MAJOR}!="0", > > ENV{MAJOR}=="$env{ROOT_MAJOR}", > ^ > > For starters

Re: [systemd-devel] Question about a udev rule

2013-12-08 Thread Robert Milasan
On Sun, 8 Dec 2013 19:30:45 +0100 "Martin Pitt" wrote: > Robert Milasan [2013-12-08 19:14 +0100]: > > IMPORT{program}="/usr/bin/udevadm info --export > > --export-prefix=ROOT_ --device-id-of-file=/" ENV{MAJOR}!="0", > > ENV{MAJOR}=="$env{ROOT_MAJOR}", > ^ > > For starters

Re: [systemd-devel] Question about a udev rule

2013-12-08 Thread Andrey Borzenkov
В Sun, 8 Dec 2013 19:14:17 +0100 Robert Milasan пишет: > I've got this small rule which seems to not work at all: > > ACTION!="add|change", GOTO="end_root_symlink" > SUBSYSTEM!="block", GOTO="end_root_symlink" > ENV{DEVTYPE}!="partition", GOTO="end_root_symlink" > > IMPORT{program}="/usr/bin/ud

Re: [systemd-devel] Question about a udev rule

2013-12-08 Thread Martin Pitt
Robert Milasan [2013-12-08 19:14 +0100]: > IMPORT{program}="/usr/bin/udevadm info --export --export-prefix=ROOT_ > --device-id-of-file=/" ENV{MAJOR}!="0", ENV{MAJOR}=="$env{ROOT_MAJOR}", ^ For starters you seem to be missing a comma there. -- Martin Pitt

[systemd-devel] "Re:Re: How to use systemctl preset ?"

2013-12-08 Thread Tony Seo
Thanks your answer, Andrey. But what is "remove policy", I can't understand what you mean. Would you plz explain more abou it? I already added all units which I'd like to disable in 00-first.preset file. 00-first.preset include: disable connman.service disable wpa_supplicant.service As you sa

[systemd-devel] Question about a udev rule

2013-12-08 Thread Robert Milasan
I've got this small rule which seems to not work at all: ACTION!="add|change", GOTO="end_root_symlink" SUBSYSTEM!="block", GOTO="end_root_symlink" ENV{DEVTYPE}!="partition", GOTO="end_root_symlink" IMPORT{program}="/usr/bin/udevadm info --export --export-prefix=ROOT_ --device-id-of-file=/" ENV{MA

[systemd-devel] [PATCH 2/2] journald: when buffering stdout, allow buffer to grow if needed

2013-12-08 Thread Dan McGee
When logging really long lines (e.g. those without an '\n') to journald via capture of stdout, the hardcoded buffer length of LINE_MAX limited us to processing the data in 2KB chunks. This is rather inefficient if we are getting a 1+ MB message handed to us. Actual case is via a unit file where Po

[systemd-devel] [PATCH 1/2] Use heap allocation for stdout journald buffer

2013-12-08 Thread Dan McGee
Previously this was a static array in the standard out stream structure. Behavior shouldn't change with this as we do a one-time allocation of the buffer on the heap when creating the stream, and free it when it is released. However, it sets the stage for a growable buffer in the future. --- The c

[systemd-devel] [PATCH] Bring bootchart code in line with CODING_STYLE

2013-12-08 Thread Dan McGee
Use double and not float, as there is little to no benefit. --- src/bootchart/svg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/bootchart/svg.c b/src/bootchart/svg.c index c21f6e8..0f4fd63 100644 --- a/src/bootchart/svg.c +++ b/src/bootchart/svg.c @@ -68,16 +

Re: [systemd-devel] How to use "systemctl preset" ?

2013-12-08 Thread Andrey Borzenkov
В Mon, 9 Dec 2013 01:58:38 +0900 Tony Seo пишет: > Hello. > > I have tried to use "systemctl preset" command. > > As you know that systemd.org already explained preset in manual page, So I > read those things about preset and some example to use "systemctl preset". > > http://www.freedesktop.o

[systemd-devel] How to use "systemctl preset" ?

2013-12-08 Thread Tony Seo
Hello. I have tried to use "systemctl preset" command. As you know that systemd.org already explained preset in manual page, So I read those things about preset and some example to use "systemctl preset". http://www.freedesktop.org/software/systemd/man/systemd.preset.html But, when I try "syste

[systemd-devel] How to use "systemctl preset" ?

2013-12-08 Thread Tony Seo
Hello. I have tried to use "systemctl preset" command. As you know that systemd.org already explained preset in manual page, So I read those things about preset and some example to use "systemctl preset". http://www.freedesktop.org/software/systemd/man/systemd.preset.html But, when I try "syste

Re: [systemd-devel] Assertion 'fd == 3 + count' failed at activate.c:115

2013-12-08 Thread Peeters Simon
2013/12/8 Peeters Simon : > hej, > > when i try to run systemd-activate from the latest git i get an > assertion failiure: > > [simon@troela server]$ /usr/lib/systemd/systemd-activate -l 9000 main.js > Assertion 'fd == 3 + count' failed at src/activate/activate.c:115, > function open_sockets(). Abo

[systemd-devel] Assertion 'fd == 3 + count' failed at activate.c:115

2013-12-08 Thread Peeters Simon
hej, when i try to run systemd-activate from the latest git i get an assertion failiure: [simon@troela server]$ /usr/lib/systemd/systemd-activate -l 9000 main.js Assertion 'fd == 3 + count' failed at src/activate/activate.c:115, function open_sockets(). Aborting. Aborted (core dumped) this is on