[systemd-devel] [PATCH] event: clear pending-state when re-arming timers

2013-11-19 Thread David Herrmann
If a timer fires and is marked pending, but an application re-arms it before it is dispatched, we now clear the pending state. This fixes a bug where an application arms a timer, which fires and is marked pending. But before it is dispatched, the application loses interest in it and disables it. N

Re: [systemd-devel] [PATCH] bus/rtnl: silence warnings with clang

2013-11-19 Thread Thomas H.P. Andersen
Hi Tom, Sorry. Git send-email is just giving me error messages right now. I have attached the patch instead. On Wed, Nov 20, 2013 at 1:12 AM, Tom Gundersen wrote: > Hi Thomas, > > I'm not able to apply this patch, could you please resend using > git-send-email? > > Cheers, > > Tom > > On Tue, N

Re: [systemd-devel] [PATCH] selinux: fix selinux check for transient units

2013-11-19 Thread Václav Pavlín
And I obviously attached wrong file...this is the right one, sorry St 20. listopad 2013, 05:47:36 CET, Václav Pavlín napsal: Út 19. listopad 2013, 15:16:47 CET, Michal Sekletar napsal: On Tue, Nov 19, 2013 at 08:54:41AM -0500, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Has

Re: [systemd-devel] [PATCH] selinux: fix selinux check for transient units

2013-11-19 Thread Václav Pavlín
Út 19. listopad 2013, 15:16:47 CET, Michal Sekletar napsal: On Tue, Nov 19, 2013 at 08:54:41AM -0500, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2013 05:45 PM, Michal Sekletar wrote: On Mon, Nov 18, 2013 at 04:19:20PM -0500, Daniel J Walsh wrote: On 11/16

Re: [systemd-devel] [PATCH] bus/rtnl: silence warnings with clang

2013-11-19 Thread Tom Gundersen
Hi Thomas, I'm not able to apply this patch, could you please resend using git-send-email? Cheers, Tom On Tue, Nov 19, 2013 at 10:16 PM, Thomas H.P. Andersen wrote: > --- > src/libsystemd-bus/bus-internal.h | 2 +- > src/libsystemd-rtnl/rtnl-internal.h | 2 +- > 2 files changed, 2 insertion

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-19 Thread Colin Guthrie
'Twas brillig, and Colin Walters at 19/11/13 18:13 did gyre and gimble: > +d /run/user/0 0755 root root 10d This should probably be 0700 like the runtime dirs usually are I think. Also won't this folder be naturally reaped in user_finalize() in login/logind-user.c: /* Kill XDG_RUNTIME_DI

Re: [systemd-devel] Systemd / PID 1 leak

2013-11-19 Thread Colin Guthrie
'Twas brillig, and Oleksii Shevchuk at 19/11/13 21:10 did gyre and gimble: >> Valgrind > > Any methodology for pid 1 valgrinding? How to start/gather information > for example? > > Do you have any setup for that? Maybe I can clone it Probably best to use systemd-nspawn and a container tree to "b

Re: [systemd-devel] [RFC][PATCH] conf-parser: allow instanced sections

2013-11-19 Thread Tom Gundersen
On Tue, Nov 19, 2013 at 7:07 PM, Colin Guthrie wrote: > 'Twas brillig, and Tom Gundersen at 19/11/13 16:57 did gyre and gimble: >> This will treat [Section:bar], [Section:foo], and [Section:baz], >> as [Section], but pass on the full section name to the options parser >> so it can treat them separ

[systemd-devel] [PATCH] bus/rtnl: silence warnings with clang

2013-11-19 Thread Thomas H.P. Andersen
--- src/libsystemd-bus/bus-internal.h | 2 +- src/libsystemd-rtnl/rtnl-internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-bus/bus-internal.h b/src/libsystemd-bus/bus-internal.h index 4f9d941..faed183 100644 --- a/src/libsystemd-bus/bus-internal.h +++

Re: [systemd-devel] Systemd / PID 1 leak

2013-11-19 Thread Oleksii Shevchuk
> Valgrind Any methodology for pid 1 valgrinding? How to start/gather information for example? Do you have any setup for that? Maybe I can clone it ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/l

Re: [systemd-devel] Systemd / PID 1 leak

2013-11-19 Thread David Timothy Strauss
On Wed, Nov 20, 2013 at 5:33 AM, Oleksii Shevchuk wrote: > Any suggestions how to find the problem? Valgrind ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] Systemd / PID 1 leak

2013-11-19 Thread Oleksii Shevchuk
Systemd system instance (not the user one) is leaking for me. WinterMute # while :; do systemctl daemon-reload; ps v 1; done PID TTY STAT TIME MAJFL TRS DRS RSS %MEM COMMAND 1 ?Rs 0:01 48 1000 30535 4244 0.0 /usr/lib/systemd/systemd PID TTY STAT TIM

Re: [systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread Greg KH
On Tue, Nov 19, 2013 at 03:47:39PM -0200, Marcos Felipe Rasia de Mello wrote: > 2013/11/19 Cristian Rodríguez : > > El 19/11/13 13:18, Marcos Felipe Rasia de Mello escribió: > > > >> It works fine, but after the machine wakes up from suspend, I need > >> that all hdparm@.service be run again. Is th

[systemd-devel] systemd 208:trouble with inactive user sessions at non-seat0 seats

2013-11-19 Thread Laércio de Sousa
Hi there! I'm testing both Fedora 20 Beta and openSUSE 13.1 in my multiseat system (with GNOME 3.10, GDM 3.10.0.1 and systemd 208). I'm currently observing a strange behaviour which didn't occur in previous distro release (with GNOME 3.8.4 and systemd 204). When I boot my system, gdm greeter sess

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-19 Thread Colin Walters
On Tue, 2013-11-19 at 18:15 +0100, Martin Pitt wrote: > For the record, I much prefer something like this to my original patch > which simply unsets it. I just shied away from that as Lennart > repeatedly said on the RHBZ bug that he doesn't want su behave that > way. This is a complex discussio

Re: [systemd-devel] [RFC][PATCH] conf-parser: allow instanced sections

2013-11-19 Thread Colin Guthrie
'Twas brillig, and Tom Gundersen at 19/11/13 16:57 did gyre and gimble: > This will treat [Section:bar], [Section:foo], and [Section:baz], > as [Section], but pass on the full section name to the options parser > so it can treat them separately. What is the semantics here? (I should probably know

Re: [systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread Marcos Felipe Rasia de Mello
2013/11/19 Cristian Rodríguez : > El 19/11/13 13:18, Marcos Felipe Rasia de Mello escribió: > >> It works fine, but after the machine wakes up from suspend, I need >> that all hdparm@.service be run again. Is there a way to accomplish > > You are looking at the wrong place.. if you disable the HDD

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-19 Thread Martin Pitt
Hello, Colin Walters [2013-11-19 10:42 -0500]: > Both of our patch series currently are basically going to have the > effect that with pkexec, XDG_RUNTIME_DIR is unset. But this is > undesirable because it forces the rest of userspace to go back to the > old dark ages when XDG_RUNTIME_DIR didn't

Re: [systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread David Timothy Strauss
On Wed, Nov 20, 2013 at 3:00 AM, Marcos Felipe Rasia de Mello wrote: > In my first attempts, I forgot to install hdparm. ;) Shouldn't you only drop the rules and service with installation of hdparm, then? ___ systemd-devel mailing list systemd-devel@lis

Re: [systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread Marcos Felipe Rasia de Mello
2013/11/19 Tom Gundersen : > On Tue, Nov 19, 2013 at 5:18 PM, Marcos Felipe Rasia de Mello > wrote: >> Hi folks, >> >> I am trying to disable HDDs power management in a systemd way (aka no >> shell scripts :) >> >> /etc/udev/rules.d/99-hdparm.rules >> >> SUBSYSTEM=="block", KERNEL=="sd*", ATTR{rem

Re: [systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread Marcos Felipe Rasia de Mello
2013/11/19 David Timothy Strauss : > On Wed, Nov 20, 2013 at 2:18 AM, Marcos Felipe Rasia de Mello > wrote: >> ConditionFileIsExecutable=/usr/sbin/hdparm > > It seems sketchy to me to put the executable in ExecStart into > ConditionFileIsExecutable. Is it supposed to fail silently when hdparm > is

Re: [systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread Cristian Rodríguez
El 19/11/13 13:18, Marcos Felipe Rasia de Mello escribió: > It works fine, but after the machine wakes up from suspend, I need > that all hdparm@.service be run again. Is there a way to accomplish You are looking at the wrong place.. if you disable the HDD power managment, then suspend but after

[systemd-devel] [RFC][PATCH] conf-parser: allow instanced sections

2013-11-19 Thread Tom Gundersen
This will treat [Section:bar], [Section:foo], and [Section:baz], as [Section], but pass on the full section name to the options parser so it can treat them separately. --- This is needed so we can add [Address:xxx] and [Route:xxx] sections ot .network files. src/shared/conf-parser.c | 28 +++

Re: [systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread David Timothy Strauss
On Wed, Nov 20, 2013 at 2:18 AM, Marcos Felipe Rasia de Mello wrote: > ConditionFileIsExecutable=/usr/sbin/hdparm It seems sketchy to me to put the executable in ExecStart into ConditionFileIsExecutable. Is it supposed to fail silently when hdparm is missing? _

Re: [systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread Tom Gundersen
On Tue, Nov 19, 2013 at 5:18 PM, Marcos Felipe Rasia de Mello wrote: > Hi folks, > > I am trying to disable HDDs power management in a systemd way (aka no > shell scripts :) > > /etc/udev/rules.d/99-hdparm.rules > > SUBSYSTEM=="block", KERNEL=="sd*", ATTR{removable}=="0", > TAG+="systemd", ENV{SYS

[systemd-devel] Restart instantiated services after suspend

2013-11-19 Thread Marcos Felipe Rasia de Mello
Hi folks, I am trying to disable HDDs power management in a systemd way (aka no shell scripts :) /etc/udev/rules.d/99-hdparm.rules SUBSYSTEM=="block", KERNEL=="sd*", ATTR{removable}=="0", TAG+="systemd", ENV{SYSTEMD_WANTS}+="hdparm@%k.service" /etc/systemd/system/hdparm@.service [Unit] Descri

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-19 Thread Colin Walters
On Mon, 2013-11-18 at 19:35 -0500, Colin Walters wrote: > And that's what I'm testing - with Martin's patch in the loop I was > still getting XDG_DATA_DIR for uid 1000, I'll try to debug soon. Ok, some discussion on IRC revealed that I was only using the second patch to s/loginuid/uid/, but we ne

Re: [systemd-devel] French translation for systemd

2013-11-19 Thread Sylvain Plantefeve
You're right, my bad. Here is an updated patch to fix these issues. Le 18 novembre 2013 17:22, Jean-Michel Pollion a écrit : > 2013/11/18 Sylvain Plantefeve > >> Ok, thanks, I'll have a look at it. >> >> BTW, while re-reading the catalog again, I found a couple of typos... >> >> --- >> diff -

Re: [systemd-devel] [PATCH] selinux: fix selinux check for transient units

2013-11-19 Thread Michal Sekletar
On Tue, Nov 19, 2013 at 08:54:41AM -0500, Daniel J Walsh wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/18/2013 05:45 PM, Michal Sekletar wrote: > > On Mon, Nov 18, 2013 at 04:19:20PM -0500, Daniel J Walsh wrote: On > > 11/16/2013 08:10 AM, Lennart Poettering wrote: > On T

Re: [systemd-devel] [PATCH] selinux: fix selinux check for transient units

2013-11-19 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2013 05:45 PM, Michal Sekletar wrote: > On Mon, Nov 18, 2013 at 04:19:20PM -0500, Daniel J Walsh wrote: On > 11/16/2013 08:10 AM, Lennart Poettering wrote: On Thu, 14.11.13 15:43, Daniel J Walsh (dwa...@redhat.com) wrote: > >>>

Re: [systemd-devel] systemd + ExecStart + python script

2013-11-19 Thread Abdelghani Ouchabane
On 18/11/13 19:24, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Nov 18, 2013 at 05:56:47PM +0100, Abdelghani Ouchabane wrote: From my understanding I can combine PathChanged & PathExists but it did not work for me. They must be *both* satisfied. I you want the unit to start when *either* is sati