[systemd-devel] [PATCH] shared/util: Fix glob_extend() argument

2013-10-13 Thread Bastien Nocera
glob_extend() would completely fail to work, or return incorrect data if it wasn't being passed the current getopt "optarg" variable as it used the global variable, instead of the passed parameters. --- src/shared/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shar

[systemd-devel] Bug in source_io_register?

2013-10-13 Thread David Strauss
source_io_register errors out with EEXIST, but that's supposed to be harmless for epoll [1]: Q1: What happens if you add the same fd to an epoll_set twice? A1: You will probably get EEXIST. However, it is possible that two threads may add the same fd twice. This is a harmless condition. I assume

Re: [systemd-devel] [PATCH 1/2] manager: connect to private bus even if $DBUS_SESSION_BUS_ADDRESS is not set

2013-10-13 Thread Colin Walters
On Wed, 2013-10-09 at 17:33 +0300, Mantas Mikulėnas wrote: > On Wed, Oct 9, 2013 at 3:59 PM, Colin Walters wrote: > > Your patch seems to be at odds with the commit message; since > > DBUS_SESSION_BUS_ADDRESS won't be set for the user bus, we won't > > attempt a connection, right? > > In the curr

Re: [systemd-devel] [PATCH 2/2] test: test for ellipsize (manual)

2013-10-13 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Oct 06, 2013 at 05:20:58AM +0200, Zbigniew Jędrzejewski-Szmek wrote: > Hi, > > sorry for the long delay. I was expecting this review to take > some time, and I was right :) > > I started by running test-ellipsize under valgrind, and found > that there unitialized memory was written. There

Re: [systemd-devel] [PATCH] Add support for Intel Rapid Start

2013-10-13 Thread Bastien Nocera
On Sun, 2013-10-13 at 22:45 +0200, Lennart Poettering wrote: > On Sun, 13.10.13 22:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > Humm. So I am very conservative regarding adding vendor specific hacks > to userspace that go that low-level into the system. Given that the > kernel ha

Re: [systemd-devel] [PATCH] Add support for Intel Rapid Start

2013-10-13 Thread Bastien Nocera
On Sun, 2013-10-13 at 22:40 +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Oct 13, 2013 at 09:50:59PM +0200, Bastien Nocera wrote: > > > > Instead of using the kernel's hybrid sleep, use the firmware for > > laptops that support Intel Rapid Start, as explained in: > > http://mjg59.dreamwidth.

Re: [systemd-devel] [PATCH] Add support for Intel Rapid Start

2013-10-13 Thread Lennart Poettering
On Sun, 13.10.13 22:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Humm. So I am very conservative regarding adding vendor specific hacks to userspace that go that low-level into the system. Given that the kernel has support for interl rapidstart anyway, why isn't this exposed properly

Re: [systemd-devel] [PATCH] Add support for Intel Rapid Start

2013-10-13 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Oct 13, 2013 at 09:50:59PM +0200, Bastien Nocera wrote: > > Instead of using the kernel's hybrid sleep, use the firmware for > laptops that support Intel Rapid Start, as explained in: > http://mjg59.dreamwidth.org/26022.html > and implemented in: > https://git.kernel.org/cgit/linux/kernel/

Re: [systemd-devel] [PATCH] Add support for Intel Rapid Start

2013-10-13 Thread Matthew Garrett
On Sun, Oct 13, 2013 at 09:50:59PM +0200, Bastien Nocera wrote: > +r = > read_one_line_file("/sys/bus/acpi/devices/INT3392:00/wakeup_events", &p); /sys/bus/acpi/drivers/intel_rapid_start/*/wakeup_events would be better, if there's any way to use wildcards here. It's possible that later

Re: [systemd-devel] [PATCH] Add support for Intel Rapid Start

2013-10-13 Thread Matthew Garrett
On Sun, Oct 13, 2013 at 10:09:28PM +0200, Bastien Nocera wrote: > On Sun, 2013-10-13 at 20:57 +0100, Matthew Garrett wrote: > > On Sun, Oct 13, 2013 at 09:50:59PM +0200, Bastien Nocera wrote: > > > > > +r = > > > read_one_line_file("/sys/bus/acpi/devices/INT3392:00/wakeup_events", &p); >

Re: [systemd-devel] [PATCH] Add support for Intel Rapid Start

2013-10-13 Thread Bastien Nocera
On Sun, 2013-10-13 at 20:57 +0100, Matthew Garrett wrote: > On Sun, Oct 13, 2013 at 09:50:59PM +0200, Bastien Nocera wrote: > > > +r = > > read_one_line_file("/sys/bus/acpi/devices/INT3392:00/wakeup_events", &p); > > /sys/bus/acpi/drivers/intel_rapid_start/*/wakeup_events would be better

[systemd-devel] [PATCH] Add support for Intel Rapid Start

2013-10-13 Thread Bastien Nocera
Instead of using the kernel's hybrid sleep, use the firmware for laptops that support Intel Rapid Start, as explained in: http://mjg59.dreamwidth.org/26022.html and implemented in: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/drivers/platform/x86/intel-rst.c --- src/shared/

Re: [systemd-devel] [PATCH] Smack enabled systems need /dev special devices correctly labeled

2013-10-13 Thread Kay Sievers
On Sun, Oct 13, 2013 at 12:20 AM, Kok, Auke-jan H wrote: >> +KERNEL=="null",SMACK="*" What is SMACK=? (and add a space after the ',' please) Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/l