[systemd-devel] [PATCH] test: Make testing work on systems without or old systemd

From: Holger Hans Peter Freyther * Introduce a macro to conditionally execute tests. This avoids skipping the entire test if some parts require systemd * Skip the journal tests when no /etc/machine-id is present * Change test-catalog to load the catalog from the source directory of systemd. *

Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits

On Wed, Jul 17, 2013 at 04:02:26PM -0300, Lucas De Marchi wrote: > Talking about kmod and travis-ci. In kmod we are using it. Pretty > cool, with an IRC bot integration. I only wish there were more options > of distributions. Right now it's only Ubuntu 12.04 32 bits You could ask the people that

Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits

On Wed, Jul 17, 2013 at 05:08:46PM +0200, Kay Sievers wrote: > > I did something like that now. Let's see if it works ... Thank you, it did[1]. [1] https://travis-ci.org/systemd/systemd ___ systemd-devel mailing list [email protected]

Re: [systemd-devel] [PATCH] journalctl: add --iso-dates for long timestamps

On Thu, Jul 18, 2013 at 01:36:51AM +0200, Lennart Poettering wrote: > On Wed, 17.07.13 17:58, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > > > + > > > + > > So, now we have -o short, -o short-monotonic, and --iso-dates. > > I'm

Re: [systemd-devel] [PATCH 2/2] test: Make testing work on systems without or old systemd

On Thu, Jul 18, 2013 at 06:16:48AM +0200, Zbigniew Jędrzejewski-Szmek wrote: > Can we use the STRINGIFY macro instead? I can try. > > /* Note: this might actually not find anything, if systemd was > > * not installed before. That should be fine too. */ > > -r = catalog

Re: [systemd-devel] [PATCH 2/2] test: Make testing work on systems without or old systemd

On Wed, Jul 17, 2013 at 04:29:56PM +0200, Holger Hans Peter Freyther wrote: > From: Holger Hans Peter Freyther > > * Introduce a macro to conditionally execute tests. This avoids > skipping the entire test if some parts require systemd > * Skip the journal tests when no /etc/machine-id is prese

Re: [systemd-devel] [PATCH 1/2] test: Keep the test-suite.log around in case of a test failure

On Wed, Jul 17, 2013 at 04:29:55PM +0200, Holger Hans Peter Freyther wrote: > From: Holger Hans Peter Freyther > > The addition of .DELETE_ON_ERROR will lead to the removal of the > test-suite.log in case of a test failure. Mark the rule as PRECIOUS > to keep that file around. Applied. Zbyszek _

Re: [systemd-devel] [PATCH v5] journalctl: Add support for showing messages from a previous boot

On Tue, Jul 16, 2013 at 05:46:04PM +0200, Lennart Poettering wrote: > On Tue, 16.07.13 17:42, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > > > > On Tue, Jul 16, 2013 at 05:39:54PM +0200, Lennart Poettering wrote: > > > On Fri, 28.06.13 17:26, Jan Janssen ([email protected]) wrote: > >

Re: [systemd-devel] [PATCH] Log failing start conditions

On Tue, Jul 16, 2013 at 07:15:56PM +0200, Lennart Poettering wrote: > On Wed, 26.06.13 15:06, [email protected] ([email protected]) wrote: > > > From: Harald Hoyer > > > > $ systemctl status dracut-initqueue.service > > dracut-initqueue.service - dracut initqueue hook > >Loaded: loaded (/usr

Re: [systemd-devel] runtime directories for services vs. tmpfiles

On Thu, Jul 18, 2013 at 02:51:09AM +0200, Lennart Poettering wrote: [snip repoquery magic] > This means: ~81% of the packages have been converted from sysv to > systemd. And ~10% of the converted packages make use of tmpfiles. > > Now, my rpm/yum-fu is a bit too limited to easily figure out what

Re: [systemd-devel] [PATCH] journalctl: add --iso-dates for long timestamps

On Thu, Jul 18, 2013 at 01:36:51AM +0200, Lennart Poettering wrote: > On Wed, 17.07.13 17:58, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > > > + > > > + > > So, now we have -o short, -o short-monotonic, and --iso-dates. > > I'm

Re: [systemd-devel] [PATCHv2] core: notify triggered by socket of a service

On Wed, 17.07.13 09:46, Umut Tezduyar ([email protected]) wrote: > +static void socket_trigger_notify(Unit *u, Unit *other) { > +Socket *s = SOCKET(u); > +Service *se = SERVICE(other); > + > +assert(u); > +assert(other); > + > +if (other->load_state != UNIT_

Re: [systemd-devel] [PATCH] service: don't try to kill the service more than once when the watchdog timeout hits

On Wed, 17.07.13 09:20, Michael Olbrich ([email protected]) wrote: > Hi, > > On Wed, Jul 17, 2013 at 03:53:09AM +0200, Lennart Poettering wrote: > > On Wed, 12.06.13 01:22, Michael Olbrich ([email protected]) wrote: > > > > > If ExecStopPost= is defined then it is executed after SI

Re: [systemd-devel] runtime directories for services vs. tmpfiles

On Wed, 17.07.13 11:24, Michael Biebl ([email protected]) wrote: > > 2013/7/17 Michael Biebl : > > If this scheme is not flexible enough to cover the vast majority of > > all cases (for services), then I fear we'd end up half of the services > > using RuntimeDirectory, the other half a tmpfile. An

Re: [systemd-devel] Stop all uninstalled units

On Thu, Jul 18, 2013 at 9:47 AM, Lennart Poettering wrote: > On Wed, 17.07.13 22:14, Tim Cuthbertson ([email protected]) wrote: > > > Hi Folks, > > > > I've posted a serverfault question [0], but it got no answers so I > thought > > I'd bring it to the mailing list: > > > > I have some systemd unit

Re: [systemd-devel] [PATCHv3] systemctl, man: option to list units by state

On Wed, 17.07.13 13:01, Maciej Wereski ([email protected]) wrote: > This allows to show only units with specified SUB or ACTIVE state. > > Signed-off-by: Maciej Wereski Hmm, could you make --state= check all three states please? i.e. active, sub and load state equally. And leave --t

Re: [systemd-devel] Stop all uninstalled units

On Wed, 17.07.13 22:14, Tim Cuthbertson ([email protected]) wrote: > Hi Folks, > > I've posted a serverfault question [0], but it got no answers so I thought > I'd bring it to the mailing list: > > I have some systemd units installed and running. Let's say I manually > uninstall foo.service by >

Re: [systemd-devel] [PATCH] journalctl: add --iso-dates for long timestamps

On Wed, 17.07.13 17:58, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > + > > + > So, now we have -o short, -o short-monotonic, and --iso-dates. > I'm sure we'll add a relative timestamp mode like the excellent one in > dmesg --hum

[systemd-devel] Stop all uninstalled units

Hi Folks, I've posted a serverfault question [0], but it got no answers so I thought I'd bring it to the mailing list: I have some systemd units installed and running. Let's say I manually uninstall foo.service by - removing its .service (and .socket) files - removing all symlinks (e.g from de

Re: [systemd-devel] [PATCH] journal: return -ECHILD after a fork

On Wed, 17.07.13 11:05, Shawn ([email protected]) wrote: > Wouldn't this be better using pthread_atfork() to avoid all the getpid() > calls? No pthread_atfork() is not useful for much since it gives no ordering guarantees. Threading and forking doesn't mix well, and neither do single-use o

Re: [systemd-devel] hwdb for gphoto2

On Thu, Jul 18, 2013 at 12:59 AM, Tom Gundersen wrote: > Out of interest, what's the best way to measure the time event processing > takes? $ grep . /sys/bus/usb/devices/*/modalias /sys/bus/usb/devices/1-0:1.0/modalias:usb:v1D6Bp0002d0309dc09dsc00dp00ic09isc00ip00in00 /sys/bus/usb/devices/1-1:1

Re: [systemd-devel] hwdb for gphoto2

On Wed, Jul 17, 2013 at 11:54 AM, Kay Sievers wrote: > On Wed, Jul 17, 2013 at 11:31 AM, Tom Gundersen wrote: >> Hi guys, >> >> Here is an attempt at converting libgphoto2 to hwdb. Seems to work for my >> phone. >> >> hwdb file: >> patch:

Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits

On Fri, Jul 12, 2013 at 2:51 PM, Lennart Poettering wrote: > On Tue, 09.07.13 18:09, Holger Hans Peter Freyther ([email protected]) wrote: > >> From: Holger Hans Peter Freyther >> >> Instruct travis-ci to build systemd and create a tarball. In case >> of an error travis-ci will complain on IRC.

Re: [systemd-devel] [PATCH] journal: return -ECHILD after a fork

On Wed, Jul 17, 2013 at 11:05:38AM -0700, Shawn wrote: > Hi! > > > On Tue, Jul 16, 2013 at 8:50 AM, Lennart Poettering > wrote: > > > On Wed, 26.06.13 19:55, Zbigniew Jędrzejewski-Szmek ([email protected]) > > wrote: > > > > > A few asserts are replaced with 'return -EINVAL'. I think that > > >

Re: [systemd-devel] [PATCH] journal: return -ECHILD after a fork

Hi! On Tue, Jul 16, 2013 at 8:50 AM, Lennart Poettering wrote: > On Wed, 26.06.13 19:55, Zbigniew Jędrzejewski-Szmek ([email protected]) > wrote: > > > A few asserts are replaced with 'return -EINVAL'. I think that > > assert should not be used to check argument in public functions. > > > > Fiel

Re: [systemd-devel] [PATCH] journalctl: add --iso-dates for long timestamps

On Wed, Jul 17, 2013 at 05:15:05PM +0200, Tomasz Torcz wrote: > Add possibility have "short" output with long format ISO 8601 timestamps, > like "2008-05-28T14:14:46.316223-04:00". > --- > man/journalctl.xml | 8 > src/journal/journalctl.c | 11 ++- > src/shared/logs-show.c

Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits

On Wed, Jul 17, 2013 at 9:18 AM, Holger Hans Peter Freyther wrote: > On Fri, Jul 12, 2013 at 07:51:26PM +0200, Lennart Poettering wrote: > >> Commited. I figure this will not be useful right-away, since current git >> of systemd requires a very new version of kmod that is not available at >> Travi

Re: [systemd-devel] Stop all uninstalled units

'Twas brillig, and Tim Cuthbertson at 17/07/13 13:14 did gyre and gimble: > Hi Folks, > > I've posted a serverfault question [0], but it got no answers so I > thought I'd bring it to the mailing list: > > I have some systemd units installed and running. Let's say I manually > uninstall foo.servic

[systemd-devel] [PATCH] journalctl: add --iso-dates for long timestamps

Add possibility have "short" output with long format ISO 8601 timestamps, like "2008-05-28T14:14:46.316223-04:00". --- man/journalctl.xml | 8 src/journal/journalctl.c | 11 ++- src/shared/logs-show.c | 8 +++- src/shared/output-mode.h | 3 ++- 4 files changed, 27 i

[systemd-devel] [PATCH 2/2] test: Make testing work on systems without or old systemd

From: Holger Hans Peter Freyther * Introduce a macro to conditionally execute tests. This avoids skipping the entire test if some parts require systemd * Skip the journal tests when no /etc/machine-id is present * Change test-catalog to load the catalog from the source directory of systemd. *

[systemd-devel] [PATCH 1/2] test: Keep the test-suite.log around in case of a test failure

From: Holger Hans Peter Freyther The addition of .DELETE_ON_ERROR will lead to the removal of the test-suite.log in case of a test failure. Mark the rule as PRECIOUS to keep that file around. --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.am b/Makefile.am index 7

Re: [systemd-devel] runtime directories for services vs. tmpfiles

On Wed, 17.07.13 11:07, Michael Biebl ([email protected]) wrote: > > 2013/7/16 Lennart Poettering : > > > I'd be very conservative regarding adding full tmpfiles support into > > unit files directly. Instead, I'd suggest adding two very minimal, very > > specific new unit file settings: > > > > R

Re: [systemd-devel] runtime directories for services vs. tmpfiles

On Wed, 17.07.13 06:56, Andrey Borzenkov ([email protected]) wrote: > > On Tue, 16.07.13 18:53, Lennart Poettering ([email protected]) wrote: > > > > I'd be very conservative regarding adding full tmpfiles support into > > unit files directly. Instead, I'd suggest adding two very minimal,

[systemd-devel] Stop all uninstalled units

Hi Folks, I've posted a serverfault question [0], but it got no answers so I thought I'd bring it to the mailing list: I have some systemd units installed and running. Let's say I manually uninstall foo.service by - removing its .service (and .socket) files - removing all symlinks (e.g from de

[systemd-devel] [PATCHv3] systemctl, man: option to list units by state

This allows to show only units with specified SUB or ACTIVE state. Signed-off-by: Maciej Wereski --- man/systemctl.xml | 15 +-- src/systemctl/systemctl.c | 43 +-- 2 files changed, 50 insertions(+), 8 deletions(-) diff --git a/man/sys

Re: [systemd-devel] hwdb for gphoto2

On Wed, Jul 17, 2013 at 11:31 AM, Tom Gundersen wrote: > Hi guys, > > Here is an attempt at converting libgphoto2 to hwdb. Seems to work for my > phone. > > hwdb file: > patch: > > Comments

[systemd-devel] hwdb for gphoto2

Hi guys, Here is an attempt at converting libgphoto2 to hwdb. Seems to work for my phone. hwdb file: patch: Comments welcome. Cheers, Tom ___

Re: [systemd-devel] hwdb for sane

On Wed, Jul 17, 2013 at 9:36 AM, Tom Gundersen wrote: > On Wed, Jul 17, 2013 at 1:57 AM, Tom Gundersen wrote: >> Hi guys, >> >> I had a stab at converting sane to using hwdb rather than a huge udev >> rules file. >> >> For now only the usb entries have been converted, I didn't look at how >> to d

Re: [systemd-devel] runtime directories for services vs. tmpfiles

2013/7/17 Michael Biebl : > If this scheme is not flexible enough to cover the vast majority of > all cases (for services), then I fear we'd end up half of the services > using RuntimeDirectory, the other half a tmpfile. And that imho would > be even more confusing. Could we have some stats from F

Re: [systemd-devel] runtime directories for services vs. tmpfiles

2013/7/17 Harald Hoyer : > If RuntimeDirectory would support variable substitutions, this feature could > not > be provided with systemd-tmpfiles. That would indeed be a nice feature. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?

Re: [systemd-devel] runtime directories for services vs. tmpfiles

2013/7/16 Lennart Poettering : > I'd be very conservative regarding adding full tmpfiles support into > unit files directly. Instead, I'd suggest adding two very minimal, very > specific new unit file settings: > > RuntimeDirectory= > RuntimeDirectoyMode= > > If RuntimeDirectory= is set we'd creat

Re: [systemd-devel] runtime directories for services vs. tmpfiles

On 07/16/2013 09:28 PM, "Jóhann B. Guðmundsson" wrote: > On 07/16/2013 06:26 PM, Lennart Poettering wrote: >> I discussed this a bit more with Kay on the phone. Here's what we'd propose: >> >> I'd be very conservative regarding adding full tmpfiles support into >> unit files directly. Instead, I'd

[systemd-devel] [PATCHv2] core: notify triggered by socket of a service

Refer to: http://lists.freedesktop.org/archives/systemd-devel/2013-June/011532.html --- TODO |3 --- src/core/service.c | 31 --- src/core/socket.c | 33 - src/core/socket.h |3 --- 4 files changed, 32 insertio

Re: [systemd-devel] hwdb for sane

On Wed, Jul 17, 2013 at 1:57 AM, Tom Gundersen wrote: > Hi guys, > > I had a stab at converting sane to using hwdb rather than a huge udev > rules file. > > For now only the usb entries have been converted, I didn't look at how > to deal with scsi. > > hwdb file:

Re: [systemd-devel] [PATCH] service: don't try to kill the service more than once when the watchdog timeout hits

Hi, On Wed, Jul 17, 2013 at 03:53:09AM +0200, Lennart Poettering wrote: > On Wed, 12.06.13 01:22, Michael Olbrich ([email protected]) wrote: > > > If ExecStopPost= is defined then it is executed after SIGKILL. Otherwise > > another round of SIGTERM/SIGSTOP is started which is rather useles

Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits

On Fri, Jul 12, 2013 at 07:51:26PM +0200, Lennart Poettering wrote: > Commited. I figure this will not be useful right-away, since current git > of systemd requires a very new version of kmod that is not available at > Travis. However, it's still a good thing to have and to enable as soon > as tha