Re: [systemd-devel] [PATCH] test: Add list testcase

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jun 26, 2013 at 01:43:16PM +0200, Jan Janssen wrote: > --- > .gitignore | 1 + > Makefile.am | 12 +- > src/shared/list.h| 2 +- > src/test/test-list.c | 109 > +++ > 4 files changed, 122 insertions(+), 2 dele

Re: [systemd-devel] [systemd-commits] 2 commits - Makefile.am TODO src/core src/login src/shared src/systemctl src/test units/-.slice units/slices.target units/system.slice

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jun 27, 2013 at 06:40:37AM +0200, Zbigniew Jędrzejewski-Szmek wrote: > make distcheck fails for me, because make uninstall chokes on -.slice. > automake-1.12.2-5.fc18.noarch and automake-1.13.4-1.fc19.noarch both. > Sent a bug report to [email protected] just now, should show > up in the

Re: [systemd-devel] [systemd-commits] 2 commits - Makefile.am TODO src/core src/login src/shared src/systemctl src/test units/-.slice units/slices.target units/system.slice

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
make distcheck fails for me, because make uninstall chokes on -.slice. automake-1.12.2-5.fc18.noarch and automake-1.13.4-1.fc19.noarch both. Sent a bug report to [email protected] just now, should show up in their db soon. Zbyszek ___ systemd-devel ma

Re: [systemd-devel] [PATCH] man: fix spacing issue in sd_is_fifo(3)

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jun 26, 2013 at 05:23:02PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Jun 26, 2013 at 04:15:18PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > > On Tue, Jun 25, 2013 at 10:04:47AM +0200, Jason St. John wrote: > > > On Fri, Jun 14, 2013 at 2:40 PM, Zbigniew Jędrzejewski-Szmek > > > w

[systemd-devel] [PATCH] journal: return -ECHILD after a fork

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
A few asserts are replaced with 'return -EINVAL'. I think that assert should not be used to check argument in public functions. Fields in struct sd_journal are rearranged to make it less swiss-cheesy. --- Does this look sound? Zbyszek TODO | 5 +-- man/sd_journal_open

Re: [systemd-devel] [PATCH] man: fix spacing issue in sd_is_fifo(3)

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jun 26, 2013 at 04:15:18PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Jun 25, 2013 at 10:04:47AM +0200, Jason St. John wrote: > > On Fri, Jun 14, 2013 at 2:40 PM, Zbigniew Jędrzejewski-Szmek > > wrote: > > > On Wed, Jun 12, 2013 at 09:25:08PM +0200, Jason St. John wrote: > > >> Fr

Re: [systemd-devel] [PATCH] man: fix spacing issue in sd_is_fifo(3)

2013-06-26 Thread Jason St. John
On Fri, Jun 14, 2013 at 2:40 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Jun 12, 2013 at 09:25:08PM +0200, Jason St. John wrote: >> From: "Jason St. John" >> >> Before: libsystemd-daemonpkg-config(1) >> After: libsystemd-daemon pkg-config(1) >> >> This fix is more complicated than it should

Re: [systemd-devel] [PATCH] man: fix spacing issue in sd_is_fifo(3)

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jun 25, 2013 at 10:04:47AM +0200, Jason St. John wrote: > On Fri, Jun 14, 2013 at 2:40 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Wed, Jun 12, 2013 at 09:25:08PM +0200, Jason St. John wrote: > >> From: "Jason St. John" > >> > >> Before: libsystemd-daemonpkg-config(1) > >> After: libs

Re: [systemd-devel] [PATCH 2/2] systemd, systemctl: export and show failing condition

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jun 26, 2013 at 03:02:58PM +0200, Harald Hoyer wrote: > On 06/26/2013 02:11 PM, Zbigniew Jędrzejewski-Szmek wrote: > > $ systemctl --user status hoohoo > > hoohoo.service > >Loaded: loaded (/home/zbyszek/.config/systemd/user/hoohoo.service; > > static) > >Active: inactive (dead) >

[systemd-devel] [PATCH] Log failing start conditions

2013-06-26 Thread harald
From: Harald Hoyer $ systemctl status dracut-initqueue.service dracut-initqueue.service - dracut initqueue hook Loaded: loaded (/usr/lib/systemd/system/dracut-initqueue.service; static) Active: inactive (dead) start condition failed at Wed 2013-06-26 13:01:05 UTC; 22s ago Doc

[systemd-devel] [PATCH] shared/log.c: log_struct_internal(): handle multiple lines

2013-06-26 Thread harald
From: Harald Hoyer Handle "VAR=line1\nline2\nline3" and split into "VAR" length "line1\nline2\nline3" "\n" --- src/shared/log.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/src/shared/log.c b/src/shared/log.c index 27317f7..2e

Re: [systemd-devel] [PATCH 2/2] systemd, systemctl: export and show failing condition

2013-06-26 Thread Harald Hoyer
On 06/26/2013 02:11 PM, Zbigniew Jędrzejewski-Szmek wrote: > $ systemctl --user status hoohoo > hoohoo.service >Loaded: loaded (/home/zbyszek/.config/systemd/user/hoohoo.service; static) >Active: inactive (dead) > start condition failed at Tue 2013-06-25 18:08:42 EDT; 1s ago >

[systemd-devel] [PATCH 2/2] systemd, systemctl: export and show failing condition

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
$ systemctl --user status hoohoo hoohoo.service Loaded: loaded (/home/zbyszek/.config/systemd/user/hoohoo.service; static) Active: inactive (dead) start condition failed at Tue 2013-06-25 18:08:42 EDT; 1s ago ConditionPathExists=/tmp/hoo was not met --- TODO

[systemd-devel] [PATCH 1/2] systemd: log failed conditions

2013-06-26 Thread Zbigniew Jędrzejewski-Szmek
ConditionPathExists=/tmp/nosuchpath failed for nosuchpath.service. --- Harald, this goes in a slightly different direction than your changes, but both would be probably useful. What do you think? Zbyszek src/core/condition.c | 12 +++- src/core/condition.h | 2 +- src/core/unit.c |

[systemd-devel] [PATCH] test: Add list testcase

2013-06-26 Thread Jan Janssen
--- .gitignore | 1 + Makefile.am | 12 +- src/shared/list.h| 2 +- src/test/test-list.c | 109 +++ 4 files changed, 122 insertions(+), 2 deletions(-) create mode 100644 src/test/test-list.c diff --git a/.gitignore b