Re: [systemd-devel] [PATCH 2/2] findkeyboards: Avoid throwaway attribute-walk.

2013-05-03 Thread Zbigniew Jędrzejewski-Szmek
On Fri, May 03, 2013 at 11:43:12PM +0300, Ville Skyttä wrote: > --- > src/udev/keymap/findkeyboards | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied both. Zbyszek ___ systemd-devel mailing list [email protected] http://l

[systemd-devel] [PATCH 1/2] Spelling fixes.

2013-05-03 Thread Ville Skyttä
--- TODO| 2 +- man/systemctl.xml | 2 +- man/systemd.service.xml | 2 +- src/libsystemd-bus/kdbus.h | 2 +- src/python-systemd/journal.py | 2 +- src/udev/keymap/95-keymap.rules | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff

[systemd-devel] [PATCH 2/2] findkeyboards: Avoid throwaway attribute-walk.

2013-05-03 Thread Ville Skyttä
--- src/udev/keymap/findkeyboards | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udev/keymap/findkeyboards b/src/udev/keymap/findkeyboards index 9ce2742..c6b50d1 100755 --- a/src/udev/keymap/findkeyboards +++ b/src/udev/keymap/findkeyboards @@ -33,12 +33,12 @@ str_line_sta

Re: [systemd-devel] Should systemd-udev-settle.service have an [Install] section?

2013-05-03 Thread Michael Biebl
2013/5/3 Kay Sievers : > On Fri, May 3, 2013 at 7:18 PM, Michael Biebl wrote: >> seeing that systemd-udev-settle.service is not enabled by default (as >> it's mostly a workaround for broken software), shouldn't we at least >> add an [Install] section, so it *can* be enabled easily by the >> admin

Re: [systemd-devel] Fedora 16 and upstart

2013-05-03 Thread Chinmay Mahata
Hi,     Thanks a lot, everybody for your support, for quick and valuable comments. So it is time for me to write the systemd service scripts (and bite the bullet !!! to be frank, I am not feeling much confident). Now I have few queries (may sound like dumb questions). 1. How can I call user-d

Re: [systemd-devel] Should systemd-udev-settle.service have an [Install] section?

2013-05-03 Thread Kay Sievers
On Fri, May 3, 2013 at 7:18 PM, Michael Biebl wrote: > seeing that systemd-udev-settle.service is not enabled by default (as > it's mostly a workaround for broken software), shouldn't we at least > add an [Install] section, so it *can* be enabled easily by the > administrator if needed? We just

Re: [systemd-devel] [RFC PATCH] logs-show: print multiline messages

2013-05-03 Thread Zbigniew Jędrzejewski-Szmek
On Fri, May 03, 2013 at 06:51:35PM +0200, Lennart Poettering wrote: > On Wed, 24.04.13 10:30, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > > [0.019862] fedora kernel: CPU0: Thermal monitoring enabled (TM1) > > [0.019900] fedora kernel: Last level iTLB entries: 4KB 512, 2MB 0,

[systemd-devel] Should systemd-udev-settle.service have an [Install] section?

2013-05-03 Thread Michael Biebl
Hi, seeing that systemd-udev-settle.service is not enabled by default (as it's mostly a workaround for broken software), shouldn't we at least add an [Install] section, so it *can* be enabled easily by the administrator if needed? Michael -- Why is it that all of the instruments seeking intelli

Re: [systemd-devel] [PATCH] systemctl: add --plain option to list-dependencies

2013-05-03 Thread Lennart Poettering
On Fri, 03.05.13 12:52, Lukas Nykryn ([email protected]) wrote: > This patch adds more script-friendly output for list-dependencies. Applied. Thanks! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list [email protected]

Re: [systemd-devel] [PATCH] systemd-delta: add support for drop-in snippets

2013-05-03 Thread Lennart Poettering
On Tue, 30.04.13 12:27, Lukas Nykryn ([email protected]) wrote: Looks mostly good. > -static int enumerate_dir(Hashmap *top, Hashmap *bottom, const char *path) { > +static int enumerate_dir_d(Hashmap *top, Hashmap *bottom, Hashmap > *drops, const char *toppath, const char *drop) { Hmm, can we m

Re: [systemd-devel] [PATCH] Dynamically allocate bootchart logs

2013-05-03 Thread Kok, Auke-jan H
On Fri, May 3, 2013 at 9:42 AM, Lennart Poettering wrote: > On Fri, 03.05.13 09:30, Kok, Auke-jan H ([email protected]) wrote: > >> >> The linked list approach drives down this memory requirement and makes >> >> navigating all the data much more straightforward. I also much prefer >> >> hea

Re: [systemd-devel] [RFC PATCH] logs-show: print multiline messages

2013-05-03 Thread Lennart Poettering
On Wed, 24.04.13 10:30, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > [0.019862] fedora kernel: CPU0: Thermal monitoring enabled (TM1) > [0.019900] fedora kernel: Last level iTLB entries: 4KB 512, 2MB 0, 4MB 0 > Last level dTLB entries: 4KB 512, 2MB

Re: [systemd-devel] [PATCH] Dynamically allocate bootchart logs

2013-05-03 Thread Lennart Poettering
On Fri, 03.05.13 09:30, Kok, Auke-jan H ([email protected]) wrote: > >> The linked list approach drives down this memory requirement and makes > >> navigating all the data much more straightforward. I also much prefer > >> head pointers instead of having index numbers around. > > > > Still

Re: [systemd-devel] [PATCH] Dynamically allocate bootchart logs

2013-05-03 Thread Kok, Auke-jan H
On Fri, May 3, 2013 at 9:14 AM, Lennart Poettering wrote: > On Thu, 25.04.13 22:47, Kok, Auke-jan H ([email protected]) wrote: > >> On Wed, Apr 24, 2013 at 5:20 PM, Zbigniew Jędrzejewski-Szmek >> wrote: >> > On Wed, Apr 24, 2013 at 04:26:12PM -0700, Nathaniel Chen wrote: >> >> Instead of s

Re: [systemd-devel] [PATCH] Dynamically allocate bootchart logs

2013-05-03 Thread Lennart Poettering
On Thu, 25.04.13 22:47, Kok, Auke-jan H ([email protected]) wrote: > On Wed, Apr 24, 2013 at 5:20 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Wed, Apr 24, 2013 at 04:26:12PM -0700, Nathaniel Chen wrote: > >> Instead of storing bootchart sample data in arrays, this patch moves > >> stor

Re: [systemd-devel] Lid close event delivered delayed

2013-05-03 Thread Lennart Poettering
On Fri, 26.04.13 10:17, Colin Guthrie ([email protected]) wrote: > 'Twas brillig, and Andrey Borzenkov at 17/04/13 18:01 did gyre and gimble: > > В Wed, 17 Apr 2013 17:31:14 +0200 > > Lennart Poettering пишет: > > > >> On Wed, 17.04.13 17:20, Jan Engelhardt ([email protected]) wrote: > >> > >>>

Re: [systemd-devel] [RFC PATCH] journal: Set the default keep free value to 15% (up from 5%)

2013-05-03 Thread Lennart Poettering
On Tue, 30.04.13 11:48, Colin Guthrie ([email protected]) wrote: > As some SSDs are still seeing performance degredation when > reaching 85% usage the default value of 5% seems a little low. > > Set this to 15% by default. Commited. This isn't really exact science anyway, we have to pick somethi

Re: [systemd-devel] audit paranoia breaks tests

2013-05-03 Thread Lennart Poettering
On Fri, 03.05.13 17:27, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > > On 03/05/13 13:16, Lennart Poettering wrote: > > > > On Fri, 03.05.13 04:51, Zbigniew Jędrzejewski-Szmek ([email protected]) > > > > wrote: > > > >> Hm, one of our tests fails because > > > >> /usr/lib/systemd/s

Re: [systemd-devel] audit paranoia breaks tests

2013-05-03 Thread Zbigniew Jędrzejewski-Szmek
On Fri, May 03, 2013 at 05:05:51PM +0200, Lennart Poettering wrote: > On Fri, 03.05.13 14:00, Simon McVittie ([email protected]) wrote: > > > On 03/05/13 13:16, Lennart Poettering wrote: > > > On Fri, 03.05.13 04:51, Zbigniew Jędrzejewski-Szmek ([email protected]) > > > wrote: > > >>

Re: [systemd-devel] [PATCH 2/2] coredump: Handle programs with spaces in COMM

2013-05-03 Thread Lennart Poettering
On Tue, 30.04.13 13:12, Colin Walters ([email protected]) wrote: > This patch makes systemd-coredump handle processes that have > whitespace in their COMM fields. > > fs/coredump.c when given %e (as systemd-coredump uses), will end up > joining the process arguments into a string (along with the

Re: [systemd-devel] login problems

2013-05-03 Thread Christian Hesse
Lennart Poettering on Fri, 2013/05/03 16:30: > On Tue, 30.04.13 00:03, Christian Hesse ([email protected]) wrote: > > > Hello everybody, > > > > ok, this looks very tricky... I have no idea what happens and I have no > > way to reproduce this. It just happens from time to time - very seldom. > > >

Re: [systemd-devel] [PATCH 2/2] coredump: Handle programs with spaces in COMM

2013-05-03 Thread Lennart Poettering
On Tue, 30.04.13 15:15, Colin Walters ([email protected]) wrote: > On Tue, 2013-04-30 at 19:47 +0200, Zbigniew Jędrzejewski-Szmek wrote: > > On Tue, Apr 30, 2013 at 01:12:19PM -0400, Colin Walters wrote: > > > This patch makes systemd-coredump handle processes that have > > > whitespace in their

Re: [systemd-devel] [PATCH 2/2] coredump: Handle programs with spaces in COMM

2013-05-03 Thread Lennart Poettering
On Wed, 01.05.13 18:42, Oleg Nesterov ([email protected]) wrote: > On 04/30, Colin Walters wrote: > > > > On Tue, 2013-04-30 at 19:47 +0200, Zbigniew Jędrzejewski-Szmek wrote: > > > On Tue, Apr 30, 2013 at 01:12:19PM -0400, Colin Walters wrote: > > > > This patch makes systemd-coredump handle proces

Re: [systemd-devel] audit paranoia breaks tests

2013-05-03 Thread Lennart Poettering
On Fri, 03.05.13 14:00, Simon McVittie ([email protected]) wrote: > On 03/05/13 13:16, Lennart Poettering wrote: > > On Fri, 03.05.13 04:51, Zbigniew Jędrzejewski-Szmek ([email protected]) > > wrote: > >> Hm, one of our tests fails because /usr/lib/systemd/system/auditd.service > >>

Re: [systemd-devel] [PATCH 1/1] RFC: Set the Default OOM Score from configuration file

2013-05-03 Thread Lennart Poettering
On Fri, 03.05.13 16:49, Lennart Poettering ([email protected]) wrote: > > If the unit file has 'OOMScoreAdjust' option, set the its oom_score_adj > > as declared value as before. > > I'd prefer to call this option OOMScoreAdjust= too, i.e. not with the > "Default" prefix, and use the same no

Re: [systemd-devel] [PATCH 1/1] RFC: Set the Default OOM Score from configuration file

2013-05-03 Thread Lennart Poettering
On Sun, 28.04.13 20:37, Umut Tezduyar ([email protected]) wrote: > Hi, > > Should DefaultOOMScore= and DefaultLimit***= be really under [Manager]? > Wouldn't it be better to have an [Exec] section. Or even have [Service], > [Mount],.. sections that can give separate configuration per exec > unit.

Re: [systemd-devel] [PATCH 1/1] RFC: Set the Default OOM Score from configuration file

2013-05-03 Thread Lennart Poettering
On Sat, 27.04.13 07:49, Sangjung Woo ([email protected]) wrote: > If 'OOMScoreAdjust' option is ommited from unit file, this patch makes > the executed process's oom_score_adj as default OOM score in case of > explicitly 'DefaultOOMScore' is declared in configuration file. > (i.e. system.conf an

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-05-03 Thread Lennart Poettering
On Fri, 26.04.13 21:10, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > On Fri, Apr 26, 2013 at 08:14:07PM +0200, Daniel Buch wrote: > > I felt the inconsistentsy was kinda awfull. > > > > I can change all to void* (instead of, void *) if you like but else leave > > this patch to the

Re: [systemd-devel] Systemd connection limit

2013-05-03 Thread Lennart Poettering
On Thu, 25.04.13 23:11, Martin Koegler ([email protected]) wrote: > Systemd includes for a long time a concurrent connection limit for > its private dbus. If it is more than 52, it yields to a "Too many concurrent > connections" > error (src/core/dbus.c:748) > > Each destroyed control gr

Re: [systemd-devel] login problems

2013-05-03 Thread Lennart Poettering
On Tue, 30.04.13 00:03, Christian Hesse ([email protected]) wrote: > Hello everybody, > > ok, this looks very tricky... I have no idea what happens and I have no way > to reproduce this. It just happens from time to time - very seldom. > > If this happens I am not able to log in from lxdm and getty.

Re: [systemd-devel] [systemd-commits] 10 commits - Makefile.am TODO man/sd_id128_to_string.xml man/systemd.unit.xml src/core src/cryptsetup src/libsystemd-id128 src/nspawn src/nss-myhostname src/share

2013-05-03 Thread Lennart Poettering
On Tue, 30.04.13 15:28, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > On Tue, Apr 30, 2013 at 04:36:11AM -0700, Lennart Poettering wrote: > > commit 5f1dac6bf605871615b35891a3966fa474db5b20 > > Author: Lennart Poettering > > Date: Mon Apr 29 19:57:29 2013 -0300 > > > > crypts

Re: [systemd-devel] [PATCH 2/3] conf-parser: add "ignored sections" parameter

2013-05-03 Thread Lennart Poettering
On Thu, 02.05.13 02:17, Tom Gundersen ([email protected]) wrote: > On Wed, May 1, 2013 at 2:53 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > config_parse will ignore settings specified in 'ignored_sections'. The > > purpose > > is being able to share a config file between two different modules (e.g.

Re: [systemd-devel] %i/%I instance expansion in ExecStartPre ?

2013-05-03 Thread Lennart Poettering
On Thu, 02.05.13 10:41, Colin Guthrie ([email protected]) wrote: > The rules for ExecStartPre and ExecStart are the same so you can use the > %i/%I specifiers in the arguments - that's what they were designed for :) > > Looking at "man systemd.service" and checking the ExecStart section it > s

Re: [systemd-devel] audit paranoia breaks tests

2013-05-03 Thread Simon McVittie
On 03/05/13 13:16, Lennart Poettering wrote: > On Fri, 03.05.13 04:51, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: >> Hm, one of our tests fails because /usr/lib/systemd/system/auditd.service >> is -rw-r-. That's crazy. Do we fight it, or work around it? > > I'd say fight it. After

Re: [systemd-devel] audit paranoia breaks tests

2013-05-03 Thread Lennart Poettering
On Fri, 03.05.13 04:51, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > Hm, one of our tests fails because /usr/lib/systemd/system/auditd.service > is -rw-r-. That's crazy. Do we fight it, or work around it? I'd say fight it. After all this is just annoying and little else since the

[systemd-devel] [PATCH] systemctl: add --plain option to list-dependencies

2013-05-03 Thread Lukas Nykryn
This patch adds more script-friendly output for list-dependencies. --- man/systemctl.xml | 9 + src/systemctl/systemctl.c | 50 +++ 2 files changed, 42 insertions(+), 17 deletions(-) diff --git a/man/systemctl.xml b/man/systemctl.xml in