[systemd-devel] [PATCH] add --with-debug-shell=PATH

2013-04-24 Thread Cristian Rodríguez
Distributions may have selinux but not sushell or might need to set a custom debug shell. Defaults to /sbin/sushell if selinux is enabled /bin/sh if not. --- configure.ac | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index ce02ff6..85

Re: [systemd-devel] [PATCH] Dynamically allocate bootchart logs

2013-04-24 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 24, 2013 at 04:26:12PM -0700, Nathaniel Chen wrote: > Instead of storing bootchart sample data in arrays, this patch moves > storage to linked lists so that there is no more limit on samples. How does this approach compare to greedy_realloc? Zbyszek > This patch also fixes parsing of

Re: [systemd-devel] [PATCH] journal: remove build warning when SELinux is disabled

2013-04-24 Thread Kay Sievers
On Wed, Apr 24, 2013 at 10:04 PM, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > A small patch to remove a build warnining when SELinux is disabled. Applied. Thanks, Kay ___ systemd-devel mailing list [email protected] http

[systemd-devel] [PATCH] Dynamically allocate bootchart logs

2013-04-24 Thread Nathaniel Chen
Instead of storing bootchart sample data in arrays, this patch moves storage to linked lists so that there is no more limit on samples. This patch also fixes parsing of /proc//smaps in kernels > 3.7. --- src/bootchart/bootchart.c | 48 -- src/bootchart/bootchart.h | 23 ++- src/bootchart/st

Re: [systemd-devel] systemd-coredump large memory allocation

2013-04-24 Thread Colin Walters
On Wed, 2013-04-24 at 22:57 +0200, Zbigniew Jędrzejewski-Szmek wrote: > Hi, > we actually have greedy_realloc to wrap realloc. Using it will simplify things > a bit. Sure, attached. >From 29a852ffa7f7084da1edd8c757092417abc5b675 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Wed, 24 Apr 201

Re: [systemd-devel] systemd-coredump large memory allocation

2013-04-24 Thread Colin Walters
On Wed, 2013-04-24 at 21:53 +0200, Umut Tezduyar wrote: > Hi, > > > Thank you for doing this before me. > > > We do not log anything but call log_oom() if realloc() fails. I was > wondering if we should do best effort and write what ever we have read > up to the failed realloc(). That's not li

Re: [systemd-devel] systemd-coredump large memory allocation

2013-04-24 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 24, 2013 at 02:41:05PM -0400, Colin Walters wrote: > On Wed, 2013-04-24 at 16:22 +0200, Lennart Poettering wrote: > > > Happy to take a patch that turns this into a realloc() loop. > > Attached. Booted and tested in gnome-ostree. > > From 6c11bcf7c151dfa8511aab0dd6e545572a7597ec Mo

[systemd-devel] [PATCH] journal: remove build warning when SELinux is disabled

2013-04-24 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman A small patch to remove a build warnining when SELinux is disabled. --- src/journal/journald-server.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/src/journal/journald-server.c +++ b/src/journal/journald-server.c @@ -508,7 +508,7 @@ static void dis

Re: [systemd-devel] systemd-coredump large memory allocation

2013-04-24 Thread Umut Tezduyar
Hi, Thank you for doing this before me. We do not log anything but call log_oom() if realloc() fails. I was wondering if we should do best effort and write what ever we have read up to the failed realloc(). Maybe even append something like "... due to lack of memory, coredump is not complete". I

Re: [systemd-devel] [PATCH v2] systemd-python: attach fields to JournalHandler, add SYSLOG_IDENTIFIER

2013-04-24 Thread Steven Hiscocks
On 24/04/13 03:10, Zbigniew Jędrzejewski-Szmek wrote: Arbitrary fields can be attached at the level of the handler, and they'll be sent with all messages from this handler. This facility is used to attach SYSLOG_IDENTIFIER to all messages, since otherwise journald attaches SYSLOG_IDENTIFIER=pyth

Re: [systemd-devel] systemd-coredump large memory allocation

2013-04-24 Thread Colin Walters
On Wed, 2013-04-24 at 16:22 +0200, Lennart Poettering wrote: > Happy to take a patch that turns this into a realloc() loop. Attached. Booted and tested in gnome-ostree. >From 6c11bcf7c151dfa8511aab0dd6e545572a7597ec Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Wed, 24 Apr 2013 14:17:03 -

Re: [systemd-devel] [PATCH] systemd: record the userspace timestamp early

2013-04-24 Thread Harald Hoyer
On 04/24/2013 05:19 PM, [email protected] wrote: > From: Harald Hoyer > > The time for systemd initialization and selinux policy loading > is accounted to the initrd or the kernel, which is wrong. > > Instead of: > > Startup finished in 5.559s (firmware) + 36ms (loader) + 665ms (kernel) + > 975

[systemd-devel] [PATCH] systemd: record the userspace timestamp early

2013-04-24 Thread harald
From: Harald Hoyer The time for systemd initialization and selinux policy loading is accounted to the initrd or the kernel, which is wrong. Instead of: Startup finished in 5.559s (firmware) + 36ms (loader) + 665ms (kernel) + 975ms (initrd) + 1.410s (userspace) = 8.647s the more correct output

[systemd-devel] [RFC PATCH] logs-show: print multiline messages

2013-04-24 Thread Zbigniew Jędrzejewski-Szmek
[0.019862] fedora kernel: CPU0: Thermal monitoring enabled (TM1) [0.019900] fedora kernel: Last level iTLB entries: 4KB 512, 2MB 0, 4MB 0 Last level dTLB entries: 4KB 512, 2MB 32, 4MB 32 tlb_flushall_shift: 5 [0.020118] fedora

Re: [systemd-devel] disabling shared mount propagation

2013-04-24 Thread Lennart Poettering
On Tue, 23.04.13 21:51, Albert Strasheim ([email protected]) wrote: > What is the recommended way to do this during early boot? Was the > fstab way of doing it (mentioned in the Git commit message) ever > implemented? Karel added that in the very latest util-linux: http://karelzak.blogspot.com.b

Re: [systemd-devel] systemd-coredump large memory allocation

2013-04-24 Thread Lennart Poettering
On Wed, 24.04.13 15:00, Umut Tezduyar ([email protected]) wrote: > Hi, > > systemd-coredump allocates 768 mb heap memory to store the core dump. Is it > really the right way? > > Commit: 41be2ca14d34b67776240bc67facf341b156b974 > > 768 mb is pretty big in 32 bit address space. I have roughly 1.

[systemd-devel] [PATCH V3] systemd-analyse: add "critical-chain" command

2013-04-24 Thread harald
From: Harald Hoyer "critical-chain" prints a tree of the critical chain of units $ ./systemd-analyze critical-chain graphical.target @1.226s └─multi-user.target @1.226s └─nfs-lock.service @961ms +265ms └─rpcbind.service @958ms +1ms └─network.target @957ms └─NetworkManager.ser

[systemd-devel] [PATCH] dbus-execute: fix introspection

2013-04-24 Thread Ronny Chevalier
Hi, Add missing property and remove duplicate properties already in src/core/dbus-kill.h Best regards, Ronny. --- src/core/dbus-execute.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/dbus-execute.h b/src/core/dbus-execute.h index eaa1b73..b9cc13c 100644 --- a/sr

[systemd-devel] systemd-coredump large memory allocation

2013-04-24 Thread Umut Tezduyar
Hi, systemd-coredump allocates 768 mb heap memory to store the core dump. Is it really the right way? Commit: 41be2ca14d34b67776240bc67facf341b156b974 768 mb is pretty big in 32 bit address space. I have roughly 1.6 gb between beginning of the heap and the first shared library so I have enough a

Re: [systemd-devel] Session problems

2013-04-24 Thread Harald Hoyer
On 04/24/2013 09:37 AM, Harald Hoyer wrote: > Starting with commit ae018d9bc900d6355dea4af05119b49c67945184 a lot of > session problems occur for me. > Any idea? > > systemd-logind[280]: New session 1 of user harald. > systemd-logind[280]: Linked /tmp/.X11-unix/X0 to /run/user/1000/X11-display. >

Re: [systemd-devel] "systemctl enable" does not report all actions

2013-04-24 Thread Ross Lagerwall
On Wed, Apr 24, 2013 at 11:18:15AM +0200, Harald Hoyer wrote: > # systemctl disable foo.service bar.service > # systemctl enable foo.service > > ... reboot ... > > # cp /lib/systemd/system/foo.service /etc/systemd/system/foo.service > # vi /etc/systemd/system/foo.service > > .. admin forgets, th

Re: [systemd-devel] "systemctl enable" does not report all actions

2013-04-24 Thread Colin Guthrie
'Twas brillig, and Harald Hoyer at 24/04/13 10:18 did gyre and gimble: > "Failed to issue method call: File exists" Even I haven't understood > this > error message, without looking in the code!! I get a lot of comments like this too... making this error better would be a definite plus. Even th

[systemd-devel] "systemctl enable" does not report all actions

2013-04-24 Thread Harald Hoyer
# systemctl disable foo.service bar.service # systemctl enable foo.service ... reboot ... # cp /lib/systemd/system/foo.service /etc/systemd/system/foo.service # vi /etc/systemd/system/foo.service .. admin forgets, that the old foo.service is already enabled. # systemctl enable foo.service bar.s

Re: [systemd-devel] disabling shared mount propagation

2013-04-24 Thread Thomas Bächler
Am 23.04.2013 21:51, schrieb Albert Strasheim: > is causing some headaches with some services of ours that use unshare > to get a new mount namespace and make some private mounts which we > don't want propagated. Proper solution: Directly after the unshare, run either mount("none", "/", "none",

[systemd-devel] Session problems

2013-04-24 Thread Harald Hoyer
Starting with commit ae018d9bc900d6355dea4af05119b49c67945184 a lot of session problems occur for me. Any idea? systemd-logind[280]: New session 1 of user harald. systemd-logind[280]: Linked /tmp/.X11-unix/X0 to /run/user/1000/X11-display. gdm-autologin][376]: pam_unix(gdm-autologin:session): ses