[systemd-devel] [PATCH] Always use our own MAX/MIN definitions

2013-03-31 Thread Cristian Rodríguez
code in src/shared/macro.h only defined MAX/MIN in case they were not defined previously. however the MAX/MIN macros implemented in glibc are not of the "safe" kind but defined as: define MIN(a,b) (((a)<(b))?(a):(b)) define MAX(a,b) (((a)>(b))?(a):(b)) Avoid nasty side effects by using our own ve

Re: [systemd-devel] snapshots not isolatable?

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 29, 2013 at 05:55:59PM +0100, Lennart Poettering wrote: > On Fri, 29.03.13 23:42, Sun Bing ([email protected]) wrote: > > > hi all, > > > > i wanna try out the systemd.snapshots for my suspend/hibernation > > configuration. but it seems the snapshots are not isolatable.

Re: [systemd-devel] [PATCH] Add AllowIsolate=yes to snapshots

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 31, 2013 at 02:40:04PM +0300, Oleksii Shevchuk wrote: > --- > TODO| 2 -- > src/core/snapshot.c | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) Applied. Zbyszek ___ systemd-devel mailing list [email protected]

Re: [systemd-devel] [PATCH v2 2/2] cryptsetup: add RequiresMountsFor for keyfile

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 29, 2013 at 10:01:12PM +, Thomas Weißschuh wrote: > This ensures that the keyfile is available during the opening of the encrypted > device. > > Also dropped the explicit ordering Before=local-fs.target, as the containers > are ordered implicitly by their content. Applied both. Zb

Re: [systemd-devel] [PATCH] cgtop: Add cpu time opt and become stdout sensitive

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 31, 2013 at 08:22:05PM +0200, Umut Tezduyar wrote: > --- > src/cgtop/cgtop.c | 108 > - > 1 files changed, 74 insertions(+), 34 deletions(-) > > diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c > index eebebf0..0ef4fcc 100644 > -

Re: [systemd-devel] [PATCH] [RFCv2] Introspect and monitor dropin configuration

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 31, 2013 at 06:53:54PM +0300, Oleksii Shevchuk wrote: > --- > src/core/dbus-unit.c | 1 + > src/core/load-dropin.c | 60 > ++ > src/core/load-dropin.h | 1 + > src/core/unit.c| 32 ++- > src/core/unit.

Re: [systemd-devel] [PATCH] [RFCv2] Add drop-in support for [Install] section

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 31, 2013 at 06:30:40PM +0300, Oleksii Shevchuk wrote: > > unit_load_dropin does also a loop over aliases (SET_FOREACH(t, u->names, > > i)). > > unit_load_dropin_file does not. Isn't this an ommision? > > We don't do that for [Install] anyway Isn't this a bug? Zbyszek

Re: [systemd-devel] [PATCH] [RFC] Show listen addresses in status output

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 01, 2013 at 12:09:50AM +0300, Oleksii Shevchuk wrote: > --- > src/systemctl/systemctl.c | 35 +++ > 1 file changed, 35 insertions(+) > > diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c > index 328b91b..0ad5112 100644 > --- a/src/syste

Re: [systemd-devel] [PATCH] Add Listen* to dbus properties

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 31, 2013 at 06:23:24PM +0300, Oleksii Shevchuk wrote: > --- > src/core/dbus-socket.c | 54 > ++ > 1 file changed, 54 insertions(+) > > diff --git a/src/core/dbus-socket.c b/src/core/dbus-socket.c > index 2092a63..1dfac6d 100644 > --- a/

Re: [systemd-devel] [HEADSUP] New module ‘libc’ in systemd git

2013-03-31 Thread Jon Stanley
On Sun, Mar 31, 2013 at 8:22 PM, Lennart Poettering wrote: > We figured to complete the systemd project we were still lacking an > email program[1] An email program? A web browser immediately strikes me as more important than an email program. That should be our first effort. Of course, an email

[systemd-devel] [HEADSUP] New module ‘libc’ in systemd git

2013-03-31 Thread Lennart Poettering
Heya, I just added a new module to systemd git, “libc”, and you are probably wondering what that is about. Here’s a quick overview over what this is and our plans with it. We figured to complete the systemd project we were still lacking an email program[1]. In order to get this off the ground qui

[systemd-devel] [PATCH] [RFC] Show listen addresses in status output

2013-03-31 Thread Oleksii Shevchuk
--- src/systemctl/systemctl.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 328b91b..0ad5112 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -2254,6 +2254,7 @@ typedef s

[systemd-devel] [PATCH] cgtop: Add cpu time opt and become stdout sensitive

2013-03-31 Thread Umut Tezduyar
--- src/cgtop/cgtop.c | 108 - 1 files changed, 74 insertions(+), 34 deletions(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index eebebf0..0ef4fcc 100644 --- a/src/cgtop/cgtop.c +++ b/src/cgtop/cgtop.c @@ -69,6 +69,11 @@ static enum {

[systemd-devel] [PATCH] [RFCv2] Introspect and monitor dropin configuration

2013-03-31 Thread Oleksii Shevchuk
--- src/core/dbus-unit.c | 1 + src/core/load-dropin.c | 60 ++ src/core/load-dropin.h | 1 + src/core/unit.c| 32 ++- src/core/unit.h| 2 ++ 5 files changed, 76 insertions(+), 20 deletions(-) diff --git

Re: [systemd-devel] [PATCH] [RFCv2] Add drop-in support for [Install] section

2013-03-31 Thread Oleksii Shevchuk
> unit_load_dropin does also a loop over aliases (SET_FOREACH(t, u->names, i)). > unit_load_dropin_file does not. Isn't this an ommision? We don't do that for [Install] anyway ___ systemd-devel mailing list [email protected] http://list

[systemd-devel] [PATCH] Add Listen* to dbus properties

2013-03-31 Thread Oleksii Shevchuk
--- src/core/dbus-socket.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/src/core/dbus-socket.c b/src/core/dbus-socket.c index 2092a63..1dfac6d 100644 --- a/src/core/dbus-socket.c +++ b/src/core/dbus-socket.c @@ -63,6 +63,10 @@ "

Re: [systemd-devel] [PATCH] [RFC] Introspect and monitor dropin configuration

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 31, 2013 at 04:52:54PM +0300, Oleksii Shevchuk wrote: > --- > src/core/dbus-unit.c | 1 + > src/core/load-dropin.c | 60 > ++ > src/core/load-dropin.h | 1 + > src/core/unit.c| 21 ++ > src/core/unit.h

Re: [systemd-devel] [PATCH] [RFCv2] Add drop-in support for [Install] section

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 31, 2013 at 02:46:58PM +0300, Oleksii Shevchuk wrote: > > Can it be unified with unit_load_dropin()? > > I think it can't =\ > > Or unit_load_dropin will require full rewrite then. The main problem is > context: [Install] section processed in code that can be runned without > systemd

Re: [systemd-devel] persistent changes to the serial console

2013-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 31, 2013 at 12:30:05PM +0400, Andrey Borzenkov wrote: > В Sat, 30 Mar 2013 11:34:08 + > Colin Guthrie пишет: > > > 'Twas brillig, and Lennart Poettering at 29/03/13 15:32 did gyre and gimble: > > > On Fri, 29.03.13 13:29, Andrey Borzenkov ([email protected]) wrote: > > > > > >>

[systemd-devel] [PATCH] [RFC] Introspect and monitor dropin configuration

2013-03-31 Thread Oleksii Shevchuk
--- src/core/dbus-unit.c | 1 + src/core/load-dropin.c | 60 ++ src/core/load-dropin.h | 1 + src/core/unit.c| 21 ++ src/core/unit.h| 2 ++ 5 files changed, 66 insertions(+), 19 deletions(-) diff --git a/src/cor

Re: [systemd-devel] [PATCH] [RFCv2] Add drop-in support for [Install] section

2013-03-31 Thread Oleksii Shevchuk
> Can it be unified with unit_load_dropin()? I think it can't =\ Or unit_load_dropin will require full rewrite then. The main problem is context: [Install] section processed in code that can be runned without systemd daemon (src/shared).. ___ systemd-d

[systemd-devel] [PATCH] Add AllowIsolate=yes to snapshots

2013-03-31 Thread Oleksii Shevchuk
--- TODO| 2 -- src/core/snapshot.c | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/TODO b/TODO index 3bf442b..584646b 100644 --- a/TODO +++ b/TODO @@ -47,8 +47,6 @@ Fedora 19: Features: -* snapshots really should be isolatable, but currently aren't. - *

Re: [systemd-devel] [PATCH] [RFCv2] Add drop-in support for [Install] section

2013-03-31 Thread Andrey Borzenkov
В Sun, 31 Mar 2013 14:16:45 +0300 Oleksii Shevchuk пишет: > --- > src/shared/install.c | 55 > +--- > 1 file changed, 52 insertions(+), 3 deletions(-) > > diff --git a/src/shared/install.c b/src/shared/install.c > index 2555a36..2f3ce7f 100644 >

[systemd-devel] [PATCH] [RFCv2] Add drop-in support for [Install] section

2013-03-31 Thread Oleksii Shevchuk
--- src/shared/install.c | 55 +--- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/src/shared/install.c b/src/shared/install.c index 2555a36..2f3ce7f 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -983,7 +983,51 @@ st

[systemd-devel] [PATCH] [RFC] Add drop-in support for [Install] section

2013-03-31 Thread Oleksii Shevchuk
--- src/shared/install.c | 54 +--- 1 file changed, 51 insertions(+), 3 deletions(-) diff --git a/src/shared/install.c b/src/shared/install.c index 2555a36..001b265 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -983,7 +983,50 @@ st

Re: [systemd-devel] persistent changes to the serial console

2013-03-31 Thread Andrey Borzenkov
В Sat, 30 Mar 2013 11:34:08 + Colin Guthrie пишет: > 'Twas brillig, and Lennart Poettering at 29/03/13 15:32 did gyre and gimble: > > On Fri, 29.03.13 13:29, Andrey Borzenkov ([email protected]) wrote: > > > >> [email protected] is used only as template, and it looks like > >> getty-ge