Re: [systemd-devel] The enum udev_monitor_netlink_group contains bit masks

2013-03-12 Thread Andrey Wagin
2013/3/13 Kay Sievers > On Tue, Mar 12, 2013 at 9:35 PM, Andrey Wagin wrote: > > According to netlink(7) nl_groups is a bit mask with every bit > representing > > a netlink group number. > > Netlink uses "numbers" not "a mask" since many years, we have just a > 32bit number, not 32 groups today.

Re: [systemd-devel] [PATCH] man: Document the actual behaviour of ExecStopPost

2013-03-12 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 13, 2013 at 12:43:40PM +0800, Mathieu Bridon wrote: > The documentation makes it sound like ExecStopPost is only run when > stopping the service with `systemctl stop foo.service` > > However, that is not the case, as it also gets run when the service > unexpectedly exists, crashes, or

[systemd-devel] [PATCH] man: Document the actual behaviour of ExecStopPost

2013-03-12 Thread Mathieu Bridon
The documentation makes it sound like ExecStopPost is only run when stopping the service with `systemctl stop foo.service` However, that is not the case, as it also gets run when the service unexpectedly exists, crashes, or gets SIGKILLed. --- man/systemd.service.xml | 9 ++--- 1 file changed

Re: [systemd-devel] Underlinking in libsystemd-login

2013-03-12 Thread Canek Peláez Valdés
On Tue, Mar 12, 2013 at 9:08 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Mar 11, 2013 at 03:25:48PM +0100, Lennart Poettering wrote: >> On Sun, 10.03.13 11:29, Canek Peláez Valdés ([email protected]) wrote: >> >> > In Gentoo we are seeing the following failure with programs linking >> > agains

Re: [systemd-devel] Underlinking in libsystemd-login

2013-03-12 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 11, 2013 at 03:25:48PM +0100, Lennart Poettering wrote: > On Sun, 10.03.13 11:29, Canek Peláez Valdés ([email protected]) wrote: > > > In Gentoo we are seeing the following failure with programs linking > > agains libsystemd-login, they all fail with: > > > > /usr/lib64/libsystemd-logi

[systemd-devel] [PATCH 3/3] unit: do not start Requisite units retroactively

2013-03-12 Thread Michal Schmidt
Activating Requisite units goes against the reason of existence of this dependency type. --- src/core/unit.c | 4 1 file changed, 4 deletions(-) diff --git a/src/core/unit.c b/src/core/unit.c index d1f109d..25109ce 100644 --- a/src/core/unit.c +++ b/src/core/unit.c @@ -1237,10 +1237,6 @@ sta

[systemd-devel] [PATCH 2/3] unit: do not care if order isn't right when retroactively starting deps

2013-03-12 Thread Michal Schmidt
Attempt to satisfy requirement dependencies retroactively even if the unexpectedly activated unit would prefer to be started After them. This way remote-fs-pre.target can be pulled in by performing a manual mount (the mount units have both Wants= and After= remote-fs-pre.target). --- src/core/uni

[systemd-devel] [PATCH 1/3] Revert "remote-fs.target: want remote-fs-pre.target"

2013-03-12 Thread Michal Schmidt
This reverts commit 6bde0b3220e95a08cefb70846f73b2cf24b7734a. remote-fs.target is usually enabled whether there are any remote mounts in fstab or not. remote-fs-pre.target pulls in NetworkManager-wait-online.service. => The commit caused NM-w-o to be pulled into boot. Let's fix the problem of t

[systemd-devel] [PATCH 0/3] alternative fix for manual mounts shutdown ordering

2013-03-12 Thread Michal Schmidt
Harald's patch "remote-fs.target: want remote-fs-pre.target" fixed the problem with shutdown ordering of manually mounted network filesystems, but it also caused NetworkManager-wait-online.service to be pulled in needlessly when no network mounts are used. I said on IRC that I intended to revert t

Re: [systemd-devel] [PATCH] shutdown: move attribute packed to the end of the declaration, so it is not ignored

2013-03-12 Thread Kay Sievers
On Tue, Mar 12, 2013 at 6:32 PM, Michal Sekletar wrote: > --- > src/systemd/sd-shutdown.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied. Thanks, Kay ___ systemd-devel mailing list [email protected] http://lists.

Re: [systemd-devel] Disconnect while running journalctl on F17

2013-03-12 Thread Kay Sievers
On Tue, Mar 12, 2013 at 8:47 PM, David Strauss wrote: > We're repeatedly seeing an issue where "journalctl -f" seems to lose > its journal "connection" and show no new output. Ctrl-C exits the > hanging trace normally, and re-running "journalctl -f" gets it back to > showing new data. > > Is this

Re: [systemd-devel] The enum udev_monitor_netlink_group contains bit masks

2013-03-12 Thread Kay Sievers
On Tue, Mar 12, 2013 at 9:35 PM, Andrey Wagin wrote: > According to netlink(7) nl_groups is a bit mask with every bit representing > a netlink group number. Netlink uses "numbers" not "a mask" since many years, we have just a 32bit number, not 32 groups today. The man page should really be update

[systemd-devel] [PATCH] smack_setup: enable Smack/CIPSO mapping

2013-03-12 Thread Nathaniel Chen
CIPSO is the Common IP Security Option, an IETF standard for setting security levels for a process sending packets. In Smack kernels, CIPSO headers are mapped to Smack labels automatically, but can be changed. This patch writes label/category mappings from /etc/smack/cipso/ to /sys/fs/smackfs/cips

[systemd-devel] The enum udev_monitor_netlink_group contains bit masks

2013-03-12 Thread Andrey Wagin
Hello, According to netlink(7) nl_groups is a bit mask with every bit representing a netlink group number. I found that constants from udev_monitor_netlink_group are set directly to nl_groups. It's dangerous. Currently this enum contains only three constant and all is ok, but the next constant wi

[systemd-devel] Disconnect while running journalctl on F17

2013-03-12 Thread David Strauss
We're repeatedly seeing an issue where "journalctl -f" seems to lose its journal "connection" and show no new output. Ctrl-C exits the hanging trace normally, and re-running "journalctl -f" gets it back to showing new data. Is this a known issue on the journal released for F17 systems? -- David

[systemd-devel] [PATCH 2/2] mount: fix network umounts of manual remote-fs mounts

2013-03-12 Thread harald
From: Harald Hoyer Revert 6bde0b3, which pulls in remote-fs-pre.target and with this i.e. NetworkManager-wait-online.service. Solve the remote-fs problem with using "PartOf". remote-fs.target is part of multi-user.target, and therefore active by default. By using UNIT_PART_OF from remote fs mou

[systemd-devel] [PATCH 1/2] add initrd-fs.target and root-fs.target

2013-03-12 Thread harald
From: Harald Hoyer Instead of using local-fs*.target in the initrd, use root-fs.target for sysroot.mount and initrd-fs.target for /sysroot/usr and friends. Using local-fs.target would mean to carry over the activated local-fs.target to the isolated initrd-switch-root.target and thus in the real

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Colin Walters
On Tue, 2013-03-12 at 15:14 +0100, Michal Sekletar wrote: > install-directories-hook: > $(MKDIR_P) $(addprefix $(DESTDIR),$(INSTALL_DIRS)) > + $(MKDIR_P) -m 000 $(addprefix $(DESTDIR),$(INACCESSIBLE_DIR)) Ugh. Can you make this /run/systemd/inaccessible or something, and have systemd

[systemd-devel] [PATCH] shutdown: move attribute packed to the end of the declaration, so it is not ignored

2013-03-12 Thread Michal Sekletar
--- src/systemd/sd-shutdown.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/systemd/sd-shutdown.h b/src/systemd/sd-shutdown.h index cee4350..b8f6a48 100644 --- a/src/systemd/sd-shutdown.h +++ b/src/systemd/sd-shutdown.h @@ -37,7 +37,7 @@ typedef enum sd_shutdown_mode

Re: [systemd-devel] [PATCH] mount: fix network umounts

2013-03-12 Thread Harald Hoyer
Am 08.03.2013 19:18, schrieb [email protected]: > From: Harald Hoyer > > Now works as expected for me. > > $ mount 192.168.2.2:/Public /mnt/test > $ systemctl status mnt-test.mount > mnt-test.mount - /mnt/test > Loaded: loaded (/proc/self/mountinfo) > Active: active (mounted) sin

[systemd-devel] [PATCH] systemctl: remove unused variable

2013-03-12 Thread Michal Sekletar
--- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 4a55c56..b5902e6 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -2053,7 +2053,7 @@ static int set_cgroup_attr(DBu

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself in addition to systemd-tmpfiles. Directory which is mounted as inaccessible is shared and created at install ti

Re: [systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-12 Thread Harald Hoyer
Am 08.03.2013 15:13, schrieb Michal Sekletar: > We should not try to get information about mount unit from fragment > if the unit was created because of /proc/self/mountinfo event. > --- > src/core/mount.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/core/moun

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Michal Sekletar
Thank you for the review! It is very appreciated. Michal ___ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 12, 2013 at 03:14:49PM +0100, Michal Sekletar wrote: > All Execs within the service, will get mounted the same /tmp and /var/tmp > directories, if service is configured with PrivateTmp=yes. Temporary > directories are cleaned up by service itself, rather than relying on > systemd-tmpfil

Re: [systemd-devel] [PATCH] systemctl: fix variable initialization

2013-03-12 Thread Michal Sekletar
Hi Zbyszek, > Hi, > > that's not necessary, it's initialized right below the assert > statements. I know it is initialized right after asserts, however we tend to initialize vars witch are marked for auto-cleanup with NULL. So I thought it would be good to do it here too, since it doesn't hurt

Re: [systemd-devel] [PATCH] systemctl: fix variable initialization

2013-03-12 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 12, 2013 at 03:34:26PM +0100, Michal Sekletar wrote: > --- > src/systemctl/systemctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c > index 4a55c56..db12255 100644 > --- a/src/systemctl/systemctl.c > +++

[systemd-devel] [PATCH] systemctl: fix variable initialization

2013-03-12 Thread Michal Sekletar
--- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 4a55c56..db12255 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -1454,7 +1454,7 @@ static int start_unit_one(

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on systemd-tmpfiles. Directory which is mounted as inaccessible is shared, created at inst

Re: [systemd-devel] Hardware watchdog support, slug speed.

2013-03-12 Thread Lennart Poettering
On Tue, 12.03.13 00:45, Sébastien Luttringer ([email protected]) wrote: > > Humm the ioctl() is supposed to be cheap. And it is on all hw I have > > tested it with. It appears that ob the hw in question it is not so > > cheap, but that really sounds like a driver issue to me. > > Before everything,

Re: [systemd-devel] Hardware watchdog support, slug speed.

2013-03-12 Thread Lennart Poettering
On Tue, 12.03.13 00:53, Sébastien Luttringer ([email protected]) wrote: > > On Mon, Mar 11, 2013 at 11:57 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Mon, Mar 11, 2013 at 11:46:55PM +0100, Lennart Poettering wrote: > >> On Mon, 11.03.13 23:42, Zbigniew Jędrzejewski-Szmek ([email protected]) >

Re: [systemd-devel] switch-root and local-fs.target

2013-03-12 Thread Lennart Poettering
On Tue, 12.03.13 10:05, Harald Hoyer ([email protected]) wrote: > We have a big problem now with local-fs.target in the > initrd-switch-root.target > now. Because local-fs.target is active now after > serialization/deserialization, > the whole boot process after the switch-root is screwed.

Re: [systemd-devel] allow a group to set datetime with timedatectrl

2013-03-12 Thread Mantas Mikulėnas
On Tue, Mar 12, 2013 at 11:52 AM, Andreas Müller wrote: > Hi, > > I know it is more a dbus-issue and an experts-LOL but maybe somebody > can help me here: I would like to have a group which is permitted to > set datetime with timedatectrl. What I did: > > As root > 1. groupadd -r datetime > 2. use

Re: [systemd-devel] [PATCH V3] core: do not serialize targets on switch-root

2013-03-12 Thread Harald Hoyer
Am 12.03.2013 13:04, schrieb [email protected]: > From: Harald Hoyer > > Targets in the initrd can differ from targets on the switched root. > > Do not assume these targets are active. > --- > src/core/main.c| 8 > src/core/manager.c | 9 ++--- > src/core/manager.h | 2 +- > 3

[systemd-devel] [PATCH V3] core: do not serialize targets on switch-root

2013-03-12 Thread harald
From: Harald Hoyer Targets in the initrd can differ from targets on the switched root. Do not assume these targets are active. --- src/core/main.c| 8 src/core/manager.c | 9 ++--- src/core/manager.h | 2 +- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/co

[systemd-devel] [PATCH V2] core: do not serialize targets on switch-root

2013-03-12 Thread harald
From: Harald Hoyer Targets in the initrd can differ from targets on the switched root. Do not assume these targets are active. --- src/core/main.c| 8 src/core/manager.c | 9 ++--- src/core/manager.h | 2 +- src/core/unit.c| 4 ++-- src/core/unit.h| 2 +- 5 files change

Re: [systemd-devel] [PATCH] transaction: if a job wants to be started before a target, set the target dead

2013-03-12 Thread Harald Hoyer
Am 12.03.2013 10:51, schrieb [email protected]: > From: Harald Hoyer > > Not sure, if this is the correct place to enforce this, but it seems to > work. > --- > src/core/transaction.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/core/transaction.c b/src/core/transaction.c

[systemd-devel] allow a group to set datetime with timedatectrl

2013-03-12 Thread Andreas Müller
Hi, I know it is more a dbus-issue and an experts-LOL but maybe somebody can help me here: I would like to have a group which is permitted to set datetime with timedatectrl. What I did: As root 1. groupadd -r datetime 2. usermod -a -G datetime operator 4. In '/etc/dbus-1/system.d/org.freedesktop.

[systemd-devel] [PATCH] transaction: if a job wants to be started before a target, set the target dead

2013-03-12 Thread harald
From: Harald Hoyer Not sure, if this is the correct place to enforce this, but it seems to work. --- src/core/transaction.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/core/transaction.c b/src/core/transaction.c index 4a8d90e..3fed57a 100644 --- a/src/core/transaction.c +++ b/

Re: [systemd-devel] switch-root and local-fs.target

2013-03-12 Thread Tom Gundersen
On Mar 12, 2013 6:05 PM, "Harald Hoyer" wrote: > > We have a big problem now with local-fs.target in the initrd-switch-root.target > now. Because local-fs.target is active now after serialization/deserialization, > the whole boot process after the switch-root is screwed. All units depending on > l

[systemd-devel] [PATCH] core: do not serialize targets on switch-root

2013-03-12 Thread harald
From: Harald Hoyer Targets in the initrd can differ from targets on the switched root. Do not assume these targets are active. --- src/core/main.c| 8 src/core/manager.c | 6 +++--- src/core/manager.h | 2 +- src/core/unit.c| 7 +-- src/core/unit.h| 2 +- 5 files change

[systemd-devel] switch-root and local-fs.target

2013-03-12 Thread Harald Hoyer
We have a big problem now with local-fs.target in the initrd-switch-root.target now. Because local-fs.target is active now after serialization/deserialization, the whole boot process after the switch-root is screwed. All units depending on local-fs.target are started now immediately!! Solutions I