Re: [systemd-devel] [PATCH] do not ellipsize cgroup members in full status

2013-01-15 Thread Lennart Poettering
On Tue, 15.01.13 10:58, Lukáš Nykrýn ([email protected]) wrote: Heya, > diff --git a/src/shared/output.h b/src/shared/output.h > new file mode 100644 > index 000..0efd430 > --- /dev/null > +++ b/src/shared/output.h "output.h" is a bit too generic for my test, maybe a better name would be ou

Re: [systemd-devel] [PATCH] continuation support in envinronment files

2013-01-15 Thread Lennart Poettering
On Fri, 11.01.13 15:03, Michal Vyskocil ([email protected]) wrote: Minor nitpick: > +if (endswith(p, "\\")) { > +*(p+strlen(p)-1) = '\0'; > + > +if (!(c = strappend(b, p))) { For new code we prefer ... c = strappe

Re: [systemd-devel] [PATCH] nspawn: document how to enter the namespace

2013-01-15 Thread Lennart Poettering
On Sat, 12.01.13 16:55, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > systemd-nspawn will now print the PID of the child. > --- > To be applied after Linux 3.8 is released and after util-linux > decided on the interface to setns(). Current unshare invocation > is ugly and unwieldy. A se

Re: [systemd-devel] [systemd-commits] TODO

2013-01-15 Thread Lennart Poettering
On Fri, 11.01.13 21:16, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote: > > I mean, we have a huge amount of docs now, I somehow think that merging > > that all into one gigantic file doesn't really scale and just creates > > noise (i.e. why would you want systemd-delta's man page in your d

Re: [systemd-devel] [PATCH 3/3] bootchart: Convert malloc/memset to calloc.

2013-01-15 Thread Lennart Poettering
On Wed, 16.01.13 00:17, Jan Engelhardt ([email protected]) wrote: > On Tuesday 2013-01-15 20:47, Lennart Poettering wrote: > >> --- a/src/bootchart/bootchart.c > >> +++ b/src/bootchart/bootchart.c > >> @@ -232,12 +232,11 @@ int main(int argc, char *argv[]) > >> } > >> > >> /* sta

Re: [systemd-devel] [PATCH 3/3] bootchart: Convert malloc/memset to calloc.

2013-01-15 Thread Jan Engelhardt
On Tuesday 2013-01-15 20:47, Lennart Poettering wrote: >> --- a/src/bootchart/bootchart.c >> +++ b/src/bootchart/bootchart.c >> @@ -232,12 +232,11 @@ int main(int argc, char *argv[]) >> } >> >> /* start with empty ps LL */ >> -ps_first = malloc(sizeof(struct ps_struct))

Re: [systemd-devel] [PATCH] journalctl: quit on I/O error

2013-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 15, 2013 at 09:36:17PM +0100, David Herrmann wrote: > Hi Zbigniew > > On Tue, Jan 15, 2013 at 9:02 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Tue, Jan 15, 2013 at 08:59:28PM +0100, Lennart Poettering wrote: > >> On Sun, 13.01.13 12:28, David Herrmann ([email protected])

Re: [systemd-devel] [PATCH] journalctl: quit on I/O error

2013-01-15 Thread David Herrmann
Hi Zbigniew On Tue, Jan 15, 2013 at 9:02 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Jan 15, 2013 at 08:59:28PM +0100, Lennart Poettering wrote: >> On Sun, 13.01.13 12:28, David Herrmann ([email protected]) wrote: >> >> > This makes journalctl quit on ferror() conditions on stdout.

Re: [systemd-devel] [PATCH] journalctl: quit on I/O error

2013-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 15, 2013 at 08:59:28PM +0100, Lennart Poettering wrote: > On Sun, 13.01.13 12:28, David Herrmann ([email protected]) wrote: > > > This makes journalctl quit on ferror() conditions on stdout. It fixes an > > annoying bug if you pipe its output through 'less' and press 'q'. With

Re: [systemd-devel] [PATCH] core: do not make sockets dependent on lo

2013-01-15 Thread Lennart Poettering
On Sat, 12.01.13 23:05, Michał Bartoszkiewicz ([email protected]) wrote: > /sys/subsystem/net/devices/lo is never considered active, so sockets > with BindToDevice=lo would never be activated. Makes sense. Applied. > --- > src/core/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [systemd-devel] [PATCH] journalctl: quit on I/O error

2013-01-15 Thread Lennart Poettering
On Sun, 13.01.13 12:28, David Herrmann ([email protected]) wrote: > This makes journalctl quit on ferror() conditions on stdout. It fixes an > annoying bug if you pipe its output through 'less' and press 'q'. Without > this fix journalctl will continue reading all journal data until EOF w

Re: [systemd-devel] [PATCH 2/2] logind: remove unused variable

2013-01-15 Thread Lennart Poettering
On Fri, 11.01.13 17:06, Michal Sekletar ([email protected]) wrote: Applied both! > --- > src/login/logind-session.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/login/logind-session.c b/src/login/logind-session.c > index b64a5d3..b981e14 100644 > --- a/src/lo

Re: [systemd-devel] [PATCH 3/3] bootchart: Convert malloc/memset to calloc.

2013-01-15 Thread Lennart Poettering
On Thu, 10.01.13 11:35, Auke Kok ([email protected]) wrote: Heya, just a few notes. > --- > src/bootchart/bootchart.c | 5 ++--- > src/bootchart/log.c | 10 -- > 2 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/src/bootchart/bootchart.c b/src/bootchart/boo

Re: [systemd-devel] systemd-analyze-197 broken

2013-01-15 Thread Kok, Auke-jan H
On Tue, Jan 15, 2013 at 9:46 AM, Peeters Simon wrote: > 2013/1/15 Peeters Simon : >> 2013/1/15 Colin Guthrie : >>> 'Twas brillig, and Kok, Auke-jan H at 14/01/13 23:55 did gyre and gimble: > > does systemd really need to introduce one 3rd party component > > after the next (libmicrohttpd a

Re: [systemd-devel] systemd-analyze-197 broken

2013-01-15 Thread Peeters Simon
2013/1/15 Peeters Simon : > 2013/1/15 Colin Guthrie : >> 'Twas brillig, and Kok, Auke-jan H at 14/01/13 23:55 did gyre and gimble: > does systemd really need to introduce one 3rd party component > after the next (libmicrohttpd as example) which will sooner > or later terrible break d

Re: [systemd-devel] [PATCH] do not ellipsize cgroup members in full status

2013-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 15, 2013 at 10:58:26AM +0100, Lukáš Nykrýn wrote: > Subject: [PATCH] systemctl,loginctl,cgls: do not ellipsize cgroup members > when --full is specified > > diff --git a/man/systemctl.xml b/man/systemctl.xml > index 2f33e0c..0289200 100644 > --- a/man/systemctl.xml > +++ b/man/systemc

Re: [systemd-devel] systemd-fstab-generator and multiple mounts to same mount point

2013-01-15 Thread Lennart Poettering
On Tue, 15.01.13 15:41, John Lane ([email protected]) wrote: > > On 04/01/13 02:56, Peeters Simon wrote: > > > >I think one of the only usecase for this kind of overmounting is to bind > >mount > >a subdir of a mountpoint on top of that mountpoint: (as in Johns original > >post) > >mount /de

[systemd-devel] [PATCH] fstab overmount

2013-01-15 Thread John Lane
--- src/core/mount.c | 13 +- src/fstab-generator/fstab-generator.c | 49 +-- 2 files changed, 47 insertions(+), 15 deletions(-) diff --git a/src/core/mount.c b/src/core/mount.c index 25bc7e1..8f35f68 100644 --- a/src/core/mount.c +++ b

Re: [systemd-devel] systemd-fstab-generator and multiple mounts to same mount point

2013-01-15 Thread John Lane
On 04/01/13 02:56, Peeters Simon wrote: I think one of the only usecase for this kind of overmounting is to bind mount a subdir of a mountpoint on top of that mountpoint: (as in Johns original post) mount /dev/somedev /images mount --bind /images/1354 /images so it might be a solution to add a

Re: [systemd-devel] systemd-analyze-197 broken

2013-01-15 Thread Peeters Simon
2013/1/15 Colin Guthrie : > 'Twas brillig, and Kok, Auke-jan H at 14/01/13 23:55 did gyre and gimble: >>> > does systemd really need to introduce one 3rd party component >>> > after the next (libmicrohttpd as example) which will sooner >>> > or later terrible break due incompatible changes in this

Re: [systemd-devel] Typo fix

2013-01-15 Thread Dave Reisner
On Tue, Jan 15, 2013 at 12:58:42PM +0200, Oleksii Shevchuk wrote: > diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c > index d56b4d6..66d031d 100644 > --- a/src/systemctl/systemctl.c > +++ b/src/systemctl/systemctl.c > @@ -1042,7 +1042,7 @@ static bool need_daemon_reload(DBusConne

[systemd-devel] Typo fix

2013-01-15 Thread Oleksii Shevchuk
diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index d56b4d6..66d031d 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -1042,7 +1042,7 @@ static bool need_daemon_reload(DBusConnection *bus, const char *unit) { /* We ignore all errors here, sinc

Re: [systemd-devel] systemd-analyze-197 broken

2013-01-15 Thread Colin Guthrie
'Twas brillig, and Kok, Auke-jan H at 14/01/13 23:55 did gyre and gimble: >> > does systemd really need to introduce one 3rd party component >> > after the next (libmicrohttpd as example) which will sooner >> > or later terrible break due incompatible changes in this minefiled > I don't think it's

Re: [systemd-devel] [PATCH] do not ellipsize cgroup members in full status

2013-01-15 Thread Lukáš Nykrýn
Lennart Poettering píše v Út 25. 09. 2012 v 17:45 +0200: > On Tue, 25.09.12 15:36, Lukáš Nykrýn ([email protected]) wrote: > > Heya, > > > diff --git a/src/shared/logs-show.h b/src/shared/logs-show.h > > index 3e6b6e0..3b63a5d 100644 > > --- a/src/shared/logs-show.h > > +++ b/src/shared/logs-sho

Re: [systemd-devel] systemd-analyze-197 broken

2013-01-15 Thread Koen Kooi
Op 15 jan. 2013, om 06:20 heeft "Kok, Auke-jan H" het volgende geschreven: > On Mon, Jan 14, 2013 at 8:21 PM, Holger Winkelmann > wrote: >> I'm just following this discussion and would ask the developer to keep the >> embedded folks in mind. Embedded systems hardly have all the dependencies