Re: [systemd-devel] [PATCH] Move path to the right to mitigate alignment issues with untruncated paths. Add --full option (like systemctl) to skip all truncation.

2012-07-25 Thread David Strauss
Sorry, looks like I stacked this on my other batch-friendliness patches. Happy to re-roll if that's an issue. On Wed, Jul 25, 2012 at 5:54 PM, wrote: > From: David Strauss > > --- > src/cgtop/cgtop.c | 35 --- > 1 file changed, 24 insertions(+), 11 deletions(-)

[systemd-devel] [PATCH] Move path to the right to mitigate alignment issues with untruncated paths. Add --full option (like systemctl) to skip all truncation.

2012-07-25 Thread david
From: David Strauss --- src/cgtop/cgtop.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index b4454c54..c3d2a28 100644 --- a/src/cgtop/cgtop.c +++ b/src/cgtop/cgtop.c @@ -67,6 +67,7 @@ static enum {

Re: [systemd-devel] [PATCH 2/2] Add a 'b' option to cgtop, equivalent to the same option in top.

2012-07-25 Thread David Strauss
Actually, the "continue" could probably get rolled into the else clause in the main loop. On Wed, Jul 25, 2012 at 4:33 PM, wrote: > From: David Strauss > > --- > src/cgtop/cgtop.c | 30 +++--- > 1 file changed, 23 insertions(+), 7 deletions(-) > > diff --git a/src/cgtop

[systemd-devel] [PATCH 2/2] Add a 'b' option to cgtop, equivalent to the same option in top.

2012-07-25 Thread david
From: David Strauss --- src/cgtop/cgtop.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index 70570a8..b4454c54 100644 --- a/src/cgtop/cgtop.c +++ b/src/cgtop/cgtop.c @@ -66,6 +66,8 @@ static enum {

[systemd-devel] [PATCH 1/2] Add an 'n' option to cgtop (equivalent to top).

2012-07-25 Thread david
From: David Strauss --- src/cgtop/cgtop.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index c3824c7..70570a8 100644 --- a/src/cgtop/cgtop.c +++ b/src/cgtop/cgtop.c @@ -55,6 +55,7 @@ typedef struct Group { }

Re: [systemd-devel] [PATCH] build-sys: really make gtk-doc optional & some portability fixes

2012-07-25 Thread Zbigniew Jędrzejewski-Szmek
On 07/25/2012 09:45 PM, Peeters Simon wrote: > 2012/7/25 Mantas Mikulėnas : >> The failing check caused autogen.sh to die mysteriously due to `set -e` >> and the unquoted `test -z $VAR`. >> >> Also, some syntax fixes to make it work with /bin/sh, which most other >> autogen.sh's use. Thanks, applie

Re: [systemd-devel] Question about mount unit generators

2012-07-25 Thread Zbigniew Jędrzejewski-Szmek
On 07/25/2012 08:28 PM, Manuel Amador (Rudd-O) wrote: > As you can tell from my code: > > https://github.com/Rudd-O/zfs/blob/master/systemd/systemd-zfs-generator.in > > I carefully calculate dependencies so the file systems are mounted in > the correct order. > > Now that fstab unit generation i

Re: [systemd-devel] mounting a UBIFS filesystem

2012-07-25 Thread Cliff Brake
OK, I figured out #3, it appears that soft links in a wants directory does the trick: ./sysinit.target.wants/cliff.mount -> ../cliff.mount ./sysinit.target.wants/dev-hugepages.mount -> ../dev-hugepages.mount ./sysinit.target.wants/dev-mqueue.mount -> ../dev-mqueue.mount ./sysinit.target.wants/sys-

Re: [systemd-devel] [PATCH] build-sys: really make gtk-doc optional & some portability fixes

2012-07-25 Thread Peeters Simon
2012/7/25 Mantas Mikulėnas : > The failing check caused autogen.sh to die mysteriously due to `set -e` > and the unquoted `test -z $VAR`. > > Also, some syntax fixes to make it work with /bin/sh, which most other > autogen.sh's use. > --- > autogen.sh | 17 - > 1 file changed, 8 in

[systemd-devel] [PATCH] build-sys: really make gtk-doc optional & some portability fixes

2012-07-25 Thread Mantas Mikulėnas
The failing check caused autogen.sh to die mysteriously due to `set -e` and the unquoted `test -z $VAR`. Also, some syntax fixes to make it work with /bin/sh, which most other autogen.sh's use. --- autogen.sh | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/au

[systemd-devel] mounting a UBIFS filesystem

2012-07-25 Thread Cliff Brake
Hello, I'm trying to figure out how to mount a UBI filesystem in systemd. One wrinkle is I need to run: ubiattach /dev/ubi_ctrl -m 6 before the file system is mounted. 1) what is the best way to run ubiattach? Should this be a service that runs first? 2) what is the best Before target to use

Re: [systemd-devel] [HEADSUP] fstab now parsed by generator in systemd git

2012-07-25 Thread Manuel Amador (Rudd-O)
> > Inotify? Calls systemd? Parses again? Dome already? In the above > > paragraph almost all wrong. > > Well, I did not check the code. But when the generator creates the > unit in /run, it must be notified somehow to systemd, no? Isn't it > inotify? Nothing gets notified at generator time. Gen

[systemd-devel] Question about mount unit generators

2012-07-25 Thread Manuel Amador (Rudd-O)
As you can tell from my code: https://github.com/Rudd-O/zfs/blob/master/systemd/systemd-zfs-generator.in I carefully calculate dependencies so the file systems are mounted in the correct order. Now that fstab unit generation is moving to a generator, I read the code in systemd.git. I discovered

Re: [systemd-devel] [PATCH] use "Out of memory." consistantly (or with "\n")

2012-07-25 Thread Lennart Poettering
On Wed, 25.07.12 11:24, Kay Sievers ([email protected]) wrote: Heya, > On Wed, Jul 25, 2012 at 6:12 AM, Shawn Landden wrote: > > glibc/glib both use "out of memory" consistantly so maybe we should > > consider that instead of this. > > > > Eliminates one string out of a number of binaries. Also fixe

Re: [systemd-devel] [PATCH] make-man-index.py: compatibility with Python 3

2012-07-25 Thread Kay Sievers
On Wed, Jul 25, 2012 at 1:59 AM, Mantas Mikulėnas wrote: > Despite its name, ElementTree.tostring() returns already-encoded > bytes() instead of a string in Python 3; sys.stdout doesn't like that. Applied. Thanks, Kay ___ systemd-devel mailing list sys

Re: [systemd-devel] [PATCH] use "Out of memory." consistantly (or with "\n")

2012-07-25 Thread Kay Sievers
On Wed, Jul 25, 2012 at 6:12 AM, Shawn Landden wrote: > glibc/glib both use "out of memory" consistantly so maybe we should > consider that instead of this. > > Eliminates one string out of a number of binaries. Also fixes extra newline > in udev/scsi_id Applied. Thanks, Kay

Re: [systemd-devel] [PATCH] service: allow service to inhibit respawn with special return code

2012-07-25 Thread Lukáš Nykrýn
Zbigniew Jędrzejewski-Szmek píše v St 25. 07. 2012 v 01:19 +0200: > On 07/24/2012 04:43 PM, Lukas Nykryn wrote: > > In some cases, like wrong configuration, restarting after error > > exit code does not help, so administrator can specify RestartIgnoreCodes > > which will not cause restart of a serv