Re: [systemd-devel] [PATCH 2/6] readahead-common:fs_on_ssd() stat might not get the real device name

2010-09-26 Thread Kay Sievers
On Mon, Sep 27, 2010 at 02:00, Lennart Poettering wrote: > On Fri, 24.09.10 12:22, Kay Sievers ([email protected]) wrote: > >> On Fri, Sep 24, 2010 at 12:06,   wrote: >> > From: Harald Hoyer >> > >> > btrfs returns a major(0) for its device, so try to find the mountpoint and >> > real device.

Re: [systemd-devel] Standard directory for shell scripts?

2010-09-26 Thread Kay Sievers
On Mon, Sep 27, 2010 at 02:30, Lennart Poettering wrote: > On Wed, 22.09.10 21:14, Wulf C. Krueger ([email protected]) wrote: >> Is there a consensus among distributions about a standard directory for shell >> scripts to be used with systemd? >> >> I've seen /lib/systemd/system/scripts being

Re: [systemd-devel] simple systemd boot status

2010-09-26 Thread Gustavo Sverzut Barbieri
On Sun, Sep 26, 2010 at 9:54 PM, Lennart Poettering wrote: > 1;2591;0cOn Tue, 21.09.10 23:39, Gustavo Sverzut Barbieri > ([email protected]) wrote: > >> Hi all, >> >> I've wrote a proof of concept of a simple boot status for systemd. >> Yeah, I know fedora folks have their super-duper plymo

Re: [systemd-devel] [PATCH] clarify message whe n unit action fails

2010-09-26 Thread Andrey Borzenkov
Mon, 27 Sep 2010 01:40:17 +0200 письмо от Lennart Poettering : > On Sun, 26.09.10 10:27, Andrey Borzenkov ([email protected]) wrote: > > > I was rather surprised to see "Starting of tmp.mount failed" > > during shutdown and spent some time searching for wrong dependencies > > until I realized t

Re: [systemd-devel] [PATCH] Allow disable of SysV init/rcN.d support at compile time

2010-09-26 Thread Lennart Poettering
On Tue, 21.09.10 00:23, Gustavo Sverzut Barbieri ([email protected]) wrote: > From: Fabiano Fidencio > > This patch adds a cpp definition HAVE_SYSV_COMPAT that is used to > isolate code dealing with /etc/init.d and /etc/rcN.d for systems where > it does not make sense (one that does not u

Re: [systemd-devel] simple systemd boot status

2010-09-26 Thread Lennart Poettering
1;2591;0cOn Tue, 21.09.10 23:39, Gustavo Sverzut Barbieri ([email protected]) wrote: > Hi all, > > I've wrote a proof of concept of a simple boot status for systemd. > Yeah, I know fedora folks have their super-duper plymouth, but I don't > want such thing just to show some progress. Why

Re: [systemd-devel] Standard directory for shell scripts?

2010-09-26 Thread Lennart Poettering
On Wed, 22.09.10 21:14, Wulf C. Krueger ([email protected]) wrote: > Hello! Heya, > Is there a consensus among distributions about a standard directory for shell > scripts to be used with systemd? > > I've seen /lib/systemd/system/scripts being suggested by someone but I don't > think t

Re: [systemd-devel] Systemd port on custom embedded linux

2010-09-26 Thread Lennart Poettering
1;2591;0cOn Thu, 23.09.10 16:26, Andrey Borzenkov ([email protected]) wrote: > It could be related to the fact that this is not enough. Standard halt command > from sysvinit behaves differently depending whether it is called by user or > by /sbin/init. When called by user it simply pokes init via

Re: [systemd-devel] Systemd port on custom embedded linux

2010-09-26 Thread Lennart Poettering
On Thu, 23.09.10 14:09, Cristian Axenie ([email protected]) wrote: > Hi ! > > Any ideas about the following behavior? > > ~ # reboot > Broadcast message from root (ttyS0) > > The system is going down for system halt NOW! > [ 296.08] systemd-initctl[698]: Received environment initct

Re: [systemd-devel] [PATCH 3/6] hashmap.h: HASHMAP_FOREACH* iterate until ITERATOR_LAST

2010-09-26 Thread Lennart Poettering
On Fri, 24.09.10 12:06, [email protected] ([email protected]) wrote: > From: Harald Hoyer > > --- > src/hashmap.h |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/hashmap.h b/src/hashmap.h > index ac5a8ae..64a468d 100644 > --- a/src/hashmap.h > +++ b/src/h

Re: [systemd-devel] [PATCH 5/6] readahead-collect: handle btrfs FIEMAP

2010-09-26 Thread Lennart Poettering
On Fri, 24.09.10 12:06, [email protected] ([email protected]) wrote: > From: Harald Hoyer > > Some files on btrfs do not have a physical extent. Just return an > increasing number. Hmm, why an increasing number? Care to elaborate? > --- > src/readahead-collect.c |9 - > 1 files ch

Re: [systemd-devel] [PATCH 2/6] readahead-common:fs_on_ssd() stat might not get the real device name

2010-09-26 Thread Lennart Poettering
On Fri, 24.09.10 12:22, Kay Sievers ([email protected]) wrote: > On Fri, Sep 24, 2010 at 12:06, wrote: > > From: Harald Hoyer > > > > btrfs returns a major(0) for its device, so try to find the mountpoint and > > real device. > > > +        fp = fopen("/proc/self/mountinfo", "r"); > > +  

Re: [systemd-devel] [PATCH 4/6] readahead-collect: check for negative return codes of fs_on_ssd()

2010-09-26 Thread Lennart Poettering
1;2591;0cOn Fri, 24.09.10 12:06, [email protected] ([email protected]) wrote: > From: Harald Hoyer Thanks, applied! > -on_ssd = fs_on_ssd(root); > +on_ssd = fs_on_ssd(root) == 0; > log_debug("On SSD: %s", yes_no(on_ssd)); > > on_btrfs = statfs(root, &sfs) >=

Re: [systemd-devel] [PATCH 6/6] readahead-collect: typo, free the correct pointer

2010-09-26 Thread Lennart Poettering
On Fri, 24.09.10 12:06, [email protected] ([email protected]) wrote: > From: Harald Hoyer Thanks, applied! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list [email protected] http://lists.freedesktop.org/

Re: [systemd-devel] [PATCH 1/6] readahead-replay: use posix_fadvise instead of readahead

2010-09-26 Thread Lennart Poettering
On Fri, 24.09.10 12:54, [email protected] ([email protected]) wrote: > @@ -96,8 +96,8 @@ static int unpack_file(FILE *pack) { > * intended to mean that the whole file shall be > * read */ > > -if (readahead(fd, 0, st.st_size) < 0) { > -

Re: [systemd-devel] [PATCH] var-run.service: create console dir needed by pam

2010-09-26 Thread Lennart Poettering
On Fri, 24.09.10 16:26, [email protected] ([email protected]) wrote: > From: Harald Hoyer After the comments from Kay and Bill I believe that a change like this is probably something we should add as a patch in the Fedora packages if at all -- instead of upstream git. It probably is nicer if we

Re: [systemd-devel] [PATCH] clarify message when unit action fails

2010-09-26 Thread Lennart Poettering
On Sun, 26.09.10 10:27, Andrey Borzenkov ([email protected]) wrote: > I was rather surprised to see "Starting of tmp.mount failed" > during shutdown and spent some time searching for wrong dependencies > until I realized that systemd always says "Starting" in this case. > > Clarify error message

Re: [systemd-devel] [PATCH 1/2] Removing double include of "mount.h"

2010-09-26 Thread Lennart Poettering
On Sun, 26.09.10 16:55, Fabiano Fidencio ([email protected]) wrote: > --- > src/mount.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/src/mount.c b/src/mount.c > index 5a05e2c..64c6790 100644 > --- a/src/mount.c > +++ b/src/mount.c > @@ -33,7 +33,6 @@ > #in

Re: [systemd-devel] [PATCH 2/2] Adding unmount functions to be used in shutdown

2010-09-26 Thread Lennart Poettering
On Sun, 26.09.10 16:55, Fabiano Fidencio ([email protected]) wrote: > +typedef struct MountPoint { > +char *path; > +char *device; > +char *fstype; > +struct MountPoint *next; > +} MountPoint; Please avoid creating your own linked list implementations. Please

[systemd-devel] [PATCH 2/2] Adding unmount functions to be used in shutdown

2010-09-26 Thread Fabiano Fidencio
This functions will unmount all filesystem that aren't api (and those which fail will be remounted read-only). Filesystems are being read from /proc/self/mountinfo. --- Makefile.am |1 + src/umount.c | 192 ++ src/umount.h | 27 ++

[systemd-devel] [PATCH 1/2] Removing double include of "mount.h"

2010-09-26 Thread Fabiano Fidencio
--- src/mount.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mount.c b/src/mount.c index 5a05e2c..64c6790 100644 --- a/src/mount.c +++ b/src/mount.c @@ -33,7 +33,6 @@ #include "strv.h" #include "mount-setup.h" #include "unit-name.h" -#include "mount.h" #include