Re: [SM-USERS] Surprise

2003-08-15 Thread Fredrik Jervfors
>> Imagine my surprise while trying to add a copy button similar to the >> move button to find that sqimap_msgs_list_copy() does not copy messages, >> it moves them. IMHO, this badly violates the principle of least >> surprise. If anyone is interested, I'll post the patches to the list >> when I'

Re: [SM-USERS] Surprise

2003-08-15 Thread Marc Groot Koerkamp
The function name isn't that weird. The IMAP protocol does not support MOVE so moving messages is actually a copy delete action. So I thing Idea 2 is better. Regards, Marc Groot Koerkamp. Chris Hilts said: >> Imagine my surprise while trying to add a copy button similar to the >> move button

Re: [SM-USERS] Surprise

2003-08-14 Thread Jonathan Angliss
>> sqimap_msgs_list_copy() does not copy messages, it moves them. > Yep, you're right. That's a badly named function, at best. I see two > possible solutions. Agreed. > Copy sqimap_msgs_list_copy() to sqimap_msgs_list_move() and remove the > delete command from sqimap_msgs_list_copy(). Updat

Re: [SM-USERS] Surprise

2003-08-14 Thread Chris Hilts
> Imagine my surprise while trying to add a copy button similar to the > move button to find that sqimap_msgs_list_copy() does not copy messages, > it moves them. IMHO, this badly violates the principle of least > surprise. If anyone is interested, I'll post the patches to the list > when I'm sat

[SM-USERS] Surprise

2003-08-14 Thread Jeffrey L. Taylor
Imagine my surprise while trying to add a copy button similar to the move button to find that sqimap_msgs_list_copy() does not copy messages, it moves them. IMHO, this badly violates the principle of least surprise. If anyone is interested, I'll post the patches to the list when I'm satisfied the