Re: [Spice-devel] Spice agent oddities

2011-10-18 Thread Damien Churchill
On 18 October 2011 17:37, Arnon Gilboa wrote: > Hi Damien, > > Seems like for some reason vdservice closed (handle of) the virtio serial > device. > > Can you please send the relevant qemu output. You should see something like: > spice_server_char_device_add_interface: CHAR_DEVICE vdagent > handle

Re: [Spice-devel] [master PATCH 1/2] server: netstat: modify network bandwidth calculation

2011-10-18 Thread Yaniv Kaul
On 18/10/2011 19:20, Uri Lublin wrote: Currently spice-server network bandwidth estimation is: send an empty ping packet to the client (and ignore it) ("warmup") Useless. 'warmup' of what exactly? The TCP MSS and everything else is already set by the TCP handshake and the RED initial connec

Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-18 Thread Yaniv Kaul
On 18/10/2011 19:20, Uri Lublin wrote: WAN accelerators may compress the zeros which results with a wrong bandwidth calculation. Is this really the right approach? Why not calculate the latency based on the time it takes to send the first image? That image is not using the WAN feature anyway,

Re: [Spice-devel] [master PATCH 1/2] server: netstat: modify network bandwidth calculation

2011-10-18 Thread Gianluca Cecchi
On Tue, Oct 18, 2011 at 8:03 PM, Alon Levy wrote: > On Tue, Oct 18, 2011 at 07:20:14PM +0200, Uri Lublin wrote: >> Currently spice-server network bandwidth estimation is: >>   send an empty ping packet to the client (and ignore it) ("warmup") >>   send an empty ping packet and calculate time till p

Re: [Spice-devel] [master PATCH 1/2] server: netstat: modify network bandwidth calculation

2011-10-18 Thread Alon Levy
On Tue, Oct 18, 2011 at 07:20:14PM +0200, Uri Lublin wrote: > Currently spice-server network bandwidth estimation is: > send an empty ping packet to the client (and ignore it) ("warmup") > send an empty ping packet and calculate time till pong is received > ("latency") > send a ping packet w

Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-18 Thread Alon Levy
On Tue, Oct 18, 2011 at 07:20:15PM +0200, Uri Lublin wrote: > WAN accelerators may compress the zeros which results with a > wrong bandwidth calculation. > ACK with some nitpicks on whitespace. I was hoping we will throw this stuff away, but I guess it's still there.. > The buffer is initialize

Re: [Spice-devel] [PATCH] qxl: fix guest cursor tracking

2011-10-18 Thread Alon Levy
On Tue, Oct 18, 2011 at 06:58:54PM +0200, Yonit Halperin wrote: > (1) If the guest cursor command is empty, don't reload it after migration. > (2) Cleaning the guest cursor when it is released by > the spice server. In addition, explicitly reset the > cursor in spice upon destroying the pri

Re: [Spice-devel] About Spice and threads

2011-10-18 Thread Alon Levy
On Tue, Oct 18, 2011 at 06:55:10PM +0200, Andrea Celestino wrote: >Hi, >I know that on the Spice Client side I have a different thread (spicec) >or a different context (spice-gtk) for each channel. How many threads >are there on the server side? I know >only that the Worker is a

Re: [Spice-devel] [PATCH] server/red_worker: fix placing of ASSERT(red_channel_client_no_item_being_sent) (fdbz #41523)

2011-10-18 Thread Alon Levy
On Tue, Oct 18, 2011 at 03:19:57PM +0200, Yonit Halperin wrote: > Call ASSERT(red_channel_client_no_item_being_sent) only if > red_wait_outgoing_item/s did not timeout. > ACK. > Signed-off-by: Yonit Halperin > --- > server/red_worker.c | 10 ++ > 1 files changed, 6 insertions(+), 4 d

[Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-18 Thread Uri Lublin
WAN accelerators may compress the zeros which results with a wrong bandwidth calculation. The buffer is initialized once. --- server/main_channel.c | 32 1 files changed, 28 insertions(+), 4 deletions(-) diff --git a/server/main_channel.c b/server/main_channel.

[Spice-devel] [master PATCH 1/2] server: netstat: modify network bandwidth calculation

2011-10-18 Thread Uri Lublin
Currently spice-server network bandwidth estimation is: send an empty ping packet to the client (and ignore it) ("warmup") send an empty ping packet and calculate time till pong is received ("latency") send a ping packet with data (256KB) and calculate time till pong ("roundtrip") bandwid

[Spice-devel] [PATCH] qxl: fix guest cursor tracking

2011-10-18 Thread Yonit Halperin
(1) If the guest cursor command is empty, don't reload it after migration. (2) Cleaning the guest cursor when it is released by the spice server. In addition, explicitly reset the cursor in spice upon destroying the primary surface (was done by spice-server implicitly). This will preven

[Spice-devel] About Spice and threads

2011-10-18 Thread Andrea Celestino
Hi, I know that on the Spice Client side I have a different thread (spicec) or a different context (spice-gtk) for each channel. How many threads are there on the server side? I know only that the Worker is a separated thread. Thanks. ___ Spice-devel ma

Re: [Spice-devel] Spice agent oddities

2011-10-18 Thread Arnon Gilboa
Hi Damien, Seems like for some reason vdservice closed (handle of) the virtio serial device. Can you please send the relevant qemu output. You should see something like: spice_server_char_device_add_interface: CHAR_DEVICE vdagent handle_dev_input: mouse mode 2 reds_main_handle_message: agent s

Re: [Spice-devel] About spice usb redirection

2011-10-18 Thread Gianluca Cecchi
On Fri, Sep 30, 2011 at 2:05 PM, Hans de Goede wrote: > Hi, > > On 09/30/2011 11:45 AM, Gianluca Cecchi wrote: >> >> On Fri, Sep 30, 2011 at 11:27 AM, Hans de Goede  wrote: >>> >>> Hi, >>> >>> Thanks for testing the usb code, and many thanks for the 2 bug reports! >> >> hello, >> is usb redirectio

[Spice-devel] [PATCH] server/red_worker: fix placing of ASSERT(red_channel_client_no_item_being_sent) (fdbz #41523)

2011-10-18 Thread Yonit Halperin
Call ASSERT(red_channel_client_no_item_being_sent) only if red_wait_outgoing_item/s did not timeout. Signed-off-by: Yonit Halperin --- server/red_worker.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 7af715d..67

Re: [Spice-devel] [RFC] server: add main_dispatcher

2011-10-18 Thread Alon Levy
On Tue, Oct 18, 2011 at 01:34:09PM +0200, Yonit Halperin wrote: > On 09/08/2011 02:17 AM, Alon Levy wrote: > Hi, > I think this patch is sufficient for the 0.8 branch (+ the comments > bellow + locks (for several display channels threads)). > However for master, due to the red_channel refactoring I

Re: [Spice-devel] [RFC] server: add main_dispatcher

2011-10-18 Thread Yonit Halperin
On 09/08/2011 02:17 AM, Alon Levy wrote: Hi, I think this patch is sufficient for the 0.8 branch (+ the comments bellow + locks (for several display channels threads)). However for master, due to the red_channel refactoring I think we should have a more general dispatcher. It would be nice if (1

Re: [Spice-devel] inputs_channel.c undefined variable

2011-10-18 Thread David Jaša
Mizon Tsai píše v Po 17. 10. 2011 v 23:27 -0700: > Hi David, > > > Thanks for the quick reply. > > > I am actually interested in setting up an environment where I can help > write some test tool for measuring Spice performance. > > > I was able to compile successfully, and start a virtual ima