Re: Extensibility of HttpSolrServer

2013-11-20 Thread Eugen Paraschiv
First - I completely agree with keeping the moving parts to a minimum - but I do think that's a case by case decision, and in this particular case - it may just be worth opening up a little. Then - adding in a custom HttpClient may work - but HttpHeaders are set on a request (and may differ from on

Re: Extensibility of HttpSolrServer

2013-11-20 Thread Shawn Heisey
On 11/20/2013 3:28 PM, Eugen Paraschiv wrote: The reason I needed access to internal details of the class - and it's not just these 2 fields (I used these just as a quick example) - was that I was trying to extend the class and overload the request method. As soon as I tried to do that, I noticed

Re: Extensibility of HttpSolrServer

2013-11-20 Thread Chris Hostetter
: The reason I needed access to internal details of the class - and it's not : just these 2 fields (I used these just as a quick example) - was that I was : trying to extend the class and overload the request method. As soon as I : tried to do that, I noticed that I really couldn't easily do so -

Re: Extensibility of HttpSolrServer

2013-11-20 Thread Eugen Paraschiv
The reason I needed access to internal details of the class - and it's not just these 2 fields (I used these just as a quick example) - was that I was trying to extend the class and overload the request method. As soon as I tried to do that, I noticed that I really couldn't easily do so - because m

Re: Extensibility of HttpSolrServer

2013-11-20 Thread Shawn Heisey
On 11/20/2013 2:21 PM, Eugen Paraschiv wrote: Quick question about the HttpSolrServer implementation - I would like to extend some of the functionality of this class - but when I extend it - I'm having issues with how extensible it is. For example - some of the details are not visible externally

Re: Extensibility of HttpSolrServer

2013-11-20 Thread Eugen Paraschiv
Will do - thanks for the quick feedback. Eugen. On Thu, Nov 21, 2013 at 12:06 AM, Mark Miller wrote: > Feel free to file a JIRA issue with the changes you think make sense. > > - Mark > > On Nov 20, 2013, at 4:21 PM, Eugen Paraschiv wrote: > > > Hi, > > Quick question about the HttpSolrServer

Re: Extensibility of HttpSolrServer

2013-11-20 Thread Mark Miller
Feel free to file a JIRA issue with the changes you think make sense. - Mark On Nov 20, 2013, at 4:21 PM, Eugen Paraschiv wrote: > Hi, > Quick question about the HttpSolrServer implementation - I would like to > extend some of the functionality of this class - but when I extend it - I'm > havin