Re: Branch/Java questions re: contributing code

2014-01-06 Thread Ryan Cutter
Thanks, everything worked fine after these pointers and I was able to generate a patch properly. Cheers, Ryan On Mon, Jan 6, 2014 at 7:31 AM, Shalin Shekhar Mangar < shalinman...@gmail.com> wrote: > On Mon, Jan 6, 2014 at 8:54 PM, Ryan Cutter wrote: > > 1. Should we be using Java 6 or 7? The

RE: Branch/Java questions re: contributing code

2014-01-06 Thread Markus Jelsma
Trunk (5.x) requires Java 1.7, 4.x still works with 1.6. Check the CHANGES.txt, you'll see it near the top. -Original message- > From:Ryan Cutter > Sent: Monday 6th January 2014 16:27 > To: solr-user@lucene.apache.org > Subject: Branch/Java questions re: contributing code > > 1. Sh

Re: Branch/Java questions re: contributing code

2014-01-06 Thread Shalin Shekhar Mangar
On Mon, Jan 6, 2014 at 8:54 PM, Ryan Cutter wrote: > 1. Should we be using Java 6 or 7? The docs say 1.6 ( > http://wiki.apache.org/solr/HowToContribute) but running 'ant test' on > trunk/ yields: > > /lucene/common-build.xml:328: Minimum supported Java version is 1.7. > > I don't get that er