Re: ClusterStateMutator

2017-01-05 Thread Hendrik Haddorp
m seemed to behave differently. And if the code always uses version 2 shouldn't the default in that line be changed accordingly? On 04/01/17 16:41, Shalin Shekhar Mangar wrote: Actually the state format defaults to 2 since many releases (all of 6.x at least). This default is enforced in

Re: ClusterStateMutator

2017-01-05 Thread Hendrik Haddorp
. This default is enforced in CollectionsHandler much before the code in ClusterStateMutator is executed. On Wed, Jan 4, 2017 at 6:16 PM, Hendrik Haddorp wrote: Hi, in solr-6.3.0/solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java there is the following code st

Re: ClusterStateMutator

2017-01-04 Thread Erick Erickson
e be changed accordingly? >>> >>> On 04/01/17 16:41, Shalin Shekhar Mangar wrote: >>>> Actually the state format defaults to 2 since many releases (all of >>>> 6.x at least). This default is enforced in CollectionsHandler much >>>> before t

Re: ClusterStateMutator

2017-01-04 Thread Hendrik Haddorp
; On 04/01/17 16:41, Shalin Shekhar Mangar wrote: >>> Actually the state format defaults to 2 since many releases (all of >>> 6.x at least). This default is enforced in CollectionsHandler much >>> before the code in ClusterStateMutator is executed. >>> >

Re: ClusterStateMutator

2017-01-04 Thread Erick Erickson
east). This default is enforced in CollectionsHandler much >> before the code in ClusterStateMutator is executed. >> >> On Wed, Jan 4, 2017 at 6:16 PM, Hendrik Haddorp >> wrote: >>> Hi, >>> >>> in >>> solr-6.3.0/solr/core/src/java/org/apache/sol

Re: ClusterStateMutator

2017-01-04 Thread Hendrik Haddorp
version 2 shouldn't the default in that line be changed accordingly? On 04/01/17 16:41, Shalin Shekhar Mangar wrote: > Actually the state format defaults to 2 since many releases (all of > 6.x at least). This default is enforced in CollectionsHandler much > before the code in ClusterS

Re: ClusterStateMutator

2017-01-04 Thread Shalin Shekhar Mangar
Actually the state format defaults to 2 since many releases (all of 6.x at least). This default is enforced in CollectionsHandler much before the code in ClusterStateMutator is executed. On Wed, Jan 4, 2017 at 6:16 PM, Hendrik Haddorp wrote: > Hi, > > in > solr-6.3.0/solr/core/

ClusterStateMutator

2017-01-04 Thread Hendrik Haddorp
Hi, in solr-6.3.0/solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java there is the following code starting line 107: //TODO default to 2; but need to debug why BasicDistributedZk2Test fails early on String znode = message.getInt(DocCollection.STATE_FORMAT, 1) == 1