Re: [Scid-users] minor patch for fics window

Cristian Stoica wrote: > Hi Fulvio, > > Please review and pull the following updated patch from > fix_proper_list branch. Pushed, thanks -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours

Re: [Scid-users] minor patch for fics window

Hi Fulvio, Please review and pull the following updated patch from fix_proper_list branch. Cristian S. The following changes since commit e8c795ee54b853a5eadbd91fca079ef6ded59cc8: make a proper list from a string (2013-09-16 22:42:53 +0300) are available in the git repository at: https:/

Re: [Scid-users] minor patch for fics window

> Speaking of it, what about four space tab-stops for new and updated code >> (of course not for the sake of it)? >> > In the eternal conflict between tabs vs spaces i'm a tabs supporter too. > However in scid we try to maintain file consistency: when patching a file > that used spaces you should u

Re: [Scid-users] minor patch for fics window

Cristian Stoica wrote: > Sure, we could simply commit the code and let users find if it add any > bugs, but i think it's not the right way. > I'm against taking patches without review and testing. I fall into > this trap myself times and times again. I needed to know if the > example was to make

Re: [Scid-users] minor patch for fics window

>...but the current code is in use by more than 4 years and there are no bug reports. No bug reports doesn't mean there are no bugs. For example, I have three of them in my queue (two for fics) that I did not report. Sure, we could simply commit the code and let users find if it add any > bugs, bu

Re: [Scid-users] minor patch for fics window

Cristian Stoica wrote: > You could argue the reverse if the patch was already there and then > removed Exactly, but the current code is in use by more than 4 years and there are no bug reports. I'm not saying that adding "split" is wrong; the point is that it makes the code more robust, but it

Re: [Scid-users] minor patch for fics window

You could argue the reverse if the patch was already there and then removed for not adding visible value. But not unless there was a real case where the removal would regress (e.g. because the parsed text is not regular). Does the addition regress? The fact that 'split' adds an empty element in y

Re: [Scid-users] minor patch for fics window

The following code: set elt "one two three" puts [lindex $elt 2] set elt [split $elt " "]puts [lindex $elt 2] will output:threetwo that's why i believe that the patch is risky and require accurate testing (and probably it's not the right approach). Bye,Fulvio Messaggio originale Da: c

Re: [Scid-users] minor patch for fics window

Hi Fulvio, Please try branch fix_proper_list2 for an updated patch. Cristian S. -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Is

Re: [Scid-users] minor patch for fics window

Thanks, I should have payed more attention to the context (and working late is overrated). I'll send you an update this weekend. Cristian S. -- See everything from the browser to the database with AppDynamics Get end-to-

Re: [Scid-users] minor patch for fics window

Hi Cristian,with your changes in fics.tcl the line 1299:if { $elt == "Click or type \[next\] to see next page." }will never be true (for example typing info into fics console and clicking on "Click or type [next] to see next page" no longer works).Bye,Fulvio Messaggio originale Da:

[Scid-users] minor patch for fics window

Hi Fulvio, Please review and pull the following patches from fix_proper_list branch. Cristian S. The following changes since commit af5a29d2fd51bbd4b06d83f9da47c4d7a93f9be2: make a proper list from a string (2013-07-10 23:08:17 +0300) are available in the git repository at: g...@github.