>I am also in favour of a merge/pull-request workflow. I now created a sf
>account and put the commit in a separate branch tooltip-reimplementation
>and created a merge-request for you.
>
Thanks.
>
>For the linux part of the problem I would be willing to help building
>things on various systems i
On 22.11.2015 13:42, f...@libero.it wrote:
>> [PATCH] Add rock-solid tooltip implementation
>
>
> Hi,
> I'm glad to see that you are sending more and more patches.
> If possible I would like to invite you (and anyone who wishes to contribute
> significantly to Scid) to use a "Pull-Requests" wor
>[PATCH] Add rock-solid tooltip implementation
Hi,
I'm glad to see that you are sending more and more patches.
If possible I would like to invite you (and anyone who wishes to contribute
significantly to Scid) to use a "Pull-Requests" workflow:
http://www.codepool.biz/co-work-with-git-on-sourcef
The current tooltip implementation has some quirks:
* tiny font: when normal font is readable, tiny font is
less readable :/
* when entering an element with a tooltip the tooltip pops
up even when the mouse has left the element in the
meantime
* tooltip stays open 15 seconds - assuming
On smaller displays the vertical ELO axis is too distorted
causing the highest number (3000) to be parltly hidden.
The fix draws one more horizontal guideline (up to ELO 3200)
in order to get more space between the top of the frame and
the label "3000".
---
tcl/tools/fics.tcl | 4 ++--
1 file cha
Signed-off-by: Cristian Stoica
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 7d53fed..86c74e7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,6 +3,7 @@
*.lo
*.la
*.so
+*.obj
*.d
Makefile
Makefile.bak
--
1.8.1.5
---
- forced focus was used as a means to achieve MouseWheel handling. This
method has some drawbacks for normal usage and is not necessary with
the upcomming patches
- the net effect is that focus on input windows (e.g. FICS) will not be
lost just by moving the mouse around
Signed-off-by: Cris
Make mouse wheel handling similar across platforms without requiring
window focusing.
This is achieved by replacing on Windows bindings to MouseWheel with
bindings to virtual events MWheel. These events are sent to the windows
with the mouse pointer instead of to the ones with focus.
Signed-off-b
- will be replaced by Text class bindings
Signed-off-by: Cristian Stoica
---
tcl/file/finder.tcl | 2 --
tcl/game/browser.tcl | 4 ++--
tcl/misc/misc.tcl| 14 --
tcl/tools/analysis.tcl | 1 -
tcl/tools/optable.tcl| 1 -
tcl/tools/preport.tcl| 1 -
tcl/
- the original tcl/tk procedure renders incorrect behavior if used
since it binds to MouseWheel on Windows platforms. The override is
necessary to maintain consistent and transparent mouse wheel handling
Signed-off-by: Cristian Stoica
---
tcl/misc/misc.tcl| 2 +-
tcl/windows/gamelist
- avoid global namespace pollution
Signed-off-by: Cristian Stoica
---
tcl/start.tcl | 1 +
1 file changed, 1 insertion(+)
diff --git a/tcl/start.tcl b/tcl/start.tcl
index 55b0928..6d62479 100644
--- a/tcl/start.tcl
+++ b/tcl/start.tcl
@@ -509,6 +509,7 @@ foreach elt {winX winY winWidth winHeigh
Signed-off-by: Cristian Stoica
---
.gitignore | 7 +++
1 file changed, 7 insertions(+)
diff --git a/.gitignore b/.gitignore
index d7e655c..7d53fed 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,13 @@
Makefile
Makefile.bak
+*~
+*.swp
+*.swo
+\#*\#
+.\#*
+*.patch
+
engines/phalanx-sc
I received Mike's message two hours after you applied the patch and I
assumed he was talking about it.
Now, since you were not in CC, maybe he wasn't...
I could not reproduce issue 1 with or without the focus patch. Issue 2 is
real but was already there: indeed, command field loses focus if you mo
Cristian Stoica wrote:
> Here is what Mike said:
>
> "1) Sometimes the left-right keyboard game move navigation gets
> disabled. For example after clicking various items on the game list or
> database switcher. For a quicker test, this also happens after
> clicking on the left or right margin of
Here is what Mike said:
"1) Sometimes the left-right keyboard game move navigation gets disabled.
For example after clicking various items on the game list or database
switcher. For a quicker test, this also happens after clicking on the left
or right margin of the game board.
2) Also, with the F
Cristian Stoica wrote:
> Thanks Fulvio,
>
> Some people reported issues with the FICS interface after the patch.
> Can you have a look?
Yes, can you tell me how to reproduce the issue? (I just logged in as
guest and started observing the Short - Tikkanen game with no problems)
--
Thanks Fulvio,
Some people reported issues with the FICS interface after the patch. Can
you have a look?
Cristian
On Tue, May 28, 2013 at 10:11 AM, Fulvio wrote:
> Cristian Stoica wrote:
>
>>
>> Before I get a chance to test on Windows, can you try the same patch with
>> a simple change? Just
Cristian Stoica wrote:
>
> Before I get a chance to test on Windows, can you try the same patch
> with a simple change? Just replace the test $tl == ".main" with ![
> ::docking::isUndocked $tl ] while leaving the rest unchanged and let
> me know if it does something sane.
Yes, committed:
http:
Hi Fulvio,
This is starting to look more complicated than it should be. I've glanced
over gitk code and it does some hocus-pocus based on platform to handle
correctly mouse wheel and focus. The same thing may be necessary here too.
Before I get a chance to test on Windows, can you try the same pa
Cristian Stoica wrote:
> How do you build on Windows?
The wiki:
http://sourceforge.net/p/scid/wiki/CompileScid/
have instruction for both Visual Studio and MinGW
Also keep in mind that tcl code is not compiled: you can also download a
precompiled package and directly modify the scid.gui file.
On
How do you build on Windows? I mean, I try to stay away from Windows as
much as I can and I could use some hints to minimize work on the build
process itself.
Anything else besides the usual configure && make? What do you use - Visual
Studio/mingw/cygwin?
Thanks,
Cristian
On Mon, May 27, 2013 a
Cristian Stoica wrote:
> I've tested for this and other scenarios on Linux and it should work
> as expected. What do you use? I may need to duplicate your setup to
> investigate further.
>
I tried it on a windows machine
---
I've tested for this and other scenarios on Linux and it should work as
expected. What do you use? I may need to duplicate your setup to
investigate further.
Cristian
On Mon, May 27, 2013 at 12:08 PM, Fulvio wrote:
> Cristian Stoica wrote:
>
>> - scid must already have focus before forcing it
- scid must already have focus before forcing it to one of its windows
- don't give auto-focus feature to undocked windows to avoid in-house
focus stealing
Signed-off-by: Cristian Stoica
---
tcl/start.tcl | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff
Hi Fulvio,
I'll have a look and get back to you.
Cristian
On Fri, May 17, 2013 at 12:20 PM, Fulvio wrote:
> Cristian Stoica wrote:
>
>> Hi guys,
>>
>> I'm sending you a patch that removes focus stealing of the main window.
>> For me, and maybe others, it was an annoyance to loose focus to sci
Signed-off-by: Cristian Stoica
---
tcl/start.tcl | 11 ---
1 file changed, 11 deletions(-)
diff --git a/tcl/start.tcl b/tcl/start.tcl
index e1a02d0..86f373c 100644
--- a/tcl/start.tcl
+++ b/tcl/start.tcl
@@ -931,17 +931,6 @@ proc createToplevel { w } {
frame $f -container 1
to
Hi guys,
I'm sending you a patch that removes focus stealing of the main window.
For me, and maybe others, it was an annoyance to loose focus to scid window
only on mouse hover.
Let me know what you think of it and if you have other suggestions.
Thanks,
Cristian Stoica (1):
do not steal focus
Hi,
In the game information area at the bottom, "FICS" is incorrectly
written as "Fics" (it's an acronym, not a word). Also, there's a typo in
one of the comments in the file.
Kind regards,
Nicky Chorley
--
--- a/scid/tcl/tools/fics.tcl 2011-02-13 18:12:
Thanks, i will commit your fix.
Larry Isaacs wrote:
> Hi,
>
> The reason that animations don't work with the board flipped is due to
> the resize2 procedure in board.tcl. Its comment mentions "incoherent
> state" if the board is resized while flipped, so in this case it
> un-flips the board, call
Hi,
The reason that animations don't work with the board flipped is due to
the resize2 procedure in board.tcl. Its comment mentions "incoherent
state" if the board is resized while flipped, so in this case it
un-flips the board, calls the normal resize procedure, and then re-flips
the board. This
Below there is a patch for sc_import.tcl which adds an extra way to run
this command. If run with
sc_import somedatabase -
the command will read the names of PGN files to import from standard
input.
Why?
--
First, it makes it possible to do things like
find . -name '*.pgn' -a -mt
> >- #Klimmek: changed, because Scid "hangs" very often
> (after 5-7 moves)
> >- # ::board::colorSquare .main.board
> $bestSq
> >- ::board::update .main.board
> >
> >With ShowSuggestedMove on, for me, this bug now
> reappears,
> >ie - on odd occasions, program will hang.
> >It appears the cause
> From: Fulvio
> 2) Change ::board::colorSquare so that textures are hided
> and not destroyed. This allow proc leaveSquare to not call
> ::board::update, solving some subtle bugs when the cpu is
> 100% and the user move fast over the board
This seems to mostly work for me :>
But in the patch th
This patch:
1) Correct the class StoredLine so it can be used as an object
2) Change ::board::colorSquare so that textures are hided and not
destroyed. This allow proc leaveSquare to not call ::board::update,
solving some subtle bugs when the cpu is 100% and the user move fast
over the board
3)
2009/8/1 Israel Chauca Fuentes
> Hi there,
>
> Tcl/Tk are installed as frameworks on the Mac platform and the "configure"
> script can't find the right setting for the Makefile. I found a setup.py
> script that solves a similar problem and ported it to tcl (see the patch
> file), this seems to wo
Hi there,
Tcl/Tk are installed as frameworks on the Mac platform and the
"configure" script can't find the right setting for the Makefile. I
found a setup.py script that solves a similar problem and ported it to
tcl (see the patch file), this seems to work fine and doesn't
interfere with
ok, you convinced me ;-)
Pascal
Marcin Kasperski a écrit :
>>> No, no, no, it should be continue!
>>>
>>> This is just semantics of handling possible empty lines. In case of
>>> continue, we just ignore empty lines and keep reading stdin. In case
>>> of break, first empty line abort the proces
>> No, no, no, it should be continue!
>>
>> This is just semantics of handling possible empty lines. In case of
>> continue, we just ignore empty lines and keep reading stdin. In case
>> of break, first empty line abort the process.
>> The process is over when stdin is finished, fgets returns fa
> I integrated your patch, and added your example and more
> details in the usage() function.
>
> But correct me if I am wrong, "continue" should be "break"
> here :
No, no, no, it should be continue!
This is just semantics of handling possible empty lines. In case
of continue, we just ignore em
Hi Marcin,
I integrated your patch, and added your example and more details in the
usage() function.
But correct me if I am wrong, "continue" should be "break" here :
// Now execute the merge process once for each existing file:
for (int i=2; i < argc; i++) {
char * sourceFileNa
The following patch (written against scid-3.6.19-rc2) adds new
way of running scmerge. One can now write
scmerge newbase -
and supply the list of merged bases on standard input (one by
one, separated by newline).
I wrote it after getting 'argument list too long' error once more
(not that
Thanks Marcin, this is integrated now.
Pascal
Marcin Kasperski a écrit :
> In the patch attached (made against 3.6.19rc1), a few extra small
> makefile corrections:
>
> 1) ratings.ssp was not installed and uninstalled. Now it is
>
> 2) old-install target was removed (whatever it was, it was not
In the patch attached (made against 3.6.19rc1), a few extra small
makefile corrections:
1) ratings.ssp was not installed and uninstalled. Now it is
2) old-install target was removed (whatever it was, it was not
maintained)
3) Additional makefile targets were added
make all_scid
make ins
> always use Scid from the
> compilation dir, and maybe others do the same (I understand
> people that are reluctant to issue a make install as root).
If somebody on Linux is not wishing to install as root, I would
recommend sth like
./configure BINDIR=$HOME/bin SHAREDIR=$HOME/share/scid
or
Marcin Kasperski a écrit :
> It should not be necessary, if somebody issues just
> ./configure
> it is equivalent to
> ./configure BINDIR=/usr/local/bin SHAREDIR=/usr/local/share/scid
> (both those defaults are set in configure file and seem reasonable)
>
> Maybe the fallback could help i
> So, for people that don't issue a correct :
> ./configure BINDIR=$HOME/scid SHAREDIR=$HOME/scid
> (...)
> Scid will fallback to the "classical" directories, and this
> cannot hurt.
It should not be necessary, if somebody issues just
./configure
it is equivalent to
./configure BINDIR=/
Thank you Marcin, it is integrated.
But before I fully understood what you did, and after I patched the code with
yours, I wrote the following fallback code :
# detect the case where, under Linux, Scid is used without prior installation
# the fallback directory is Scid's exec dir
if {! [file isdir
The attached patch (due to my laziness it is in two parts as I just maintan it
in this way, apply both in order)
changes scid so it complies to the typical Linux way of organising data files
(data files are separate from
the binary, all paths in use are set-able by ./configure switches) - but it
48 matches
Mail list logo
