Attached my patch for this one.
This concludes the efficiency story as far as I would like to address
it.
I kept the limited-set-of-corrections [-max N] operational on the tkscid
API, with the convention that if N = 0, this is taken as "unlimited."
Both the spellchecker and the cleaner use this
Hi Pascal,
I see I need just a little bit more patience :-)
The switch - if defined, of course (!) - does exactly what it says: It
makes scid bail out after it has found maxCorrections. This saves time.
This means that it handles issue (2) from my previous posting.
So, indeed my proposal is in
Thanks for your patience and your explanation. What I see :
1. The define is useless. I was mislead by your default
#undef BAIL_OUT_AFTER_MAXCORRECTIONS
where
#define BAIL_OUT_AFTER_MAXCORRECTIONS
gives far better result, and I don't see much drawbacks using this one (or
did I miss something ?)
Hi Pascal,
Let's review the situation once more...
The spell current spell checker has some problems:
1) It proposes only 2000 corrections per 'run'
This is what the discussion started off with. I made a first patch to
solve it; you were not happy with that patch, for some reasons, and
mainly b
Hi,
I tried your patch and I am not sure if it completely achieves its goal
(again I am not an expert in spell checking ...). What I understood is that
when checking players' names, a limited list of corrections is displayed.
After applying the proposed 2000 corrections, some will be displayed aga
On Thu, 2009-02-26 at 20:43 +0100, Pascal Georges wrote:
> I will try to look at it but :
> - I will before release Scid 3.7 this week-end;
> - are you sure it is a regular diff file ? I can't apply patch with
> this. If necessary send to me in PM the complete files.
>
Hi Pascal,
Done.
The file
I will try to look at it but :
- I will before release Scid 3.7 this week-end;
- are you sure it is a regular diff file ? I can't apply patch with this. If
necessary send to me in PM the complete files.
Pascal
--
Open Sour
2009/2/16 Joost ´t Hart :
> Hi there!
>
> [scid3.6.26 - WinXP]
>
> After importing a huge number of games (about 3.7M) into a fresh
> database, I wanted to do the name corrections.
>
> 1) Is there any particular reason why scid corrects only 2000 names in a
> go? Might mean I have to run this dialo
Joost ´t Hart wrote:
Hi!
> Interesting stuff, but you may have noticed that I am not
> the fully-pack-it-with-features type of guy. I am more in
> favor of improving what we have before adding new things
> (that may or may not be related, even
> implementation-wise).
Its just a collection of tho
On Thu, 2009-02-19 at 18:45 +0100, Alexander Wagner wrote:
Hi!
Interesting stuff, but you may have noticed that I am not the
fully-pack-it-with-features type of guy. I am more in favor of improving
what we have before adding new things (that may or may not be related,
even implementation-wise).
Joost ´t Hart wrote:
Hello Joost!
> I am willing to take this on, provided that we agree on
> some sort of specification first.
This is great news :)
> So it is either
> a) a configurable quicker scan, without knowing what is at
> stake beyond,
> or
> b) a full scan, taking some time
I prefer
Sorry that I was maybe not clear enough. I try to clarify below.
Joost.
On Thu, 2009-02-19 at 13:08 +0100, Pascal Georges wrote:
>
>
> 2009/2/19 Joost ´t Hart
>
> The duration of the correction phase depends on the number of
> corrections only (which is easily understo
2009/2/19 Joost ´t Hart
>
> The duration of the correction phase depends on the number of
> corrections only (which is easily understood by the user as he has given
> them 'a go' himself) and is as far as I have noticed reasonably mild.
> Besides, it shows a progress bar.
When using the command
Hi Pascal,
Aha! Now you _are_ interested :-)
I am willing to take this on, provided that we agree on some sort of
specification first.
The points you raise are valid, but you should be aware that the number
of corrections to make in one 'go' does not practically influence the
duration of this 'c
This part of Scid needs more corrections than that. For example :
- triggering a players'name correction makes Scid enter in calculation mode
without any user feedback (and this lasts a couple of minutes)
- the limit of corrections should be user defined (a drop down list with
"1000", "1", "100
Hi Pascal,
Sorry to hear that it does not interest you.
I did some changes locally that seem to do the job. That is, as far as
part 1 below is concerned. A correct approach to this part should make
part 2 obsolete. It is nice to know where game dates seem to be
inconsistent to player's dates of b
2009/2/16 Joost ´t Hart
> Hi there!
>
> [scid3.6.26 - WinXP]
>
> After importing a huge number of games (about 3.7M) into a fresh
> database, I wanted to do the name corrections.
>
> 1) Is there any particular reason why scid corrects only 2000 names in a
> go? Might mean I have to run this dialo
Hi there!
[scid3.6.26 - WinXP]
After importing a huge number of games (about 3.7M) into a fresh
database, I wanted to do the name corrections.
1) Is there any particular reason why scid corrects only 2000 names in a
go? Might mean I have to run this dialog about 70 times (!) to correct
the compl
18 matches
Mail list logo
