Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Cristian Stoica
I received Mike's message two hours after you applied the patch and I assumed he was talking about it. Now, since you were not in CC, maybe he wasn't... I could not reproduce issue 1 with or without the focus patch. Issue 2 is real but was already there: indeed, command field loses focus if you mo

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Fulvio
Cristian Stoica wrote: > Here is what Mike said: > > "1) Sometimes the left-right keyboard game move navigation gets > disabled. For example after clicking various items on the game list or > database switcher. For a quicker test, this also happens after > clicking on the left or right margin of

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Cristian Stoica
Here is what Mike said: "1) Sometimes the left-right keyboard game move navigation gets disabled. For example after clicking various items on the game list or database switcher. For a quicker test, this also happens after clicking on the left or right margin of the game board. 2) Also, with the F

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Fulvio
Cristian Stoica wrote: > Thanks Fulvio, > > Some people reported issues with the FICS interface after the patch. > Can you have a look? Yes, can you tell me how to reproduce the issue? (I just logged in as guest and started observing the Short - Tikkanen game with no problems) --

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Cristian Stoica
Thanks Fulvio, Some people reported issues with the FICS interface after the patch. Can you have a look? Cristian On Tue, May 28, 2013 at 10:11 AM, Fulvio wrote: > Cristian Stoica wrote: > >> >> Before I get a chance to test on Windows, can you try the same patch with >> a simple change? Just

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Fulvio
Cristian Stoica wrote: > > Before I get a chance to test on Windows, can you try the same patch > with a simple change? Just replace the test $tl == ".main" with ![ > ::docking::isUndocked $tl ] while leaving the rest unchanged and let > me know if it does something sane. Yes, committed: http:

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-27 Thread Cristian Stoica
Hi Fulvio, This is starting to look more complicated than it should be. I've glanced over gitk code and it does some hocus-pocus based on platform to handle correctly mouse wheel and focus. The same thing may be necessary here too. Before I get a chance to test on Windows, can you try the same pa

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-27 Thread Fulvio
Cristian Stoica wrote: > How do you build on Windows? The wiki: http://sourceforge.net/p/scid/wiki/CompileScid/ have instruction for both Visual Studio and MinGW Also keep in mind that tcl code is not compiled: you can also download a precompiled package and directly modify the scid.gui file. On

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-27 Thread Cristian Stoica
How do you build on Windows? I mean, I try to stay away from Windows as much as I can and I could use some hints to minimize work on the build process itself. Anything else besides the usual configure && make? What do you use - Visual Studio/mingw/cygwin? Thanks, Cristian On Mon, May 27, 2013 a

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-27 Thread Fulvio
Cristian Stoica wrote: > I've tested for this and other scenarios on Linux and it should work > as expected. What do you use? I may need to duplicate your setup to > investigate further. > I tried it on a windows machine ---

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-27 Thread Cristian Stoica
I've tested for this and other scenarios on Linux and it should work as expected. What do you use? I may need to duplicate your setup to investigate further. Cristian On Mon, May 27, 2013 at 12:08 PM, Fulvio wrote: > Cristian Stoica wrote: > >> - scid must already have focus before forcing it

[Scid-users] [PATCH] fix focus stealing from other applications

2013-05-26 Thread Cristian Stoica
- scid must already have focus before forcing it to one of its windows - don't give auto-focus feature to undocked windows to avoid in-house focus stealing Signed-off-by: Cristian Stoica --- tcl/start.tcl | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff