Re: [Scid-users] autoconf patches for scid

2014-04-01 Thread Cristian Stoica
I believe that if we trash the useless zlib and c++ scripts it should be possible to build scid in most systems with just: > g++ -I/usr/include/tcl -ltcl src/*.cpp src/polyglot/*.cpp > Yes, this will work on most Linux distros. I don't know about *BSD though. They install system packages in /usr/

Re: [Scid-users] autoconf patches for scid

2014-04-01 Thread Cristian Stoica
irst round. If anyone has the time and wants to try his hand at a fix, the file to look at is m4/ax_prog_tcl.m4; it's just a shell script. Thanks, Cristian S. On Tue, Apr 1, 2014 at 11:25 AM, Fulvio wrote: > Cristian Stoica wrote: > >> Hi Fulvio and all, >> >&g

Re: [Scid-users] autoconf patches for scid

2014-03-31 Thread Cristian Stoica
Hi Michael, Thanks for your test. I think I know the tcl.h problem but I suspect another one after seeing your configure output. Do you have another installation of tcl on the system? I think configure found Activestate tclsh in PATH, but took tcl library from another place than /opt/ActiveTcl. C

[Scid-users] autoconf patches for scid

2014-03-30 Thread Cristian Stoica
Hi Fulvio and all, I've been working lately on a set of patches for autoconf and I'm glad to say that they are >90% done. I've tested them on Linux (gcc), Freebsd (clang) and Windows XP(mingw) and I've got successful builds there. The install target is not finished but build should work at least f

Re: [Scid-users] minor patch for fics window

2013-09-16 Thread Cristian Stoica
Hi Fulvio, Please review and pull the following updated patch from fix_proper_list branch. Cristian S. The following changes since commit e8c795ee54b853a5eadbd91fca079ef6ded59cc8: make a proper list from a string (2013-09-16 22:42:53 +0300) are available in the git repository at: https:/

Re: [Scid-users] minor patch for fics window

2013-07-12 Thread Cristian Stoica
> Speaking of it, what about four space tab-stops for new and updated code >> (of course not for the sake of it)? >> > In the eternal conflict between tabs vs spaces i'm a tabs supporter too. > However in scid we try to maintain file consistency: when patching a file > that used spaces you should u

Re: [Scid-users] minor patch for fics window

2013-07-12 Thread Cristian Stoica
>...but the current code is in use by more than 4 years and there are no bug reports. No bug reports doesn't mean there are no bugs. For example, I have three of them in my queue (two for fics) that I did not report. Sure, we could simply commit the code and let users find if it add any > bugs, bu

Re: [Scid-users] minor patch for fics window

2013-07-12 Thread Cristian Stoica
You could argue the reverse if the patch was already there and then removed for not adding visible value. But not unless there was a real case where the removal would regress (e.g. because the parsed text is not regular). Does the addition regress? The fact that 'split' adds an empty element in y

Re: [Scid-users] minor patch for fics window

2013-07-11 Thread Cristian Stoica
Hi Fulvio, Please try branch fix_proper_list2 for an updated patch. Cristian S. -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Is

Re: [Scid-users] minor patch for fics window

2013-07-10 Thread Cristian Stoica
Thanks, I should have payed more attention to the context (and working late is overrated). I'll send you an update this weekend. Cristian S. -- See everything from the browser to the database with AppDynamics Get end-to-

[Scid-users] minor patch for fics window

2013-07-10 Thread Cristian Stoica
Hi Fulvio, Please review and pull the following patches from fix_proper_list branch. Cristian S. The following changes since commit af5a29d2fd51bbd4b06d83f9da47c4d7a93f9be2: make a proper list from a string (2013-07-10 23:08:17 +0300) are available in the git repository at: g...@github.

Re: [Scid-users] Keyboard bindings

2013-07-10 Thread Cristian Stoica
I'll start working and see if I can find a sensible solution. We'll see if "bind all" is OK for this - it depends on the breadth of added bindings. 'all' is going to cover even more windows than what we have now with specific calls to standardShortcuts. Cristian S. --

[Scid-users] Keyboard bindings

2013-07-09 Thread Cristian Stoica
Hi Fulvio, I've just noticed an old issue on FICS command window: Home and End keys fire on both the board and the cursor. Normally, when focus is on command window they should influence only the cursor but fics bindings come from "standardShortcuts" where game navigation is set among other things

Re: [Scid-users] Mouse Wheel handling without focus stealing

2013-07-08 Thread Cristian Stoica
07-08 22:54:51 +0300) Cristian Stoica (2): allow board to take focus on click redirect MouseWheel events on Windows platform ChangeLog | 6 ++ tcl/end.tcl | 42 +-

Re: [Scid-users] Mouse Wheel handling without focus stealing

2013-07-06 Thread Cristian Stoica
> > placing library functions is very error prone. A new developer should not > need to read all the code to contribute to the project and he should be > able to assume that standard functions behave normally. > We can call it scidBindMouseWheel or consistentBindMouseWheel or > nofocusBindMouseWhe

Re: [Scid-users] Mouse Wheel handling without focus stealing

2013-07-06 Thread Cristian Stoica
> Unfortunately there are still some small issues, for example: > - Without the "break" in ttk_bindMouseWheel the message continues to be > propagated (add a line "return" in gamelist.tcl:823 to try what I mean) > With disabled glist.ybar_, mouse wheel is handled by Treeview class but in current ma

[Scid-users] [PATCH 1/5] git: ignore MS Windows object files

2013-07-05 Thread Cristian Stoica
Signed-off-by: Cristian Stoica --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 7d53fed..86c74e7 100644 --- a/.gitignore +++ b/.gitignore @@ -3,6 +3,7 @@ *.lo *.la *.so +*.obj *.d Makefile Makefile.bak -- 1.8.1.5

[Scid-users] Mouse Wheel handling without focus stealing

2013-07-05 Thread Cristian Stoica
for you to fetch changes up to 214204aac1ec70b6ada5b53f823e6c2236ffc66d: fix_mw: replace original tcl/tk bindMouseWheel method (2013-07-06 00:08:00 +0300) Cristian Stoica (5): git: ignore MS Windows object files fix_mw:

[Scid-users] [PATCH 3/5] fix_mw: drop forced focus used for handling MouseWheel

2013-07-05 Thread Cristian Stoica
: Cristian Stoica --- tcl/windows.tcl | 10 -- 1 file changed, 10 deletions(-) diff --git a/tcl/windows.tcl b/tcl/windows.tcl index e69ec1c..a2dec7e 100644 --- a/tcl/windows.tcl +++ b/tcl/windows.tcl @@ -42,16 +42,6 @@ proc createToplevel { w } { frame $f -container 1 toplevel

[Scid-users] [PATCH 4/5] fix_mw: consistent mouse handling on all platforms

2013-07-05 Thread Cristian Stoica
-by: Cristian Stoica --- ChangeLog | 6 tcl/end.tcl | 94 +-- tcl/misc/misc.tcl | 8 ++--- 3 files changed, 87 insertions(+), 21 deletions(-) diff --git a/ChangeLog b/ChangeLog index d38cd43..5bcb5fc 100644 --- a/ChangeLog

[Scid-users] [PATCH 2/5] fix_mw: drop MouseWheel bindings to individual text windows

2013-07-05 Thread Cristian Stoica
- will be replaced by Text class bindings Signed-off-by: Cristian Stoica --- tcl/file/finder.tcl | 2 -- tcl/game/browser.tcl | 4 ++-- tcl/misc/misc.tcl| 14 -- tcl/tools/analysis.tcl | 1 - tcl/tools/optable.tcl| 1 - tcl/tools/preport.tcl| 1 - tcl

[Scid-users] [PATCH 5/5] fix_mw: replace original tcl/tk bindMouseWheel method

2013-07-05 Thread Cristian Stoica
- the original tcl/tk procedure renders incorrect behavior if used since it binds to MouseWheel on Windows platforms. The override is necessary to maintain consistent and transparent mouse wheel handling Signed-off-by: Cristian Stoica --- tcl/misc/misc.tcl| 2 +- tcl/windows

Re: [Scid-users] I need help SCID / Mac OSX

2013-07-03 Thread Cristian Stoica
Hi, Is there a trace or scid just freezes? What about the blank window - does it have a name? Does anything suggest it is an error pop-up? Cristian S. On Wed, Jul 3, 2013 at 10:58 AM, Patalex wrote: > Hello everybody, > > I reiterated my request for help on icons and buttons that are not > di

Re: [Scid-users] maintenance patches

2013-06-13 Thread Cristian Stoica
) Cristian Stoica (2): initialize "findopponent" array in ::fics namespace refactoring: reduce global namespace polution tcl/start.tcl | 206 +- tcl/tools/fics.tcl | 1 + 2 fil

Re: [Scid-users] maintenance patches

2013-06-10 Thread Cristian Stoica
gitignore for you to fetch changes up to 330bea2625bdf88d1ad1b90bc1adb41197b217e8: git: ignore patches and vim backup files (2013-06-10 11:41:56 +0300) Cristian Stoica (1): git: ignore patches and vim backup files .gitignore

[Scid-users] maintenance patches

2013-06-09 Thread Cristian Stoica
[PATCH 1/2] git: ignore patches and vim backup files [PATCH 2/2] remove temporary variables from global namespace Hi Fulvio, Of these two, the second patch removes a global variable (name) that troubled me during debugging of window focus. Other candidates to unset still remain (one or two lett

[Scid-users] [PATCH 2/2] remove temporary variables from global namespace

2013-06-09 Thread Cristian Stoica
- avoid global namespace pollution Signed-off-by: Cristian Stoica --- tcl/start.tcl | 1 + 1 file changed, 1 insertion(+) diff --git a/tcl/start.tcl b/tcl/start.tcl index 55b0928..6d62479 100644 --- a/tcl/start.tcl +++ b/tcl/start.tcl @@ -509,6 +509,7 @@ foreach elt {winX winY winWidth

[Scid-users] [PATCH 1/2] git: ignore patches and vim backup files

2013-06-09 Thread Cristian Stoica
Signed-off-by: Cristian Stoica --- .gitignore | 7 +++ 1 file changed, 7 insertions(+) diff --git a/.gitignore b/.gitignore index d7e655c..7d53fed 100644 --- a/.gitignore +++ b/.gitignore @@ -7,6 +7,13 @@ Makefile Makefile.bak +*~ +*.swp +*.swo +\#*\# +.\#* +*.patch + engines/phalanx

Re: [Scid-users] build scid on Windows

2013-06-01 Thread Cristian Stoica
Hi Michael, Is your version installed from git source or does it come with Ubuntu? Cristian. On Sat, Jun 1, 2013 at 12:45 AM, Michael G Thomas wrote: > on ubuntu-12.04 "/usr/games/scid" crashes at launch: error message below. > > no files matched glob pattern "*" > while executing > "glob

Re: [Scid-users] build scid on Windows

2013-06-01 Thread Cristian Stoica
Hi Fulvio, Yes, it works now. Cristian On Fri, May 31, 2013 at 1:51 AM, f...@libero.it wrote: > > > Messaggio originale > Da: cristi...@gmail.com > Data: 30/05/2013 22.37 > A: "Mike Curtis", < > scid-users@lists.sourceforge.net> > Ogg: Re: [Scid-users] build scid on Windows > > It's

Re: [Scid-users] build scid on Windows

2013-05-30 Thread Cristian Stoica
For reference: scid.exe that was built in a path with spaces will work if spaces are removed from the path - but only started from cmd. Double clicking on scid.exe will still not work. Cristian -- Introducing AppDynamics L

Re: [Scid-users] build scid on Windows

2013-05-30 Thread Cristian Stoica
1} { > set boardStyle [lindex $boardStyles 0] > } > +puts "2) boardStyle = $boardStyle" > setPieceFont $boardStyle > > #Load all img/buttons/_filename_.png > > > > On Thu, May 30, 2013 at 1:31 PM, Cristian Stoi

Re: [Scid-users] build scid on Windows

2013-05-30 Thread Cristian Stoica
3 at 5:57 AM, Cristian Stoica wrote: > >> I want to check why it wants a _25.gif file. This is just a suffix to >> some of the piece files that are one level deeper than /img/pieces. >> Something is not right. >> >> Anyway, config dir being present or not does not c

Re: [Scid-users] build scid on Windows

2013-05-30 Thread Cristian Stoica
, 2013 at 10:33 AM, Fulvio wrote: > Cristian Stoica wrote: > >> Hi Fulvio, >> >> I don't know what I did, but for a brief period of time I could run the >> build without any problems. After reboot the problem came back. Here is the >> trace. If I put a

Re: [Scid-users] build scid on Windows

2013-05-29 Thread Cristian Stoica
t; (procedure "InitImg" line 16) invoked from within "InitImg" (file "C:\Documents and Settings\cristi\My Documents\work\scid_empty\Release\scid.gui" line 1742) On Wed, May 29, 2013 at 11:18 AM, Fulvio wrote: > Cristian Stoica wrote: > >> Hi Fu

[Scid-users] build scid on Windows

2013-05-28 Thread Cristian Stoica
Hi Fulvio, I've prepared a mingw build env on Windows as per wiki instructions. The build succeeds but the binary file crashes at runtime after a few seconds while splash window is showing up. Do you have any suggestions? I would prefer to make clean builds if possible - instead of messing with 4

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Cristian Stoica
cus if you move the mouse. Cristian Cristian On Tue, May 28, 2013 at 6:27 PM, Fulvio wrote: > Cristian Stoica wrote: > >> Here is what Mike said: >> >> "1) Sometimes the left-right keyboard game move navigation gets disabled. >> For example after clicki

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Cristian Stoica
h the FICS interface, it's near impossible to set the focus to send any text." Cristian On Tue, May 28, 2013 at 4:23 PM, Fulvio wrote: > Cristian Stoica wrote: > >> Thanks Fulvio, >> >> Some people reported issues with the FICS interface after the patch. Can >

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-28 Thread Cristian Stoica
Thanks Fulvio, Some people reported issues with the FICS interface after the patch. Can you have a look? Cristian On Tue, May 28, 2013 at 10:11 AM, Fulvio wrote: > Cristian Stoica wrote: > >> >> Before I get a chance to test on Windows, can you try the same patch with

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-27 Thread Cristian Stoica
27, 2013 at 4:22 PM, Fulvio wrote: > Cristian Stoica wrote: > >> How do you build on Windows? >> > The wiki: > http://sourceforge.net/p/scid/**wiki/CompileScid/<http://sourceforge.net/p/scid/wiki/CompileScid/> > have instruction for both Visual Studio and MinGW > &g

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-27 Thread Cristian Stoica
27, 2013 at 12:49 PM, Fulvio wrote: > Cristian Stoica wrote: > >> I've tested for this and other scenarios on Linux and it should work as >> expected. What do you use? I may need to duplicate your setup to >> investigate further. &

Re: [Scid-users] [PATCH] fix focus stealing from other applications

2013-05-27 Thread Cristian Stoica
I've tested for this and other scenarios on Linux and it should work as expected. What do you use? I may need to duplicate your setup to investigate further. Cristian On Mon, May 27, 2013 at 12:08 PM, Fulvio wrote: > Cristian Stoica wrote: > >> - scid must already have focus

[Scid-users] [PATCH] fix focus stealing from other applications

2013-05-26 Thread Cristian Stoica
- scid must already have focus before forcing it to one of its windows - don't give auto-focus feature to undocked windows to avoid in-house focus stealing Signed-off-by: Cristian Stoica --- tcl/start.tcl | 27 ++- 1 file changed, 14 insertions(+), 13 dele

Re: [Scid-users] game list window broken?

2013-05-22 Thread Cristian Stoica
> Some people take toolchain upgrades less lightly. For example, Gentoo has >> currently unmasked only gcc 4.6. >> > Are you trying to argue that it is better to use software that is not > updated? > On the contrary. On the other hand, to upgrade or not is an interesting discussion on itself as yo

Re: [Scid-users] game list window broken?

2013-05-21 Thread Cristian Stoica
comes from -std=c++0x rather than from -pthreads did you consider activating c++0x only if the toolchain supports it instead of setting it the default? What is your view on this? Cristian S. On Mon, May 20, 2013 at 4:10 PM, Fulvio wrote: > Cristian Stoica wrote: > >> I'

Re: [Scid-users] game list window broken?

2013-05-20 Thread Cristian Stoica
I'm using gcc 4.5.4. Is it old in this context? Cristian S. On Mon, May 20, 2013 at 1:26 PM, Fulvio wrote: > Cristian Stoica wrote: > >> Hi Fulvio, >> >> I get crashes when selecting the game window. >> I traced it to 71755878fc405 but I did not inve

[Scid-users] game list window broken?

2013-05-18 Thread Cristian Stoica
Hi Fulvio, I get crashes when selecting the game window. I traced it to 71755878fc405 but I did not investigate further. Can you guys reproduce it? Clean build, start and then select Window/GameList. $ ./scid terminate called after throwing an instance of 'std::system_error' what(): Operation

Re: [Scid-users] [PATCH] fix focus stealing

2013-05-17 Thread Cristian Stoica
Hi Fulvio, I'll have a look and get back to you. Cristian On Fri, May 17, 2013 at 12:20 PM, Fulvio wrote: > Cristian Stoica wrote: > >> Hi guys, >> >> I'm sending you a patch that removes focus stealing of the main window. >> For me, and maybe other

[Scid-users] [PATCH] do not steal focus from other windows

2013-05-16 Thread Cristian Stoica
Signed-off-by: Cristian Stoica --- tcl/start.tcl | 11 --- 1 file changed, 11 deletions(-) diff --git a/tcl/start.tcl b/tcl/start.tcl index e1a02d0..86f373c 100644 --- a/tcl/start.tcl +++ b/tcl/start.tcl @@ -931,17 +931,6 @@ proc createToplevel { w } { frame $f -container 1

[Scid-users] [PATCH] fix focus stealing

2013-05-16 Thread Cristian Stoica
Hi guys, I'm sending you a patch that removes focus stealing of the main window. For me, and maybe others, it was an annoyance to loose focus to scid window only on mouse hover. Let me know what you think of it and if you have other suggestions. Thanks, Cristian Stoica (1): do not