On Sat, Oct 5, 2024 at 6:06 PM John H Palmieri wrote:
>
>
>
> On Saturday, October 5, 2024 at 6:38:20 AM UTC-7 Kwankyu Lee wrote:
>
> But I don't know how big a problem the codecov issue is ...
>
>
> We want to regard the check failure as there is a problem with the PR that
> the author sho
Le dimanche 6 octobre 2024 à 01:07:06 UTC+2, Kwankyu Lee a écrit :
It seems we have to choose between:
(1) We keep the status quo: not testing every code path created in the PR
results in the PR check failure.
(2) we keep codecov/patch as it is, but require to add doctests for every
code pat
(3) We keep our current practice (add doctests for major functionality, and
later doctests are added for broken cases). We change codecov/path to
report but not fail.
(3) is implemented in the PR https://github.com/sagemath/sage/pull/38812.
--
You received this message because you are sub
There are ways to "bloat" the set of doctests with minimal impact. For
example, we could create a file "TESTS.py" (for example) in a Sage module,
consisting only of doctests. It would not be included in the reference
manual, not visible when someone does "X.my_favorite_method?" or
"X.my_favor
On Saturday, October 5, 2024 at 6:38:20 AM UTC-7 Kwankyu Lee wrote:
But I don't know how big a problem the codecov issue is ...
We want to regard the check failure as there is a problem with the PR that
the author should resolve.
Currently the codecov failure triggers the check failur
"normal" codepaths ought to be tested. Error processing with try/except blocks
might be hard to test in the 1st place, and less crucial.
On 5 October 2024 14:38:19 BST, Kwankyu Lee wrote:
>
>
> But I don't know how big a problem the codecov issue is ...
>
>
>We want to regard the check fai
But I don't know how big a problem the codecov issue is ...
We want to regard the check failure as there is a problem with the PR that
the author should resolve.
Currently the codecov failure triggers the check failure, but no reviewer
and no author regard the codecov failure as a pro
On Saturday, October 5, 2024 at 7:47:33 AM UTC-4 Kwankyu Lee wrote:
No comment will be construed as no objection.
I guess I'm not actively developing at this point, and doubtless there are
many untested code paths existing. I do think that on the whole I've found
it pretty useful in the pas
No comment will be construed as no objection.
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on t
