cloud-fan closed pull request #49212: [SPARK-50705][SQL] Make `QueryPlan`
lock-free
URL: https://github.com/apache/spark/pull/49212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
cloud-fan commented on PR #49212:
URL: https://github.com/apache/spark/pull/49212#issuecomment-2579571513
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
zhengruifeng commented on PR #49212:
URL: https://github.com/apache/spark/pull/49212#issuecomment-2579247001
Unfortunately, the new added tests failed in CI (they passed in my local),
let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message
JoshRosen commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1908212415
##
core/src/test/scala/org/apache/spark/util/BestEffortLazyValSuite.scala:
##
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
JoshRosen commented on PR #49212:
URL: https://github.com/apache/spark/pull/49212#issuecomment-2579243000
> test failed
>
> ```
> [info] TransientBestEffortLazyValSuite:
> [info] - TransientBestEffortLazyVal works *** FAILED *** (4 milliseconds)
> [info] 1 did not equal 2 (T
cloud-fan commented on PR #49212:
URL: https://github.com/apache/spark/pull/49212#issuecomment-2579224891
test failed
```
[info] TransientBestEffortLazyValSuite:
[info] - TransientBestEffortLazyVal works *** FAILED *** (4 milliseconds)
[info] 1 did not equal 2 (TransientBestEffo
zhengruifeng commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1908113165
##
core/src/test/scala/org/apache/spark/util/BestEffortLazyValSuite.scala:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
zhengruifeng commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1908068904
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##
@@ -97,16 +99,17 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]
JoshRosen commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1908046176
##
core/src/test/scala/org/apache/spark/util/BestEffortLazyValSuite.scala:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
JoshRosen commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1908021165
##
core/src/test/scala/org/apache/spark/util/BestEffortLazyValSuite.scala:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
JoshRosen commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1908033776
##
core/src/test/scala/org/apache/spark/util/BestEffortLazyValSuite.scala:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
JoshRosen commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1908021165
##
core/src/test/scala/org/apache/spark/util/BestEffortLazyValSuite.scala:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
JoshRosen commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1908004655
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##
@@ -97,16 +99,17 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
JoshRosen commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1907994117
##
core/src/test/scala/org/apache/spark/SerializerHelper.scala:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
JoshRosen commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1907998126
##
core/src/test/scala/org/apache/spark/util/BestEffortLazyValSuite.scala:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
zhengruifeng commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1906548039
##
core/src/test/scala/org/apache/spark/SparkFunSuite.scala:
##
@@ -463,6 +463,27 @@ abstract class SparkFunSuite
condition = "TABLE_OR_VIEW_ALREADY_EXISTS"
zhengruifeng commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1906529292
##
core/src/test/scala/org/apache/spark/SparkFunSuite.scala:
##
@@ -463,6 +463,27 @@ abstract class SparkFunSuite
condition = "TABLE_OR_VIEW_ALREADY_EXISTS"
cloud-fan commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1906471684
##
core/src/test/scala/org/apache/spark/SparkFunSuite.scala:
##
@@ -463,6 +463,27 @@ abstract class SparkFunSuite
condition = "TABLE_OR_VIEW_ALREADY_EXISTS",
18 matches
Mail list logo
