Well, they’re all using the same osm-auth library under the hood:
https://github.com/osmlab/osm-auth/network/dependents
HOT Tasking Manager is another much used site on the list that doesn’t seem to
work anymore.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
mmd-osm left a comment (openstreetmap/openstreetmap-website#4109)
> _aggressively parallelizing_
Whatever this means in detail, it doesn't sound like it is covered by the [API
Usage policy](https://operations.osmfoundation.org/policies/api/).
--
Reply to this email directly or view it on GitHu
mmd-osm left a comment (openstreetmap/openstreetmap-website#6188)
We could change the text to "planet.osm.org". Adding a link is not a good idea
because the message originates from cgimap, and returned as plain text.
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
mmd-osm created an issue (openstreetmap/openstreetmap-website#6186)
Sometimes diary discussions are not rendered underneath the diary post, as
shown on the screenshot below.
https://github.com/user-attachments/assets/3130625b-11ef-4f45-b23e-3c3f9cdd5788";
/>
Sample page: https://master.apis.d
mmd-osm left a comment (openstreetmap/openstreetmap-website#6188)
The issue here is that there's no client in every case. As an example, the
export feature on osm.org
(https://www.openstreetmap.org/export#map=13/51.48630/-0.08583) delegates the
download to
https://www.openstreetmap.org/api/0.6
I was expecting `:rel => "noopener"` to be sufficient to prevent this sort of
issue. I found 1 or 2 places where this attribute isn't set. Can you maybe
comment if adding this attribute would have helped here, irrespective of adding
the COOP header?
--
Reply to this email directly or view it o
Once a user clicks on "Download" Image, there's currently no
visual feedback that anything happens. Since the image generation may take a
few seconds, a user may be tempted to hit the download button multiple times.
This PR disables the button as soon as a hits the download button, similar to
t
mmd-osm left a comment (openstreetmap/openstreetmap-website#6191)
I'm using something similar that creates a few sample users + also registers an
app for JOSM: https://gist.github.com/mmd-osm/a3a0b5a8799a333e7fae578038aa7a93
I'm also generating a doorkeeper_signing_key in that script and add it
@mmd-osm pushed 1 commit.
85f452adfc5fb9fc87f1b08b0c4ad8219b2d152f Image download w/ submit_tag
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/456ff4dfced1ee743bd2e3b0b9b51eae7cd31298..85f452adfc5fb9fc87f1b08b0c4ad8219b2d152f
You are receiving this
@mmd-osm pushed 1 commit.
456ff4dfced1ee743bd2e3b0b9b51eae7cd31298 Image download w/ submit_tag
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/6c4103c3b5f738a1813faf93d2a11aeb9da0f9b3..456ff4dfced1ee743bd2e3b0b9b51eae7cd31298
You are receiving this
mmd-osm left a comment (openstreetmap/openstreetmap-website#6170)
> cgimap update is supposedly ready now
Right, PR https://github.com/zerebubuth/openstreetmap-cgimap/pull/510 is ready
to be merged.
My proposal to move ahead is as follows:
- Merge Rails part of the solution, which includes d
mmd-osm left a comment (openstreetmap/openstreetmap-website#6119)
Adding
```css
.select_language_dialog {
display:none
}
```
to
https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/stylesheets/print.scss
should fix this.
--
Reply to this email directly or view it o
mmd-osm left a comment (openstreetmap/openstreetmap-website#6173)
I'd suggest to check the respective repos instead, such as
https://github.com/facebook/Rapid/issues/1722
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6173#iss
mmd-osm created an issue (openstreetmap/openstreetmap-website#6177)
I have to admit that I lost track at which point we have introduced dynamic
colors for changeset bounding boxes on the map. In any case, the changeset
color hint bar as shown in the screenshot below doesn't match these dynamic
mmd-osm left a comment (openstreetmap/openstreetmap-website#6189)
I've tested your code, and for me color replacement is working ok. I also put
in some debug code in both library methods, and they're being called when
loading the page.
https://github.com/user-attachments/assets/470cba90-5f5d-4a
mmd-osm left a comment (openstreetmap/openstreetmap-website#6137)
Did you plan to integrate the language selector as well, to show the `lang_en`
text version? I think this would be a nice addition, and frequently requested
since about 1872.
https://github.com/user-attachments/assets/b00ccc41-7b
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
So the button is set to disabled in the setTimeout function below.
```javascript
$document.on('submit.rails', rails.formSubmitSelector, function(e) {
var form = $(this),
remote = rails.isRemote(form),
blan
@mmd-osm commented on this pull request.
> +TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient
for lookups.
+ # So, convert it to a hash and only keep the item with the best rank.
+ array = JSON.parse(Rails.root.join("node_modules/tag2link/index.
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The other issue I've noticed is that Thunderforest maps (and all others) need
to be added to policy.connect_src as well.
Although the download is triggered, the resulting PNG file disappears into
nowhere.
--
Reply to this email
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Now I'm getting _Error - Missing or invalid token_, which makes sense because
we're not sending any cookies across.
I'm not even sure this works. fetch is using credentials option "same-origin"
by default, and even "include: alwa
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> is it preflighting because this will switch to POST or because of the cookie
> or something
In the AJAX case, it's the second (GET) request on render.osm.org that triggers
the preflight request.
--
Reply to this email di
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I think we could skip the cookie altogether:
>From app/controllers/application_controller.rb -> update_totp -> generates new
>TOTP cookie today.
`ROTP::TOTP.new(Settings.totp_key, :interval => 3600).now` needs to be added to
app
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
https://render.openstreetmap.org/cgi-bin/export seems to return multiple /
deviating Access-Control-Allow-Origin headers:
https://github.com/user-attachments/assets/1f78a339-2e67-4639-bba6-a251cd67bf1a";
/>
https://github.com/u
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I'm using the code below, which includes `Access-Control-Request-Headers:
x-csrf-token,x-turbo-request-id` in the request.
The preflight fails, because we're not allowing these headers:
Reason: header ‘x-csrf-token’ is not allowe
@mmd-osm pushed 1 commit.
012aec679f34a109865eaf12da1bc8ca4c200847 Fix unit test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/b94b4a3fb03666a0f2598b71f6621b37b07a925f..012aec679f34a109865eaf12da1bc8ca4c200847
You are receiving this because you are
@mmd-osm pushed 3 commits.
53149fd121112052ae9e511ad08e72a106304505 Add image provider to CSP connect_src
1f853ca1b57ff7b5186fe160199fd851e40bc519 TOTP token as URL parameter
730c56c58867732f2dee941809900648c6115c56 Export image as AJAX request
--
View it on GitHub:
https://github.com/openstr
@mmd-osm pushed 4 commits.
25f0fda3ec69da488feb3f6ad83e4c3df7eab8fd Image download w/ submit_tag
c2748f8d8f6660e190dbd3ad365b0f5e532c861d Add image provider to CSP connect_src
ed404ae8f570a6db4794885ad5142dd04648c9d3 TOTP token as URL parameter
b94b4a3fb03666a0f2598b71f6621b37b07a925f Export i
@mmd-osm pushed 1 commit.
926535a2ffad5f5b7455ea6bc989a78572be778e Matching download file suffix
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/ac8bbfff948f471a46db7d6bd579069727ff63aa..926535a2ffad5f5b7455ea6bc989a78572be778e
You are receiving this
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
So the image download seems to work now. I still want to hardcode PNG format
for thunderforst (that's the only format available for download), and check how
the code handles bad request due to timeouts during image generation.
I'
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The preflight request is failing with HTTP 500. There might be something wrong
with `form.getfirst("token")`. Elsewhere we're using `getvalue` to fetch the
parameter value, and check if a value is available:
```
elif "token" in f
@mmd-osm pushed 1 commit.
3d9d24d26e1dd9d44688f7e908e7b48afe07473c Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/012aec679f34a109865eaf12da1bc8ca4c200847..3d9d24d26e1dd9d44688f7e908e7b48afe07473c
You are receiving this
@mmd-osm pushed 1 commit.
5008934940ce060263c0878334ecc0e08e63a337 Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/3d9d24d26e1dd9d44688f7e908e7b48afe07473c..5008934940ce060263c0878334ecc0e08e63a337
You are receiving this
@mmd-osm pushed 1 commit.
38d452e4356f62b9f304bb6ae6fd20d40fd0cff0 Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/5008934940ce060263c0878334ecc0e08e63a337..38d452e4356f62b9f304bb6ae6fd20d40fd0cff0
You are receiving this
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
It's available on the dev instance for testing now:
https://master.apis.dev.openstreetmap.org/user/mmd2mod/history
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/iss
@mmd-osm pushed 3 commits.
81869381defa872638c9f6035586aed625530f76 Remove not needed submit handler
b50b9d192b1e0bb4b8f50ac7a541e0023f500887 Eslint fix
ac8bbfff948f471a46db7d6bd579069727ff63aa Added downloading text
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website
@mmd-osm pushed 1 commit.
e4c1d373d9380fca420d6863a2e5fb8018a984ce Restrict select options to supported
map export formats
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/926535a2ffad5f5b7455ea6bc989a78572be778e..e4c1d373d9380fca420d6863a2e5fb8018a9
@mmd-osm pushed 2 commits.
70e1eab3dad76200e2e16bc5b2191aa0bea127ee Restrict select options to supported
map export formats
08e788ba8c2b8e1c2a3589689bb4a6004456d59d Map download failure message
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/e4c1d3
@mmd-osm pushed 1 commit.
ba31ffd976f9aa672c2e5a1c42068e80a604eaef Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/cf0fc1cdb176798f6c6a838fa1f4b4b76ae12d19..ba31ffd976f9aa672c2e5a1c42068e80a604eaef
You are receiving
mmd-osm left a comment (openstreetmap/openstreetmap-website#6214)
#6192 also fixes this issue, you won’t be able to select non png for
thunderforest layers.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6214#issuecomment-3094
@mmd-osm pushed 1 commit.
cf0fc1cdb176798f6c6a838fa1f4b4b76ae12d19 Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/2d614082c31b689b7913ff08b045e230ed698ee6..cf0fc1cdb176798f6c6a838fa1f4b4b76ae12d19
You are receiving
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Mmh, Thunderforst is still sending us HTML error messages. Can we change this
somehow?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094690120
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I'm not sure I have enough karma points to propose such a change.
Anyway, one alternative I found is to handle the Turbo before-fetch-response
event. In case the endpoint is sending us failures in html format, we tell
Turbo to no
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I gave it a quick try and reverted to the previous version. I'd say, let's keep
the text version, to avoid showing HTML tags in the popup:
https://github.com/user-attachments/assets/1d7f97f3-7e3d-4b22-a334-caf16c7dbc17";
/>
Mayb
@mmd-osm pushed 1 commit.
7370d311b26655911f0cf09390beddb1e9f2b7a7 Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/ba31ffd976f9aa672c2e5a1c42068e80a604eaef..7370d311b26655911f0cf09390beddb1e9f2b7a7
You are receiving
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Last update for today. I did a bit of refactoring and split the larger
functions into smaller parts.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomm
301 - 345 of 345 matches
Mail list logo
