@mmd-osm pushed 1 commit.
af134de5eb1fa394aa906bc10875eb1bfca1d484 Added two railway svgs
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/a30a89c8dbf28df8377c85196dea68ea351e7fac..af134de5eb1fa394aa906bc10875eb1bfca1d484
You are receiving this becaus
@mmd-osm pushed 1 commit.
6642c0517243448031c2e4f0667aa12da57693ba Added childcare svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/2ff0b3617bde2fe206875ef8bc004fdf41aec894..6642c0517243448031c2e4f0667aa12da57693ba
You are receiving this because y
The question is what happens with validations. Do we want to maintain them in
two different places (Tracepoint model and trace.rb)?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2371894309
You are receiving thi
@mmd-osm pushed 1 commit.
2b83a6dfc6cf6f9cf574afe8f568404a1de797a0 Added svg symbols for school and car
share
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/6642c0517243448031c2e4f0667aa12da57693ba..2b83a6dfc6cf6f9cf574afe8f568404a1de797a0
You are
It's been a while. The javascript workaround is in place and appears to be
working ok. I haven't seen other projects with similar requirements. Should we
keep this open, and assign it to @simonpoole, or close it? Any other ideas?
--
Reply to this email directly or view it on GitHub:
https://git
@mmd-osm pushed 1 commit.
39a14376de10e1d7eb7a0d8a88422eaab3cdd041 Added railway level_crossing svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/af134de5eb1fa394aa906bc10875eb1bfca1d484..39a14376de10e1d7eb7a0d8a88422eaab3cdd041
You are receiving t
@mmd-osm pushed 1 commit.
97e5251a8064be4f982f12f0fe21d77b78c47cb8 Added amenity university svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/39a14376de10e1d7eb7a0d8a88422eaab3cdd041..97e5251a8064be4f982f12f0fe21d77b78c47cb8
You are receiving this
Tracepoint.import! calls model validations internally, like we discussed above.
Try to upload data without timestamp and see what happens.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2373075375
You are receiv
@mmd-osm pushed 1 commit.
dc0863b71f7eea9828a7364f0cb80d5bdad17546 Added historic wreck svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/97e5251a8064be4f982f12f0fe21d77b78c47cb8..dc0863b71f7eea9828a7364f0cb80d5bdad17546
You are receiving this beca
This comment still refers to the previous version where the whole file was
added to .rubocop.yml.
@tomhughes hasn’t commented on the inline annotation variant yet, and I would
suggest to wait for feedback before continuing.
Like I said, I don’t really have an issue with this annotation.
--
Re
@mmd-osm pushed 1 commit.
7ea4e8b0f6e003abf5097660179713b50b3c62a8 Added historic ruins svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/4a0ab792a46d28ea9f7db5d4114944a9897ede42..7ea4e8b0f6e003abf5097660179713b50b3c62a8
You are receiving this beca
Closed #5240 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5240#event-14427757207
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
Changeset visualization is very similar to #1376. Please add your comments
there as well.
Tag coloring is already covered in #738
-> closing as duplicate
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5240#issuecomment-2378779
Alternative approach to Achavi is being proposed here:
https://www.openstreetmap.org/user/TrickyFoxy/diary/405188
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1376#issuecomment-2378784232
You are receiving this because you a
A few years back, I've introduced both the activerecord-import gem and
`import!` method call to speed up Tracepoint imports. Alternative options
weren't available then. Now with the recent Rails version, it's a good time to
move to the core Rails code.
At least today, we have exactly one locati
@mmd-osm pushed 1 commit.
4a0ab792a46d28ea9f7db5d4114944a9897ede42 Added estate agent svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/dc0863b71f7eea9828a7364f0cb80d5bdad17546..4a0ab792a46d28ea9f7db5d4114944a9897ede42
You are receiving this becaus
@mmd-osm pushed 1 commit.
5b61d54da9b213474b301b18653b007429e9cbdc Using osm.org as identity provider
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5071/files/358d158afb83d6d73aecd92898834eba36d2226c..5b61d54da9b213474b301b18653b007429e9cbdc
You are receiving
@mmd-osm pushed 1 commit.
2cd72f00c773845a8c66bcdd042930148a7ad432 Rescale golf svgs to 14
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/f5302501bec349d46bea6731827c722f3c04bc30..2cd72f00c773845a8c66bcdd042930148a7ad432
You are receiving this becau
@mmd-osm pushed 1 commit.
f387f71ee0d11379f70ce4299af4b9f3ceabf116 Rescale some svgs to 14pt
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/2cd72f00c773845a8c66bcdd042930148a7ad432..f387f71ee0d11379f70ce4299af4b9f3ceabf116
You are receiving this bec
@mmd-osm pushed 1 commit.
f5302501bec349d46bea6731827c722f3c04bc30 Remove white background for amenity
bus_station svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/7ea4e8b0f6e003abf5097660179713b50b3c62a8..f5302501bec349d46bea6731827c722f3c04bc30
I don't think it makes a whole lot of sense to reimplement the GPX export for 3
different routing engines. However, it might be a better idea to add some links
underneath the direction results which point to the respective engine demo
pages.
These pages anyway have much more capabilities, like
@AntonKhorev : you're right, I checked the response in wireshark, and the POST
request returns HTTP 302 without any payload. Closing here, since there's no
issue really.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5222#issu
Closed #5222 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5222#event-14343183140
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
This could probably all be handled automatically by #2621. However, I believe
Sophox database is still not up to date with most recent wiki updates.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5200#issuecomment-2384907195
Yo
I was also wondering about this. IMHO the right place to address this issue
would be a proper parser in https://github.com/glebm/i18n-tasks, which is able
to handle model validation error messages. I didn't find anything in there,
maybe we could raise an issue?
--
Reply to this email directly
As a follow up, this use case is not (yet) supported by i18n-tasks. The
referenced GitHub issue has some comments on how this could be implemented.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5242#issuecomment-2387079370
You a
_I'm not covering the question how and where we're generating these links in
the first place._
> Links to OSM entities are quite unwieldy, e. g.:
> https://www.openstreetmap.org/changeset/157188078.
There's still the third option to use `osm.org` along with the current schema:
`https://osm.org
@mmd-osm pushed 1 commit.
a30a89c8dbf28df8377c85196dea68ea351e7fac Remove white background for barrier
gate svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/3e54397b865318d10591ea4fd559ea78c9cbda22..a30a89c8dbf28df8377c85196dea68ea351e7fac
You ar
@mmd-osm pushed 1 commit.
3e54397b865318d10591ea4fd559ea78c9cbda22 Added mini_roundabout svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/0836b0caa2f5146ba86857b6f44d3cd9fbfdc3cc..3e54397b865318d10591ea4fd559ea78c9cbda22
You are receiving this bec
@mmd-osm pushed 1 commit.
0836b0caa2f5146ba86857b6f44d3cd9fbfdc3cc rtl:ignore added for additional
transforms
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/2b83a6dfc6cf6f9cf574afe8f568404a1de797a0..0836b0caa2f5146ba86857b6f44d3cd9fbfdc3cc
You are
@mmd-osm pushed 1 commit.
b35ceab840fd3e978e735ddb4c8cb8566ce66b31 Unit test to accept filenames with
optional # suffix
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/f387f71ee0d11379f70ce4299af4b9f3ceabf116..b35ceab840fd3e978e735ddb4c8cb8566ce66b3
Closed #5244 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5244#event-14503513509
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
Ok, let's close this issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5244#issuecomment-2391268828
You are receiving this because you are subscribed to this thread.
Message ID:
@mmd-osm pushed 1 commit.
be6f334b1698fb919a1e486122b87ac5d3a9d56b Use relative position instead of svg
transform
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/b35ceab840fd3e978e735ddb4c8cb8566ce66b31..be6f334b1698fb919a1e486122b87ac5d3a9d56b
You
@mmd-osm commented on this pull request.
> @@ -12,5 +15,33 @@ def show
rescue ActiveRecord::RecordNotFound
raise OSM::APINotFoundError
end
+
+def create
+ raise OSM::APIBadUserInput, "No user was given" unless params[:user]
+
+ user = User.visible.find_by(:id => pa
Closed #5287 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5287#event-14867415806
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
This seems like the wrong place, you need to report iD topics here:
https://github.com/openstreetmap/iD
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5287#issuecomment-2437241652
You are receiving this because you are subscrib
One of the links I've posted mentioned "public_repo" scope, that's read only
access to public repos.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2420107906
You are receiving this because you are subscribed
I wouldn't use my own account to create the token, and rather create some new
"OSM Danger Bot" GH account. You could also keep that token secret and
reference it by variable name only.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/i
I've just created a new PR, let's see how it goes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2420157110
You are receiving this because you are subscribed to this thread.
Message ID:
_
Follow up for https://github.com/openstreetmap/operations/issues/1107
The goal of this PR is to set the `expiry_after` value for unauthenticated
users to a fairly low value (read: a few hours). This way, memcached entries
are no longer created with a TTL of 0 (unlimited).
Previously, logged one
Diary and other user provided content frequently includes rather large external
images, which slows down page loading. We could force lazy loading of these
assets by adding a loading="lazy" attribute to img tags, as described here:
https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_lo
This PR adds the UI facing parts for
https://github.com/openstreetmap/chef/pull/735 and adds WebP as as additional
output format, as well as a checkbox to toggle copyright/attribution in the map
export.
*
See #5601 for discussion
---
Closes #5601
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5615
-- Commit Summary --
* Image lazy loading
-- File Changes --
M config/initializers/sanitize.rb (6)
-- Patch Li
> So my proposal is to rename the tables to match the model names.
Have you also evaluated the other way around, i.e. change the model names to
match the db table names? Assuming that's feasible, that's significantly less
risk and effort for anything non-Rails.
--
Reply to this email directl
@mmd-osm pushed 1 commit.
f6f75d6e844f04fcea3b27e604428eb0a883e9b6 Add copyright/attribution message to
downloaded map images
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5607/files/68a1ce22dcac71dd1500c190eee34339a83698d4..f6f75d6e844f04fcea3b27e604428eb0a
### URL
_No response_
### How to reproduce the issue?
1. Pick random diary entry with spaces in title, e.g.
https://www.openstreetmap.org/user/watmildon/diary/406063
2. Click on "Share via Email" button
3. Note that the title in your email client reads as
"`OSM+US+Board+Candidate+Statement+202
Yes, I was about to post the same link.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5587#issuecomment-2629048488
You are receiving this because you are subscribed to this thread.
Message ID:
__
I forgot to mention, I was seeing this behavior in Thunderbird...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5587#issuecomment-2629045582
You are receiving this because you are subscribed to this thread.
Message ID:
__
I gave it a try and added attribution for *backend* rendering for PS, PDF, SVG,
PNG, JPEG and WEBP formats.
Code and some sample images:
https://gist.github.com/mmd-osm/fb7b0b53794240315a05369911fc66a2
--
With the latest changes I was able to render Lake Huron locally for the first
time (455k nodes). That is definitely a significant speed-up.
--
Reply to this email directly or view it on GitHub:
https://gi
The issue here is in osm.js.erb: if mlon and mlat are set, we're not
initializing "loc" from the _osm_location cookie. Later on we cannot set
mapParams.layers, since "loc" should be nil at this time. This impacts both the
notes layer, as well as the map layer.
```javascript
} else if (param
@DavidKarlas : by the way, are you somehow aware/involved in this discussion?
https://gitlab.com/panoramax/server/api/-/issues/227
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5497#issuecomment-2607157426
You are receiving this
As reported in #3971, some URLs like
https://www.openstreetmap.org/?mlat=53.32607&mlon=-1.49033 reset the
currently selected layers. In order to restore the previous setting, a user
needs to select both map and overlay layers after click on the link.
It seems a bit premature to simply override
@Cj-Malone : issue should be fixed now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3971#issuecomment-2608399376
You are receiving this because you are subscribed to this thread.
Message ID:
According to
https://github.com/openstreetmap/openstreetmap-website/blob/master/lib/tasks/eslint.rake#L23
we would need to use `bundle exec rails eslint:fix` instead. This seems to
work for me at least.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/ope
As discussed in
https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-2585349128,
this PR adds an error handling in case the API request fails.
You can view, comment on, or merge th
_✖ 40 problems (31 errors, 9 warnings)
26 errors and 0 warnings potentially fixable with the `--fix` option._
Is `--fix` of any help here, have you tried this out already?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5549#iss
By the way, I checked mdn before using optional chaining: _It’s been available
across browsers since July 2015._ That’s close to 10 years…
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/#issuecomment-2615005156
You are rece
Well, what about the other issue in turbo.js (:5:154-178)? That's an external
dependency we have no control over, and it causes the exact same issue on the
(assumed to be) old browser.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/i
I will create the PR to switch to JSON format shortly:
https://github.com/mmd-osm/openstreetmap-website/tree/patch/datalayerjson
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-2616458723
You are receiving this b
https://github.com/openstreetmap/leaflet-osm/pull/44 introduced OSM JSON
support in the underlying leaflet osm package. This PR enables the new feature
by requesting application/json format (via Accept header).
You can view, comment on, or merge this pull request online at:
https://github.com/
@mmd-osm commented on this pull request.
> <% end %>
};
var map = L.map("map");
map.attributionControl.setPrefix("");
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
-new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclemap" || arg
@mmd-osm commented on this pull request.
> <% end %>
};
var map = L.map("map");
map.attributionControl.setPrefix("");
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
-new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclemap" || arg
Maybe create a new issue for this topic.
https://github.com/prettier/plugin-ruby could be starting point.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2614086393
You are receiving this because you are subscr
A while back I've noticed that the [Messaging
API](https://wiki.openstreetmap.org/wiki/Messaging_API_proposal) allows to
retrieve deleted messages via the API (`GET /api/0.6/user/messages/_nnn_`).
This seems to be inconsistent to how our UI works, where deleted messages are
no longer shown.
We
Undeleting messages is fine as a use case, that’s how the trash folder could
work. What I’m really missing is a way to permanently remove messages with no
way to undelete them. Has this been discussed already at some point?
--
Reply to this email directly or view it on GitHub:
https://github.co
By the way, if you're looking into map data layer performance, we're also
spending some time in XML parsing (DOMParser.parseFromString). Maybe we could
switch to /map.json and directly parse the response as json(). Both Rapid and
iD are using json for performance reasons.
--
Reply to this emai
@AntonKhorev 's comment wasn't exactly clear to me either. I think it's the
following. Note that once you change the layer in the URL, the share link
"layer" attribute is updated accordingly:
 was added._
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4
I'm wondering why you want to send id_tokens to a resource server in the first
place. That's not really their intended use:
https://oauth.net/id-tokens-vs-access-tokens/
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5497#issuec
mmd-osm left a comment (openstreetmap/openstreetmap-website#5589)
> [...] if they were part of an invisible way that had nodes inside the
> bounding box [...]
Tbh, I don't really understand this use case, and I didn't find a corresponding
unit test for this specific scenario.
As soon as we de
mmd-osm left a comment (openstreetmap/openstreetmap-website#5619)
> I can see that changeset_subscribers is accessed by cgimap, for example.
> Would that be a blocker?
I don't think so. The code you've found in cgimap is not used in production.
Rails is taking care of the changeset create endp
mmd-osm left a comment (openstreetmap/openstreetmap-website#5619)
> even the question of how much point there is in treating the two
> separately but that's another can of worms.
The idea to get rid of current tables in one way or another isn't entirely new.
Back in 2009, the infamous "Rant
mmd-osm left a comment (openstreetmap/openstreetmap-website#5607)
It seems there's no need to support optional attribution. I'm going to close
this PR and create another one for this webp one liner:
```
diff --git a/app/assets/javascripts/leaflet.share.js
b/app/assets/javascripts/leaflet.share.
Closed #5607.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5607#event-16321975637
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
Yes, that's totally fine for me. I anyway keep the stats per operation
(create/modify/delete) and object type (node/way/relation).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetm
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
@AntonKhorev : I propose to get started with additional columns for the
changesets table. It should be similar to the existing `num_changes` column,
and ideally supports something like:
```sql
UPDATE changesets
SE
mmd-osm left a comment (openstreetmap/openstreetmap-website#5880)
By the way: it would be really good, if you could also work out a way to use
external SVGs, which is also suitable for
https://github.com/openstreetmap/openstreetmap-website/pull/5080 ... as a
special requirement: the SVG color n
mmd-osm left a comment (openstreetmap/openstreetmap-website#5880)
For additional context: the "icon" in line 137 of `external_svg` refers to an
additional `id="icon"` I had to add to each of the external svgs, like in this
example:
```xml
http://www.w3.org/2000/svg"; id="icon" width="12" heigh
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
I think i'm mostly done with the cgimap part, including unit tests. For the
time being, I have enhanced structure.sql with the following statement:
```
ALTER TABLE public.changesets
ADD COLUMN num_created_nodes integer DEFAULT
mmd-osm left a comment (openstreetmap/openstreetmap-website#5891)
I think a better solution would be to add a "Deleted items" folder with an
option to recover items. The data is anyway still available (see #5496).
Confirmation popups are a good fit for mass deletions only (which we don't
suppor
mmd-osm left a comment (openstreetmap/openstreetmap-website#5941)
It was removed on purpose: #4696
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5941#issuecomment-2817098184
You are receiving this because you are subscribed to
@mmd-osm commented on this pull request.
> @@ -7,7 +7,10 @@ class TracesController < ApiController
def index
@traces = current_user.traces.reload
-render :content_type => "application/xml"
+respond_to do |format|
+ format.xml { render :content_type => "
mmd-osm left a comment (openstreetmap/openstreetmap-website#5937)
Although I couldn't figure out how "to_time_preserves_timezone = :zone" works,
or what "receiver" the documentation talks about, I didn't encounter any
obvious issues on a non UTC-time machine. In particular, test cases were
work
mmd-osm left a comment (openstreetmap/openstreetmap-website#5965)
In case you’re changing something regarding this endpoint, can you also create
an issue for cgimap as well? I can’t commit this will be picked up in the near
future, but at least it should be documented.
--
Reply to this email d
mmd-osm left a comment (openstreetmap/openstreetmap-website#5970)
Changeset download in XML format is currently being served by
https://github.com/zerebubuth/openstreetmap-cgimap. That's where the productive
implementation for JSON format would have to go as well.
--
Reply to this email direct
@mmd-osm commented on this pull request.
> @@ -247,7 +247,7 @@ def respond_to_timeout
# To work round this we call rewind on the body here, which is added
# as a filter, to force it to be fetched from Apache into a file.
def fetch_body
-request.body.rewind
+request.body&.rewind
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
I tried a few variations to have `if-unused` on the same level as it is in the
XML version. This turned out to be tricky. It would require us to introduce
another `elements` array that would have to be added to create and modify
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
> > Changefiles today are usually sorted by (OSM type, OSM id, version). This
> > ensures that most(*) dependent changes are already available, when reading
> > an object. Consumers may rely on that order.
> I think we can keep
mmd-osm left a comment (openstreetmap/openstreetmap-website#5979)
This seems like a breaking change. As an example, JOSM needs to call
/api/versions + /api/0.6/capabilities, instead of /api/capabilities as it is
today.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
mmd-osm left a comment (openstreetmap/openstreetmap-website#5979)
I'm a bit surprised about "deprecated /api/capabilities". Was there any
previous discussion on this topic? How would an api client find out about the
current API version?
--
Reply to this email directly or view it on GitHub:
htt
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
> In my opinion, this format is better because: …
Now for the upload, you might have multiple create/modify/delete blocks in
random order, including repeating blocks for the same action. How would this
work with your proposed for
mmd-osm left a comment (openstreetmap/openstreetmap-website#5970)
I would start in this repo with a json version of
app/views/api/changesets/downloads/show.xml.builder, then add some test cases.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
They could in theory, but the xml format today doesn't have any assumptions in
that direction. Processing happens from top to bottom in the exact sequence
defined in xml, and you're free to do pretty much whatever you like in term
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
I think we can keep the sorting of objects (per action) as is, regardless of
the format.
Obviously we would have to define in which sequence create/modified/delete
actions need to be processed, b/c JSON properties don't have a de
mmd-osm left a comment (openstreetmap/openstreetmap-website#5983)
I see cf-way in the http header, as well as some mix up of different header
fields. Could this be Cloudflare related?
It would be interesting to see if https://master.apis.dev.openstreetmap.org has
the same issue (which doesn't h
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
Indeed, this looks like a good option. It's probably a matter of taste to have
"type": "create" or "action": "create", either way should be ok. I can see the
benefit of keeping the element objects clean.
NB: I plan to use an even
mmd-osm left a comment (openstreetmap/openstreetmap-website#5943)
Thanks! By the way, I've proposed swagger / openapi a few years ago in #3107...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943#issuecomment-2828879487
You are
mmd-osm left a comment (openstreetmap/openstreetmap-website#5943)
@HarelM : It would be nice if you could document your API change on the API 0.6
wiki page ( https://wiki.openstreetmap.org/wiki/API_v0.6 ) to help others
developers.
You can find a bit of change history in the header section. Fur
101 - 200 of 345 matches
Mail list logo
