tomhughes left a comment (openstreetmap/openstreetmap-website#5819)
It's
https://github.com/openstreetmap/openstreetmap-website/blob/9e3f9aa353fc48d994d52b3a17d02be3b81fc7f6/test/lib/i18n_test.rb#L4-L56
which does the check by making sure that each language only uses interpolation
variables whi
tomhughes left a comment (openstreetmap/openstreetmap-website#5819)
Here's an example, with a resource that exists in `fr` but not in `ga`:
```
open-street-map(dev)> I18n.t("redactions.edit.heading", :locale => "fr")
=> "Modifier le masquage"
open-street-map(dev)> I18n.t("redactions.edit.heading"
@tomhughes approved this pull request.
This looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5809#pullrequestreview-2688772612
You are receiving this because you are subscribed to this thread.
Message ID:
tomhughes left a comment (openstreetmap/openstreetmap-website#5815)
The only thing that can actually change over time is the (proposed) tags right?
So is the OSM data model of copying everything the right approach?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstr
tomhughes left a comment (openstreetmap/openstreetmap-website#5821)
No actually it's specific to graphhopper and valhalla and doesn't happen with
OSRM routes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5821#issuecomment-27
As pointed out in
https://github.com/mozilla/geckodriver/issues/2218#issuecomment-2735625538 you
can use port zero to ask Firefox to dynamically allocate a port which should
make this more robust as well as much simpler.
You can view, comment on, or merge this pull request online at:
https://
Closed #5822.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5822#event-16873636646
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
tomhughes left a comment (openstreetmap/openstreetmap-website#5822)
Thanks for the fix, but I just pushed 949c5276091f35e77796d39a4ed024dd2ea9f7da
to fix this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5822#issuecomment-273
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5818#pullrequestreview-2699492936
You are receiving this because you are subscribed to this thread.
Messa
tomhughes left a comment (openstreetmap/openstreetmap-website#5821)
Yes and `bidi` there is not about bidirectional text but about the
bidirectional control port used to drive the browser automatically during
testing.
In any case this is clearly something specific to the user's environment or
tomhughes left a comment (openstreetmap/openstreetmap-website#5812)
Looks good to me, thanks, and we can always change the labels later if we want.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5812#issuecomment-2737540144
You a
Merged #5818 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5818#event-16873865923
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 1 commit.
c7d04440b62e9bff96eef0b75a3b3d765fa69910 Make account deletion remove the
email address when possible
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3488/files/f7a852942eee4a596578ddd270ec2bc3606dd58c..c7d04440b62e9bff96eef0b75a3b3
Closed #5807 as completed via #5823.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5807#event-16875830029
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tomhughes pushed 1 commit.
843f6c492750fe56ec72fa4fbcbb31b2288a760b Allow users to delete their own diary
entries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4540/files/11a59aadfb8cf32de0808f8f8d98212cf9b21582..843f6c492750fe56ec72fa4fbcbb31b2288a760b
You
@tomhughes pushed 4 commits.
8c4d380e32d05598f0f1e25f6fcec5df5b46c61e Update to rails 8.0.2
590e30caec804b9029c544e6f5c9e374c560fc34 Replace permit/require with expect
for parameter validation
dafdfeceaa50af2b539c8654ae1738abeab4284a Avoid parsing of XML requests with ;
in the body
ab030b54c0
Merged #5824 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5824#event-16876456770
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5430)
Oh think I forgot about that... Will have to investigate.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5430#issuecomment-2740119238
You are receiving this beca
tomhughes left a comment (openstreetmap/openstreetmap-website#5821)
Yes it was caused by that update but updates aren't automatically deployed to
production when they're merged here - that happens manually usually every day
or two.
--
Reply to this email directly or view it on GitHub:
https://
tomhughes left a comment (openstreetmap/openstreetmap-website#5430)
Looks like they've done a release so I'll update that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5430#issuecomment-2740122292
You are receiving this because
tomhughes left a comment (openstreetmap/openstreetmap-website#5900)
This doesn't seem to work in Firefox on Android but it does in Chrome, and
presumably in Safari on iOS, so it looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
tomhughes left a comment (openstreetmap/openstreetmap-website#5899)
Reading https://github.com/openstreetmap/trac-tickets/issues/5065 it seems the
javascript fallback was for IE so it can definitely go and this looks good to
me.
--
Reply to this email directly or view it on GitHub:
https://git
Merged #5898 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5898#event-17143360238
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5898)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5898#issuecomment-2781446348
You are receiving this because you are subscribed to this t
@tomhughes approved this pull request.
Looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5863#pullrequestreview-2745158401
You are receiving this because you are subscribed to this thread.
Message ID
Closed #5859 as completed via #5863.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5859#event-17143360293
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5900 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5900#event-17143360239
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5899 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5899#event-17143360237
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5863 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5863#event-17143360242
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5882)
Can confirm it works nicely in Firefox on Android but not on desktop - there is
an option to enabled it on desktop but (at least on linux) nothing actually
happens when you click it and the console shows that the promise is reso
tomhughes left a comment (openstreetmap/openstreetmap-website#5121)
> ... to indicate if an entry has been truncated
What should this look like because I don't seem to be seeing this? I also can't
see anything in the code that looks like it would do it?
--
Reply to this email directly or view
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
Second weekend in a row that coveralls has a 24 hour planned outage...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#issuecomment-2781315481
You are rece
tomhughes left a comment (openstreetmap/openstreetmap-website#5897)
Looks good to me, thanks. The test failures are related to coveralls and can be
ignored.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5897#issuecomment-278131
Merged #5877 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5877#event-17142615589
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5893 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5893#event-17142615584
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5877)
I'm a bit worried that we're going round in circles here but I'll merge this
for now... Hopefully somebody can work on better ways to do updates in the
future.
--
Reply to this email directly or view it on GitHub:
https://gith
Merged #5897 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5897#event-17142615585
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5896 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5896#event-17142615587
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5896)
If the test fails then the first thing you're going to do is look at the test
and I think it's pretty obvious there what's going on so I think this is
probably fine.
--
Reply to this email directly or view it on GitHub:
https:
tomhughes left a comment (openstreetmap/openstreetmap-website#5893)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5893#issuecomment-2781316685
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5828)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5828#issuecomment-2741101731
You are receiving this because you are subscribed to this t
Merged #5823 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5823#event-16875829806
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5831)
The `sqrt` one looks pretty good to me?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5831#issuecomment-2742945154
You are receiving this because you are subs
Merged #5812 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5812#event-16873865945
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5826)
Thanks - this looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5826#issuecomment-2746385756
You are receiving this because you are subscribed
tomhughes left a comment (openstreetmap/openstreetmap-website#5892)
I don't actually remember the data layer being anything other than blue but it
does look like the previous, presumably working, styling existed before #328
broke it.
Looks good to me anyway.
--
Reply to this email directly or
Merged #5892 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5892#event-17140581139
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5827 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5827#event-16914775148
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5888 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5888#event-17139612969
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5885)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5885#issuecomment-2780651150
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5881)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5881#issuecomment-2780647831
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5872)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5872#issuecomment-2780648811
You are receiving this because you are subscribed to this t
Merged #5890 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5890#event-17139564633
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5885 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5885#event-17139564632
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5886 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5886#event-17139564631
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5872 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5872#event-17139564628
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5881 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5881#event-17139564630
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5886)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5886#issuecomment-2780651969
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5889)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5889#issuecomment-2780655711
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5877)
Well https://github.com/openstreetmap/leaflet-osm/pull/38 explains the reasons
for asynchronous operation - are you saying that the reasons there are somehow
incorrect?
--
Reply to this email directly or view it on GitHub:
htt
Merged #5889 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5889#event-17139612972
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5888)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5888#issuecomment-2780655241
You are receiving this because you are subscribed to this t
Closed #5845 as completed via ca938d07a26b21bc528e7b55db1649ccdd62c217.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5845#event-16995964376
You are receiving this because you are subscribed to this thread.
Message ID:
__
tomhughes left a comment (openstreetmap/openstreetmap-website#5819)
Well we don't allow that - as you say if necessary we have to change the
translations and we have tests to ensure that we catch it if Translatewiki push
broken translations back to us.
--
Reply to this email directly or view i
Closed #5821 as completed via 949c5276091f35e77796d39a4ed024dd2ea9f7da.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5821#event-16873609803
You are receiving this because you are subscribed to this thread.
Message ID:
__
@tomhughes pushed 2 commits.
33870d09dbefb0ad3302183ecdc9577e24ef6fb3 Add dir=auto to user generated content
b5ed10168ac6c31d6e6d1f404d749a4a521a4020 Add dir=auto to usernames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3429/files/4c46fcbb0fc300c82333f7353
tomhughes left a comment (openstreetmap/openstreetmap-website#5845)
I really don't believe that the second screenshot is the output of running
`db:migrate` it looks more like a web page to me?
Please post the full output of running `db:migrate` preferably as text rather
than a screenshot.
--
Merged #5901 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5901#event-17144344711
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5901)
I think the only thing I might question is the removal of multi-leg support but
I guess without waypoints the engines are only going to return one leg and in
general this looks good to me, thanks.
--
Reply to this email direct
Merged #5843 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5843#event-16979834608
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5844)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5844#issuecomment-2752275823
You are receiving this because you are subscribed to t
Merged #4872 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4872#event-16980672025
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -76,11 +76,13 @@ def sanitize(text)
end
def linkify(text, mode = :urls)
- if text.html_safe?
-Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow
noopener noreferrer")).html_safe
- else
-Rink
@tomhughes commented on this pull request.
> +const textarea = content.find("textarea");
+if (textarea.length) {
+ data.set("text", textarea.val());
+}
Which API call are you talking about? Surely we want to avoid any errors?
--
Reply to this email directly or
tomhughes left a comment (openstreetmap/openstreetmap-website#4872)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4872#issuecomment-2752290742
You are receiving this because you are subscribed to this t
Merged #5844 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5844#event-16980672003
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5846)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5846#issuecomment-2754953766
You are receiving this because you are subscribed to this t
Merged #5846 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5846#event-16995964534
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Fixes #5847 by forcing migrations to run in test, and fixing some noise that
had crept into the structure as a result of them not running.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5848
-- Commit Summary --
*
tomhughes left a comment (openstreetmap/openstreetmap-website#5847)
How can the tests run if the migrations haven't run?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5847#issuecomment-2754928143
You are receiving this because
tomhughes left a comment (openstreetmap/openstreetmap-website#5842)
I think this is probably fine as it is, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5842#issuecomment-2755391411
You are receiving this because you ar
tomhughes left a comment (openstreetmap/openstreetmap-website#5847)
Also how does the structure compare equal? It can't possibly so the migrations
must have run, it just doesn't log the output?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-
tomhughes left a comment (openstreetmap/openstreetmap-website#5847)
Oh it's loading `structure.sql` instead of running migrations even though we
explicitly ask it to run migrations? Even removing `db/structure.sql` first
doesn't help - it sill doesn't run the migrations and you get an empty data
@tomhughes commented on this pull request.
> @@ -3,6 +3,10 @@ def self.full_definitions(layers_filename)
YAML.load_file(Rails.root.join(layers_filename))
.reject { |layer| layer["apiKeyId"] && !Settings[layer["apiKeyId"]] }
.map do |layer|
+ layer["name"] = I18n.t
@tomhughes commented on this pull request.
> +# "li", # child; sometimes container
+
+"table", # similar to Discourse, where the parent of
gets dir="auto" (no parent div in kramdown)
+# "td", # child
+# "th", # child; not actually a thing in kramdown but hypoth
Merged #5842 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5842#event-16998425853
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #647 as completed via #5826.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/647#event-16945524843
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes commented on this pull request.
> @@ -1,5 +1,45 @@
# frozen_string_literal: true
+module Kramdown
Actually https://kramdown.gettalong.org/rdoc/Kramdown/Converter/Base.html is
the relevant documentation here but yes it does seem that this is intended as
an extension point.
--
R
Merged #5825 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5825#event-16914942287
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5852)
Looks food to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5852#issuecomment-2758877309
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5855)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5855#issuecomment-2758892572
You are receiving this because you are subscribed to this t
Merged #5852 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5852#event-17019034389
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5850 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5850#event-17019034382
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5855 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5855#event-17019034403
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5850)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5850#issuecomment-2758899837
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5853)
I haven't really reviewed the PRs relating to hiding the heatmap because I was
waiting to see how the policy questions played out so I would know what we
needed to do.
--
Reply to this email directly or view it on GitHub:
http
@tomhughes commented on this pull request.
This is adding a whole load of names to the global namespace and I'm not sure
any of it is necessary...
Is there are reason all the things declared at global scope before the event
listener can't be declared inside it as they were before?
--
Reply
@tomhughes commented on this pull request.
> @@ -2,7 +2,10 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.body.to_html(2000) : diary_entry.body.to_html
%>
+<% if
tomhughes left a comment (openstreetmap/openstreetmap-website#5832)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832#issuecomment-2794392403
You are receiving this because you are subscribed to this t
901 - 1000 of 2140 matches
Mail list logo
