@tomhughes approved this pull request.
Thanks for the changes. I think this all looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#pullrequestreview-2619362102
You are receiving this because you are subscribed
Merged #5669 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#event-16321099868
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 2 commits.
acabad71a669c632bea8b96e9edbf0e37a763e43 Update eslint to prefer let/const
over var
83dde9e78e9ea4eb6a7be3e5cb43bf740082f6b2 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
tomhughes left a comment (openstreetmap/openstreetmap-website#5662)
Superseded by #5669.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5662#issuecomment-2660832367
You are receiving this because you are subscribed to this thread
Closed #5662.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5662#event-16321102866
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
tomhughes left a comment (openstreetmap/openstreetmap-website#5521)
This PR is marked as draft - if it's ready for review can you clear the draft
flag please?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521#issuecomment-2660
Merged #5452 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5452#event-16321353285
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks for the fix - this looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521#pullrequestreview-2619424293
You are receiving this because you are subscribed to this t
This enhances the user list view for administrators to include a search
parameter bar at the top, to allow searching by IP subnet, and to properly
preserve all search fields in links.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap
Merged #5521 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521#event-16321799200
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> + note_ids = notes.pluck(:id)
+
+ sql_query = <<-SQL.squish
+WITH first_comment AS(
+ SELECT DISTINCT ON (note_id) *
+ FROM note_comments
+ WHERE note_id BETWEEN #{note_ids.min} AND #{note_ids.max}
+
tomhughes left a comment (openstreetmap/openstreetmap-website#5667)
> How will that code know if the first comment has been already deleted for a
> given note? It can't just be `all_comments.drop(1)` for example, since that
> won't work after the next migration has completed.
I was imagining de
@tomhughes pushed 2 commits.
b3e0a7b5fd43680e3ca992ac7c31a9bfb09c47a6 Update eslint to prefer let/const
over var
61760af161bab1b8a91dc08df63d139d70185e1c Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Closed #865 as completed via b14965e4b211ad7eece9b8a77b984c140744dc8f.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/865#event-16322047640
You are receiving this because you are subscribed to this thread.
Message ID:
tomhughes left a comment (openstreetmap/openstreetmap-website#5679)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5679#issuecomment-2660989708
You are receiving this because you are subscribed to this t
Merged #5679 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5679#event-16322047643
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5131 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5131#event-16322096668
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5131)
Most of the discussion here seems to be about whether this goes far enough but
I don't see any significant complaints about the things this does do, and it
looks good to me so I'm going to merge it.
If people want to propose ad
tomhughes left a comment (openstreetmap/openstreetmap-website#2621)
It's been pointed out on #5200 that this could be simplified by using the
`tag2link` npm package and loading the JSON data it includes - we'd probably
want to only link things with a rank of `preferred` if only to avoid having
I think this should be reasonably safe - it will need three reports to trigger
a suspension or possibly less if there are already links in the content adding
to a score.
Given the negative influence of edits on the score it's unlikely that
people reporting users for map spam will manage to trig
tomhughes left a comment (openstreetmap/openstreetmap-website#5663)
That change does indeed seem to be the cause.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5663#issuecomment-2660963705
You are receiving this because you ar
tomhughes left a comment (openstreetmap/openstreetmap-website#5521)
It still seems to be restricted to half the screen for me:
--
Reply to this email directly or view it on GitHub:
https://github.com/open
Long term we should fix the sidebar to use turbo but for now this fixes #5663.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5678
-- Commit Summary --
* Prevent caching a partial XHR response as a full page URL
--
Merged #5233 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5233#event-16321895028
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5233)
This looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5233#issuecomment-2660969747
You are receiving this because you are subscribed
Closed #5683 as completed via #5686.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5683#event-16323960837
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5686 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5686#event-16323960802
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 2 commits.
f83424aeb20cf371925094c6640ff407185cc0a4 Update eslint to prefer let/const
over var
c47cb299a842a2eb7d022fcf4f0d02c08001f928 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
tomhughes left a comment (openstreetmap/openstreetmap-website#5686)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5686#issuecomment-2661381664
You are receiving this because you are subscribed to this t
Closed #648 as completed via 793757a6ff4a6ca3cb7ad5454fec1c51fe63804f.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/648#event-16323960799
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #5684 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5684#event-16323643765
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5684)
I usually just hack to code temporarily to do that, but it looks good to me,
thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5684#issuecomment-2661320634
tomhughes left a comment (openstreetmap/openstreetmap-website#4359)
This looks good to me. Thanks for keeping it alive for so long.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4359#issuecomment-2661332529
You are receiving thi
Merged #4359 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4359#event-16323706600
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 2 commits.
887ec6f6ef56ce660a43306dd771d8768e7b58b5 Update eslint to prefer let/const
over var
a2de8402b34f3d68e49260bd52b71fa837f83a4a Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
tomhughes left a comment (openstreetmap/openstreetmap-website#5558)
I've rebased this now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#issuecomment-2661341416
You are receiving this because you are subscribed to this thre
tomhughes left a comment (openstreetmap/openstreetmap-website#5656)
I've just discussed this with @gravitystorm and we think the fallback code
should only be enabled when the old route is used - the best way to do that is
probably to have the route set a flag parameter and then make the action o
tomhughes left a comment (openstreetmap/openstreetmap-website#5681)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5681#issuecomment-2661018313
You are receiving this because you are subscribed to this t
Merged #5681 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5681#event-16322231598
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5800)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5800#issuecomment-2725228239
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5765)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5765#issuecomment-2725254119
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5439)
That seems to have been some glitch with the tests. I forced a rerun and they
passed fine.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2711
Closed #5798 as completed via #5799.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5798#event-16777680654
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5754 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5754#event-16620261499
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -8,6 +8,7 @@ use Pod::Usage;
use MediaWiki::API;
use Test::More qw(no_plan);
use YAML::XS qw(Dump);
+# NOTE: on macos, LWP::Protocol::https also needs to be installed
There's nothing macos specific about that - the https protocol handler is in
tomhughes left a comment (openstreetmap/openstreetmap-website#5819)
Missing translations do fall back to english - what make you think they don't?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5819#issuecomment-2734882038
You
tomhughes left a comment (openstreetmap/openstreetmap-website#5823)
It's a bit nasty but I don't see a better solution - the ideal would be that
the server forces a full page reload when it needs to redirect the id frame to
the login but that isn't possible for obvious reasons because of the sec
tomhughes left a comment (openstreetmap/openstreetmap-website#5820)
It also hasn't been deployed yet!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#issuecomment-2737465744
You are receiving this because you are subscribed t
tomhughes left a comment (openstreetmap/openstreetmap-website#5824)
I'm not really sure why it's doing that... There an aspiration to separate API
calls onto a separate domain which I guess is the reason but we've never got
anywhere near making it a reality.
--
Reply to this email directly or
tomhughes left a comment (openstreetmap/openstreetmap-website#5824)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5824#issuecomment-2737774611
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5837)
Looks good to me, thanks.
I was going to say we should do the same for diary entries, but I see that
already use `article` so there's nothing to do there.
--
Reply to this email directly or view it on GitHub:
https://github.co
@tomhughes requested changes on this pull request.
Looks good to me - just one small cosmetic comment.
> @@ -97,11 +158,22 @@ OSM.History = function (map) {
.then(response => response.text())
.then(function (html) {
displayFirstChangesets(html);
+enableChangesetInte
tomhughes left a comment (openstreetmap/openstreetmap-website#5835)
Can you also squash the fixup commits into the commit they're fixing please.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5835#issuecomment-2746264423
You are
tomhughes left a comment (openstreetmap/openstreetmap-website#5835)
In fact this is going to just wind up as a single commit I think so squash
everything together unless you have a good reason not to.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
@tomhughes commented on this pull request.
> @@ -139,6 +139,16 @@
+<% if @user.home_location_name &&
@user.home_location_name.strip.present? %>
This could just be `@user.home_location_name&.strip.present?`?
> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndp
Merged #5826 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5826#event-16945524797
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5836 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5836#event-16943964850
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5837 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5837#event-16943964848
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5827)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5827#issuecomment-2741046475
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5825)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5825#issuecomment-2741145208
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5430)
Ah I had actually re-enabled the gem but forgot to uncomment the config again.
Now fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5430#issuecomment-27401
tomhughes left a comment (openstreetmap/openstreetmap-website#5831)
I hadn't realised we were using fixed buckets - that does seem like a poor
choice.
Is there any benefit to use one of the log types rather than linear, to better
capture variation at the low end for people that occasionally do
Merged #5830 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5830#event-16932984750
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5834 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5834#event-16932984762
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes requested changes on this pull request.
> @@ -3,6 +3,10 @@ def self.full_definitions(layers_filename)
YAML.load_file(Rails.root.join(layers_filename))
.reject { |layer| layer["apiKeyId"] && !Settings[layer["apiKeyId"]] }
.map do |layer|
+ layer["name"]
tomhughes left a comment (openstreetmap/openstreetmap-website#5830)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5830#issuecomment-2744021100
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5834)
It's a bit annoying having to use mix our own translation with the browser's
like this bit it seems to work OK so this looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/ope
tomhughes left a comment (openstreetmap/openstreetmap-website#5829)
Well we can allow moderators to see the heatmap even where the user has asked
to hide it, and I was assuming that we would, which helps with the review
problem.
--
Reply to this email directly or view it on GitHub:
https://git
tomhughes left a comment (openstreetmap/openstreetmap-website#5706)
There's no need to "accept" changes to the terms though, or rather the terms
says that you're expected to check them when you want and that [continuing to
use the service constitutes acceptance of any
changes](https://osmfounda
tomhughes left a comment (openstreetmap/openstreetmap-website#5121)
I think this needs some sort of indication when an entry has been truncated -
an ellipsis at the end of the truncated text or something.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/ope
tomhughes left a comment (openstreetmap/openstreetmap-website#5829)
Look I don't want to remove it but it legally we have no choice but to offer
that option then so be it - it would be good to get an actual statement from
the current LWG rather than comments from a former member of course.
My c
tomhughes left a comment (openstreetmap/openstreetmap-website#5845)
Whatever your problem with migrations is I can assure it's nothing to do with
that message.
It doesn't really make much sense for `db:migrate` to complain about pending
migrations because it's job is to run them but I've never
Reopened #5845.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5845#event-16970894205
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
Closed #5845 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5845#event-16970666145
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@tomhughes pushed 1 commit.
6ea3991de6ee0fc78335663a6a33f611d1304efb Update to i18n-js 4.x
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811/files/93fab10f6e606e14a867bac1f5a990d22c41cd6d..6ea3991de6ee0fc78335663a6a33f611d1304efb
You are receiving this becau
@tomhughes commented on this pull request.
> @@ -0,0 +1,19 @@
+module MapLayers
+ def self.full_definitions(layers_filename)
+YAML.load_file(Rails.root.join(layers_filename)).filter_map do |layer|
Err... I guess... Which is why I hate that sort of control flow :-(
--
Reply to this email
Merged #5809 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5809#event-16791863281
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -0,0 +1,19 @@
+module MapLayers
+ def self.full_definitions(layers_filename)
+YAML.load_file(Rails.root.join(layers_filename)).filter_map do |layer|
This isn't actually doing any filtering it is? The block always returns a
"truthy" value so
@tomhughes pushed 1 commit.
6f887001dec8a31da29ee3a17d64549511d21bff Filter out invisible nodes and ways
during initial selection
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5589/files/ff0c1b492a966b183d8a03f47bc4b8c9f598418d..6f887001dec8a31da29ee3a17d645
This updates i18n-js to the 4.x branch which requires quite a bit of
re-engineering due to upstream API changes.
Although this looks quite large the vast majority of it is just replacement of
`I18n.t` with `OSM.i18n.t` as you now need to instantiate an instance of I18n
instead of just using glo
@tomhughes pushed 1 commit.
37dfb402cfe3d8e6429f80ebacbe37ae97fef158 Update to i18n-js 4.x
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811/files/aa75a1ec628fe387342bce58f90ca14bc6c3714e..37dfb402cfe3d8e6429f80ebacbe37ae97fef158
You are receiving this becau
@tomhughes pushed 1 commit.
93fab10f6e606e14a867bac1f5a990d22c41cd6d Update to i18n-js 4.x
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811/files/37dfb402cfe3d8e6429f80ebacbe37ae97fef158..93fab10f6e606e14a867bac1f5a990d22c41cd6d
You are receiving this becau
tomhughes left a comment (openstreetmap/openstreetmap-website#5806)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5806#issuecomment-2727479794
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5805)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5805#issuecomment-2727498726
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#1148)
Well technically this issue suggests including note comments as well, which are
there, but on a separate link.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/
Merged #5813 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5813#event-16792398736
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5806 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5806#event-16791358517
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5796)
I don't normally self-merge things but nobody has spotted any problems with
this and it's getting annoying seeing a sea of red in the PR queue so I'm going
to merge and if anybody spots a problem we can fix it later.
--
Reply
Merged #5796 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5796#event-16791358519
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5802 as completed via #5806.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5802#event-16791358588
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5805 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5805#event-16791358522
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 1 commit.
cc525cdf2a47f9807ce71cc4722265d8c344122f Update to i18n-js 4.x
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811/files/6ea3991de6ee0fc78335663a6a33f611d1304efb..cc525cdf2a47f9807ce71cc4722265d8c344122f
You are receiving this becau
tomhughes left a comment (openstreetmap/openstreetmap-website#5811)
I've split this as suggested so that the mass renaming can be done first and
then the functional changes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811#is
tomhughes left a comment (openstreetmap/openstreetmap-website#5799)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5799#issuecomment-2725223986
You are receiving this because you are subscribed to this t
Merged #5800 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5800#event-16777680245
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5765 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5765#event-16777875466
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> +
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\.
Merged #5801 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5801#event-16778327177
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5801)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5801#issuecomment-2725348044
You are receiving this because you are subscribed to this t
@tomhughes requested changes on this pull request.
I'm not sure why you say union is hard? We have
https://github.com/brianhempel/active_record_union installed already so you can
just use the `union` or `union_all` method on a relation to merge it with
another one?
> + # Common SQL for activi
801 - 900 of 2182 matches
Mail list logo
