Re: [openstreetmap/openstreetmap-website] Create api map resource (PR #5545)

2025-01-24 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5545#issuecomment-2612760562 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Embedded map - missing cs-CZ translation (Issue #5526)

2025-01-20 Thread Tom Hughes via rails-dev
I very much doubt that "only mobile browsers are affected" here - it's much more likely that what matters is what `Accept-Language` header the browser sends and that the mobile browsers you have tested are doing configured differently. -- Reply to this email directly or view it on GitHub: http

Re: [openstreetmap/openstreetmap-website] Embedded map - missing cs-CZ translation (Issue #5526)

2025-01-20 Thread Tom Hughes via rails-dev
Desktop firefox doesn't even offer `cs-CZ` as an option , just plain `cs` but I can reproduce the problem using a country specific version of arabic with the client side I18n failing to fall back to generic arabic. -- Reply to this email directly or view it on GitHub: https://github.com/openstr

[openstreetmap/openstreetmap-website] Enable I18n fallback for the embed page (PR #5527)

2025-01-20 Thread Tom Hughes via rails-dev
Enable I18n fallback for the embed page to fix #5526. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5527 -- Commit Summary -- * Enable I18n fallback for the embed page -- File Changes -- M app/assets/javascri

[openstreetmap/openstreetmap-website] Friend cleanups (PR #5512)

2025-01-17 Thread Tom Hughes via rails-dev
This continues the renaming of friends as follows by tidying up some of the remaining code references to friendships. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5512 -- Commit Summary -- * Rename friends_with t

Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode (PR #5340)

2025-01-18 Thread Tom Hughes via rails-dev
Closed #5340. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5340#event-15986254965 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)

2025-01-18 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. Why does this need to use `[:user_id]` etc rather than the more typical `.user_id` form? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5511#pullrequestreview-2560409294 You are recei

Re: [openstreetmap/openstreetmap-website] Remove "Public editing" line from settings page (PR #5513)

2025-01-18 Thread Tom Hughes via rails-dev
Seems reasonable to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5513#issuecomment-2599683565 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Remove "Public editing" line from settings page (PR #5513)

2025-01-18 Thread Tom Hughes via rails-dev
Merged #5513 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5513#event-15985685179 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use dark map tiles classlessly (PR #5507)

2025-01-18 Thread Tom Hughes via rails-dev
@tomhughes pushed 7 commits. 297e8374f495d2487d42a4ad96a0f0d981ffd697 Adds validating of notes foreign key 9c744ab65da1a5ae8a94c8738878d23ed278684b Remove "Public editing" line from settings page 8809e1fd08377ebb010db09a5fd7de7e759d2583 Merge remote-tracking branch 'upstream/pull/5510' 8312dd

Re: [openstreetmap/openstreetmap-website] Adds validating of notes foreign key (PR #5510)

2025-01-18 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5510#issuecomment-2599682550 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Adds validating of notes foreign key (PR #5510)

2025-01-18 Thread Tom Hughes via rails-dev
Merged #5510 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5510#event-15985685184 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use dark map tiles classlessly (PR #5507)

2025-01-18 Thread Tom Hughes via rails-dev
I've tweaked this a bit to remove the unused code for adding a class and reworded the commit messages but other than that I think this looks good now. Thanks for all your work on the different versions. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/opens

Re: [openstreetmap/openstreetmap-website] Use dark map tiles classlessly (PR #5507)

2025-01-18 Thread Tom Hughes via rails-dev
Merged #5507 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5507#event-15985707383 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use class based map tiles dark mode (PR #5505)

2025-01-18 Thread Tom Hughes via rails-dev
Closed #5505. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5505#event-15985711952 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Use class based map tiles dark mode (PR #5505)

2025-01-18 Thread Tom Hughes via rails-dev
Superseded by #5507. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5505#issuecomment-2599692179 You are receiving this because you are subscribed to this thread. Message ID: ___ rails

Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode (PR #5340)

2025-01-18 Thread Tom Hughes via rails-dev
I believe so, yes. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5340#issuecomment-2599792845 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-d

Re: [openstreetmap/openstreetmap-website] Initialize I18n and OSM as soon as application.js loads (PR #5538)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5538 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5538#event-16069473426 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.4 to 2.3.5 (PR #5553)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5553 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5553#event-16069473415 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.18.0 to 9.19.0 (PR #5552)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5552 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5552#event-16069473427 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Message read_mark and mute resources (PR #5536)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5536 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5536#event-16069473420 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

2025-01-26 Thread Tom Hughes via rails-dev
> I'm working on resolving this CSP violations. Right now I'm trying to > generate nonce for the .js file and use that to validate and transpass the > CSP violation. I'm not sure if it is the right approach for this since I > never had experience dealing with similar stuff before. If there is a

Re: [openstreetmap/openstreetmap-website] Initialize I18n and OSM as soon as application.js loads (PR #5538)

2025-01-26 Thread Tom Hughes via rails-dev
I thought I had merged this one the other day but apparently not... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5538#issuecomment-2614313656 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Added error handling for data layer (PR #5551)

2025-01-26 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5551#issuecomment-2614314619 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Added error handling for data layer (PR #5551)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5551 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5551#event-16069473422 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Drop some legacy browser support code (PR #5556)

2025-01-26 Thread Tom Hughes via rails-dev
@tomhughes pushed 2 commits. 776459a0a092f06fbab170db456292236c9e8de9 Drop ES6 polyfill 22b00228639e58c7a9ad2991d3d4993a5fff101f Drop IE specific favicon support -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5556/files/ac1b98acae13ffd1e7680e30833be80c0c0ad81

Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)

2025-01-27 Thread Tom Hughes via rails-dev
Can we keep this on topic please... I have no idea what holes you are referring to in any case - we made the decision to allow newer JS features and knew full well that might affect a very small number of people using old browsers but in any case this is not the place to discuss it. Until @maro

Re: [openstreetmap/openstreetmap-website] Message read_mark and mute resources (PR #5536)

2025-01-26 Thread Tom Hughes via rails-dev
@tomhughes approved this pull request. Thanks - this all looks good now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5536#pullrequestreview-2574191440 You are receiving this because you are subscribed to this thread. Messag

Re: [openstreetmap/openstreetmap-website] Refactor embed.js.erb (PR #5550)

2025-01-26 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. This looks pretty good - just a couple of minor suggestions that I've made inline. > @@ -15,14 +15,7 @@ I18n.default_locale = <%= I18n.default_locale.to_json %>; I18n.fallbacks = true; window.onload = function () { - var query = (window.location.se

[openstreetmap/openstreetmap-website] Drop some legacy browser support code (PR #5556)

2025-01-26 Thread Tom Hughes via rails-dev
This drops the ES6 polyfill which is a bit pointless since #5421 allows ES2021 code now. It also drops an IE specific legacy favicon tag, which allows us to drop the dependency on the browser gem. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap

[openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)

2025-01-26 Thread Tom Hughes via rails-dev
This updates the eslint config to prohibit use of `var` and to prefer `const` over `let` and then fixes all uses of `var` to respect that. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5558 -- Commit Summary -- *

Re: [openstreetmap/openstreetmap-website] Move deprecated eslint rules to stylistic plugin (PR #5557)

2025-01-26 Thread Tom Hughes via rails-dev
Shouldn't this update `yarn.lock` as well as `package.json`? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5557#issuecomment-2614555995 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Modernize eslint config (Issue #5554)

2025-01-25 Thread Tom Hughes via rails-dev
Can you explain what this has to do with keeping the current config? Are you saying that the current config is invoking some style rules that are no longer having any effect? We'd still want to keep the other rules though? We wouldn't want to just dump the whole thing... -- Reply to this email

Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)

2025-01-25 Thread Tom Hughes via rails-dev
There haven't been any deployments for days so this is not related to #1155 at all - that was an operational issue relating to the production deployment and was something triggered by doing new deployments I believe. Nobody else has reported any problems so it seems this must be something speci

Re: [openstreetmap/openstreetmap-website] Close button for loading error alert (PR #5561)

2025-01-27 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5561#issuecomment-2616704016 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Close button for loading error alert (PR #5561)

2025-01-27 Thread Tom Hughes via rails-dev
Merged #5561 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5561#event-1608300 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Increase the limit when a warning about a large number of objects is displayed (PR #5562)

2025-01-27 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5562#issuecomment-2616706362 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Increase the limit when a warning about a large number of objects is displayed (PR #5562)

2025-01-27 Thread Tom Hughes via rails-dev
Merged #5562 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5562#event-1608301 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] DataLayer to consume JSON format responses (PR #5563)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5563#issuecomment-2619803933 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Move deprecated eslint rules to stylistic plugin (PR #5557)

2025-01-28 Thread Tom Hughes via rails-dev
Does that vscode config file work automatically? It seems like an unlikely location for it to be found? I thought `.vscode/settings.json` was the location for workspace setting to be picked up automatically... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetma

Re: [openstreetmap/openstreetmap-website] DataLayer to consume JSON format responses (PR #5563)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5563 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5563#event-16098071837 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove unused max_features parameter from feature warning (PR #5566)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5566#issuecomment-2619752956 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Removes author_{id, ip} methods from Note model (PR #5568)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5568#issuecomment-2619769695 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove unused max_features parameter from feature warning (PR #5566)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5566 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5566#event-16097798944 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.5 to 2.3.6 (PR #5564)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5564 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5564#event-16097798955 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove IE conditional compilation that limited max features (PR #5565)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5565 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5565#event-16097798975 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove layersAdded variable from map.updateLayers() (PR #5560)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5560 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5560#event-16097798961 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)

2025-01-28 Thread Tom Hughes via rails-dev
@tomhughes pushed 5 commits. df227ee2742e454f6c20a5025c6324e40eb27662 Drop support for ruby 3.1 a38e5a9584748a8465dc3084eaba00b4d9829627 Update to rails 8.0.1 bf682f34acb6ab4b82829f39b66f7654a97447e8 Avoid parsing of XML requests with ; in the body d09621c354d381c8a380a8c97444f21532205a33 Use

Re: [openstreetmap/openstreetmap-website] Remove IE conditional compilation that limited max features (PR #5565)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5565#issuecomment-2619749568 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove layersAdded variable from map.updateLayers() (PR #5560)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5560#issuecomment-2619761711 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Removes author_{id, ip} methods from Note model (PR #5568)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5568 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5568#event-16097798945 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove jquery-simulate (PR #5567)

2025-01-28 Thread Tom Hughes via rails-dev
Is that replacement something new that didn't exist when `simulate` was created? or does it have limitations compared to `simulate` that we were trying to avoid? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5567#issuecomment-2

Re: [openstreetmap/openstreetmap-website] Replace info message with clearer version (PR #5569)

2025-01-28 Thread Tom Hughes via rails-dev
Closed #5569. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5569#event-16100820377 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Replace info message with clearer version (PR #5569)

2025-01-28 Thread Tom Hughes via rails-dev
Changes to iD need to be filed at https://github.com/openstreetmap/iD. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5569#issuecomment-2620302652 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Repo: editor help to find eslint config file (Issue #5572)

2025-01-29 Thread Tom Hughes via rails-dev
My vote would be for `.vscode/settings.json` because a hidden file doesn't really pollute the root folder in a meaningful way. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5572#issuecomment-2620976179 You are receiving this b

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-21 Thread Tom Hughes via rails-dev
This all looks great to me, thanks. We probably want to think about indexes because changeset comments don't have an index on author+id (neither do diary comments but some people have 80k changeset comments vs a few hundred diary comments) but I don't think that's a blocker based on some quick

[openstreetmap/openstreetmap-website] Preload parent objects for user comments (PR #5530)

2025-01-21 Thread Tom Hughes via rails-dev
I noticed that the comment views were loading objects one by one and this should make it more efficient. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5530 -- Commit Summary -- * Preload parent objects for user co

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #4248)

2025-01-21 Thread Tom Hughes via rails-dev
Closed #4248. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4248#event-16019021545 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Test fallback locale on embed page (PR #5528)

2025-01-21 Thread Tom Hughes via rails-dev
Merged #5528 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5528#event-16019015774 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #4248)

2025-01-21 Thread Tom Hughes via rails-dev
Superseded by #5518. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4248#issuecomment-2605528199 You are receiving this because you are subscribed to this thread. Message ID: ___ rails

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-21 Thread Tom Hughes via rails-dev
Merged #5518 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5518#event-16019015784 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

[openstreetmap/openstreetmap-website] Add indes on user+id to changeset and diary comments (PR #5531)

2025-01-21 Thread Tom Hughes via rails-dev
This adds indexes on `user+id` to diary and changeset comments to make comment views more efficient. Once this is merged we can switch the `diary_comments` association on users to sort by id instead of creation date and then drop the creation date indexes. You can view, comment on, or merge this

Re: [openstreetmap/openstreetmap-website] Add indexes on user+id to changeset and diary comments (PR #5531)

2025-01-21 Thread Tom Hughes via rails-dev
Those indexes are all pretty tiny currently so I guess keeping them doesn't hurt. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5531#issuecomment-2605864060 You are receiving this because you are subscribed to this thread. Mess

Re: [openstreetmap/openstreetmap-website] Repo: editor help to find eslint config file (Issue #5572)

2025-01-29 Thread Tom Hughes via rails-dev
> Other than that, what I find useful many times is the amazing [just command > runner](https://github.com/casey/just) that is multi-platform. If you often > find yourself executing the same command in the terminal, this might be > useful such that everybody can do something like `just lint js`.

Re: [openstreetmap/openstreetmap-website] Refactor embed.js.erb with layers.yml (PR #5571)

2025-01-29 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > <% end %> }; var map = L.map("map"); map.attributionControl.setPrefix(""); map.removeControl(map.attributionControl); - if (args.layer === "cyclosm") { -new L.OSM.CyclOSM().addTo(map); - } else if (args.layer === "cyclemap" || a

Re: [openstreetmap/openstreetmap-website] Don't remove-readd standard layer with visible overlays (PR #5573)

2025-01-29 Thread Tom Hughes via rails-dev
I can't reproduce the blink in Firefox, but the code looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5573#issuecomment-2622512125 You are receiving this because you are subscribed to this thread. Message

Re: [openstreetmap/openstreetmap-website] Remove unnecessary wrapper divs from data layer error message (PR #5574)

2025-01-29 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5574#issuecomment-2622514227 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Show only description as a marker tooltip in note layer (PR #5576)

2025-01-29 Thread Tom Hughes via rails-dev
Hopefully this will stop being a problem once the notes schema migration is complete but this looks fine as a temporary fix. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5576#issuecomment-2622517773 You are receiving this becau

Re: [openstreetmap/openstreetmap-website] Show only description as a marker tooltip in note layer (PR #5576)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5576 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5576#event-16112442654 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Abort loading when note layer is removed (PR #5577)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5577 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5577#event-16112442640 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Select user ids from reports using pluck (PR #5578)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5578 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5578#event-16112442646 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove unnecessary wrapper divs from data layer error message (PR #5574)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5574 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5574#event-16112442642 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)

2025-01-29 Thread Tom Hughes via rails-dev
@tomhughes pushed 2 commits. f52db008232c71a23d3f7990b8168d36af952576 Update eslint to prefer let/const over var 728d9910a1bdb88b46514536985262de716931d5 Replace uses of var with let or const as appropriate -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/555

Re: [openstreetmap/openstreetmap-website] Select user ids from reports using pluck (PR #5578)

2025-01-29 Thread Tom Hughes via rails-dev
It should also mean that the `uniq` becomes part of the database query I think. Looks good to me in any case! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5578#issuecomment-2622523134 You are receiving this because you are subs

Re: [openstreetmap/openstreetmap-website] Abort loading when note layer is removed (PR #5577)

2025-01-29 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5577#issuecomment-2622520423 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Abort loading when data layer is removed (PR #5575)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5575 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5575#event-16112528023 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)

2025-01-29 Thread Tom Hughes via rails-dev
@tomhughes pushed 2 commits. 358417ee2aa7313178ec906c9985dfb7a6b92756 Update eslint to prefer let/const over var 4e28e7f5fd4b5f1037f25528b1f0f7909ba836d9 Replace uses of var with let or const as appropriate -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/555

Re: [openstreetmap/openstreetmap-website] Don't remove-readd standard layer with visible overlays (PR #5573)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5573 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5573#event-16112442645 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Messaging API: deleted messages (Issue #5496)

2025-01-13 Thread Tom Hughes via rails-dev
I think this was discussed during the PR review and it was decided to keep it like this? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5496#issuecomment-2588361906 You are receiving this because you are subscribed to this thre

Re: [openstreetmap/openstreetmap-website] Messaging API: deleted messages (Issue #5496)

2025-01-13 Thread Tom Hughes via rails-dev
Yes https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1616061310 is where I raised it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5496#issuecomment-2588369080 You are receiving this because you a

Re: [openstreetmap/openstreetmap-website] Messaging API: deleted messages (Issue #5496)

2025-01-13 Thread Tom Hughes via rails-dev
Well the general rule is that we never delete anything for real in OSM so no. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5496#issuecomment-2588404585 You are receiving this because you are subscribed to this thread. Message

Re: [openstreetmap/openstreetmap-website] Remove test_logout_removes_session_token (PR #5456)

2025-01-02 Thread Tom Hughes via rails-dev
Merged #5456 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5456#event-15801427603 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove commit parameter from diary controller test (PR #5455)

2025-01-02 Thread Tom Hughes via rails-dev
Merged #5455 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5455#event-15801427614 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use resourceful route for message reply (PR #5458)

2025-01-02 Thread Tom Hughes via rails-dev
@tomhughes requested changes on this pull request. This mostly looks good but it turns out it fails when applied on top of #5457 as the reply route no longer works properly when combined with the change to new. -- Reply to this email directly or view it on GitHub: https://github.com/openstre

Re: [openstreetmap/openstreetmap-website] bug with selenium while running the tests (Issue #5467)

2025-01-04 Thread Tom Hughes via rails-dev
A snap based firefox is unlikely to work. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5467#issuecomment-2571446173 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] bug with selenium while running the tests (Issue #5467)

2025-01-04 Thread Tom Hughes via rails-dev
Closed #5467 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5467#event-15816390123 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] display warning in new note form after too many anonymous notes (PR #5468)

2025-01-04 Thread Tom Hughes via rails-dev
If they're valid notes I don't really see the problem? Are these genuine notes or is this some sort of spam attack? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5468#issuecomment-2571446909 You are receiving this because you ar

[openstreetmap/openstreetmap-website] Use turbo for the settings page to stop the URL changing (PR #5453)

2025-01-01 Thread Tom Hughes via rails-dev
This changes the user settings page to use turbo to fix the problem identified in https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2565252266 where the URL changes when submitting a settings page with errors. It also fixes an issue where errors weren't moved from th

Re: [openstreetmap/openstreetmap-website] New note page on low zooms (PR #5443)

2025-01-01 Thread Tom Hughes via rails-dev
Merged #5443 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5443#event-15793555770 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] New note page on low zooms (PR #5443)

2025-01-01 Thread Tom Hughes via rails-dev
@tomhughes approved this pull request. Looks good to me now, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5443#pullrequestreview-2526839590 You are receiving this because you are subscribed to this thread. Message ID

Re: [openstreetmap/openstreetmap-website] low zoom URLs for adding a note handled badly (#1291)

2025-01-01 Thread Tom Hughes via rails-dev
Closed #1291 as completed via #5443. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1291#event-15793555827 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Fix allow_thirdparty_images options (PR #5469)

2025-01-05 Thread Tom Hughes via rails-dev
Looks good to me, and the others should definitely be fixed as well. I believe the `allow_all_form_action` one is related to a difference in how browsers enforce CSP for form submissions - specifically some (eg Firefox) only require that the initial URL submitted to meet the form action policy w

Re: [openstreetmap/openstreetmap-website] Remove zoomend listener on history unload (PR #5470)

2025-01-05 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5470#issuecomment-2571677461 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove old browse redirects (PR #5463)

2025-01-05 Thread Tom Hughes via rails-dev
I'm afraid to say there were still about 26000 hits on `/browse` yesterday :disappointed: -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5463#issuecomment-2571673889 You are receiving this because you are subscribed to this thre

Re: [openstreetmap/openstreetmap-website] Show outbox after sending new message (PR #5465)

2025-01-05 Thread Tom Hughes via rails-dev
Seems reasonable to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5465#issuecomment-2571675158 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Fix allow_thirdparty_images options (PR #5469)

2025-01-05 Thread Tom Hughes via rails-dev
Merged #5469 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5469#event-15817759683 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Show outbox after sending new message (PR #5465)

2025-01-05 Thread Tom Hughes via rails-dev
Merged #5465 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5465#event-15817759692 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Inconsistency between a link and the text of the link on copyright page (Issue #5472)

2025-01-05 Thread Tom Hughes via rails-dev
We have no control over that page and I believe OSMF changed it because it was getting too much spam. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5472#issuecomment-2571681182 You are receiving this because you are subscribed

Re: [openstreetmap/openstreetmap-website] Add OldElementsController base class (PR #5464)

2025-01-05 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5464#issuecomment-2571683359 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove zoomend listener on history unload (PR #5470)

2025-01-05 Thread Tom Hughes via rails-dev
Merged #5470 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5470#event-15817759684 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

<    2   3   4   5   6   7   8   9   10   11   >