@tomhughes requested changes on this pull request.
I don't think leaflet-osm should be getting involved in automatic transforms -
it should have the ability to select a dark tile version where there is one and
any automatic transformations should only be in the osm.org code.
> options = L.
Changes to anything under `vendor` need to be done in the appropriate upstream
repository, not here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5396#issuecomment-2539848666
You are receiving this because you are subscribed to
We've been on 2015 for a long time as we no longer care about IE
there's probably no good reason not to bump it.
I've had a look at the support matrices and up to 2022 just about
everything seems to be supported in all current browsers. Detailed results can
be found:
* [ECMAScript
2016](https
@tomhughes approved this pull request.
That looks much better now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5416#pullrequestreview-2515402410
You are receiving this because you are subscribed to this thread.
Mess
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5420#issuecomment-2554844503
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5416 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5416#event-15721807960
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5420 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5420#event-15721807996
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -411,34 +416,20 @@ L.OSM.share = function (options) {
$("#mapnik_image_width").text(mapWidth);
$("#mapnik_image_height").text(mapHeight);
- const layerId = map.getMapBaseLayerId();
- const layerKeys = new Map([
-["
We certainly have statistics.. Here's some for yesterday for Chrome:
|Label|Unique visitors|Visits|Actions|
|-|---|--|---|
|Chrome 109.0|1348|1638|3661|
|Chrome 111.0|240|242|445|
|Chrome 116.0|182|203|303|
|Chrome 117.0|210|223|268|
|Chrome 119.0|134|186|409|
|Chrome 120.0
Looks like there is one feature in 2022 that is an issue for Safari 15 and the
Chrome 87/92 outliers are also a bit more limited but of the rest is OK I think?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5421#issuecomment-2554
@tomhughes commented on this pull request.
> @@ -64,11 +64,7 @@ def authorize(errormessage = "Couldn't authenticate you")
def current_ability
# Use capabilities from the oauth token if it exists and is a valid access
token
-if doorkeeper_token&.accessible?
- ApiAbility.new(ni
Merged #5429 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5429#event-15734219570
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
This looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5429#pullrequestreview-2517841441
You are receiving this because you are subscribed to this thread.
Message ID:
First draft of updating to rails 8 which currently needs to pull a couple of
dependent gems from git as they are awaiting new releases for rails 8
compatibility.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5430
--
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5427#issuecomment-2557047984
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes pushed 4 commits.
207303a6592b6f81e4e38f8045115dcd872476e9 Drop support for ruby 3.1
4f685c09dd43ce8de3bfde1cb4847bc4f0842914 Update to rails 8.0.1
f91306a932354062fcc5ea23b969710b7095a0b9 Avoid parsing of XML requests with ;
in the body
bb6551471a00fe1c3a444ff161c9f2642bcf6df9 Use
@tomhughes pushed 3 commits.
c381e9a0f60056cee69b0c9019883ae4fda14bcc Update to rails 8.0.1
df87fb9d19aeb866f419494e24b5141a1eb2907b Avoid parsing of XML requests with ;
in the body
df55d76a7c96a779ead3bcf3d46fe1ae2b41185a Use rails 8 compatible
active_record_union
--
View it on GitHub:
htt
So this also requires ruby 3.2 which is going to be painful for us in
production, so I've had to drop 3.1 support.
It also needs a git version of `annotate` though
https://github.com/ctran/annotate_models/issues/1032 suggests that it may be
dead and `annotaterb` may be taking over.
--
Reply t
@tomhughes pushed 1 commit.
a3e83301f4597dba4962465d646ef1544c5c3dbb Use rails 8 compatible annotate gem
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5430/files/4c37c65917155953803eac02aabaf3050596d7c4..a3e83301f4597dba4962465d646ef1544c5c3dbb
You are receiv
@tomhughes pushed 4 commits.
3ae458b40ad5914578d52515a51b0aa8b791ae20 Drop support for ruby 3.1
a44c1897d005cbc8159cdcc283edab4820faa317 Update to rails 8.0.1
015a06cbd71b7c78d3b282fb19db5a99afdd66fb Avoid parsing of XML requests with ;
in the body
4c37c65917155953803eac02aabaf3050596d7c4 Use
@tomhughes pushed 5 commits.
c61cc73923a3ae68e53b2d88a60a18ceb352a223 Drop support for ruby 3.1
5e6edf83ee28a98d004672b55d5ad483fe9ec233 Update to rails 8.0.1
5bc7d041b6d5802c719bce658ebf6c3d32a2230a Avoid parsing of XML requests with ;
in the body
3e7921f9ebb87233aad8e6ff22abff15a2641cec Use
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5422#issuecomment-2556524449
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5424 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5424#event-15729818472
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5424#issuecomment-2556528286
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5423#issuecomment-2556527196
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5423 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5423#event-15729818482
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5425 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5425#event-15729818494
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5425#issuecomment-2556529543
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5422 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5422#event-15729818497
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
This is deprecated in rails 8.0 and 8.1 will remove it.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5428
-- Commit Summary --
* Don't map multiple paths in a single route
-- File Changes --
M config/routes.
Merged #5427 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5427#event-15732933603
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5349#issuecomment-2494426837
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5349 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5349#event-15401756335
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5346 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5346#event-15389511479
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks - that looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5346#pullrequestreview-2452872448
You are receiving this because you are subscribed to this thread.
Message ID
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5348#issuecomment-2492033444
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5348 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5348#event-15386831177
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
This mostly looks good - my only question would be about error handling for
subscribe/unsubscribe as the error text reporting has been moved to only happen
for the comment button.
The equivalent code for changesets reports the error in all cases by the
Why on earth is it `josm:` though...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5351#issuecomment-2494261840
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5334 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5334#event-15325716215
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5372 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5372#event-15514586543
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I have to say I'm not clear exactly what dependencies are being referred to
here, or how a web site could "run on CLI" exactly.
Perhaps @x64x2 could provide a bit more information about what they have in
mind?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5435#issuecomment-2559387263
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5480 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5480#event-15858260557
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5483 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5483#event-15858426181
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5482 as completed via 14b33b9433244c34b8809fcbe6528a077b1709ad.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5482#event-15858426089
You are receiving this because you are subscribed to this thread.
Message ID:
__
> > Unfortunately the ruby lifecycle and the Debian lifecycle are poorly
> > matched...
>
> I don't think it's a lifecycle mismatch thing, I think it's more that the
> debian packagers are asleep at the wheel. They are shipping software and not
> shipping the bug fixes for that version. Ruby 3.
Merged #5486 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5486#event-15859578170
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
This is only affecting docker right? Because the main tests are using Ubuntu,
but it would bite us in production which would be very bad.
I really hate the number of version locks we've got going on now though - we'll
never remember them all when we upgrade and can remove them :cry:
Unfortunat
Why has this downgraded us all the way to `1.13.0` when we were on `1.13.4`
before I updated yesterday?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5483#issuecomment-2578363824
You are receiving this because you are subscribed
Much as it pains me I guess we have to take this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5483#issuecomment-2578360741
You are receiving this because you are subscribed to this thread.
Message ID:
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5492#issuecomment-2585790739
You are receiving this because you are subscribed to this thread.
Message ID:
___
I hadn't previously noticed that #5294 had proposed adding versioning - that's
a whole other level of additional complication.
I can understand why it might be needed for tags, and I guess it also allows
for editing the initial description if we want once that it part of the note
itself rather
Merged #5491 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5491#event-15896304568
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5492 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5492#event-15896304570
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes requested changes on this pull request.
This is going to need to be broken down in to multiple PRs as we can't take all
three migrations in one go, and we can't take code changes that rely on new
fields until after those fields have been created.
The first two PRs should be one to cr
@tomhughes commented on this pull request.
I'm not totally convinced showing the numeric level is useful but generally
this looks good apart from the specific point I've mentioned in a comment.
> @@ -101,9 +101,13 @@ def search_osm_nominatim
if klass == "boundary" && type == "administrati
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5515#issuecomment-2600894905
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5516#issuecomment-2600895236
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5517#issuecomment-2600896430
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5520#issuecomment-2600896747
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", self[:description])
+end
end
We could make it consistent by using `all_comments` instead but that
@tomhughes commented on this pull request.
Please try to avoid including stylistic changes like replacing single quotes
with double quotes in the same commit as functional changes as it makes it very
hard to tell what the actual functional changes are when reviewing...
--
Reply to this email
Merged #5520 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5520#event-15989108339
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5489 as completed via #5520.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5489#event-15989108397
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5516 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5516#event-15989108341
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5517 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5517#event-15989108343
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5515 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5515#event-15989108358
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", self[:description])
+end
end
I don't think I've said that as such.
What I have said is that we n
@tomhughes pushed 3 commits.
bf3983562b0c6ca265882005eb62492a0e62ae5a Use turbo for the settings page to
stop the URL changing
d223270779fc28a84d2227fbf63aab0f92d012c2 Replace count.zero? with empty?
368ea6589769e8eb9ccfb1a50f9fa611039c17fb Move errors from email to new_email
properly
--
Vi
Firstly I didn't say it wasn't wanted, I said it is better to keep it in a
separate commit to make reviewing easier.
Secondly what "same linting as usual" is this? As far as I know it was already
passing our eslint rules so is this some additional linting of your own?
--
Reply to this email di
Merged #5535 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5535#event-16033065440
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I don't really like bundling third party code like this, but the upstream PR
doesn't seem to be going anywhere :disappointed:
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5533#issuecomment-2607933573
You are receiving this bec
Merged #5533 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5533#event-16033065464
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5529 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5529#event-16033065500
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5534 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5534#event-16033065473
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5532 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5532#event-16033065459
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5535#issuecomment-2607926067
You are receiving this because you are subscribed to this thread.
Message ID:
___
Well then you'd ideally want an index on author+date+id though we have to think
about how much space we want o use on indexes at some point - is here really a
need for filtering by date? How often do you know that you need to look at
comments from a particular date?
--
Reply to this email dire
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5528#issuecomment-2605459918
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes pushed 1 commit.
0100c2c8b148f2a8d3c2d9181c4454c6d3691ae3 Add indes on user+id to changeset and
diary comments
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5531/files/3ebe31d65cea0442111afd70e29aca4bce153bb7..0100c2c8b148f2a8d3c2d9181c4454c6d3691
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5532#issuecomment-2607899405
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5534#issuecomment-2607891586
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5529#issuecomment-2607909864
You are receiving this because you are subscribed to this thread.
Message ID:
___
They were added so that we could fill in the `List-Unsubscribe` header in
emails as Google had made that a requirement for gmail.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5535#issuecomment-2607920028
You are receiving this
Merged #5541 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5541#event-16048015164
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I generally try to avoid doing anything before `ready` fires as it's hard to
know what's safe but I guess this OK as `head` must have loaded in order for
the javascript to load. I do wonder what #5402 is doing that it needs this
before the page is ready though...
--
Reply to this email directl
I think I did it the way I did to make it consistent with the non-test code,
where there is no user/resource_owner association on the access token model
that doorkeeper provides, but this does make the tests a lot nicer.
--
Reply to this email directly or view it on GitHub:
https://github.com/o
@tomhughes requested changes on this pull request.
> @@ -43,7 +43,7 @@ def initialize(user)
can :update, DiaryEntry, :user => user
can [:create], DiaryComment
can [:show, :create, :destroy], Follow
-can [:read, :create, :mark, :unmute, :destroy], Message
+
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5537#issuecomment-2610621188
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5537 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5537#event-16048015190
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5545 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5545#event-16060343355
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5544 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5544#event-16060343366
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5548#issuecomment-2612735489
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5542#issuecomment-2612737801
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5542 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5542#event-16059949993
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5543#issuecomment-2612738797
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5548 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5548#event-16059932268
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5543 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5543#event-16059950010
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Yes it's probably a hangover from when we had other ways to authenticate to the
API that would set `current_user` but it's redundant now as you say.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5544#issuecomment-2612754242
You
501 - 600 of 2173 matches
Mail list logo
