tomhughes left a comment (openstreetmap/openstreetmap-website#5916)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5916#issuecomment-2794396829
You are receiving this because you are subscribed to this t
Merged #5916 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5916#event-17209538733
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5909 as completed via #5916.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#event-17209539056
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5832 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832#event-17209538764
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5908)
What exactly is the goal here? How is the new wording better than the old
wording?
In general when opening a PR you need to explain what it is you're trying to do
and why your PR improves things, not just say "Update " and expe
tomhughes left a comment (openstreetmap/openstreetmap-website#5907)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5907#issuecomment-2786964639
You are receiving this because you are subscribed to this t
Merged #5907 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5907#event-17174066554
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5913#pullrequestreview-2754572740
You are receiving this because you are subscribed to this thread.
Messa
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473#pullrequestreview-2754584515
You are receiving this because you are subscribed to this thread.
Messa
Closed #3423 as completed via #5473.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3423#event-17195057899
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5913 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5913#event-17195057646
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5903)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5903#issuecomment-2790847236
You are receiving this because you are subscribed to t
Merged #5903 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5903#event-17195370007
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5473 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473#event-17195057628
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
Can you squash the final commit into the previous one please, so that the
comments come in along with the code changes given that they're kind of
important in explaining what the code is doing?
--
Reply to this email directly or view it on GitHub:
h
Reopened #5909.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#event-17201959945
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
Closed #5909 as completed via #5911.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#event-17193383872
You are receiving this because you are subscribed to this thread.
Message ID:
_
tomhughes left a comment (openstreetmap/openstreetmap-website#5911)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5911#issuecomment-2790447990
You are receiving this because you are subscribed to this t
Merged #5911 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5911#event-17193383603
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5912 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5912#event-17193383589
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> + row
+.on("mouseenter", function () {
+ highlight
+.setLatLngs(lineseg)
+.addTo(map);
+})
+.on("mouseleave", function () {
+ map.removeLayer(highlight);
+});
+}
+
+
@tomhughes commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
Is 1000 still the right boundary to use in feet/mil
tomhughes left a comment (openstreetmap/openstreetmap-website#5917)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5917#issuecomment-2794764880
You are receiving this because you are subscribed to this t
Merged #5917 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5917#event-17211395488
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes requested changes on this pull request.
Other than the one minor suggestion I made this looks great to me.
> @@ -578,7 +578,7 @@ en:
use_map_link: Use Map
index:
title: "Users' Diaries"
- title_followed: "Followings' Diaries"
+ title_followed: "Your Followe
tomhughes left a comment (openstreetmap/openstreetmap-website#5858)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5858#issuecomment-2761930585
You are receiving this because you are subscribed to this t
@tomhughes commented on this pull request.
> @@ -391,13 +391,17 @@ OSM.isDarkMap = function () {
return window.matchMedia("(prefers-color-scheme: dark)").matches;
};
-OSM.getUserIcon = function (url) {
- return L.icon({
-iconUrl: url || OSM.MARKER_RED,
-iconSize: [25, 41],
-ic
Merged #5858 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5858#event-17035955378
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Rather than adding an ever larger list of configuration options for link
normalisation this uses a single option that provides an array of rules to
apply.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5862
-- Commit
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
> we can always change this temporarily if there is a problem with coveralls
> that we need to work around.
This is not really true though as once it starts happening changing the
workflow won't have any effect on existing PRs
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
> I've been thinking about if more granular control about which errors get
> reported in which way could help. (maybe issue at
> [coverallsapp/github-action](https://github.com/coverallsapp/github-action)?)
I was just looking a
@tomhughes approved this pull request.
Thanks for the fix. I think this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5857#pullrequestreview-2727906151
You are receiving this because you are subscribed to this
Merged #5866 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5866#event-17047999638
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
This is the current coveralls status, and the end time has already been
extended at least once:
Coveralls posts it's results separately i
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
I really think we need to revisit this - having every PR show as erroneous
because coveralls is down for maintenance for long periods is a massive pain
for maintainers trying to work out what can be reviewed.
--
Reply to this
tomhughes left a comment (openstreetmap/openstreetmap-website#5867)
Sorry yes I just realised I merged this by accident - it wasn't what I intended
to merge.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5867#issuecomment-27646
Merged #5857 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5857#event-17048553887
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5866)
Sorry @hlfan I merged this accidentally and have now reverted it but there
doesn't seem to be any way to reopen the PR so if you want to pursue it can you
reopen but you might want to read @AntonKhorev's comments in #5867 first.
Merged #5867 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5867#event-17048553883
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5875 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5875#event-17087104857
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@tomhughes commented on this pull request.
> @@ -63,7 +63,7 @@ class User < ApplicationRecord
has_many :preferences, :class_name => "UserPreference"
has_many :changesets, -> { order(:created_at => :desc) }, :inverse_of =>
:user
has_many :changeset_comments, :foreign_key => :author_id,
@tomhughes commented on this pull request.
> @@ -63,7 +63,7 @@ class User < ApplicationRecord
has_many :preferences, :class_name => "UserPreference"
has_many :changesets, -> { order(:created_at => :desc) }, :inverse_of =>
:user
has_many :changeset_comments, :foreign_key => :author_id,
tomhughes left a comment (openstreetmap/openstreetmap-website#5733)
It's not really fixed - they closed the mini_racer bug because they determined
the real problem was in libv8 and the PR to fix that is still open
(https://github.com/rubyjs/libv8-node/pull/36).
--
Reply to this email directly
tomhughes left a comment (openstreetmap/openstreetmap-website#5802)
Agreed - it looks right to me to. As well as browser the other thing that might
possible affect it is what locale you're using - can you see what `I18n.locale`
evaluates to in the console?
--
Reply to this email directly or vi
@tomhughes commented on this pull request.
> +
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\.
Merged #5799 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5799#event-16777680267
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5804)
I would argue that by signing up to the project it's your intent to make your
edits public - building a public data set is the entire point of the project
after all but what do I know.
I certainly don't see any point in showing
Merged #5814 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5814#event-16811554092
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
>
// '-' are replaced with '_' in
https://github.com/eemeli/make-plural/tree/main/packages/plurals
const pluralizer = plurals[locale.replace(/\W+/g, "_")] ||
plurals[locale.split("-")[0]];
if (pluralizer) {
-I18n.pluralization[locale] =
@tomhughes commented on this pull request.
>
// '-' are replaced with '_' in
https://github.com/eemeli/make-plural/tree/main/packages/plurals
const pluralizer = plurals[locale.replace(/\W+/g, "_")] ||
plurals[locale.split("-")[0]];
if (pluralizer) {
-I18n.pluralization[locale] =
tomhughes left a comment (openstreetmap/openstreetmap-website#5814)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5814#issuecomment-2730330356
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5817)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5817#issuecomment-2730340542
You are receiving this because you are subscribed to this t
Merged #5817 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5817#event-16811554114
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5803)
I'm not sure we can turn the documentation into a tutorial for the quirks of
each individual operating system... If wget isn't downloading to the current
directory by default then where is is downloading to? Maybe that's a bug t
Closed #5352 via #5809.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5352#event-16791863337
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
@tomhughes pushed 3 commits.
453a28653174616843c651c0bbce4ebfaf90cb90 Add OSM.i18n as an alias for I18n
e2e61692ea04fc156221082aeddc21ea18facdec Replace use of I18n in javascript
with OSM.i18n
d52c7943f24aae4ede55f1ef055af415dcf3da59 Update to i18n-js 4.x
--
View it on GitHub:
https://github
This updates to rack 3 which was blocked by omniauth being locked to 2.0 so
this updates omniauth to 2.1 which unlocks the rack 3 update which in turn
requires a puma update.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/
@tomhughes pushed 3 commits.
8fcdb3be60650ed89cd5b457e3df4de7ecf10d87 Update to omniauth 2.1, puma 6 and
rack 3
1418186493e27a2a02e55bdb22c1833b6433858e Handle request objects with no body
6a4806ee523f1e4b5c50c7963fae9a9e28b37b72 Pass correct headers to POST requests
--
View it on GitHub:
ht
@tomhughes pushed 4 commits.
045e305d8bc0967251bcb1d420e03674fed2b8ec Update to omniauth 2.1, puma 6 and
rack 3
3bd56383b893006916bf67d4399f15667299d74c Handle request objects with no body
86d5a5c50e17444adee4106966d51ab43eafc319 Pass correct headers to POST requests
9fbeb37689f1ae8955e00cad01
@tomhughes commented on this pull request.
> @@ -157,7 +157,11 @@ def search_osm_nominatim_reverse
:type => object_type, :id => object_id)
end
-render :action => "results"
+respond_to do |format|
+ format.html { render :action => "results" }
+ format
Merged #5926 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5926#event-17238229304
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
Technically this looks so I think the main questions here will be whether (a)
people think it's a good idea and (b) whether these are the best colour choices.
> @@ -1,15 +1,40 @@
OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({
- _changesets: [],
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5925#pullrequestreview-2762728413
You are receiving this because you are subscribed to this thread.
Messa
Closed #1000 as completed via #5925.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1000#event-17238269253
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tomhughes requested changes on this pull request.
The third commit should be squashed into the first one rather than keeping it
as a fixup commit.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5902#pullrequestreview-27627287
tomhughes left a comment (openstreetmap/openstreetmap-website#5925)
Apparently I did, which is really weird because I retested it before I pushed
and it seemed to be correct!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5925#i
Merged #5925 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5925#event-17238269208
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5927)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5927#issuecomment-2799973993
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5928)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5928#issuecomment-2799974262
You are receiving this because you are subscribed to this t
Merged #5928 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5928#event-17238783405
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5929)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5929#issuecomment-2799974421
You are receiving this because you are subscribed to this t
Merged #5929 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5929#event-17238783401
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5927 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5927#event-17238783406
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5923)
Why would it not be if a request arrives with that header? Are you suggesting
that rack 3 has changed how it present request headers or something?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstr
@tomhughes commented on this pull request.
> @@ -247,7 +247,7 @@ def respond_to_timeout
# To work round this we call rewind on the body here, which is added
# as a filter, to force it to be fetched from Apache into a file.
def fetch_body
-request.body.rewind
+request.body&.rewin
@tomhughes pushed 4 commits.
20d1b9fa212ea62a372cf2e7f019dfa38bbda971 Update to omniauth 2.1, puma 6 and
rack 3
85a7d5d880cd8cd3dbfc1b4240bf3e24e81a358a Avoid trying to rewind the request
body
66c9fd1ef6d7f8bd5b7a192e37e0fe797cb31d60 Pass correct headers to POST requests
41513983b97895463c605
tomhughes left a comment (openstreetmap/openstreetmap-website#5923)
Yes it downcases everything now but so long as you're using `Rack::Headers`
instead of a plain hash any lookups are also downcased.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstre
tomhughes left a comment (openstreetmap/openstreetmap-website#5923)
Nothing there specifies a class? The class is what ever rack passes up the
stack, and from my debugging that is `Rack::Headers`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetm
tomhughes left a comment (openstreetmap/openstreetmap-website#5923)
I assume you're thinking about
https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#response-headers-must-be-lower-case
which is technically about response headers though the same is essentially
true for request headers.
I
@tomhughes commented on this pull request.
> @@ -247,7 +247,7 @@ def respond_to_timeout
# To work round this we call rewind on the body here, which is added
# as a filter, to force it to be fetched from Apache into a file.
def fetch_body
-request.body.rewind
+request.body&.rewin
Closed #5941 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5941#event-17331016673
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
tomhughes left a comment (openstreetmap/openstreetmap-website#5943)
Oh and the rubocop warnings will need to be fixed as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943#issuecomment-2822013558
You are receiving this bec
tomhughes left a comment (openstreetmap/openstreetmap-website#5942)
I didn't even know teaspoon had a UI... How do you use it?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5942#issuecomment-2822016491
You are receiving this bec
tomhughes left a comment (openstreetmap/openstreetmap-website#5942)
Managed to figure it out now - you have to start a server with `RAILS_ENV=test
bundle exec rails server` and then visit `/teaspoon` to access it.
This does indeed seem to make things work, so it looks good to me.
--
Reply to t
Merged #5944 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5944#event-17357855907
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5942 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5942#event-17357855879
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 1 commit.
417ec875dee783a5fdce97e99a36ea63a5561ee2 Switch to rails 8.0 defaults
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5937/files/d616aeef186593086b27a3e4f1ef8ca2db61fede..417ec875dee783a5fdce97e99a36ea63a5561ee2
You are receiving thi
@tomhughes pushed 1 commit.
33c0a0e830f06f9f2c50f8d71d2817d1088808fc Add frozen_string_literal comments to
ruby files
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5932/files/13a8386008b8d7cddf3b28a9200d4f677b700599..33c0a0e830f06f9f2c50f8d71d2817d1088808fc
tomhughes left a comment (openstreetmap/openstreetmap-website#5779)
Superseded by #5943.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5779#issuecomment-2822002957
You are receiving this because you are subscribed to this thread
Closed #5779.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5779#event-17357662765
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@tomhughes requested changes on this pull request.
This will definitely need some tests - basically cloning the existing XML tests
and adjusting them for JSON would be a good start.
Does CONTRIBUTING.md not explain what you need to know?
> +respond_to do |format|
+ format.xml {
tomhughes left a comment (openstreetmap/openstreetmap-website#5882)
> Firefox doesn’t officially support this API yet; you have to toggle
> `dom.webshare.enabled` in about:config first.
Yes I know - that's what I meant about enabling it. But even when enabled it
doesn't actually do anything, at
tomhughes left a comment (openstreetmap/openstreetmap-website#5882)
MDN claims that Chrome supports it from 129 but it doesn't seem to on linux at
least - possibly Windows only or something. Mobile works fine though which is
the main use case anyway.
--
Reply to this email directly or view it
tomhughes left a comment (openstreetmap/openstreetmap-website#5882)
I don't see any issues with this, so I think it's good to merge, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5882#issuecomment-2822091699
You are rece
Merged #5882 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5882#event-17358189398
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5943)
There aren't any default users created - there's some information in
CONFIGURE.md on setting up at initial user.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
tomhughes left a comment (openstreetmap/openstreetmap-website#5943)
I think you need to change the two controllers to add something like this at
the top:
```ruby
before_action :set_request_formats, :only => [:index]
```
That should stop those test failures on the XML version.
Please also squas
tomhughes left a comment (openstreetmap/openstreetmap-website#5937)
The receiver is the object you're calling the method on.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5937#issuecomment-2822531222
You are receiving this becau
tomhughes left a comment (openstreetmap/openstreetmap-website#5943)
I prefer to use merge commits so we record what PR changes have come from -
feel free to squash everything together if you prefer but having the tests in a
separate commit is also fine we just prefer not to have fixups.
--
Rep
I think so yes... Rails is a bit too clever for it's own good and fakes up
`Home location name` in the UI from the field name by removing the underscores
and capitalising the first word making it not at all obvious that there is a
missing translation!
--
Reply to this email directly or view it
1001 - 1100 of 2171 matches
Mail list logo
